clang: don't disable any warnings
v4 cover clang: don't disable any warnings
Hello,
The following series removes the disable of certain clang warnings, after this all clang warnings are enabled. This supersedes "[PATCH v3 0/2] Enable Wformat for clang".
It has been tested in FreeBSD with clang 3.8, and by travis, all OK:
https://travis-ci.org/royger/xen/builds/201482055
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
PATCH v4 1/4 xen/grants: print grant number and handle in hex format
Due to the large number of grants in use it seems more useful to print the grant references and handlers in hex format rather than decimal.
---
Cc: Andrew Cooper <[email protected]>
Cc: George Dunlap <[email protected]>
Cc: Ian Jackson <[email protected]>
Cc: Jan Beulich <[email protected]>
Cc: Konrad Rzeszutek Wilk <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: Tim Deegan <[email protected]>
Cc: Wei Liu <[email protected]>
---
Changes since v2:
- Remove the () and the final dot of messages.
- Fix printing the ref in the 'g' debug key, so that 3 chars are used for the ref itself.
--- xen/common/grant_table.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-)
xen/common/grant_table.c +14 -15
@@ -814,7 +814,7 @@ __gnttab_map_grant_ref(/* Bounds check on the grant ref */ if (unlikely (op->ref >=nr_grant_entries (rgt))) -PIN_FAIL (unlock_out, GNTST_bad_gntref,"Bad ref (%d).\n" , op->ref); +PIN_FAIL (unlock_out, GNTST_bad_gntref,"Bad ref %#x\n" , op->ref); act =active_entry_acquire (rgt, op->ref); shah =shared_entry_header (rgt, op->ref);
@@ -1087,7 +1087,7 @@ __gnttab_unmap_common(if (unlikely (op->handle >= lgt->maptrack_limit) ) { -gdprintk (XENLOG_INFO ,"Bad handle (%d).\n" , op->handle); +gdprintk (XENLOG_INFO ,"Bad handle %#x\n" , op->handle); op->status = GNTST_bad_handle;return ; }
@@ -1099,7 +1099,7 @@ __gnttab_unmap_common(if (unlikely (!read_atomic (&op->map->flags)) ) {grant_read_unlock (lgt); -gdprintk (XENLOG_INFO ,"Zero flags for handle (%d).\n" , op->handle); +gdprintk (XENLOG_INFO ,"Zero flags for handle %#x\n" , op->handle); op->status = GNTST_bad_handle;return ; }
@@ -1132,7 +1132,7 @@ __gnttab_unmap_common( op->flags =read_atomic (&op->map->flags);if (unlikely (!op->flags) ||unlikely (op->map->domid != dom) ) { -gdprintk (XENLOG_WARNING ,"Unstable handle %u\n" , op->handle); +gdprintk (XENLOG_WARNING ,"Unstable handle %#x\n" , op->handle); rc = GNTST_bad_handle; goto unmap_out; }
@@ -1706,7 +1706,7 @@ gnttab_prepare_for_transfer(if (unlikely (ref >=nr_grant_entries (rgt)) ) {gdprintk (XENLOG_INFO , -"Bad grant reference (%d) for transfer to domain(%d).\n" , +"Bad grant reference %#x for transfer to d%d\n" , ref, rd->domain_id); goto fail; }
@@ -2672,7 +2672,7 @@ gnttab_set_version(XEN_GUEST_HANDLE_PARAM(gnttab_set_version_t) uop)break ;default :gdprintk (XENLOG_INFO , -"bad flags %#x in grant %u when switching version\n" , +"bad flags %#x in grant %#x when switching version\n" , flags, i);/* fall through */ case GTF_invalid:
@@ -2836,9 +2836,9 @@ __gnttab_swap_grant_ref(grant_ref_t ref_a, grant_ref_t ref_b)/* Bounds check on the grant refs */ if (unlikely (ref_a >=nr_grant_entries (d->grant_table))) -PIN_FAIL (out, GNTST_bad_gntref,"Bad ref-a (%d).\n" , ref_a); +PIN_FAIL (out, GNTST_bad_gntref,"Bad ref-a %#x\n" , ref_a);if (unlikely (ref_b >=nr_grant_entries (d->grant_table))) -PIN_FAIL (out, GNTST_bad_gntref,"Bad ref-b (%d).\n" , ref_b); +PIN_FAIL (out, GNTST_bad_gntref,"Bad ref-b %#x\n" , ref_b);/* Swapping the same ref is a no-op. */ if ( ref_a == ref_b )
@@ -2846,11 +2846,11 @@ __gnttab_swap_grant_ref(grant_ref_t ref_a, grant_ref_t ref_b) act_a =active_entry_acquire (gt, ref_a);if ( act_a->pin ) -PIN_FAIL (out, GNTST_eagain,"ref a %ld busy\n" , (long )ref_a); +PIN_FAIL (out, GNTST_eagain,"ref a %#x busy\n" , ref_a); act_b =active_entry_acquire (gt, ref_b);if ( act_b->pin ) -PIN_FAIL (out, GNTST_eagain,"ref b %ld busy\n" , (long )ref_b); +PIN_FAIL (out, GNTST_eagain,"ref b %#x busy\n" , ref_b);if ( gt->gt_version ==1 ) {
@@ -3284,9 +3284,8 @@ gnttab_release_mappings( ref = map->ref; -gdprintk (XENLOG_INFO ,"Grant release (%hu) ref:(%hu) " -"flags:(%x) dom:(%hu)\n" , - handle, ref, map->flags, map->domid); +gdprintk (XENLOG_INFO ,"Grant release %#x ref %#x flags %#x dom %u\n" , + handle, ref, map->flags, map->domid); rd =rcu_lock_domain_by_id (map->domid);if ( rd ==NULL )
@@ -3530,8 +3529,8 @@ static void gnttab_usage_print(struct domain *rd) first =0 ; } -/* [ddd] ddddd 0xXXXXXX 0xXXXXXXXX ddddd 0xXXXXXX 0xXX */ -printk ("[%3d] %5d 0x%06lx 0x%08x %5d 0x%06" PRIx64" 0x%02x\n" , +/* [0xXXX] ddddd 0xXXXXXX 0xXXXXXXXX ddddd 0xXXXXXX 0xXX */ +printk ("[0x%03x] %5d 0x%06lx 0x%08x %5d 0x%06" PRIx64" 0x%02x\n" , ref, act->domid, act->frame, act->pin, sha->domid, frame, status);active_entry_release (act);
Signature · 7 lines
2.10.1 (Apple Git-78) _______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
PATCH v4 2/4 build/printf: fix incorrect format specifiers
In reply to Roger Pau MonneThe following incorrect format specifiers and incorrect number of parameters passed to printf like functions are reported by clang:
mce.c:601:18: error: data argument not used by format string [-Werror,-Wformat-extra-args]
smp_processor_id());
^xenpm.c:102:23: error: data argument not used by format string [-Werror,-Wformat-extra-args]
what, argv[argc > 1]);
^libxl_internal.c:25:69: error: data argument not used by format string
[-Werror,-Wformat-extra-args]
libxl__log(ctx, XTL_CRITICAL, ENOMEM, 0,0, func, INVALID_DOMID, L);
^libxl_internal.c:24:17: note: expanded from macro 'L'
func, (unsigned long)nmemb, (unsigned long)size
^
libxl_internal.c:26:21: error: data argument not used by format string
[-Werror,-Wformat-extra-args]
fprintf(stderr, L);
^libxl_internal.c:24:17: note: expanded from macro 'L'
func, (unsigned long)nmemb, (unsigned long)size
^
This patch contains the fixes for them and enables -Wformat for clang.
---
NB: FWIW, there's a way to disable extra arguments checks (-Wno-format-extra-args), that would prevent us from having to apply some of the changes here. However, given that there are not that many occurrences, I would rather leave the full checks of Wformat enabled.
NB2: this has only been tested with a FreeBSD clang build (3.8.0), and only against the components that build on FreeBSD (ie: no qemu-trad, and certainly no blktap).
---
Cc: Ian Jackson <[email protected]>
Cc: Wei Liu <[email protected]>
Cc: Christoph Egger <[email protected]>
Cc: Jan Beulich <[email protected]>
Cc: Andrew Cooper <[email protected]>
---
Changes since v2:
- Remove the printf related comment near the -Wno-format.
Changes since v1:
- Change the format string for MCE to avoid duplicating CPU%i.
- Remove the grant-ref format specifier change, it's already taken care in patch #1.
--- Config.mk | 3 +-- tools/libxl/libxl_internal.c | 21 ++++++++++++++++----- tools/misc/xenpm.c | 13 ++++++++----- xen/arch/x86/cpu/mcheck/mce.c | 5 ++--- 4 files changed, 27 insertions(+), 15 deletions(-)
Config.mk +1 -2
@@ -213,9 +213,8 @@ CFLAGS += -std=gnu99 CFLAGS += -Wall -Wstrict-prototypes # Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...' -# and is over-zealous with the printf format lint # and is a bit too fierce about unused return values -CFLAGS-$(clang) += -Wno-parentheses -Wno-format -Wno-unused-value +CFLAGS-$(clang) += -Wno-parentheses -Wno-unused-value $(call cc-option-add,HOSTCFLAGS,HOSTCC,-Wdeclaration-after-statement) $(call cc-option-add,CFLAGS,CC,-Wdeclaration-after-statement)
tools/libxl/libxl_internal.c +16 -5
@@ -20,14 +20,25 @@void libxl__alloc_failed (libxl_ctx *ctx,const char *func,size_t nmemb,size_t size) {#define M "libxl: FATAL ERROR: memory allocation failure" -#define L (size ? M " (%s, %lu x %lu)\n" : M " (%s)\n"), \ - func, (unsigned long)nmemb, (unsigned long)size -libxl__log (ctx,XTL_CRITICAL ,ENOMEM ,0 ,0 , func,INVALID_DOMID ,L ); -fprintf (stderr,L ); +#define M_SIZE M " (%s, %lu x %lu)\n" +#define M_NSIZE M " (%s)\n" +if (size) { +libxl__log (ctx,XTL_CRITICAL ,ENOMEM ,0 ,0 , func,INVALID_DOMID , +M_SIZE , func, (unsigned long )nmemb, (unsigned long )size); +fprintf (stderr,M_SIZE , func, (unsigned long )nmemb, + (unsigned long )size); + }else { +libxl__log (ctx,XTL_CRITICAL ,ENOMEM ,0 ,0 , func,INVALID_DOMID , +M_NSIZE , func); +fprintf (stderr,M_NSIZE , func); + + } +fflush (stderr);_exit (-1 ); +#undef M_NSIZE +#undef M_SIZE#undef M -#undef L }void libxl__ptr_add (libxl__gc *gc,void *ptr)
tools/misc/xenpm.c +8 -5
@@ -93,13 +93,16 @@ static void parse_cpuid(const char *arg, int *cpuid)static void parse_cpuid_and_int (int argc,char *argv[],int *cpuid,int *val,const char *what) { -if ( argc >1 ) -parse_cpuid (argv[0 ], cpuid); +if ( argc ==0 ) + { +fprintf (stderr,"Missing %s\n" , what); +exit (EINVAL ); + } -if ( argc ==0 ||sscanf (argv[argc >1 ],"%d" , val) !=1 ) +parse_cpuid (argv[0 ], cpuid); +if (sscanf (argv[1 ],"%d" , val) !=1 ) { -fprintf (stderr, argc ?"Invalid %s '%s'\n" :"Missing %s\n" , - what, argv[argc >1 ]); +fprintf (stderr,"Invalid %s '%s'\n" , what, argv[1 ]);exit (EINVAL ); } }
xen/arch/x86/cpu/mcheck/mce.c +2 -3
@@ -595,9 +595,8 @@ int show_mca_info(int inited, struct cpuinfo_x86 *c) [mcheck_intel] = "Intel" }; -snprintf (prefix,ARRAY_SIZE (prefix), - g_type != mcheck_unset ?XENLOG_WARNING "CPU%i: " - :XENLOG_INFO , +snprintf (prefix,ARRAY_SIZE (prefix),"%sCPU%u: " , + g_type != mcheck_unset ?XENLOG_WARNING :XENLOG_INFO ,smp_processor_id ());BUG_ON (inited >=ARRAY_SIZE (type_str));switch (inited) {
Signature · 7 lines
2.10.1 (Apple Git-78) _______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
Re: [PATCH v4 2/4] build/printf: fix incorrect format specifiers
Quoted 36 lines · Roger Pau Monne
The following incorrect format specifiers and incorrect number of parameters passed to printf like functions are reported by clang:
mce.c:601:18: error: data argument not used by format string [-Werror,-Wformat-extra-args]
smp_processor_id()); ^xenpm.c:102:23: error: data argument not used by format string [-Werror,-Wformat-extra-args]
what, argv[argc > 1]); ^libxl_internal.c:25:69: error: data argument not used by format string
[-Werror,-Wformat-extra-args] libxl__log(ctx, XTL_CRITICAL, ENOMEM, 0,0, func, INVALID_DOMID, L); ^libxl_internal.c:24:17: note: expanded from macro 'L'
func, (unsigned long)nmemb, (unsigned long)size
^
libxl_internal.c:26:21: error: data argument not used by format string[-Werror,-Wformat-extra-args] fprintf(stderr, L); ^libxl_internal.c:24:17: note: expanded from macro 'L'
func, (unsigned long)nmemb, (unsigned long)size
^This patch contains the fixes for them and enables -Wformat for clang.
Signed-off-by Roger Pau Monné <[email protected]>Acked-by Andrew Cooper <[email protected]>---
NB: FWIW, there's a way to disable extra arguments checks (-Wno-format-extra-args), that would prevent us from having to apply some of the changes here. However, given that there are not that many occurrences, I would rather leave the full checks of Wformat enabled.
Quoted 4 lines
NB2: this has only been tested with a FreeBSD clang build (3.8.0), and only against the components that build on FreeBSD (ie: no qemu-trad, and certainly no blktap).
---
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
PATCH v4 3/4 build: enable unused value checks for clang
In reply to Roger Pau Monne---
Cc: Andrew Cooper <[email protected]>
Cc: George Dunlap <[email protected]>
Cc: Ian Jackson <[email protected]>
Cc: Jan Beulich <[email protected]>
Cc: Konrad Rzeszutek Wilk <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: Tim Deegan <[email protected]>
Cc: Wei Liu <[email protected]>
--- Config.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Config.mk +1 -2
@@ -213,8 +213,7 @@ CFLAGS += -std=gnu99 CFLAGS += -Wall -Wstrict-prototypes # Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...' -# and is a bit too fierce about unused return values -CFLAGS-$(clang) += -Wno-parentheses -Wno-unused-value +CFLAGS-$(clang) += -Wno-parentheses $(call cc-option-add,HOSTCFLAGS,HOSTCC,-Wdeclaration-after-statement) $(call cc-option-add,CFLAGS,CC,-Wdeclaration-after-statement)
Signature · 7 lines
2.10.1 (Apple Git-78) _______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
Re: [PATCH v4 3/4] build: enable unused value checks for clang
Config.mk CFLAGS += -std=gnu99 · line 216
Quoted 10 lines
Quoted 1 line
Quoted 1 line · On 14.02.17 at 13:30, <[email protected]> wrote:
Config.mk +1
-2@@ -213,8 +213,7 @@ CFLAGS += -std=gnu99 CFLAGS += -Wall -Wstrict-prototypes # Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...' -# and is a bit too fierce about unused return values -CFLAGS-$(clang) += -Wno-parentheses -Wno-unused-value +CFLAGS-$(clang) += -Wno-parentheses
Same question here - does removing the warning suppression work with all clang versions, or just new enough ones?
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
Re: [PATCH v4 3/4] build: enable unused value checks for clang
Quoted 6 lines · Jan Beulich
Quoted 6 lines
Quoted 1 line
Quoted 1 line · On 14.02.17 at 13:30, <[email protected]> wrote:
Config.mk +0
-0@@ -213,8 +213,7 @@ CFLAGS += -std=gnu99 CFLAGS += -Wall -Wstrict-prototypes
Quoted 7 lines
Config.mk CFLAGS += -std=gnu99 · line 216
Quoted 4 lines
Config.mk +1
-2# Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...' -# and is a bit too fierce about unused return values -CFLAGS-$(clang) += -Wno-parentheses -Wno-unused-value +CFLAGS-$(clang) += -Wno-parenthesesSame question here - does removing the warning suppression work with all clang versions, or just new enough ones?
Works with 3.5 and 3.8 at least. As I said in the other reply, given the previous state of Xen with clang I barely doubt anyone was actually compiling Xen with clang until I setup the FreeBSD ports and Doug the Travis stuff.
Roger.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
PATCH v4 4/4 build: enable no-parentheses in clang
In reply to Roger Pau MonneAnd fix the following errors reported:
traps.c:2014:25: error: equality comparison with extraneous parentheses
[-Werror,-Wparentheses-equality]
else if ( (port == RTC_PORT(0)) )
~~~~~^~~~~~~~~~~~~~traps.c:2014:25: note: remove extraneous parentheses around the comparison to silence this warning
else if ( (port == RTC_PORT(0)) )
~ ^ ~
traps.c:2014:25: note: use '=' to turn this equality comparison into an assignment
else if ( (port == RTC_PORT(0)) )
^~
=
traps.c:2083:25: error: equality comparison with extraneous parentheses
[-Werror,-Wparentheses-equality]
else if ( (port == RTC_PORT(0)) )
~~~~~^~~~~~~~~~~~~~---
Cc: Andrew Cooper <[email protected]>
Cc: George Dunlap <[email protected]>
Cc: Ian Jackson <[email protected]>
Cc: Jan Beulich <[email protected]>
Cc: Konrad Rzeszutek Wilk <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: Tim Deegan <[email protected]>
Cc: Wei Liu <[email protected]>
--- Config.mk | 3 --- xen/arch/x86/traps.c | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-)
Config.mk +0 -3
@@ -212,9 +212,6 @@ CFLAGS += -std=gnu99 CFLAGS += -Wall -Wstrict-prototypes -# Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...' -CFLAGS-$(clang) += -Wno-parentheses - $(call cc-option-add,HOSTCFLAGS,HOSTCC,-Wdeclaration-after-statement) $(call cc-option-add,CFLAGS,CC,-Wdeclaration-after-statement) $(call cc-option-add,CFLAGS,CC,-Wno-unused-but-set-variable)
xen/arch/x86/traps.c +2 -2
@@ -2011,7 +2011,7 @@ uint32_t guest_io_read(unsigned int port, unsigned int bytes, { sub_data =pv_pit_handler (port,0 ,0 ); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) ) { sub_data = currd->arch.cmos_idx; }
@@ -2080,7 +2080,7 @@ void guest_io_write(unsigned int port, unsigned int bytes, uint32_t data, {pv_pit_handler (port, (uint8_t )data,1 ); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) ) { currd->arch.cmos_idx = data; }
Signature · 7 lines
2.10.1 (Apple Git-78) _______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
Re: [PATCH v4 4/4] build: enable no-parentheses in clang
Quoted 19 lines · Roger Pau Monne
And fix the following errors reported:
traps.c:2014:25: error: equality comparison with extraneous parentheses
[-Werror,-Wparentheses-equality] else if ( (port == RTC_PORT(0)) ) ~~~~~^~~~~~~~~~~~~~traps.c:2014:25: note: remove extraneous parentheses around the comparison to silence this warning
else if ( (port ==RTC_PORT(0)) )
~ ^ ~
traps.c:2014:25: note: use '=' to turn this equality comparison into an assignmentelse if ( (port == RTC_PORT(0)) ) ^~ = traps.c:2083:25: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] else if ( (port == RTC_PORT(0)) ) ~~~~~^~~~~~~~~~~~~~Signed-off-by Roger Pau Monné <[email protected]>
Quoted 9 lines
---
Cc: Andrew Cooper <[email protected]>
Cc: George Dunlap <[email protected]>
Cc: Ian Jackson <[email protected]>
Cc: Jan Beulich <[email protected]>
Cc: Konrad Rzeszutek Wilk <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: Tim Deegan <[email protected]>
Cc: Wei Liu <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
Re: [PATCH v4 4/4] build: enable no-parentheses in clang
In reply to Roger Pau MonneConfig.mk CFLAGS += -std=gnu99 · line 216
Quoted 9 lines
Quoted 1 line
Quoted 1 line · On 14.02.17 at 13:30, <[email protected]> wrote:
Config.mk +0
-2@@ -212,9 +212,6 @@ CFLAGS += -std=gnu99 CFLAGS += -Wall -Wstrict-prototypes -# Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...' -CFLAGS-$(clang) += -Wno-parentheses
Taking the comment being removed here together with ....
Quoted 12 lines
xen/arch/x86/traps.c +1
-1@@ -2011,7 +2011,7 @@ uint32_t guest_io_read(unsigned int port, unsigned int bytes, { sub_data =pv_pit_handler (port,0 ,0 ); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) ) { sub_data = currd->arch.cmos_idx; }
xen/arch/x86/traps.c void guest_io_write(unsigned int port, unsigned int bytes, uint32_t data, · line 2086
Quoted 8 lines
xen/arch/x86/traps.c +1
-1@@ -2080,7 +2080,7 @@ void guest_io_write(unsigned int port, unsigned int bytes, uint32_t data, {pv_pit_handler (port, (uint8_t )data,1 ); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) ) { currd->arch.cmos_idx = data; }
... the code adjustments all being to other than macros I wonder whether in the version you use the issue is no longer being reported in macro expansions, but older clang still chokes on such. Or did you go check that we have no such uses left (which seems unlikely to me)?
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
Re: [PATCH v4 4/4] build: enable no-parentheses in clang
Quoted 30 lines · Jan Beulich
Config.mk CFLAGS += -std=gnu99 · line 216
Quoted 9 lines
Quoted 1 line
Quoted 1 line · On 14.02.17 at 13:30, <[email protected]> wrote:
Config.mk +0
-2@@ -212,9 +212,6 @@ CFLAGS += -std=gnu99 CFLAGS += -Wall -Wstrict-prototypes -# Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...' -CFLAGS-$(clang) += -Wno-parenthesesTaking the comment being removed here together with ....
Quoted 18 lines
xen/arch/x86/traps.c +2
-2@@ -2011,7 +2011,7 @@ uint32_t guest_io_read(unsigned int port, unsigned int bytes, { sub_data =pv_pit_handler (port,0 ,0 ); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) ) { sub_data = currd->arch.cmos_idx; }@@ -2080,7 +2080,7 @@ void guest_io_write(unsigned int port, unsigned int bytes, uint32_t data, {pv_pit_handler (port, (uint8_t )data,1 ); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) ) {
Quoted 8 lines
xen/arch/x86/traps.c void guest_io_write(unsigned int port, unsigned int bytes, uint32_t data, · line 2086
Quoted 2 lines
xen/arch/x86/traps.c +0
-0currd->arch.cmos_idx = data; }... the code adjustments all being to other than macros I wonder whether in the version you use the issue is no longer being reported in macro expansions, but older clang still chokes on such. Or did you go check that we have no such uses left (which seems unlikely to me)?
I assume that in recent versions of clang this is no longer an issue. Travis tests with clang 3.5 and I test with 3.8, and none of them find any issues. IMHO we should turn it on because I barely doubt anyone is building Xen with older versions of clang, when I started working on this the clang support was completely bitrotted.
Roger.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
Re: [PATCH v4 4/4] build: enable no-parentheses in clang
Quoted 37 lines · Roger Pau Monne
Quoted 28 lines · Jan Beulich
Config.mk CFLAGS += -std=gnu99 · line 216
Quoted 9 lines
Quoted 1 line
Quoted 1 line · On 14.02.17 at 13:30, <[email protected]> wrote:
Config.mk +0
-2@@ -212,9 +212,6 @@ CFLAGS += -std=gnu99 CFLAGS += -Wall -Wstrict-prototypes -# Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...' -CFLAGS-$(clang) += -Wno-parenthesesTaking the comment being removed here together with ....
Quoted 17 lines
xen/arch/x86/traps.c +2
-2@@ -2011,7 +2011,7 @@ uint32_t guest_io_read(unsigned int port, unsigned int bytes, { sub_data =pv_pit_handler (port,0 ,0 ); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) ) { sub_data = currd->arch.cmos_idx; }@@ -2080,7 +2080,7 @@ void guest_io_write(unsigned int port, unsigned int bytes, uint32_t data, {pv_pit_handler (port, (uint8_t )data,1 ); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) )Quoted 8 lines
xen/arch/x86/traps.c void guest_io_write(unsigned int port, unsigned int bytes, uint32_t data, · line 2086
Quoted 3 lines
xen/arch/x86/traps.c +0
-0{ currd->arch.cmos_idx = data; }... the code adjustments all being to other than macros I wonder whether in the version you use the issue is no longer being reported in macro expansions, but older clang still chokes on such. Or did you go check that we have no such uses left (which seems unlikely to me)?
Quoted 5 lines
I assume that in recent versions of clang this is no longer an issue. Travis tests with clang 3.5 and I test with 3.8, and none of them find any issues. IMHO we should turn it on because I barely doubt anyone is building Xen with older versions of clang, when I started working on this the clang support was completely bitrotted.
There was some Clang 3.2 support in the past, but it had completely bitrotten.
Clang 3.5 is our documented minimum, so I think it is reasonable to take these clobbers out, seeing as they are not needed.
~Andrew
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
Re: [PATCH v4 4/4] build: enable no-parentheses in clang
Quoted 45 lines
Quoted 1 line
Quoted 1 line · On 14.02.17 at 15:13, <[email protected]> wrote:
Quoted 37 lines · Roger Pau Monne
Quoted 28 lines · Jan Beulich
Config.mk CFLAGS += -std=gnu99 · line 216
Quoted 9 lines
Quoted 1 line
Quoted 1 line · On 14.02.17 at 13:30, <[email protected]> wrote:
Config.mk +0
-2@@ -212,9 +212,6 @@ CFLAGS += -std=gnu99 CFLAGS += -Wall -Wstrict-prototypes -# Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...' -CFLAGS-$(clang) += -Wno-parenthesesTaking the comment being removed here together with ....
Quoted 17 lines
xen/arch/x86/traps.c +2
-2@@ -2011,7 +2011,7 @@ uint32_t guest_io_read(unsigned int port, unsigned int bytes, { sub_data =pv_pit_handler (port,0 ,0 ); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) ) { sub_data = currd->arch.cmos_idx; }@@ -2080,7 +2080,7 @@ void guest_io_write(unsigned int port, unsigned int bytes, uint32_t data, {pv_pit_handler (port, (uint8_t )data,1 ); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) )Quoted 8 lines
xen/arch/x86/traps.c void guest_io_write(unsigned int port, unsigned int bytes, uint32_t data, · line 2086
Quoted 3 lines
xen/arch/x86/traps.c +0
-0{ currd->arch.cmos_idx = data; }... the code adjustments all being to other than macros I wonder whether in the version you use the issue is no longer being reported in macro expansions, but older clang still chokes on such. Or did you go check that we have no such uses left (which seems unlikely to me)?
Quoted 5 lines
I assume that in recent versions of clang this is no longer an issue. Travis tests with clang 3.5 and I test with 3.8, and none of them find any issues. IMHO we should turn it on because I barely doubt anyone is building Xen with older versions of clang, when I started working on this the clang support was completely bitrotted.
Quoted 5 lines
There was some Clang 3.2 support in the past, but it had completely bitrotten.
Clang 3.5 is our documented minimum, so I think it is reasonable to take these clobbers out, seeing as they are not needed.
Okay, if the minimum version was tested, then I'm fine with the adjustment.
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel