Skip to contentSkip to conversation

iommu: of: Fix check for returning EPROBE_DEFER

PATCH In review Sricharan R 2 participants 3 messages May 16, 2017 – May 17, 2017

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iommu: of: Fix check for returning EPROBE_DEFER

While returning EPROBE_DEFER for iommu masters
take in to account of iommu nodes that could be
marked in DT as 'status=disabled', in which case
simply return NULL and let the master's probe
continue rather than deferring.

---
 drivers/iommu/of_iommu.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iommu/of_iommu.c +1 -0
index 9f44ee8..e6e9bec 100644
@@ -118,6 +118,7 @@ static bool of_iommu_driver_present(struct device_node *np)
 
 	ops = iommu_ops_from_fwnode(fwnode);
 	if ((ops && !ops->of_xlate) ||
+	    !of_device_is_available(iommu_spec->np) ||
 	    (!ops && !of_iommu_driver_present(iommu_spec->np)))
 		return NULL;
 
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#1 lore raw

Hi, I have a few suggestions on how to make this commit message more readable:

Quoted 1 line · Sricharan R

While returning EPROBE_DEFER for iommu masters

Add a comma at the end of this line

Quoted 1 line

take in to account of iommu nodes that could be

s/in to/into/
s/of iommu/of_iommu/

Quoted 7 lines

marked in DT as 'status=disabled', in which case simply return NULL and let the master's probe continue rather than deferring.

Thanks,
Jonathan Neuschäfer

#2 lore raw

Hi,

Quoted 4 lines · Jonathan Neuschäfer

Hi, I have a few suggestions on how to make this commit message more readable:

On Tue, May 16, 2017 at 10:54:13AM +0530, Sricharan R wrote:

Quoted 9 lines
Quoted 1 line

While returning EPROBE_DEFER for iommu masters

Add a comma at the end of this line

Quoted 1 line

take in to account of iommu nodes that could be

s/in to/into/
s/of iommu/of_iommu/

ok, will correct the above.

Regards,
Sricharan

Quoted 12 lines
Quoted 7 lines

marked in DT as 'status=disabled', in which case simply return NULL and let the master's probe continue rather than deferring.

Thanks,
Jonathan Neuschäfer

Signature · 5 lines
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu