Skip to contentSkip to conversation

libbpf: zip: Remove unneeded semicolon from zip_archive_open()

PATCH In review [email protected] 2 participants 2 messages Jun 14, 2023 – Jun 16, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 libbpf: zip: Remove unneeded semicolon from zip_archive_open()

./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon

---
 tools/lib/bpf/zip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/bpf/zip.c +1 -1
index 3f26d629b2b4..88c376a8348d 100644
@@ -223,7 +223,7 @@ struct zip_archive *zip_archive_open(const char *path)
     if (!archive) {
         munmap(data, size);
         return ERR_PTR(-ENOMEM);
-    };
+    }
 
     archive->data = data;
     archive->size = size;
#2 lore raw
Quoted 2 lines · On Wed, Jun 14, 2023 at 1:29 AM <[email protected]> wrote:

./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon

This is not a very human-readable commit message. Something like

Drop unnecessary semicolon, which triggers (presumable coccicheck?) warning:

./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon

But also this doesn't apply cleanly to bpf-next tree. Please rebase and resend. Also make sure to have [PATCH bpf-next] prefix in email subject. Thanks.

Quoted 20 lines
---
  tools/lib/bpf/zip.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/bpf/zip.c +1 -1
index 3f26d629b2b4..88c376a8348d 100644
@@ -223,7 +223,7 @@ struct zip_archive *zip_archive_open(const char
 *path)
      if (!archive) {
          munmap(data, size);
          return ERR_PTR(-ENOMEM);
-    };
+    }
 
      archive->data = data;
      archive->size = size;