coresight: Fix all W=1 build warnings
PATCH 1/1 coresight: Fix all W=1 build warnings
The kernel test robot looks for new warnings in a W=1 build, so fix all the existing warnings to make it easier to spot new ones when building locally.
The fixes are for undocumented function arguments and an incorrect doc style.
--- drivers/hwtracing/coresight/coresight-cti-core.c | 2 +- drivers/hwtracing/coresight/coresight-etm4x-cfg.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/hwtracing/coresight/coresight-cti-core.c +1 -1
@@ -22,7 +22,7 @@#include "coresight-priv.h" #include "coresight-cti.h" -/** +/* * CTI devices can be associated with a PE, or be connected to CoreSight * hardware. We have a list of all CTIs irrespective of CPU bound or * otherwise.
drivers/hwtracing/coresight/coresight-etm4x-cfg.c +2 -2
@@ -40,7 +40,7 @@* Invalid offsets will result in fail code return and feature load failure. * * @drvdata: driver data to map into. -* @reg: register to map. +* @reg_csdev: register to map. * @offset: device offset for the register */ static int etm4_cfg_map_reg_offset(struct etmv4_drvdata *drvdata,
@@ -132,7 +132,7 @@ static int etm4_cfg_map_reg_offset(struct etmv4_drvdata *drvdata,* etm4_cfg_load_feature - load a feature into a device instance. * * @csdev: An ETMv4 CoreSight device. -* @feat: The feature to be loaded. +* @feat_csdev: The feature to be loaded. * * The function will load a feature instance into the device, checking that * the register definitions are valid for the device.
Signature · 1 line
2.34.1
Quoted 50 lines · James Clark
The kernel test robot looks for new warnings in a W=1 build, so fix all the existing warnings to make it easier to spot new ones when building locally.
The fixes are for undocumented function arguments and an incorrect doc style.
Signed-off-by James Clark <[email protected]>--- drivers/hwtracing/coresight/coresight-cti-core.c | 2 +- drivers/hwtracing/coresight/coresight-etm4x-cfg.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)drivers/hwtracing/coresight/coresight-cti-core.c +1
-1@@ -22,7 +22,7 @@#include "coresight-priv.h" #include "coresight-cti.h" -/** +/* * CTI devices can be associated with a PE, or be connected to CoreSight * hardware. We have a list of all CTIs irrespective of CPU bound or * otherwise. drivers/hwtracing/coresight/coresight-etm4x-cfg.c +2
-3@@ -40,7 +40,7 @@* Invalid offsets will result in fail code return and feature load failure. * * @drvdata: driver data to map into. -* @reg: register to map. +* @reg_csdev: register to map. * @offset: device offset for the register */ static int etm4_cfg_map_reg_offset(struct etmv4_drvdata *drvdata,@@ -132,7 +132,7 @@ static int etm4_cfg_map_reg_offset(struct etmv4_drvdata *drvdata,* etm4_cfg_load_feature - load a feature into a device instance. * * @csdev: An ETMv4 CoreSight device. -* @feat: The feature to be loaded. +* @feat_csdev: The feature to be loaded. * * The function will load a feature instance into the device, checking that * the register definitions are valid for the device. --
Quoted 2 lines
2.34.1
Signature · 3 lines
Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK
Quoted 8 lines · James Clark
The kernel test robot looks for new warnings in a W=1 build, so fix all the existing warnings to make it easier to spot new ones when building locally.
The fixes are for undocumented function arguments and an incorrect doc style.
[...]
Applied, thanks!
[1/1] coresight: Fix all W=1 build warnings
https://git.kernel.org/coresight/c/04e8429c5b4f644257fe64db3403205a7a41e33b
Best regards,
Signature · 1 line
Suzuki K Poulose <[email protected]>
Suzuki K Poulose
maintainerQuoted 8 lines · Suzuki K Poulose
Quoted 7 lines · James Clark
The kernel test robot looks for new warnings in a W=1 build, so fix all the existing warnings to make it easier to spot new ones when building locally.
The fixes are for undocumented function arguments and an incorrect doc style.
Quoted 6 lines
Quoted 1 line
[...]
Applied, thanks!
[1/1] coresight: Fix all W=1 build warnings
https://git.kernel.org/coresight/c/04e8429c5b4f644257fe64db3403205a7a41e33b
Apologies, that should be:
https://git.kernel.org/coresight/c/04e8429c5b4f
Suzuki