Skip to contentSkip to conversation

drm/stm: dsi: Use devm_platform_ioremap_resource()

PATCH In review Yang Li 3 participants 3 messages Apr 21, 2023 – May 26, 2023

Subsystems (4)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 drm/stm: dsi: Use devm_platform_ioremap_resource()

Convert platform_get_resource(),devm_ioremap_resource() to a single call to devm_platform_ioremap_resource(), as this is exactly what this function does.

---
 drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c +1 -3
index 89897d5f5c72..1750b6a25e87 100644
@@ -444,15 +444,13 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct dw_mipi_dsi_stm *dsi;
 	struct clk *pclk;
-	struct resource *res;
 	int ret;
 
 	dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
 	if (!dsi)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	dsi->base = devm_ioremap_resource(dev, res);
+	dsi->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(dsi->base)) {
 		ret = PTR_ERR(dsi->base);
 		DRM_ERROR("Unable to get dsi registers %d\n", ret);
Signature · 1 line
2.20.1.7.g153144c
maintainer Acked-by on v1 1/1
#1 lore raw

Hi Yang,

Quoted 20 lines · Yang Li

Convert platform_get_resource(),devm_ioremap_resource() to a single call to devm_platform_ioremap_resource(), as this is exactly what this function does.

---
 drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c +0 -1
index 89897d5f5c72..1750b6a25e87 100644
@@ -444,15 +444,13 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct dw_mipi_dsi_stm *dsi;
 	struct clk *pclk;
-	struct resource *res;
 	int ret;
 

drivers/gpu/drm/stm/dw_mipi_dsi-stm.c static int dw_mipi_dsi_stm_probe(struct platform_device *pdev) · line 456

Quoted 10 lines
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c +1 -2
 	dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
 	if (!dsi)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	dsi->base = devm_ioremap_resource(dev, res);
+	dsi->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(dsi->base)) {
 		ret = PTR_ERR(dsi->base);
 		DRM_ERROR("Unable to get dsi registers %d\n", ret);

Thanks for the patch.

maintainer
#2 lore raw
In reply to Yang Li
Quoted 20 lines · Yang Li

Convert platform_get_resource(),devm_ioremap_resource() to a single call to devm_platform_ioremap_resource(), as this is exactly what this function does.

---
  drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c +0 -1
index 89897d5f5c72..1750b6a25e87 100644
@@ -444,15 +444,13 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
  	struct device *dev = &pdev->dev;
  	struct dw_mipi_dsi_stm *dsi;
  	struct clk *pclk;
-	struct resource *res;
  	int ret;
 

drivers/gpu/drm/stm/dw_mipi_dsi-stm.c static int dw_mipi_dsi_stm_probe(struct platform_device *pdev) · line 456

Quoted 10 lines
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c +1 -2
  	dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
  	if (!dsi)
  		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	dsi->base = devm_ioremap_resource(dev, res);
+	dsi->base = devm_platform_ioremap_resource(pdev, 0);
  	if (IS_ERR(dsi->base)) {
  		ret = PTR_ERR(dsi->base);
  		DRM_ERROR("Unable to get dsi registers %d\n", ret);

Applied on drm-misc-next.
Many thanks for your patch,
Philippe :-)