Skip to contentSkip to conversation

crda: rdepends on wireless-regdb-static

PATCH In review kai 2 participants 5 messages Sep 24, 2020 – Sep 28, 2020

lore
Share & tools
lore

kai

author
#0 lore raw

PATCH 1/1 crda: rdepends on wireless-regdb-static

From: Robert Yang <[email protected]>

The wireless-regdb has been moved to oe-core. According the commit message:

wireless-regdb-static should be used with kernel >= 4.15. wireless-regdb can be used with older kernels and is mostly irrelevant here, but keeping it in meta-networking would create needless recipe duplication.

it should replace runtime dependency wireless-regdb with wireless-regdb-static.

---
 meta-networking/recipes-connectivity/crda/crda_3.18.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-connectivity/crda/crda_3.18.bb +1 -1
index b380eaf94..e59d2f437 100644
@@ -35,4 +35,4 @@ do_install() {
     oe_runmake SBINDIR=${sbindir}/ install
 }
 
-RDEPENDS_${PN} = "udev wireless-regdb"
+RDEPENDS_${PN} = "udev wireless-regdb-static"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 25 lines · kai

From: Robert Yang <[email protected]>

The wireless-regdb has been moved to oe-core. According the commit message:

wireless-regdb-static should be used with kernel >= 4.15. wireless-regdb can be used with older kernels and is mostly irrelevant here, but keeping it in meta-networking would create needless recipe duplication.

it should replace runtime dependency wireless-regdb with wireless-regdb-static.

---
 meta-networking/recipes-connectivity/crda/crda_3.18.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-connectivity/crda/crda_3.18.bb +0 -0
index b380eaf94..e59d2f437 100644

meta-networking/recipes-connectivity/crda/crda_3.18.bb do_install() { · line 38

Quoted 5 lines
meta-networking/recipes-connectivity/crda/crda_3.18.bb +1 -1
@@ -35,4 +35,4 @@ do_install() {
     oe_runmake SBINDIR=${sbindir}/ install
 }
 
-RDEPENDS_${PN} = "udev wireless-regdb"
+RDEPENDS_${PN} = "udev wireless-regdb-static"

It was wrong/at least dangerous before this - but the operator '+=' should be used

Andreas

author
#2 lore raw
Quoted 28 lines · Andreas Müller
Quoted 27 lines · kai

From: Robert Yang <[email protected]>

The wireless-regdb has been moved to oe-core. According the commit message:

wireless-regdb-static should be used with kernel >= 4.15. wireless-regdb can be used with older kernels and is mostly irrelevant here, but keeping it in meta-networking would create needless recipe duplication.

it should replace runtime dependency wireless-regdb with wireless-regdb-static.

---
  meta-networking/recipes-connectivity/crda/crda_3.18.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-connectivity/crda/crda_3.18.bb +0 -0
index b380eaf94..e59d2f437 100644
@@ -35,4 +35,4 @@ do_install() {
      oe_runmake SBINDIR=${sbindir}/ install
  }
 
Quoted 4 lines

meta-networking/recipes-connectivity/crda/crda_3.18.bb do_install() { · line 38

Quoted 2 lines
meta-networking/recipes-connectivity/crda/crda_3.18.bb +1 -1
-RDEPENDS_${PN} = "udev wireless-regdb"
+RDEPENDS_${PN} = "udev wireless-regdb-static"

It was wrong/at least dangerous before this - but the operator '+=' should be used

Hi Andreas,

Thanks for your comment.

I do not get your point why it is dangerous. From output of 'bitbake -e crda', RDEPENDS_crda is evaluated by:

# $RDEPENDS_crda [2 operations]
#   set /buildarea6/kkang/Yocto/meta-openembedded/meta-networking/recipes-connectivity/crda/crda_3.18.bb:38 #     "udev wireless-regdb-static"
#   rename from RDEPENDS_${PN} data.py:104 [expandKeys]
#     "udev wireless-regdb-static"

# pre-expansion value:
#   "udev wireless-regdb-static"
RDEPENDS_crda="udev wireless-regdb-static"

It does not show differences compares to other recipes that "RDEPENDS_${PN} =" widely used.

Regards,
Kai

Quoted 5 lines

Andreas

Signature · 2 lines
Kai Kang
Wind River Linux
#3 lore raw
Quoted 49 lines · Kang Kai

On 9/25/20 5:36 AM, Andreas Müller wrote:

On Thu, Sep 24, 2020 at 11:36 AM kai <[email protected]> wrote:

From: Robert Yang <[email protected]>

The wireless-regdb has been moved to oe-core. According the commit message:

wireless-regdb-static should be used with kernel >= 4.15. wireless-regdb can be used with older kernels and is mostly irrelevant here, but keeping it in meta-networking would create needless recipe duplication.

it should replace runtime dependency wireless-regdb with wireless-regdb-static.

---
 meta-networking/recipes-connectivity/crda/crda_3.18.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-connectivity/crda/crda_3.18.bb +1 -1
index b380eaf94..e59d2f437 100644
@@ -35,4 +35,4 @@ do_install() {
     oe_runmake SBINDIR=${sbindir}/ install
 }
 
-RDEPENDS_${PN} = "udev wireless-regdb"
+RDEPENDS_${PN} = "udev wireless-regdb-static"

It was wrong/at least dangerous before this - but the operator '+=' should be used

Hi Andreas,

Thanks for your comment.

I do not get your point why it is dangerous. From output of 'bitbake -e crda', RDEPENDS_crda is evaluated by:

# $RDEPENDS_crda [2 operations]
# set /buildarea6/kkang/Yocto/meta-openembedded/meta-networking/recipes-connectivity/crda/crda_3.18.bb:38
# "udev wireless-regdb-static"
# rename from RDEPENDS_${PN} data.py:104 [expandKeys]
# "udev wireless-regdb-static"

Quoted 6 lines
# pre-expansion value:
#   "udev wireless-regdb-static"
RDEPENDS_crda="udev wireless-regdb-static"

It does not show differences compares to other recipes that "RDEPENDS_${PN} =" widely used.

I could swear there were times that just using '=' overided the RDEPNEDS done by ldd-like-magic. Checked in pkgdata: the results are the same. So: Sorry for the noise

Andreas

author
#4 lore raw
Quoted 53 lines · Andreas Müller
Quoted 52 lines · Kang Kai

On 9/25/20 5:36 AM, Andreas Müller wrote:

On Thu, Sep 24, 2020 at 11:36 AM kai <[email protected]> wrote:

From: Robert Yang <[email protected]>

The wireless-regdb has been moved to oe-core. According the commit message:

wireless-regdb-static should be used with kernel >= 4.15. wireless-regdb can be used with older kernels and is mostly irrelevant here, but keeping it in meta-networking would create needless recipe duplication.

it should replace runtime dependency wireless-regdb with wireless-regdb-static.

---
  meta-networking/recipes-connectivity/crda/crda_3.18.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-connectivity/crda/crda_3.18.bb +1 -1
index b380eaf94..e59d2f437 100644
@@ -35,4 +35,4 @@ do_install() {
      oe_runmake SBINDIR=${sbindir}/ install
  }
 
-RDEPENDS_${PN} = "udev wireless-regdb"
+RDEPENDS_${PN} = "udev wireless-regdb-static"

It was wrong/at least dangerous before this - but the operator '+=' should be used

Hi Andreas,

Thanks for your comment.

I do not get your point why it is dangerous. From output of 'bitbake -e crda', RDEPENDS_crda is evaluated by:

# $RDEPENDS_crda [2 operations]
# set /buildarea6/kkang/Yocto/meta-openembedded/meta-networking/recipes-connectivity/crda/crda_3.18.bb:38
# "udev wireless-regdb-static"
# rename from RDEPENDS_${PN} data.py:104 [expandKeys]
# "udev wireless-regdb-static"

# pre-expansion value:
#   "udev wireless-regdb-static"
RDEPENDS_crda="udev wireless-regdb-static"
Quoted 5 lines
Quoted 2 lines

It does not show differences compares to other recipes that "RDEPENDS_${PN} =" widely used.

I could swear there were times that just using '=' overided the RDEPNEDS done by ldd-like-magic. Checked in pkgdata: the results are the same. So: Sorry for the noise

It is ok. Thanks all the same.

Regards,
Kai

Quoted 2 lines

Andreas

Signature · 2 lines
Kai Kang
Wind River Linux