vhost: missing __user tags
Subsystems (5)
Michael S. Tsirkin
maintainerPATCH 1/1 vhost: missing __user tags
sparse warns about converting void * to void __user *. This is not new but only got noticed now that vhost is built on more systems. This is just a question of __user tags missing in a couple of places, so fix it up.
Fixes f88949138058 ("vhost: introduce O(1) vq metadata cache")
Reported-by kbuild test robot <[email protected]>
Signed-off-by Michael S. Tsirkin <[email protected]>
--- drivers/vhost/vhost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/vhost/vhost.c +2 -2
@@ -730,7 +730,7 @@ static inline void __user *vhost_vq_meta_fetch(struct vhost_virtqueue *vq,if (!map)return NULL ; -return (void *)(uintptr_t )(map->addr + addr - map->start); +return (void __user *)(uintptr_t )(map->addr + addr - map->start); }/* Can we switch to this memory table? */
@@ -869,7 +869,7 @@ static void __user *__vhost_get_user_slow(struct vhost_virtqueue *vq,* not happen in this case. */ static inline void __user *__vhost_get_user (struct vhost_virtqueue *vq, -void *addr,unsigned int size, +void __user *addr,unsigned int size,int type) { void __user *uaddr = vhost_vq_meta_fetch(vq,
Signature · 1 line
MST
Quoted 26 lines · Michael S. Tsirkin
sparse warns about converting void * to void
__user*. This is not new but only got noticed now that vhost is built on more systems. This is just a question of__usertags missing in a couple of places, so fix it up.Fixes f88949138058 ("vhost: introduce O(1) vq metadata cache")Reported-by kbuild test robot <[email protected]>Signed-off-by Michael S. Tsirkin <[email protected]>--- drivers/vhost/vhost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/vhost/vhost.c +1
-1@@ -730,7 +730,7 @@ static inline void __user *vhost_vq_meta_fetch(struct vhost_virtqueue *vq,if (!map)return NULL ; -return (void *)(uintptr_t )(map->addr + addr - map->start); +return (void __user *)(uintptr_t )(map->addr + addr - map->start); }/* Can we switch to this memory table? */
drivers/vhost/vhost.c static void __user *__vhost_get_user_slow(struct vhost_virtqueue *vq, · line 875
Quoted 8 lines
drivers/vhost/vhost.c +1
-1@@ -869,7 +869,7 @@ static void __user *__vhost_get_user_slow(struct vhost_virtqueue *vq,* not happen in this case. */ static inline void __user *__vhost_get_user (struct vhost_virtqueue *vq, -void *addr,unsigned int size, +void __user *addr,unsigned int size,int type) { void __user *uaddr = vhost_vq_meta_fetch(vq,
Acked-by Jason Wang <[email protected]>
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization