Change in openvpn[master]: Only announce support push updates/IV_NCP when actually supporting it
A message that is not in the archive (sent off-list or not yet received): gerrit.1776768003000.I0737b769e78e6d271ec874cadb9fbd81bfefdec1@gerrit.openvpn.net
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email )
Change subject: Only announce support push updates/IV_NCP when actually supporting it
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File src/openvpn/ssl.c:
http://gerrit.openvpn.net/c/openvpn/+/1634/comment/6508d17c_46eba2f4?usp=email :
PS1, Line 1951: * of IV_CIPHERS */
missing closing parenthesis
http://gerrit.openvpn.net/c/openvpn/+/1634/comment/f3ccea45_937a2361?usp=email :
PS1, Line 1960: /* We are not using pull or p2mp server, instead do P2P NCP */
comment is now out-of-sync with code
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0737b769e78e6d271ec874cadb9fbd81bfefdec1
Gerrit-Change-Number: 1634
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Mon, 22 Jun 2026 13:21:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by flichtenheld
Change subject: Only announce support push updates/IV_NCP when actually supporting it
......................................................................
Only announce support push updates/IV_NCP when actually supporting it
Currently even p2p clients that do not accept push message, so announcing PUSH UPDATE or DNSv2 is not very useful.
The change for IV_NCP is more a documentation bugfix as in mode server we currently never have push_peer_info_detail > 0.
But change the message to indicate that IV_NCP nowadays is more a legacy variable and replaced by IV_CIPHERS.
---
M src/openvpn/ssl.c
1 file changed, 12 insertions(+), 14 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/34/1634/2
src/openvpn/ssl.c +12 -14
@@ -1914,21 +1914,21 @@/* support for P_DATA_V2 */ int iv_proto =IV_PROTO_DATA_V2 ; -/* support for the latest --dns option */ - iv_proto |=IV_PROTO_DNS_OPTION_V2 ; -/* support for exit notify via control channel */ iv_proto |=IV_PROTO_CC_EXIT_NOTIFY ; -/* currently push-update is not supported when DCO is enabled */ -if (!session->opt->dco_enabled) - { -/* support push-updates */ - iv_proto |=IV_PROTO_PUSH_UPDATE ; - } -if (session->opt->pull) { +/* support for the latest --dns option */ + iv_proto |=IV_PROTO_DNS_OPTION_V2 ; + +/* currently push-update is not supported when DCO is enabled */ +if (!session->opt->dco_enabled) + { +/* support push-updates */ + iv_proto |=IV_PROTO_PUSH_UPDATE ; + } +/* support for receiving push_reply before sending * push request, also signal that the client wants * to get push-reply messages without requiring a round
@@ -1943,11 +1943,9 @@/* support for tun-mtu as part of the push message */ buf_printf (&out,"IV_MTU=%d\n" , session->opt->frame.tun_max_mtu); - } -/* support for Negotiable Crypto Parameters */ -if (session->opt->mode ==MODE_SERVER || session->opt->pull) - { +/* legacy support for Negotiable Crypto Parameters (deprecated in favour +* of IV_CIPHERS */ if (tls_item_in_cipher_list ("AES-128-GCM" , session->opt->config_ncp_ciphers) &&tls_item_in_cipher_list ("AES-256-GCM" , session->opt->config_ncp_ciphers)) {
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0737b769e78e6d271ec874cadb9fbd81bfefdec1
Gerrit-Change-Number: 1634
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email )
Change subject: Only announce support push updates/IV_NCP when actually supporting it
......................................................................
Patch Set 2: Code-Review-1
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0737b769e78e6d271ec874cadb9fbd81bfefdec1
Gerrit-Change-Number: 1634
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Mon, 22 Jun 2026 13:30:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review-1 by flichtenheld
Change subject: Only announce support push updates/IV_NCP when actually supporting it
......................................................................
Only announce support push updates/IV_NCP when actually supporting it
Currently even p2p clients that do not accept push message, so announcing PUSH UPDATE or DNSv2 is not very useful.
The change for IV_NCP is more a documentation bugfix as in mode server we currently never have push_peer_info_detail > 0.
But change the message to indicate that IV_NCP nowadays is more a legacy variable and replaced by IV_CIPHERS.
---
M src/openvpn/ssl.c
1 file changed, 13 insertions(+), 15 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/34/1634/3
src/openvpn/ssl.c +13 -15
@@ -1914,21 +1914,21 @@/* support for P_DATA_V2 */ int iv_proto =IV_PROTO_DATA_V2 ; -/* support for the latest --dns option */ - iv_proto |=IV_PROTO_DNS_OPTION_V2 ; -/* support for exit notify via control channel */ iv_proto |=IV_PROTO_CC_EXIT_NOTIFY ; -/* currently push-update is not supported when DCO is enabled */ -if (!session->opt->dco_enabled) - { -/* support push-updates */ - iv_proto |=IV_PROTO_PUSH_UPDATE ; - } -if (session->opt->pull) { +/* support for the latest --dns option */ + iv_proto |=IV_PROTO_DNS_OPTION_V2 ; + +/* currently push-update is not supported when DCO is enabled */ +if (!session->opt->dco_enabled) + { +/* support push-updates */ + iv_proto |=IV_PROTO_PUSH_UPDATE ; + } +/* support for receiving push_reply before sending * push request, also signal that the client wants * to get push-reply messages without requiring a round
@@ -1943,11 +1943,9 @@/* support for tun-mtu as part of the push message */ buf_printf (&out,"IV_MTU=%d\n" , session->opt->frame.tun_max_mtu); - } -/* support for Negotiable Crypto Parameters */ -if (session->opt->mode ==MODE_SERVER || session->opt->pull) - { +/* legacy support for Negotiable Crypto Parameters (deprecated in +* favour of IV_CIPHERS) */ if (tls_item_in_cipher_list ("AES-128-GCM" , session->opt->config_ncp_ciphers) &&tls_item_in_cipher_list ("AES-256-GCM" , session->opt->config_ncp_ciphers)) {
@@ -1956,7 +1954,7 @@ }else { -/* We are not using pull or p2mp server, instead do P2P NCP */ +/* If we are not using pull we announce P2P NCP support */ iv_proto |=IV_PROTO_NCP_P2P ; }
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0737b769e78e6d271ec874cadb9fbd81bfefdec1
Gerrit-Change-Number: 1634
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email )
Change subject: Only announce support push updates/IV_NCP when actually supporting it
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File src/openvpn/ssl.c:
http://gerrit.openvpn.net/c/openvpn/+/1634/comment/f68afcba_f0324f2d?usp=email :
PS1, Line 1951: * of IV_CIPHERS */
Quoted 1 line
missing closing parenthesis
Done
http://gerrit.openvpn.net/c/openvpn/+/1634/comment/c67440a8_2d6c4410?usp=email :
PS1, Line 1960: /* We are not using pull or p2mp server, instead do P2P NCP */
Quoted 1 line
comment is now out-of-sync with code
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0737b769e78e6d271ec874cadb9fbd81bfefdec1
Gerrit-Change-Number: 1634
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Mon, 22 Jun 2026 14:24:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
PATCH v6 1/1 Only announce support push updates/IV_NCP when actually supporting it
In reply to a message not in the archiveFrom: Arne Schwabe <[email protected]>
Currently even p2p clients that do not accept push message, so announcing PUSH UPDATE or DNSv2 is not very useful.
The change for IV_NCP is more a documentation bugfix as in mode server we currently never have push_peer_info_detail > 0.
But change the message to indicate that IV_NCP nowadays is more a legacy variable and replaced by IV_CIPHERS.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1634
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1634
This mail reflects revision 6 of this Change.
Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <[email protected]>
src/openvpn/ssl.c +13 -15
@@ -1961,21 +1961,21 @@/* support for P_DATA_V2 */ int iv_proto =IV_PROTO_DATA_V2 ; -/* support for the latest --dns option */ - iv_proto |=IV_PROTO_DNS_OPTION_V2 ; -/* support for exit notify via control channel */ iv_proto |=IV_PROTO_CC_EXIT_NOTIFY ; -/* currently push-update is not supported when DCO is enabled */ -if (!session->opt->dco_enabled) - { -/* support push-updates */ - iv_proto |=IV_PROTO_PUSH_UPDATE ; - } -if (session->opt->pull) { +/* support for the latest --dns option */ + iv_proto |=IV_PROTO_DNS_OPTION_V2 ; + +/* currently push-update is not supported when DCO is enabled */ +if (!session->opt->dco_enabled) + { +/* support push-updates */ + iv_proto |=IV_PROTO_PUSH_UPDATE ; + } +/* support for receiving push_reply before sending * push request, also signal that the client wants * to get push-reply messages without requiring a round
@@ -1990,11 +1990,9 @@/* support for tun-mtu as part of the push message */ buf_printf (&out,"IV_MTU=%d\n" , session->opt->frame.tun_max_mtu); - } -/* support for Negotiable Crypto Parameters */ -if (session->opt->mode ==MODE_SERVER || session->opt->pull) - { +/* legacy support for Negotiable Crypto Parameters (deprecated in +* favour of IV_CIPHERS) */ if (tls_item_in_cipher_list ("AES-128-GCM" , session->opt->config_ncp_ciphers) &&tls_item_in_cipher_list ("AES-256-GCM" , session->opt->config_ncp_ciphers)) {
@@ -2003,7 +2001,7 @@ }else { -/* We are not using pull or p2mp server, instead do P2P NCP */ +/* If we are not using pull we announce P2P NCP support */ iv_proto |=IV_PROTO_NCP_P2P ; }
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
to look at the new patch set (#7).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.
Change subject: Only announce support push updates/IV_NCP when actually supporting it
......................................................................
Only announce support push updates/IV_NCP when actually supporting it
Currently even p2p clients that do not accept push message, so announcing PUSH UPDATE or DNSv2 is not very useful.
The change for IV_NCP is more a documentation bugfix as in mode server we currently never have push_peer_info_detail > 0.
But change the message to indicate that IV_NCP nowadays is more a legacy variable and replaced by IV_CIPHERS.
---
M src/openvpn/ssl.c
1 file changed, 13 insertions(+), 15 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/34/1634/7
src/openvpn/ssl.c +13 -15
@@ -1961,21 +1961,21 @@/* support for P_DATA_V2 */ int iv_proto =IV_PROTO_DATA_V2 ; -/* support for the latest --dns option */ - iv_proto |=IV_PROTO_DNS_OPTION_V2 ; -/* support for exit notify via control channel */ iv_proto |=IV_PROTO_CC_EXIT_NOTIFY ; -/* currently push-update is not supported when DCO is enabled */ -if (!session->opt->dco_enabled) - { -/* support push-updates */ - iv_proto |=IV_PROTO_PUSH_UPDATE ; - } -if (session->opt->pull) { +/* support for the latest --dns option */ + iv_proto |=IV_PROTO_DNS_OPTION_V2 ; + +/* currently push-update is not supported when DCO is enabled */ +if (!session->opt->dco_enabled) + { +/* support push-updates */ + iv_proto |=IV_PROTO_PUSH_UPDATE ; + } +/* support for receiving push_reply before sending * push request, also signal that the client wants * to get push-reply messages without requiring a round
@@ -1990,11 +1990,9 @@/* support for tun-mtu as part of the push message */ buf_printf (&out,"IV_MTU=%d\n" , session->opt->frame.tun_max_mtu); - } -/* support for Negotiable Crypto Parameters */ -if (session->opt->mode ==MODE_SERVER || session->opt->pull) - { +/* legacy support for Negotiable Crypto Parameters (deprecated in +* favour of IV_CIPHERS) */ if (tls_item_in_cipher_list ("AES-128-GCM" , session->opt->config_ncp_ciphers) &&tls_item_in_cipher_list ("AES-256-GCM" , session->opt->config_ncp_ciphers)) {
@@ -2003,7 +2001,7 @@ }else { -/* We are not using pull or p2mp server, instead do P2P NCP */ +/* If we are not using pull we announce P2P NCP support */ iv_proto |=IV_PROTO_NCP_P2P ; }
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0737b769e78e6d271ec874cadb9fbd81bfefdec1
Gerrit-Change-Number: 1634
Gerrit-PatchSet: 7
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Attention is currently required from: plaisthos.
cron2 has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email )
Change subject: Only announce support push updates/IV_NCP when actually supporting it
......................................................................
Patch Set 7: Code-Review-2
(1 comment)
File src/openvpn/ssl.c:
http://gerrit.openvpn.net/c/openvpn/+/1634/comment/60cdb326_0f4bce27?usp=email :
PS7, Line 1997: {
NAK on that change, because it would lead to a setup with --server + --push-peer-info send out IV_PROTO_NCP_P2P... so the MODE_SERVER check is needed. Unlikely scenario, but possible...
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0737b769e78e6d271ec874cadb9fbd81bfefdec1
Gerrit-Change-Number: 1634
Gerrit-PatchSet: 7
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Wed, 15 Jul 2026 14:57:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Attention is currently required from: flichtenheld, plaisthos.
Hello cron2, flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Only announce support push updates/IV_NCP when actually supporting it
......................................................................
Only announce support push updates/IV_NCP when actually supporting it
Currently even p2p clients that do not accept push message, so announcing PUSH UPDATE or DNSv2 is not very useful.
The change for IV_NCP is more a documentation bugfix as in mode server we currently never have push_peer_info_detail > 0.
But change the message to indicate that IV_NCP nowadays is more a legacy variable and replaced by IV_CIPHERS.
---
M src/openvpn/ssl.c
1 file changed, 14 insertions(+), 16 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/34/1634/8
src/openvpn/ssl.c +14 -16
@@ -1914,21 +1914,21 @@/* support for P_DATA_V2 */ int iv_proto =IV_PROTO_DATA_V2 ; -/* support for the latest --dns option */ - iv_proto |=IV_PROTO_DNS_OPTION_V2 ; -/* support for exit notify via control channel */ iv_proto |=IV_PROTO_CC_EXIT_NOTIFY ; -/* currently push-update is not supported when DCO is enabled */ -if (!session->opt->dco_enabled) - { -/* support push-updates */ - iv_proto |=IV_PROTO_PUSH_UPDATE ; - } -if (session->opt->pull) { +/* support for the latest --dns option */ + iv_proto |=IV_PROTO_DNS_OPTION_V2 ; + +/* currently push-update is not supported when DCO is enabled */ +if (!session->opt->dco_enabled) + { +/* support push-updates */ + iv_proto |=IV_PROTO_PUSH_UPDATE ; + } +/* support for receiving push_reply before sending * push request, also signal that the client wants * to get push-reply messages without requiring a round
@@ -1943,20 +1943,18 @@/* support for tun-mtu as part of the push message */ buf_printf (&out,"IV_MTU=%d\n" , session->opt->frame.tun_max_mtu); - } -/* support for Negotiable Crypto Parameters */ -if (session->opt->mode ==MODE_SERVER || session->opt->pull) - { +/* legacy support for Negotiable Crypto Parameters (deprecated in +* favour of IV_CIPHERS) */ if (tls_item_in_cipher_list ("AES-128-GCM" , session->opt->config_ncp_ciphers) &&tls_item_in_cipher_list ("AES-256-GCM" , session->opt->config_ncp_ciphers)) {buf_printf (&out,"IV_NCP=2\n" ); } } -else +else if (session->opt->mode !=MODE_SERVER ) { -/* We are not using pull or p2mp server, instead do P2P NCP */ +/* If we are not using pull we announce P2P NCP support */ iv_proto |=IV_PROTO_NCP_P2P ; }
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0737b769e78e6d271ec874cadb9fbd81bfefdec1
Gerrit-Change-Number: 1634
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Attention is currently required from: cron2, flichtenheld.
plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email )
Change subject: Only announce support push updates/IV_NCP when actually supporting it
......................................................................
Patch Set 8:
(1 comment)
File src/openvpn/ssl.c:
http://gerrit.openvpn.net/c/openvpn/+/1634/comment/7e62779c_1ef9d35a?usp=email :
PS7, Line 1997: {
Quoted 1 line
NAK on that change, because it would lead to a setup with
--server+--push-peer-infosend out I […]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0737b769e78e6d271ec874cadb9fbd81bfefdec1
Gerrit-Change-Number: 1634
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Wed, 22 Jul 2026 14:18:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Attention is currently required from: cron2, flichtenheld.
plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email )
Change subject: Only announce support push updates/IV_NCP when actually supporting it
......................................................................
Patch Set 8:
(1 comment)
File src/openvpn/ssl.c:
http://gerrit.openvpn.net/c/openvpn/+/1634/comment/002ad1c5_acd8decc?usp=email :
PS7, Line 1997: {
Quoted 1 line
Done
But I have a follow up patch that actually allows the p2p NCP to work in server mode. You still need a fixed ip for the clinet in the server config to make it actually work but there is that 😊
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1634?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0737b769e78e6d271ec874cadb9fbd81bfefdec1
Gerrit-Change-Number: 1634
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Wed, 22 Jul 2026 14:21:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]>
Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel