Skip to contentSkip to conversation

db: enable verify PACKAGECONFIG

PATCH In review Chen Qi 3 participants 4 messages Jun 3, 2020 – Jun 5, 2020

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

PATCH 1/1 db: enable verify PACKAGECONFIG

On target, when running `db_verify /var/lib/rpm/Packages', we get the following error.

db_verify: BDB0571 library build did not include support for database verification

Enable the 'verify' PACKAGECONFIG to avoid such issue.

---
 meta/recipes-support/db/db_5.3.28.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/db/db_5.3.28.bb +1 -1
index 3a0923ae36..b64c4c089a 100644
@@ -61,7 +61,7 @@ DB5_CONFIG ?= "--enable-o_direct --disable-cryptography --disable-queue --disabl
 
 EXTRA_OECONF = "${DB5_CONFIG} --enable-shared --enable-cxx --with-sysroot STRIP=true"
 
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= "verify"
 PACKAGECONFIG[verify] = "--enable-verify, --disable-verify"
 PACKAGECONFIG[dbm] = "--enable-dbm,--disable-dbm,"
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 17 lines · Chen Qi

On target, when running `db_verify /var/lib/rpm/Packages', we get the following error.

db_verify: BDB0571 library build did not include support for database verification

Enable the 'verify' PACKAGECONFIG to avoid such issue.

---
 meta/recipes-support/db/db_5.3.28.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/db/db_5.3.28.bb +0 -0
index 3a0923ae36..b64c4c089a 100644

meta/recipes-support/db/db_5.3.28.bb DB5_CONFIG ?= "--enable-o_direct --disable-cryptography --disable-queue --disabl · line 66

Quoted 7 lines
meta/recipes-support/db/db_5.3.28.bb +1 -1
@@ -61,7 +61,7 @@ DB5_CONFIG ?= "--enable-o_direct --disable-cryptography --disable-queue --disabl
 
 EXTRA_OECONF = "${DB5_CONFIG} --enable-shared --enable-cxx --with-sysroot STRIP=true"
 
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= "verify"
 PACKAGECONFIG[verify] = "--enable-verify, --disable-verify"
 PACKAGECONFIG[dbm] = "--enable-dbm,--disable-dbm,"

Do we ever need to run this on target? I'm wondering why we need this and what the implications are (extra size to the binaries?). Perhaps we just shouldn't ship that binary if verify isn't enabled?

Cheers,

Richard

#2 lore raw

By the way upcoming rpm 4.16 deprecates db backend in favor of ndb (not sure what that uses exactly, but it's not berkeley db), and they're working on sqlite support as well. So a major consumer of bdb should be eliminated, and then we can look at moving bdb out of core, as it never got proper upstream maintenance.

Alex

Quoted 40 lines · Richard Purdie
Quoted 4 lines · Chen Qi

On target, when running `db_verify /var/lib/rpm/Packages', we get the following error.

db_verify: BDB0571 library build did not include support for database

verification

Review

Quoted 9 lines

Enable the 'verify' PACKAGECONFIG to avoid such issue.

---
 meta/recipes-support/db/db_5.3.28.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta/recipes-support/db/db_5.3.28.bb

meta/recipes-support/db/db_5.3.28.bb DB5_CONFIG ?= "--enable-o_direct

Quoted 4 lines

index 3a0923ae36..b64c4c089a 100644

meta/recipes-support/db/db_5.3.28.bb +0 -0
@@ -61,7 +61,7 @@ DB5_CONFIG ?= "--enable-o_direct

--disable-cryptography --disable-queue --disabl

meta/recipes-support/db/db_5.3.28.bb DB5_CONFIG ?= "--enable-o_direct · line 61

Quoted 2 lines
meta/recipes-support/db/db_5.3.28.bb +0 -0
 EXTRA_OECONF = "${DB5_CONFIG} --enable-shared --enable-cxx

--with-sysroot STRIP=true"

meta/recipes-support/db/db_5.3.28.bb DB5_CONFIG ?= "--enable-o_direct --disable-cryptography --disable-queue --disabl · line 66

Quoted 5 lines
meta/recipes-support/db/db_5.3.28.bb +1 -1
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= "verify"
 PACKAGECONFIG[verify] = "--enable-verify, --disable-verify"
 PACKAGECONFIG[dbm] = "--enable-dbm,--disable-dbm,"

Do we ever need to run this on target? I'm wondering why we need this and what the implications are (extra size to the binaries?). Perhaps we just shouldn't ship that binary if verify isn't enabled?

Cheers,

Richard

author
#3 lore raw
In reply to Richard Purdie
Quoted 29 lines · Richard Purdie
Quoted 17 lines · Chen Qi

On target, when running `db_verify /var/lib/rpm/Packages', we get the following error.

db_verify: BDB0571 library build did not include support for database verification

Enable the 'verify' PACKAGECONFIG to avoid such issue.

---
  meta/recipes-support/db/db_5.3.28.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/db/db_5.3.28.bb +0 -0
index 3a0923ae36..b64c4c089a 100644

meta/recipes-support/db/db_5.3.28.bb DB5_CONFIG ?= "--enable-o_direct --disable-cryptography --disable-queue --disabl · line 66

Quoted 7 lines
meta/recipes-support/db/db_5.3.28.bb +1 -1
@@ -61,7 +61,7 @@ DB5_CONFIG ?= "--enable-o_direct --disable-cryptography --disable-queue --disabl
 
  EXTRA_OECONF = "${DB5_CONFIG} --enable-shared --enable-cxx --with-sysroot STRIP=true"
 
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= "verify"
  PACKAGECONFIG[verify] = "--enable-verify, --disable-verify"
  PACKAGECONFIG[dbm] = "--enable-dbm,--disable-dbm,"

Do we ever need to run this on target? I'm wondering why we need this and what the implications are (extra size to the binaries?). Perhaps we just shouldn't ship that binary if verify isn't enabled?

Quoted 5 lines

Cheers,

Richard

Thanks. I've sent out a new patch.

Regards,

Chen Qi