ci: do not dump error logs in GHA containers
PATCH 1/1 ci: do not dump error logs in GHA containers
On error, the build logs are displayed in GHA console and logs unless the GITHUB_WORKFLOW env variable is set.
However, containers in GHA do not automatically inherit this variable. We could pass this variable in the container environment, but in the end, dumping those logs is only for Travis which we don't really care about anymore.
Let's make the linux-build.sh more generic and dump logs from Travis yaml itself.
--- .ci/linux-build.sh | 19 ------------------- .travis.yml | 4 ++++ 2 files changed, 4 insertions(+), 19 deletions(-)
.ci/linux-build.sh +0 -19
@@ -3,25 +3,6 @@ # Builds are run as root in containers, no need for sudo [ "$(id -u)" != '0' ] || alias sudo= -on_error() { - if [ $? = 0 ]; then - exit - fi - FILES_TO_PRINT="build/meson-logs/testlog.txt" - FILES_TO_PRINT="$FILES_TO_PRINT build/.ninja_log" - FILES_TO_PRINT="$FILES_TO_PRINT build/meson-logs/meson-log.txt" - FILES_TO_PRINT="$FILES_TO_PRINT build/gdb.log" - - for pr_file in $FILES_TO_PRINT; do - if [ -e "$pr_file" ]; then - cat "$pr_file" - fi - done -} -# We capture the error logs as artifacts in Github Actions, no need to dump -# them via a EXIT handler. -[ -n "$GITHUB_WORKFLOW" ] || trap on_error EXIT - install_libabigail() { version=$1 instdir=$2
.travis.yml +4 -0
@@ -38,6 +38,10 @@ _doc_packages: &doc_packages before_install: ./.ci/${TRAVIS_OS_NAME}-setup.sh script: ./.ci/${TRAVIS_OS_NAME}-build.sh +after_failure: +- [ ! -e build/meson-logs/testlog.txt ] || cat build/meson-logs/testlog.txt +- [ ! -e build/.ninja_log ] || cat build/.ninja_log +- [ ! -e build/meson-logs/meson-log.txt ] || cat build/meson-logs/meson-log.txt env: global:
Signature · 1 line
2.23.0
Quoted 8 lines · David Marchand
On error, the build logs are displayed in GHA console and logs unless the
GITHUB_WORKFLOWenv variable is set.
However, containers in GHA do not automatically inherit this variable. We could pass this variable in the container environment, but in the end, dumping those logs is only for Travis which we don't really care about anymore.
Quoted 6 lines
Let's make the
linux-build.shmore generic and dump logs from Travis yaml itself.Fixes b35c4b0aa2bc ("ci: add Fedora 35 container in GHA")Signed-off-by David Marchand <[email protected]>
TBH, I did not test Travis by lack of interest (plus I don't want to be bothered with their ui / credit stuff).
We could consider dropping Travis in the near future.
Opinions?
Signature · 1 line
David Marchand
Quoted 15 lines · David Marchand
Quoted 13 lines · David Marchand
On error, the build logs are displayed in GHA console and logs unless the
GITHUB_WORKFLOWenv variable is set.
However, containers in GHA do not automatically inherit this variable. We could pass this variable in the container environment, but in the end, dumping those logs is only for Travis which we don't really care about anymore.Let's make the
linux-build.shmore generic and dump logs from Travis yaml itself.Fixes b35c4b0aa2bc ("ci: add Fedora 35 container in GHA")
Quoted 7 lines
Quoted 1 line
Signed-off-by David Marchand <[email protected]>TBH, I did not test Travis by lack of interest (plus I don't want to be bothered with their ui / credit stuff).
We could consider dropping Travis in the near future.Opinions?
I think it makes sense. We haven't had travis reports in a while because their credit system made it impossible to use. We had kept it around for users of travis, but at this point, I think most people have migrated to GHA.
Quoted 5 lines · Aaron Conole
Quoted 5 lines
TBH, I did not test Travis by lack of interest (plus I don't want to be bothered with their ui / credit stuff).
We could consider dropping Travis in the near future.
Quoted 7 lines
Quoted 1 line
Opinions?
I think it makes sense. We haven't had travis reports in a while because their credit system made it impossible to use. We had kept it around for users of travis, but at this point, I think most people have migrated to GHA.
Honnappa, do you see an issue if we stop maintaining the Travis configuration in the DPDK repo?
Thanks.
Signature · 1 line
David Marchand
<snip>
Quoted 10 lines
Quoted 7 lines · Aaron Conole
Quoted 6 lines
TBH, I did not test Travis by lack of interest (plus I don't want to be bothered with their ui / credit stuff).
We could consider dropping Travis in the near future.Opinions?
Quoted 8 lines
Quoted 5 lines
I think it makes sense. We haven't had travis reports in a while because their credit system made it impossible to use. We had kept it around for users of travis, but at this point, I think most people have migrated to GHA.
Honnappa, do you see an issue if we stop maintaining the Travis configuration in the DPDK repo?
I do not see much of an issue from Arm side. The machines in the UNH lab provide the cover.
I am wondering that this might still be useful for individual developers who I believe are not affected by the Travis's credit system (I am not sure on this).
Quoted 5 lines
Thanks.
--
David Marchand
Quoted 18 lines · Honnappa Nagarahalli
<snip>
Quoted 16 lines
Quoted 12 lines · Aaron Conole
Quoted 6 lines
TBH, I did not test Travis by lack of interest (plus I don't want to be bothered with their ui / credit stuff).
We could consider dropping Travis in the near future.Opinions?
I think it makes sense. We haven't had travis reports in a while because their credit system made it impossible to use. We had kept it around for users of travis, but at this point, I think most people have migrated to GHA.
Quoted 7 lines
Quoted 2 lines
Honnappa, do you see an issue if we stop maintaining the Travis configuration in the DPDK repo?
I do not see much of an issue from Arm side. The machines in the UNH lab provide the cover.
I am wondering that this might still be useful for individual developers who I believe are not affected by the Travis's credit system (I am not sure on this).
I don't use travis now that GHA "just works" for my private repositories. I would guess most developers will prefer GHA anyway.
Quoted 5 lines
Quoted 5 lines
Thanks.
--
David Marchand