Skip to contentSkip to conversation

gpu/cuda: Add missing stdlib include

PATCH In review Aaron Conole 3 participants 4 messages Sep 26, 2023 – Oct 6, 2023 DRM drivers

lore
Share & tools
lore

Aaron Conole

author
#0 lore raw

PATCH 1/1 gpu/cuda: Add missing stdlib include

From: John Romein <[email protected]>

getenv needs stdlib.h to be included.

Bugzilla ID: 1133

Fixes 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
Signed-off-by John Romein <[email protected]>

---
NOTE: this is a post of https://github.com/DPDK/dpdk/pull/69 to the
mailing list.

 drivers/gpu/cuda/gdrcopy.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/cuda/gdrcopy.c +2 -0
index 322a5dbeb20..f19ad396f14 100644
@@ -2,6 +2,8 @@
  * Copyright (c) 2022 NVIDIA Corporation & Affiliates
  */
 
+#include <stdlib.h>
+
 #include "common.h"
 
 #ifdef DRIVERS_GPU_CUDA_GDRCOPY_H

---
2.40.1

#2 lore raw

Ack

Thanks
EA

From: David Marchand <[email protected]>
Date: Friday, 29 September 2023 at 16:58
To: Aaron Conole <[email protected]>, John Romein <[email protected]>
Cc: [email protected] <[email protected]>, Elena Agostini <[email protected]>, [email protected] <[email protected]>
Subject: Re: [PATCH] gpu/cuda: Add missing stdlib include
External email: Use caution opening links or attachments

Quoted 10 lines · Aaron Conole

From: John Romein <[email protected]>

getenv needs stdlib.h to be included.

Bugzilla ID: 1133

Fixes 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
Signed-off-by John Romein <[email protected]>

Thanks for the patch, it seems to be a duplicate of the prior patch sent by Levend:
https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/

--
David Marchand

#3 lore raw

Hello,

Quoted 2 lines · Elena Agostini

Ack

Please, don't top post.

Quoted 25 lines

Thanks

EA

From: David Marchand <[email protected]>
Date: Friday, 29 September 2023 at 16:58
To: Aaron Conole <[email protected]>, John Romein <[email protected]>
Cc: [email protected] <[email protected]>, Elena Agostini <[email protected]>, [email protected] <[email protected]>
Subject: Re: [PATCH] gpu/cuda: Add missing stdlib include

External email: Use caution opening links or attachments

Quoted 6 lines · Aaron Conole

From: John Romein <[email protected]>

getenv needs stdlib.h to be included.

Quoted 8 lines
Quoted 4 lines

Bugzilla ID: 1133

Fixes 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
Signed-off-by John Romein <[email protected]>

Thanks for the patch, it seems to be a duplicate of the prior patch sent by Levend:
https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/

As I mentionned, this is a duplicate and you just acked the other patch. Please pay attention.

Signature · 1 line
David Marchand