Skip to contentSkip to conversation

ci: update travis to use bionic

PATCH Applied Kevin Laatz 4 participants 8 messages Dec 17, 2019 – Jan 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ci: update travis to use bionic

Currently, the Travis CI is using Ubuntu 16.04 LTS (Xenial) which is becoming increasingly outdated. This patch updates Travis to use Ubuntu 18.04 LTS (Bionic) which will give us the benefit of more up-to-date packages being availble and the newer features that come with them.

---
 .travis.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
.travis.yml +2 -2
index 8f90d06f2..6e0626353 100644
@@ -4,7 +4,7 @@ compiler:
   - gcc
   - clang
 
-dist: xenial
+dist: bionic
 
 os:
   - linux
@@ -21,7 +21,7 @@ aarch64_packages: &aarch64_packages
 
 extra_packages: &extra_packages
   - *required_packages
-  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4]
+  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]
 
 build_32b_packages: &build_32b_packages
   - *required_packages
Signature · 1 line
2.17.1
#1 lore raw
Quoted 15 lines · Kevin Laatz

Currently, the Travis CI is using Ubuntu 16.04 LTS (Xenial) which is becoming increasingly outdated. This patch updates Travis to use Ubuntu 18.04 LTS (Bionic) which will give us the benefit of more up-to-date packages being availble and the newer features that come with them.

---
 .travis.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
.travis.yml +0 -0
index 8f90d06f2..6e0626353 100644

.travis.yml compiler: · line 7

Quoted 5 lines
.travis.yml +1 -1
@@ -4,7 +4,7 @@ compiler:
   - gcc
   - clang
 
-dist: xenial
+dist: bionic

This LGTM.

.travis.yml aarch64_packages: &aarch64_packages · line 24

Quoted 8 lines
.travis.yml +1 -1
 os:
   - linux
@@ -21,7 +21,7 @@ aarch64_packages: &aarch64_packages
 
 extra_packages: &extra_packages
   - *required_packages
-  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4]
+  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]

Will adding the abigail-tools automatically invoke the ABI checks? Otherwise, maybe it's best to save this for a future commit.

I'll look for the robot build when it comes by. Thanks!

Quoted 2 lines
.travis.yml +0 -0
 build_32b_packages: &build_32b_packages
   - *required_packages
#2 lore raw
Quoted 28 lines · Aaron Conole
Quoted 15 lines · Kevin Laatz

Currently, the Travis CI is using Ubuntu 16.04 LTS (Xenial) which is becoming increasingly outdated. This patch updates Travis to use Ubuntu 18.04 LTS (Bionic) which will give us the benefit of more up-to-date packages being availble and the newer features that come with them.

---
  .travis.yml | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
.travis.yml +0 -0
index 8f90d06f2..6e0626353 100644

.travis.yml compiler: · line 7

Quoted 5 lines
.travis.yml +1 -1
@@ -4,7 +4,7 @@ compiler:
    - gcc
    - clang
 
-dist: xenial
+dist: bionic

This LGTM.

Quoted 4 lines
.travis.yml +0 -0
  os:
    - linux
@@ -21,7 +21,7 @@ aarch64_packages: &aarch64_packages
 
Quoted 8 lines

.travis.yml aarch64_packages: &aarch64_packages · line 24

Quoted 4 lines
.travis.yml +1 -1
  extra_packages: &extra_packages
    - *required_packages
-  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4]
+  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]

Will adding the abigail-tools automatically invoke the ABI checks? Otherwise, maybe it's best to save this for a future commit.

I'll look for the robot build when it comes by. Thanks!

Yes, the meson option that will be introduced with the "Add ABI compatibility checks to the meson build" [1] patch set will be set to "auto" meaning the checks will run if abidiff is found.

[1] http://patches.dpdk.org/project/dpdk/list/?series=7830

Quoted 3 lines
Quoted 3 lines
.travis.yml +0 -0
  build_32b_packages: &build_32b_packages
    - *required_packages
#3 lore raw
Quoted 34 lines · Kevin
Quoted 33 lines · Aaron Conole
Quoted 15 lines · Kevin Laatz

Currently, the Travis CI is using Ubuntu 16.04 LTS (Xenial) which is becoming increasingly outdated. This patch updates Travis to use Ubuntu 18.04 LTS (Bionic) which will give us the benefit of more up-to-date packages being availble and the newer features that come with them.

---
  .travis.yml | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
.travis.yml +0 -0
index 8f90d06f2..6e0626353 100644

.travis.yml compiler: · line 7

Quoted 4 lines
.travis.yml +1 -0
@@ -4,7 +4,7 @@ compiler:
    - gcc
    - clang
  -dist: xenial
+dist: bionic

This LGTM.

.travis.yml aarch64_packages: &aarch64_packages · line 23

Quoted 7 lines
.travis.yml +1 -1
  os:
    - linux
@@ -21,7 +21,7 @@ aarch64_packages: &aarch64_packages
    extra_packages: &extra_packages
    - *required_packages
-  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4]
+  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]

Will adding the abigail-tools automatically invoke the ABI checks? Otherwise, maybe it's best to save this for a future commit.

Quoted 5 lines
Quoted 1 line

I'll look for the robot build when it comes by. Thanks!

Yes, the meson option that will be introduced with the "Add ABI compatibility checks to the meson build" [1] patch set will be set to "auto" meaning the checks will run if abidiff is found.

Okay. I'm fine with that change.

Quoted 1 line

[1] http://patches.dpdk.org/project/dpdk/list/?series=7830

I noticed the shared builds are failing:
https://travis-ci.com/ovsrobot/dpdk/jobs/268042693

But not sure what the issue is with librte_mempool_ring

Can you see why it would fail under bionic?

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
.travis.yml +0 -0
  build_32b_packages: &build_32b_packages
    - *required_packages
#4 lore raw
Quoted 42 lines · Aaron Conole
Quoted 34 lines · Kevin
Quoted 33 lines · Aaron Conole
Quoted 15 lines · Kevin Laatz

Currently, the Travis CI is using Ubuntu 16.04 LTS (Xenial) which is becoming increasingly outdated. This patch updates Travis to use Ubuntu 18.04 LTS (Bionic) which will give us the benefit of more up-to-date packages being availble and the newer features that come with them.

---
   .travis.yml | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
.travis.yml +0 -0
index 8f90d06f2..6e0626353 100644

.travis.yml compiler: · line 7

Quoted 4 lines
.travis.yml +1 -0
@@ -4,7 +4,7 @@ compiler:
     - gcc
     - clang
   -dist: xenial
+dist: bionic

This LGTM.

.travis.yml aarch64_packages: &aarch64_packages · line 23

Quoted 7 lines
.travis.yml +1 -1
   os:
     - linux
@@ -21,7 +21,7 @@ aarch64_packages: &aarch64_packages
     extra_packages: &extra_packages
     - *required_packages
-  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4]
+  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]

Will adding the abigail-tools automatically invoke the ABI checks? Otherwise, maybe it's best to save this for a future commit.

Quoted 4 lines
Quoted 1 line

I'll look for the robot build when it comes by. Thanks!

Yes, the meson option that will be introduced with the "Add ABI compatibility checks to the meson build" [1] patch set will be set to "auto" meaning the checks will run if abidiff is found.

Okay. I'm fine with that change.

Quoted 7 lines
Quoted 1 line

[1] http://patches.dpdk.org/project/dpdk/list/?series=7830

I noticed the shared builds are failing:

   https://travis-ci.com/ovsrobot/dpdk/jobs/268042693

But not sure what the issue is with librte_mempool_ring

Can you see why it would fail under bionic?

Between Xenial and Bionic, there has been a slight change (RPATH related) in how shared objects are linked causing librte_mempool_ring to not be found.

Ruifeng has submitted a patch [1] that addresses this issue.

[1] http://patches.dpdk.org/patch/63978/

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
.travis.yml +0 -0
   build_32b_packages: &build_32b_packages
     - *required_packages
 
Acked-by on v1 1/1
#5 lore raw
In reply to Kevin Laatz
Quoted 4 lines · Kevin Laatz

Currently, the Travis CI is using Ubuntu 16.04 LTS (Xenial) which is becoming increasingly outdated. This patch updates Travis to use Ubuntu 18.04 LTS (Bionic) which will give us the benefit of more up-to-date packages being availble and the newer features that come with them.

But I do have a question - should this come together with removal of extra sources/packages added just to overcome building problems resulting from outdated distro? Or this should be responsibility of person that added those (e.g. I've added gcc-7 from ubuntu-toolchain/r-test for LTO builds)

Regards
Andrzej

#6 lore raw
Quoted 7 lines · Andrzej Ostruszka
Quoted 4 lines · Kevin Laatz

Currently, the Travis CI is using Ubuntu 16.04 LTS (Xenial) which is becoming increasingly outdated. This patch updates Travis to use Ubuntu 18.04 LTS (Bionic) which will give us the benefit of more up-to-date packages being availble and the newer features that come with them.

Quoted 7 lines

But I do have a question - should this come together with removal of extra sources/packages added just to overcome building problems resulting from outdated distro? Or this should be responsibility of person that added those (e.g. I've added gcc-7 from ubuntu-toolchain/r-test for LTO builds)

We disabled the LTO job in Travis on 11/08:
https://git.dpdk.org/dpdk/commit/?id=20d3f48be1d1
Were you referring to something else?

Thanks.

Signature · 1 line
David Marchand
#7 lore raw
In reply to Kevin Laatz
Quoted 5 lines · Kevin Laatz

Currently, the Travis CI is using Ubuntu 16.04 LTS (Xenial) which is becoming increasingly outdated. This patch updates Travis to use Ubuntu 18.04 LTS (Bionic) which will give us the benefit of more up-to-date packages being availble and the newer features that come with them.

available*

The Intel CI tests Ubuntu 16.04.
As you mentioned, 18.04 comes with a more recent clang and libabigail which will be necessary in other series.

I am ok with this change too.

Quoted 20 lines
---
 .travis.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
.travis.yml +1 -1
index 8f90d06f2..6e0626353 100644
@@ -4,7 +4,7 @@ compiler:
   - gcc
   - clang
 
-dist: xenial
+dist: bionic
 
 os:
   - linux

.travis.yml aarch64_packages: &aarch64_packages · line 24

Quoted 5 lines
.travis.yml +1 -1
@@ -21,7 +21,7 @@ aarch64_packages: &aarch64_packages
 
 extra_packages: &extra_packages
   - *required_packages
-  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4]
+  - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]

I removed this change.
libabigail will be added when needed.

I also removed the distrib field for the aarch64 jobs, that were not pushed to master yet, at the time this patch had been proposed.

Applied, thanks.

--
David Marchand