arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT
PATCH 1/1 arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT
Thundercomm AI MiniPC G1 IoT is single board computer with AI capability based on Qualcomm QCS6490 platform.
This device tree is confirmed to work as below:
- GPU
- HDMI output port
- PCIe M.2 port (for external Wi-Fi or 5G connectivity)
- UART / serial console port
- UFS
- USB Type-C port, with Display Port
--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../qcom/qcs6490-thundercomm-minipc-g1iot.dts | 1110 +++++++++++++++++ 2 files changed, 1111 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -145,6 +145,7 @@ qcs6490-rb3gen2-industrial-mezzanine-dtbs := qcs6490-rb3gen2.dtb qcs6490-rb3gen2 dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2-industrial-mezzanine.dtb dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2-vision-mezzanine.dtb +dtb-$(CONFIG_ARCH_QCOM) += qcs6490-thundercomm-minipc-g1iot.dtb dtb-$(CONFIG_ARCH_QCOM) += qcs6490-thundercomm-rubikpi3.dtb dtb-$(CONFIG_ARCH_QCOM) += qcs8300-ride.dtb dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtb
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +1110 -0
1,110 lines not on this page · raw message
Quoted 85 lines · Roger Shimizu
Thundercomm AI MiniPC G1 IoT is single board computer with AI capability based on Qualcomm QCS6490 platform.
This device tree is confirmed to work as below:
- GPU
- HDMI output port
- PCIe M.2 port (for external Wi-Fi or 5G connectivity)
- UART / serial console port
- UFS
- USB Type-C port, with Display PortSigned-off-by Roger Shimizu <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../qcom/qcs6490-thundercomm-minipc-g1iot.dts | 1110 +++++++++++++++++ 2 files changed, 1111 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -145,6 +145,7 @@ qcs6490-rb3gen2-industrial-mezzanine-dtbs := qcs6490-rb3gen2.dtb qcs6490-rb3gen2 dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2-industrial-mezzanine.dtb dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2-vision-mezzanine.dtb +dtb-$(CONFIG_ARCH_QCOM) += qcs6490-thundercomm-minipc-g1iot.dtb dtb-$(CONFIG_ARCH_QCOM) += qcs6490-thundercomm-rubikpi3.dtb dtb-$(CONFIG_ARCH_QCOM) += qcs8300-ride.dtb dtb-$(CONFIG_ARCH_QCOM) += qcs8550-aim300-aiot.dtbarch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +49
-0@@ -0,0 +1,1110 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) 2026, Roger Shimizu <[email protected]> + */ + +/dts-v1/; + +/* PM7250B is configured to use SID8/9 */ +#define PM7250B_SID 8 +#define PM7250B_SID1 9 + +#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h> +#include <dt-bindings/iio/qcom,spmi-adc7-pm7325.h> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> +#include "kodiak.dtsi" +#include "pm7250b.dtsi" +#include "pm7325.dtsi" +#include "pm8350c.dtsi" /* PM7350C */ +#include "pmk8350.dtsi" /* PMK7325 */ + +/delete-node/ &adsp_mem; +/delete-node/ &cdsp_mem; +/delete-node/ &ipa_fw_mem; +/delete-node/ &mpss_mem; +/delete-node/ &remoteproc_mpss; +/delete-node/ &remoteproc_wpss; +/delete-node/ &rmtfs_mem; +/delete-node/ &video_mem; +/delete-node/ &wifi; +/delete-node/ &wlan_ce_mem; +/delete-node/ &wlan_fw_mem; +/delete-node/ &wpss_mem; +/delete-node/ &xbl_mem; + +/ { + model = "Thundercomm AI Mini PC G1 IoT"; + compatible = "qcom,sc7280", "qcom,qcm6490"; + chassis-type = "embedded"; + + aliases { + serial0 = &uart5; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + hdmi-connector { + compatible = "hdmi-connector";
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 59
Quoted 10 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +10
-0+ type = "a"; + + port { + hdmi_con: endpoint { + remote-endpoint = <<9611_out>; + }; + }; + }; + + lt9611_1v2: lt9611-vdd12-regulator {
Please be consistent, regulator-lt9611-vdd12
Quoted 154 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +154
-0+ compatible = "regulator-fixed"; + regulator-name = "LT9611_1V2"; + + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + }; + + reserved-memory { + xbl_mem: xbl@80700000 { + reg = <0x0 0x80700000 0x0 0x100000>; + no-map; + }; + + cdsp_secure_heap_mem: cdsp-secure-heap@81800000 { + reg = <0x0 0x81800000 0x0 0x1e00000>; + no-map; + }; + + camera_mem: camera@84300000 { + reg = <0x0 0x84300000 0x0 0x500000>; + no-map; + }; + + adsp_mem: adsp@86100000 { + reg = <0x0 0x86100000 0x0 0x2800000>; + no-map; + }; + + cdsp_mem: cdsp@88900000 { + reg = <0x0 0x88900000 0x0 0x1e00000>; + no-map; + }; + + video_mem: video@8a700000 { + reg = <0x0 0x8a700000 0x0 0x700000>; + no-map; + }; + + cvp_mem: cvp@8ae00000 { + reg = <0x0 0x8ae00000 0x0 0x500000>; + no-map; + }; + + gpu_microcode_mem: gpu-microcode@8b31a000 { + reg = <0x0 0x8b31a000 0x0 0x2000>; + no-map; + }; + + tz_stat_mem: tz-stat@c0000000 { + reg = <0x0 0xc0000000 0x0 0x100000>; + no-map; + }; + + tags_mem: tags@c0100000 { + reg = <0x0 0xc0100000 0x0 0x1200000>; + no-map; + }; + + qtee_mem: qtee@c1300000 { + reg = <0x0 0xc1300000 0x0 0x500000>; + no-map; + }; + + trusted_apps_mem: trusted-apps@c1800000 { + reg = <0x0 0xc1800000 0x0 0x1c00000>; + no-map; + }; + + debug_vm_mem: debug-vm@d0600000 { + reg = <0x0 0xd0600000 0x0 0x100000>; + no-map; + }; + }; + + pmic-glink { + compatible = "qcom,qcm6490-pmic-glink", "qcom,pmic-glink"; + + #address-cells = <1>; + #size-cells = <0>; + orientation-gpios = <&tlmm 140 GPIO_ACTIVE_HIGH>; + + connector@0 { + compatible = "usb-c-connector"; + reg = <0>; + power-role = "dual"; + data-role = "dual"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + pmic_glink_hs_in: endpoint { + remote-endpoint = <&usb_1_dwc3_hs>; + }; + }; + + port@1 { + reg = <1>; + + pmic_glink_ss_in: endpoint { + remote-endpoint = <&redriver_usb_con_ss>; + }; + }; + + port@2 { + reg = <2>; + + pmic_glink_sbu_in: endpoint { + remote-endpoint = <&redriver_usb_con_sbu>; + }; + }; + }; + }; + }; + + vph_pwr: regulator-vph-pwr { + compatible = "regulator-fixed"; + regulator-name = "vph_pwr"; + regulator-min-microvolt = <3700000>; + regulator-max-microvolt = <3700000>; + }; + + thermal-zones { + sdm-skin-thermal { + thermal-sensors = <&pmk8350_adc_tm 3>; + + trips { + active-config0 { + temperature = <125000>; + hysteresis = <1000>; + type = "passive"; + }; + }; + }; + + quiet-thermal { + thermal-sensors = <&pmk8350_adc_tm 1>; + + trips { + active-config0 { + temperature = <125000>; + hysteresis = <1000>; + type = "passive"; + }; + }; + }; + + xo-thermal { + thermal-sensors = <&pmk8350_adc_tm 0>; + + trips {
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 223
Quoted 10 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +10
-0+ active-config0 { + temperature = <125000>; + hysteresis = <1000>; + type = "passive"; + }; + }; + }; + }; + + vdd_ntn_0p9: regulator-vdd-ntn-0p9 {
regulator < thermal
Quoted 29 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +28
-0+ compatible = "regulator-fixed"; + regulator-name = "VDD_NTN_0P9"; + gpio = <&pm8350c_gpios 2 GPIO_ACTIVE_HIGH>; + regulator-min-microvolt = <899400>; + regulator-max-microvolt = <899400>; + enable-active-high; + pinctrl-0 = <&ntn_0p9_en>; + pinctrl-names = "default"; + regulator-enable-ramp-delay = <4300>; + }; + + vdd_ntn_1p8: regulator-vdd-ntn-1p8 { + compatible = "regulator-fixed"; + regulator-name = "VDD_NTN_1P8"; + gpio = <&pm8350c_gpios 3 GPIO_ACTIVE_HIGH>; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + enable-active-high; + pinctrl-0 = <&ntn_1p8_en>; + pinctrl-names = "default"; + regulator-enable-ramp-delay = <10000>; + }; +}; + + +&mdss { + status = "okay"; +};
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts
Quoted 10 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +10
-0+ +&mdss_dp { + status = "okay"; +}; + +&mdss_dp_out { + data-lanes = <0 1>; + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>; + + remote-endpoint = <&usb_dp_qmpphy_dp_in>;
It's already a part of kodiak.dtsi
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 1048
Quoted 10 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +9
-0+}; + + +&uart5 { + status = "okay"; +}; + +&usb_1 { + dr_mode = "otg";
Default, can be dropped
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 1049
Quoted 1 line
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +1
-0+ usb-role-switch;
Please move to kodiak.dtsi
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 1059
Quoted 10 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +10
-0+ + status = "okay"; +}; + +&usb_1_dwc3_hs { + remote-endpoint = <&pmic_glink_hs_in>; +}; + +&usb_1_dwc3_ss { + remote-endpoint = <&usb_dp_qmpphy_usb_ss_in>;
It's already in kodiak.dtsi
Quoted 13 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +13
-0+}; + +&usb_1_hsphy { + vdda-pll-supply = <&vreg_l10c_0p88>; + vdda33-supply = <&vreg_l2b_3p072>; + vdda18-supply = <&vreg_l1c_1p8>; + + status = "okay"; +}; + +&usb_1_qmpphy { + vdda-phy-supply = <&vreg_l6b_1p2>; + vdda-pll-supply = <&vreg_l1b_0p912>;
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 1082
Quoted 10 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +10
-0+ + status = "okay"; +}; + +&usb_dp_qmpphy_out { + remote-endpoint = <&redriver_phy_con_ss>; +}; + +&usb_dp_qmpphy_usb_ss_in { + remote-endpoint = <&usb_1_dwc3_ss>;
Already there
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 1086
Quoted 4 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +4
-0+}; + +&usb_dp_qmpphy_dp_in { + remote-endpoint = <&mdss_dp_out>;
Already there
Quoted 24 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +24
-0+}; + +&ufs_mem_hc { + reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>; + vcc-supply = <&vreg_l7b_2p952>; + vcc-max-microamp = <800000>; + vccq-supply = <&vreg_l9b_1p2>; + vccq-max-microamp = <900000>; + vccq2-supply = <&vreg_l9b_1p2>; + vccq2-max-microamp = <900000>; + + status = "okay"; +}; + +&ufs_mem_phy { + vdda-phy-supply = <&vreg_l10c_0p88>; + vdda-pll-supply = <&vreg_l6b_1p2>; + + status = "okay"; +}; + +&venus { + status = "okay"; +};
Signature · 2 lines
With best wishes Dmitry
Quoted 4 lines · Dmitry Baryshkov
Quoted 2 lines · Roger Shimizu
Thundercomm AI MiniPC G1 IoT is single board computer with AI capability based on Qualcomm QCS6490 platform.
Thanks Dmitry for the review!
I will send out the updated v2 by the end of this week.
-Roger
Quoted 13 lines · Roger Shimizu
Thundercomm AI MiniPC G1 IoT is single board computer with AI capability based on Qualcomm QCS6490 platform.
This device tree is confirmed to work as below:
- GPU
- HDMI output port
- PCIe M.2 port (for external Wi-Fi or 5G connectivity)
- UART / serial console port
- UFS
- USB Type-C port, with Display PortSigned-off-by Roger Shimizu <[email protected]>---
[...]
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 37
Quoted 3 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +3
-0+/ { + model = "Thundercomm AI Mini PC G1 IoT"; + compatible = "qcom,sc7280", "qcom,qcm6490";
You need to add a board-specific compatible here, see:
Documentation/devicetree/bindings/arm/qcom.yaml
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 38
Quoted 1 line
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +1
-0+ chassis-type = "embedded";
The allowed values are:
enum:
- desktop
- laptop
- convertible
- server
- all-in-one
- tablet
- handset
- watch
- embedded
- television
- spectacles
I think it's more of a desktop, but a) that's minor and b) you could argue either way
[...]
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 272
Quoted 4 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +4
-0+ vreg_s1b_1p872: smps1 { + regulator-name = "vreg_s1b_1p872"; + regulator-min-microvolt = <1840000>; + regulator-max-microvolt = <2040000>;
Have you cross-checked the regulator settings against the original vendor-provided sw?
[...]
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 566
Quoted 2 lines
+&gpu_zap_shader {
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +1
-0+ firmware-name = "qcom/qcs6490/a660_zap.mbn";
I'm assuming this means the thing can take Qualcomm- (vs OEM-)signed firmware Could you please confirm that's the case?
[...]
Review
Quoted 3 lines
+&pon_pwrkey {
(quoted diff) +2
-0+ status = "okay"; +};
This one is already enabled
Konrad
Thanks Konrad for the review!
Quoted 18 lines · Konrad Dybcio
Quoted 13 lines · Roger Shimizu
Thundercomm AI MiniPC G1 IoT is single board computer with AI capability based on Qualcomm QCS6490 platform.
This device tree is confirmed to work as below:
- GPU
- HDMI output port
- PCIe M.2 port (for external Wi-Fi or 5G connectivity)
- UART / serial console port
- UFS
- USB Type-C port, with Display PortSigned-off-by Roger Shimizu <[email protected]>---
[...]
Quoted 7 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 37
Quoted 3 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +3
-0+/ { + model = "Thundercomm AI Mini PC G1 IoT"; + compatible = "qcom,sc7280", "qcom,qcm6490";You need to add a board-specific compatible here, see:
Documentation/devicetree/bindings/arm/qcom.yaml
Thanks for the hint!
I'll add it in v2 series.
Quoted 17 lines
Quoted 1 line
+ chassis-type = "embedded";
The allowed values are:
enum:
- desktop
- laptop
- convertible
- server
- all-in-one
- tablet
- handset
- watch
- embedded
- television
- spectacles
Quoted 2 lines
I think it's more of a desktop, but a) that's minor and b) you could argue either way
The device name indicates it's Mini PC, so desktop is better.
Quoted 9 lines
[...]
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 272
Quoted 4 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +4
-0+ vreg_s1b_1p872: smps1 { + regulator-name = "vreg_s1b_1p872"; + regulator-min-microvolt = <1840000>; + regulator-max-microvolt = <2040000>;Have you cross-checked the regulator settings against the original vendor-provided sw?
No. Those are from RB3 Gen2. So far there's no issue. If there's an issue, we can fix it later.
Quoted 7 lines
[...]
Quoted 2 lines
+&gpu_zap_shader {
+ firmware-name = "qcom/qcs6490/a660_zap.mbn";I'm assuming this means the thing can take Qualcomm- (vs OEM-)signed firmware Could you please confirm that's the case?
Yes, so far I don't find issue by using gpu firmware from this path.
Quoted 7 lines
[...]
Review
Quoted 3 lines
+&pon_pwrkey {
(quoted diff) +2
-0+ status = "okay"; +};This one is already enabled
May I know where it's enabled?
From my search, pon_pwrkey is defined in:arch/arm64/boot/dts/qcom/pmk8350.dtsi, which is disabled.
-Roger
Quoted 19 lines · Roger Shimizu
Thanks Konrad for the review!
Quoted 15 lines · Konrad Dybcio
Quoted 13 lines · Roger Shimizu
Thundercomm AI MiniPC G1 IoT is single board computer with AI capability based on Qualcomm QCS6490 platform.
This device tree is confirmed to work as below:
- GPU
- HDMI output port
- PCIe M.2 port (for external Wi-Fi or 5G connectivity)
- UART / serial console port
- UFS
- USB Type-C port, with Display PortSigned-off-by Roger Shimizu <[email protected]>---
[...]
Quoted 10 lines
Quoted 7 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 272
Quoted 4 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +4
-0+ vreg_s1b_1p872: smps1 { + regulator-name = "vreg_s1b_1p872"; + regulator-min-microvolt = <1840000>; + regulator-max-microvolt = <2040000>;Have you cross-checked the regulator settings against the original vendor-provided sw?
No. Those are from RB3 Gen2. So far there's no issue. If there's an issue, we can fix it later.
The issue may be that once you enable one of these regulators, you'll see magic smoke.. please cross-check it
Quoted 11 lines
Quoted 7 lines
[...]
Review
Quoted 3 lines
+&pon_pwrkey {
(quoted diff) +2
-0+ status = "okay"; +};This one is already enabled
May I know where it's enabled?
From my search,pon_pwrkeyis defined in:arch/arm64/boot/dts/qcom/pmk8350.dtsi, which is disabled.
Right, I must have misread.
Konrad
Quoted 29 lines · Konrad Dybcio
Quoted 19 lines · Roger Shimizu
Thanks Konrad for the review!
Quoted 15 lines · Konrad Dybcio
Quoted 13 lines · Roger Shimizu
Thundercomm AI MiniPC G1 IoT is single board computer with AI capability based on Qualcomm QCS6490 platform.
This device tree is confirmed to work as below:
- GPU
- HDMI output port
- PCIe M.2 port (for external Wi-Fi or 5G connectivity)
- UART / serial console port
- UFS
- USB Type-C port, with Display PortSigned-off-by Roger Shimizu <[email protected]>---
[...]
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +4
-0+ vreg_s1b_1p872: smps1 { + regulator-name = "vreg_s1b_1p872"; + regulator-min-microvolt = <1840000>; + regulator-max-microvolt = <2040000>;
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Have you cross-checked the regulator settings against the original vendor-provided sw?
No. Those are from RB3 Gen2. So far there's no issue. If there's an issue, we can fix it later.
The issue may be that once you enable one of these regulators, you'll see magic smoke.. please cross-check it
Thanks for the explanation!
I'll check it.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
[...]
Quoted 3 lines
+&pon_pwrkey {
(quoted diff) +2
-0+ status = "okay"; +};
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
This one is already enabled
May I know where it's enabled?
From my search,pon_pwrkeyis defined in:arch/arm64/boot/dts/qcom/pmk8350.dtsi, which is disabled.Right, I must have misread.
Glad it's clarified.
-Roger
Quoted 5 lines · Konrad Dybcio
Quoted 1 line · Roger Shimizu
---
[...]
Quoted 7 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 37
Quoted 3 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +3
-0+/ { + model = "Thundercomm AI Mini PC G1 IoT"; + compatible = "qcom,sc7280", "qcom,qcm6490";You need to add a board-specific compatible here, see:
Documentation/devicetree/bindings/arm/qcom.yaml
The true problem is that this would probably fail validation, so I suspect this was never tested/checked.
Best regards,
Krzysztof
Quoted 11 lines · Krzysztof Kozlowski
Quoted 9 lines · Konrad Dybcio
Quoted 1 line · Roger Shimizu
---
[...]
Quoted 3 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +3
-0+/ { + model = "Thundercomm AI Mini PC G1 IoT"; + compatible = "qcom,sc7280", "qcom,qcm6490";
Quoted 6 lines
Quoted 3 lines
You need to add a board-specific compatible here, see:
Documentation/devicetree/bindings/arm/qcom.yamlThe true problem is that this would probably fail validation, so I suspect this was never tested/checked.
Thanks for the review!
I did test this device-tree with the board.
If you mean some other test, please let me know in detail.
-Roger
Quoted 14 lines · Roger Shimizu
Quoted 13 lines · Krzysztof Kozlowski
Quoted 11 lines · Konrad Dybcio
Quoted 1 line · Roger Shimizu
---
[...]
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 37
Quoted 3 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +3
-0+/ { + model = "Thundercomm AI Mini PC G1 IoT"; + compatible = "qcom,sc7280", "qcom,qcm6490";You need to add a board-specific compatible here, see:
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Documentation/devicetree/bindings/arm/qcom.yamlThe true problem is that this would probably fail validation, so I suspect this was never tested/checked.
Thanks for the review!
I did test this device-tree with the board.
If you mean some other test, please let me know in detail.
make ... CHECK_DTBS=1 qcom/qcs6490-thundercomm-minipc-g1iot.dtb
make ... dt_binding_check
Konrad
Quoted 18 lines · Konrad Dybcio
Quoted 16 lines · Roger Shimizu
Quoted 15 lines · Krzysztof Kozlowski
Quoted 12 lines · Konrad Dybcio
Quoted 1 line · Roger Shimizu
---
[...]
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 37
Quoted 3 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +3
-0+/ { + model = "Thundercomm AI Mini PC G1 IoT"; + compatible = "qcom,sc7280", "qcom,qcm6490";You need to add a board-specific compatible here, see:
Documentation/devicetree/bindings/arm/qcom.yaml
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
The true problem is that this would probably fail validation, so I suspect this was never tested/checked.
Thanks for the review!
I did test this device-tree with the board.
If you mean some other test, please let me know in detail.make ... CHECK_DTBS=1 qcom/qcs6490-thundercomm-minipc-g1iot.dtb
Thanks for the guide!
I tested above command, it was passed for my v1.
Sure, it also passes after I add the board-specific compatible. (not send yet)
Quoted 1 line
make ...
dt_binding_check
Sorry, I never can run this check command. It reports many python syntax error. I guess the script has issue, or it needs patch to run on my Debian system. I'll report the issue to upstream separately.
-Roger
Quoted 33 lines · Roger Shimizu
Quoted 18 lines · Konrad Dybcio
Quoted 16 lines · Roger Shimizu
Quoted 15 lines · Krzysztof Kozlowski
Quoted 12 lines · Konrad Dybcio
Quoted 1 line · Roger Shimizu
---
[...]
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts line 37
Quoted 3 lines
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts new file +3
-0+/ { + model = "Thundercomm AI Mini PC G1 IoT"; + compatible = "qcom,sc7280", "qcom,qcm6490";You need to add a board-specific compatible here, see:
Documentation/devicetree/bindings/arm/qcom.yamlQuoted 8 lines
Quoted 6 lines
Quoted 2 lines
The true problem is that this would probably fail validation, so I suspect this was never tested/checked.
Thanks for the review!
I did test this device-tree with the board.
If you mean some other test, please let me know in detail.make ... CHECK_DTBS=1 qcom/qcs6490-thundercomm-minipc-g1iot.dtb
Thanks for the guide!
I tested above command, it was passed for my v1.
Sure, it also passes after I add the board-specific compatible. (not send yet)
Quoted 5 lines
Quoted 1 line
make ...
dt_binding_checkSorry, I never can run this check command. It reports many python syntax error. I guess the script has issue, or it needs patch to run on my Debian system. I'll report the issue to upstream separately.
It may be that your version of pydtschema is wildly out of date.
Nowadays the general expectation for using bleeding-edge python tools seems to be for one to grab them via pipx
Konrad
Quoted 5 lines · Konrad Dybcio
It may be that your version of pydtschema is wildly out of date.
Nowadays the general expectation for using bleeding-edge python tools seems to be for one to grab them via pipx
Thanks for the info!
Sorry I forgot to mention that I spent some time last weekend, and resolved the issue in Debian [1]. (patch was enclosed in the ticket) I prefer to use deb pkg, over pip install.
Now I'm using locally built dt-schema deb pkg (updated to latest tag 2025.12), and and run "make dt_binding_check" successfully.
[1] https://bugs.debian.org/1127460
-Roger
Quoted 5 lines · Roger Shimizu
Quoted 3 lines · Konrad Dybcio
It may be that your version of pydtschema is wildly out of date.
Quoted 7 lines
Quoted 2 lines
Nowadays the general expectation for using bleeding-edge python tools seems to be for one to grab them via pipx
Thanks for the info!
Sorry I forgot to mention that I spent some time last weekend, and resolved the issue in Debian [1]. (patch was enclosed in the ticket) I prefer to use deb pkg, over pip install.
Thanks for being an active contributor!
Konrad
Quoted 7 lines
Now I'm using locally built dt-schema deb pkg (updated to latest tag 2025.12), and and run "make
dt_binding_check" successfully.[1] https://bugs.debian.org/1127460
-Roger