Skip to contentSkip to conversation

drm/i915: delete shadow "ret" variable

PATCH In review Dan Carpenter 4 participants 7 messages Jan 27, 2022 – Jan 28, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: delete shadow "ret" variable

This "ret" declaration shadows an existing "ret" variable at the top of the function. Delete it.

---
 drivers/gpu/drm/i915/i915_vma.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/i915_vma.c +0 -2
index 0026e85a0a0d..b66591d6e436 100644
@@ -505,8 +505,6 @@ int i915_vma_bind(struct i915_vma *vma,
 			work->pinned = i915_gem_object_get(vma->obj);
 	} else {
 		if (vma->obj) {
-			int ret;
-
 			ret = i915_gem_object_wait_moving_fence(vma->obj, true);
 			if (ret) {
 				i915_vma_resource_free(vma->resource);
Signature · 1 line
2.20.1
#1 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: delete shadow "ret" variable

== Series Details ==

== Series Details ==

Series: drm/i915: delete shadow "ret" variable
URL : https://patchwork.freedesktop.org/series/99408/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11149 -> Patchwork_22121
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/index.html

Participating hosts (45 -> 41)
------------------------------

Additional (1): fi-icl-u2
Missing (5): fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-bdw-samus

Known issues
------------

Here are the changes found in Patchwork_22121 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-gfx:
- fi-hsw-4770: NOTRUN -> [SKIP][1] ([fdo#109271] / [fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/fi-hsw-4770/igt@amdgpu/[email protected]

* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> [SKIP][2] ([fdo#109315]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/fi-icl-u2/igt@amdgpu/[email protected]

* igt@gem_exec_suspend@basic-s3@smem:
- fi-skl-6600u: [PASS][3] -> [INCOMPLETE][4] ([i915#4547])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/fi-skl-6600u/igt@gem_exec_suspend@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/fi-skl-6600u/igt@gem_exec_suspend@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][5] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/fi-icl-u2/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/fi-icl-u2/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [PASS][7] -> [DMESG-FAIL][8] ([i915#4957])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/bat-dg1-6/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/bat-dg1-6/igt@i915_selftest@[email protected]
- fi-snb-2600: [PASS][9] -> [INCOMPLETE][10] ([i915#3921])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/fi-snb-2600/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/fi-snb-2600/igt@i915_selftest@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][11] ([fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/fi-icl-u2/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][12] ([fdo#109278]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/fi-icl-u2/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][13] ([fdo#109285])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/fi-icl-u2/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][14] ([i915#3301])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/fi-icl-u2/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [DMESG-FAIL][15] ([i915#4957]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/bat-dg1-5/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/bat-dg1-5/igt@i915_selftest@[email protected]
- fi-hsw-4770: [INCOMPLETE][17] ([i915#4785]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/fi-hsw-4770/igt@i915_selftest@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/fi-hsw-4770/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957

Build changes
-------------

* Linux: CI_DRM_11149 -> Patchwork_22121

CI-20190529: 20190529
CI_DRM_11149: 626b06cccf398c25e95dc0534ad018193005ad1b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6336: ae2eb9e18bc58a4c45f28cfd80962938198dec3c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22121: 5177018d7d17166fd0234e698b380ceff9e6c0ed @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

5177018d7d17 drm/i915: delete shadow "ret" variable

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/index.html

#2 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: delete shadow "ret" variable

In reply to Dan Carpenter
== Series Details ==

== Series Details ==

Series: drm/i915: delete shadow "ret" variable
URL : https://patchwork.freedesktop.org/series/99408/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11149_full -> Patchwork_22121_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in Patchwork_22121_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_caching@reads:
- shard-glk: [PASS][1] -> [DMESG-WARN][2] ([i915#118]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-glk3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-glk6/igt@[email protected]

* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [PASS][3] -> [FAIL][4] ([i915#2410])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-tglb1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb2/igt@[email protected]

* igt@gem_exec_balancer@parallel:
- shard-iclb: [PASS][5] -> [SKIP][6] ([i915#4525])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-iclb4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb8/igt@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-iclb3/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@rcs0:
- shard-kbl: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-kbl7/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-kbl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][11] ([i915#2842]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fence@basic-wait@bcs0:
- shard-kbl: NOTRUN -> [SKIP][12] ([fdo#109271]) +29 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-kbl1/igt@gem_exec_fence@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#2190])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl1/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl7/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][15] ([i915#2658])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl8/igt@[email protected]

* igt@gem_pxp@verify-pxp-execution-after-suspend-resume:
- shard-tglb: NOTRUN -> [SKIP][16] ([i915#4270]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@gem_userptr_blits@access-control:
- shard-iclb: NOTRUN -> [SKIP][17] ([i915#3297])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb6/igt@[email protected]

* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][18] ([i915#4990])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl5/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap-after-close:
- shard-tglb: NOTRUN -> [SKIP][19] ([i915#3297])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@gem_userptr_blits@vma-merge:
- shard-kbl: NOTRUN -> [FAIL][20] ([i915#3318])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-kbl1/igt@[email protected]
- shard-skl: NOTRUN -> [FAIL][21] ([i915#3318])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl10/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-tglb: NOTRUN -> [SKIP][22] ([i915#2527] / [i915#2856])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-skl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#658]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl7/igt@[email protected]

* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][24] ([i915#1886] / [i915#2291])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl7/igt@i915_selftest@live@gt_pm.html

* igt@i915_selftest@mock@requests:
- shard-skl: [PASS][25] -> [INCOMPLETE][26] ([i915#4919])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl10/igt@i915_selftest@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl2/igt@i915_selftest@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][27] ([i915#3743])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl10/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][28] ([fdo#111615]) +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@kms_big_fb@yf-tiled-64bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][29] ([fdo#110723])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb6/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#3777]) +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl7/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][31] ([i915#3689] / [i915#3886]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3886]) +6 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl8/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#3689]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_ccs.html

* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][34] ([fdo#109278] / [i915#3886]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb6/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3886])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-kbl1/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
- shard-skl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3886]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl10/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#111615] / [i915#3689]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs.html

* igt@kms_chamelium@dp-crc-single:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109284] / [fdo#111827])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb6/igt@[email protected]

* igt@kms_chamelium@vga-edid-read:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +11 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl8/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-0-25:
- shard-skl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +7 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl5/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-0-5:
- shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-kbl1/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-blue-to-red:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#109284] / [fdo#111827]) +4 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-tglb: NOTRUN -> [SKIP][43] ([i915#3116] / [i915#3299])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-32x10-offscreen:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#3359]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-max-size-sliding:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109278]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-512x170-random:
- shard-tglb: NOTRUN -> [SKIP][46] ([fdo#109279] / [i915#3359])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-32x32-random:
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#3319])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@kms_flip@2x-plain-flip-interruptible:
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#109274] / [fdo#111825]) +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [PASS][49] -> [FAIL][50] ([i915#79])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl8/igt@kms_flip@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl9/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@b-edp1:
- shard-skl: NOTRUN -> [INCOMPLETE][51] ([i915#4839])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl6/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [PASS][52] -> [FAIL][53] ([i915#2122])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl2/igt@kms_flip@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl7/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-ts-check@b-hdmi-a2:
- shard-glk: [PASS][54] -> [FAIL][55] ([i915#2122])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-glk7/igt@kms_flip@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-glk7/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling:
- shard-glk: [PASS][56] -> [FAIL][57] ([i915#4911])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-glk5/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
- shard-iclb: [PASS][58] -> [SKIP][59] ([i915#3701])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-iclb6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-skl: NOTRUN -> [SKIP][60] ([fdo#109271]) +91 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109280])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt:
- shard-tglb: NOTRUN -> [SKIP][62] ([fdo#109280] / [fdo#111825]) +6 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt.html

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#533])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl8/igt@[email protected]

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
- shard-skl: [PASS][64] -> [DMESG-WARN][65] ([i915#1982])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl6/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl4/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: [PASS][66] -> [INCOMPLETE][67] ([i915#1982] / [i915#4939])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl4/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl4/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-apl: [PASS][68] -> [DMESG-WARN][69] ([i915#180]) +3 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-apl6/igt@kms_plane@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl1/igt@kms_plane@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][70] ([fdo#108145] / [i915#265]) +3 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][71] ([fdo#108145] / [i915#265]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl5/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][72] ([fdo#108145] / [i915#265])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-kbl1/igt@[email protected]

* igt@kms_plane_lowres@pipe-b-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][73] ([fdo#111615] / [fdo#112054])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-tglb: NOTRUN -> [SKIP][74] ([i915#2920])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@kms_psr2_su@page_flip-p010:
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#658])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl1/igt@kms_psr2_su@page_flip-p010.html

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][76] -> [SKIP][77] ([fdo#109441]) +4 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb3/igt@kms_psr@psr2_cursor_render.html

* igt@kms_vblank@pipe-d-wait-forked-hang:
- shard-apl: NOTRUN -> [SKIP][78] ([fdo#109271]) +159 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl2/igt@[email protected]

* igt@kms_vrr@flip-dpms:
- shard-tglb: NOTRUN -> [SKIP][79] ([fdo#109502])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@nouveau_crc@pipe-c-source-outp-complete:
- shard-tglb: NOTRUN -> [SKIP][80] ([i915#2530])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@[email protected]

* igt@perf@polling-parameterized:
- shard-skl: [PASS][81] -> [FAIL][82] ([i915#1542])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl10/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl2/igt@[email protected]

* igt@prime_udl:
- shard-tglb: NOTRUN -> [SKIP][83] ([fdo#109291]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb5/igt@prime_udl.html

* igt@prime_vgem@coherency-gtt:
- shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109292])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb6/igt@[email protected]

* igt@sysfs_clients@fair-0:
- shard-apl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#2994]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl2/igt@[email protected]

* igt@sysfs_clients@fair-3:
- shard-skl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#2994])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl7/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_persistence@legacy-engines-hostile@vebox:
- shard-iclb: [FAIL][87] ([i915#2410]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-iclb6/igt@gem_ctx_persistence@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb2/igt@gem_ctx_persistence@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-tglb: [FAIL][89] ([i915#232]) -> [PASS][90] +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-tglb5/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-tglb6/igt@[email protected]

* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][91] ([i915#4525]) -> [PASS][92] +3 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-iclb5/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb2/igt@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-apl: [FAIL][93] ([i915#2842]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-apl1/igt@gem_exec_fair@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [FAIL][95] ([i915#2842]) -> [PASS][96] +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-kbl3/igt@gem_exec_fair@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-kbl6/igt@gem_exec_fair@[email protected]

* igt@gem_linear_blits@interruptible:
- shard-apl: [INCOMPLETE][97] ([i915#4977]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-apl8/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl1/igt@[email protected]

* igt@gem_softpin@allocator-evict-all-engines:
- shard-glk: [FAIL][99] ([i915#4171]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-glk2/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-glk5/igt@[email protected]

* igt@gem_spin_batch@legacy-resubmit@vebox:
- shard-skl: [DMESG-WARN][101] ([i915#1982]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl5/igt@gem_spin_batch@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl7/igt@gem_spin_batch@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][103] ([i915#454]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-iclb2/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb6/igt@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [DMESG-WARN][105] ([i915#118]) -> [PASS][106] +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-glk8/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-glk4/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [INCOMPLETE][107] ([i915#2828] / [i915#300]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl1/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl5/igt@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][109] ([i915#2122]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-glk9/igt@kms_flip@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-glk9/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-kbl: [DMESG-WARN][111] ([i915#180]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-kbl4/igt@kms_flip@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-kbl1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-skl: [INCOMPLETE][113] -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl2/igt@kms_flip@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl6/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [DMESG-WARN][115] ([i915#180]) -> [PASS][116] +4 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-apl7/igt@kms_flip@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-apl2/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate@a-edp1:
- shard-skl: [FAIL][117] ([i915#2122]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl2/igt@kms_flip@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl7/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling:
- shard-glk: [FAIL][119] ([i915#4911]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-glk2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling:
- shard-iclb: [SKIP][121] ([i915#3701]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb6/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html

* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][123] ([i915#1188]) -> [PASS][124] +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl8/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl8/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- shard-iclb: [FAIL][125] ([i915#1888]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-iclb3/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb7/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-glk: [SKIP][127] ([fdo#109271]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-glk3/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-glk9/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][129] ([fdo#108145] / [i915#265]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl6/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl8/igt@[email protected]

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][131] ([fdo#109441]) -> [PASS][132] +2 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-iclb6/igt@kms_psr@psr2_sprite_blt.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html

* igt@sysfs_heartbeat_interval@mixed@bcs0:
- shard-skl: [WARN][133] ([i915#4055]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl5/igt@sysfs_heartbeat_interval@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl1/igt@sysfs_heartbeat_interval@[email protected]

* igt@sysfs_heartbeat_interval@mixed@vcs0:
- shard-skl: [FAIL][135] ([i915#1731]) -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-skl5/igt@sysfs_heartbeat_interval@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-skl1/igt@sysfs_heartbeat_interval@[email protected]

#### Warnings ####

* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][137] ([i915#4916]) -> [SKIP][138] ([i915#4525])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-iclb4/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb8/igt@[email protected]

* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][139] ([i915#2842]) -> [FAIL][140] ([i915#2852])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11149/shard-iclb6/igt@gem_exec_fair@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/shard-iclb2/igt@gem_exec_fair@[email protected]

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][141]

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22121/index.html

maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Dan Carpenter
Quoted 4 lines · Dan Carpenter

This "ret" declaration shadows an existing "ret" variable at the top of the function. Delete it.

and pushing right now

Quoted 20 lines
---
 drivers/gpu/drm/i915/i915_vma.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/i915_vma.c +0 -2
index 0026e85a0a0d..b66591d6e436 100644
@@ -505,8 +505,6 @@ int i915_vma_bind(struct i915_vma *vma,
 			work->pinned = i915_gem_object_get(vma->obj);
 	} else {
 		if (vma->obj) {
-			int ret;
-
 			ret = i915_gem_object_wait_moving_fence(vma->obj, true);
 			if (ret) {
 				i915_vma_resource_free(vma->resource);
Signature · 1 line
2.20.1
#4 lore raw
Quoted 10 lines · Rodrigo Vivi
Quoted 5 lines · Dan Carpenter

This "ret" declaration shadows an existing "ret" variable at the top of
the function.  Delete it.

and pushing right now

Should probably have had a Fixes: tag on this one. I'm not 100% sure whether the faulty patch is already upstream. In that case we might need to manually include it in a -fixes pull.

/Thomas

Quoted 25 lines
Quoted 25 lines

---
 drivers/gpu/drm/i915/i915_vma.c | 2 --

 1 file changed, 2 deletions(-)
drivers/gpu/drm/i915/i915_vma.c +0 -0
index 0026e85a0a0d..b66591d6e436 100644
@@ -505,8 +505,6 @@ int i915_vma_bind(struct i915_vma *vma,

                        work->pinned = i915_gem_object_get(vma-

Quoted 1 line

obj);

        } else {
                if (vma->obj) {
-                       int ret;
-
                        ret = i915_gem_object_wait_moving_fence(vma->obj, true); if (ret) { i915_vma_resource_free(vma-

Quoted 1 line

resource);

Signature · 1 line
2.20.1
#5 lore raw
Quoted 8 lines · Thomas Hellström
Quoted 7 lines · Rodrigo Vivi
Quoted 5 lines · Dan Carpenter

This "ret" declaration shadows an existing "ret" variable at the top of
the function.  Delete it.

Quoted 8 lines
Quoted 3 lines

and pushing right now

Should probably have had a Fixes: tag on this one. I'm not 100% sure whether the faulty patch is already upstream. In that case we might need to manually include it in a -fixes pull.

It's not really a bug. It's just a Sparse warning which is disabled by default (-Wshadow). The patch is in linux-next.

Fixes 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding")

regards,
dan carpenter

maintainer
#6 lore raw
Quoted 8 lines · Dan Carpenter
Quoted 7 lines · Thomas Hellström
Quoted 6 lines · Rodrigo Vivi
Quoted 5 lines · Dan Carpenter

This "ret" declaration shadows an existing "ret" variable at the
top of
the function.  Delete it.

Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 1 line

and pushing right now

Should probably have had a Fixes: tag on this one. I'm not 100%

Well, I had added while pushing yesterday... but...

Quoted 7 lines
Quoted 4 lines

sure
whether the faulty patch is already upstream. In that case we might need to manually include it in a -fixes pull.

It's not really a bug.  It's just a Sparse warning which is disabled by default (-Wshadow).  The patch is in linux-next.

Yeap, but it is good to add Fixes so if anyone is backporting the other patch it is clear that this patch is a good addition on top.

Quoted 3 lines
Fixes 2f6b90da9192 ("drm/i915: Use vma resources for async

unbinding")

hmm... you are right... this one was the one...

I had added

Fixes f6c466b84cfa ("drm/i915: Add support for moving fence waiting")

pointing to the original patch that introduced this int ret instead of the one that created the duplication...

so my Fixes addition can actually break some backport out there... But luckily I believe that these 2 patches will be backported together anyway...

Sorry about the confusion,
Rodrigo.

Quoted 4 lines

regards,
dan carpenter