tty/serial/imx: Enable TXEN bit in imx_poll_init().
Subsystems (2)
PATCH RESEND 1/1 tty/serial/imx: Enable TXEN bit in imx_poll_init().
From: Mingrui Ren <[email protected]>
As described in Documentation, poll_init() is called by kgdb to initialize hardware which supports both poll_put_char() and poll_get_char().
It's necessary to enable TXEN bit, otherwise, it will cause hardware fault and kernel panic when calling imx_poll_put_char().
Generally, if use /dev/ttymxc0 as kgdb console as well as system console, ttymxc0 is initialized early by system console which does enable TXEN bit.But when use /dev/ttymxc1 as kgbd console, ttymxc1 is only initialized by imx_poll_init() cannot enable the TXEN bit, which will cause kernel panic.
---
Hi, thanks for your reply, and sorry for sending two identical emails. The email service I used before seems to have some problems, so I switched to gmail.This is the "correct" version, please check.
drivers/tty/serial/imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/imx.c +1 -1
@@ -1829,7 +1829,7 @@ static int imx_uart_poll_init(struct uart_port *port) ucr1 |=UCR1_UARTEN ; ucr1 &= ~(UCR1_TRDYEN |UCR1_RTSDEN |UCR1_RRDYEN ); - ucr2 |=UCR2_RXEN ; + ucr2 |=UCR2_RXEN |UCR2_TXEN ; ucr2 &= ~UCR2_ATEN ;imx_uart_writel (sport, ucr1,UCR1 );
Signature · 1 line
2.29.2
Greg KH
maintainerQuoted 28 lines · On Wed, Dec 02, 2020 at 07:03:08AM +0800, jiladahe1997 wrote:
From: Mingrui Ren <[email protected]>
As described in Documentation,
poll_init()is called by kgdb to initialize hardware which supports bothpoll_put_char()andpoll_get_char().It's necessary to enable TXEN bit, otherwise, it will cause hardware fault and kernel panic when calling
imx_poll_put_char().Generally, if use
/dev/ttymxc0as kgdb console as well as system console, ttymxc0 is initialized early by system console which does enable TXEN bit.But when use/dev/ttymxc1as kgbd console, ttymxc1 is only initialized byimx_poll_init()cannot enable the TXEN bit, which will cause kernel panic.Signed-off-by Mingrui Ren <[email protected]>---
Hi, thanks for your reply, and sorry for sending two identical emails. The email service I used before seems to have some problems, so I switched to gmail.This is the "correct" version, please check.drivers/tty/serial/imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/tty/serial/imx.c +0
-0
drivers/tty/serial/imx.c static int imx_uart_poll_init(struct uart_port *port) · line 1832
Quoted 5 lines
drivers/tty/serial/imx.c +1
-1@@ -1829,7 +1829,7 @@ static int imx_uart_poll_init(struct uart_port *port) ucr1 |=UCR1_UARTEN ; ucr1 &= ~(UCR1_TRDYEN |UCR1_RTSDEN |UCR1_RRDYEN ); - ucr2 |=UCR2_RXEN ; + ucr2 |=UCR2_RXEN |UCR2_TXEN ;
Didn't checkpatch complain about this? Please use ' ' characters around the '|' character.
thanks,
greg k-h
Quoted 32 lines · Greg KH
Quoted 31 lines · On Wed, Dec 02, 2020 at 07:03:08AM +0800, jiladahe1997 wrote:
From: Mingrui Ren <[email protected]>
As described in Documentation,
poll_init()is called by kgdb to initialize hardware which supports bothpoll_put_char()andpoll_get_char().It's necessary to enable TXEN bit, otherwise, it will cause hardware fault and kernel panic when calling
imx_poll_put_char().Generally, if use
/dev/ttymxc0as kgdb console as well as system console, ttymxc0 is initialized early by system console which does enable TXEN bit.But when use/dev/ttymxc1as kgbd console, ttymxc1 is only initialized byimx_poll_init()cannot enable the TXEN bit, which will cause kernel panic.Signed-off-by Mingrui Ren <[email protected]>---
Hi, thanks for your reply, and sorry for sending two identical emails. The email service I used before seems to have some problems, so I switched to gmail.This is the "correct" version, please check.drivers/tty/serial/imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/tty/serial/imx.c +0
-0@@ -1829,7 +1829,7 @@ static int imx_uart_poll_init(struct uart_port *port) ucr1 |=UCR1_UARTEN ; ucr1 &= ~(UCR1_TRDYEN |UCR1_RTSDEN |UCR1_RRDYEN );
Quoted 8 lines
drivers/tty/serial/imx.c static int imx_uart_poll_init(struct uart_port *port) · line 1832
Quoted 2 lines
drivers/tty/serial/imx.c +1
-1- ucr2 |=UCR2_RXEN ; + ucr2 |=UCR2_RXEN |UCR2_TXEN ;Didn't checkpatch complain about this? Please use ' ' characters around the '|' character.
thanks,
greg k-h
Yeah, checkpatch didn't complain:
root@iZ2zefbvkcoj7o7ledf4oqZ:~/workspace/linux-imx$ ./scripts/checkpatch.pl 0001-tty-serial-imx-Enable-TXEN-bit-in-imx_poll_init.patch
total: 0 errors, 0 warnings, 8 lines checked
0001-tty-serial-imx-Enable-TXEN-bit-in-imx_poll_init.patch has no obvious style problems and is ready for submission.
Maybe some patches should be submitted to checkpatch.pl :).
Anyway, I will add ' ' characters and send PATCH V2.
Thanks,
Mingrui Ren