Skip to contentSkip to conversation

linux-firmware: Add firmware for RTL8812AU device

PATCH In review Nick Morrow 2 participants 4 messages Aug 22, 2024 – Aug 26, 2024

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 linux-firmware: Add firmware for RTL8812AU device

This firmware was extracted from the 20210708 - v5.13.6-23 release of the vendor driver for this device and is believed to be the latest release by Realtek. Testing of the new driver has been accomplished using this firmware. Numerous testers have been involved.

---
v2:
- No change. Resubmitted now that the driver is in review.

---
 WHENCE                |   1 +
 rtw88/README          |   3 +++
 rtw88/rtw8812a_fw.bin | Bin 0 -> 27030 bytes
 3 files changed, 4 insertions(+)
 create mode 100644 rtw88/rtw8812a_fw.bin
WHENCE +1 -0
index 8aebe56b..d6bd4814 100644
@@ -3270,6 +3270,7 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
 Driver: rtw88 - Realtek 802.11ac WLAN driver for RTL8822BE and RTL8822CE
 
 Info: Sent to Larry Finger by Realtek engineer Yan-Hsuan Chuang <[email protected]>
+File: rtw88/rtw8812a_fw.bin
 File: rtw88/rtw8821a_fw.bin
 File: rtw88/rtw8822b_fw.bin
 File: rtw88/rtw8822c_fw.bin
rtw88/README +3 -0
index 469db2f7..ef3a7505 100644
@@ -19,6 +19,9 @@ except that the device cannot be waken from the wireless NICs.
 
 Currently supported devices with corresponding firmwares:
 
+RTL8812AU
+    rtw8812a_fw.bin
+
 RTL8821AU
     rtw8821a_fw.bin
 
rtw88/rtw8812a_fw.bin new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..eabb779a944e7120e1de4025e05d89a74379b066
GIT binary patch
Signature · 1 line
2.39.2
#1 lore raw

+linux-wireless

Hi Nick,

Please always Cc linux-wireless for rtw88 firmware.

And subject prefix would be "rtw88: ..."

Quoted 21 lines · Nick Morrow

This firmware was extracted from the 20210708 - v5.13.6-23 release of the vendor driver for this device and is believed to be the latest release by Realtek. Testing of the new driver has been accomplished using this firmware. Numerous testers have been involved.

---
v2:
- No change. Resubmitted now that the driver is in review.

---
  WHENCE                |   1 +
  rtw88/README          |   3 +++
  rtw88/rtw8812a_fw.bin | Bin 0 -> 27030 bytes
  3 files changed, 4 insertions(+)

create mode 100644 rtw88/rtw8812a_fw.bin

WHENCE +0 -0
index 8aebe56b..d6bd4814 100644

WHENCE Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details. · line 3274

Quoted 5 lines
WHENCE +1 -0
@@ -3270,6 +3270,7 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
  Driver: rtw88 - Realtek 802.11ac WLAN driver for RTL8822BE and RTL8822CE
 
  Info: Sent to Larry Finger by Realtek engineer Yan-Hsuan Chuang <[email protected]>
+File: rtw88/rtw8812a_fw.bin
  File: rtw88/rtw8821a_fw.bin

I failed to apply this patch, even this textual part.

Two leading spaces before "File: rtw88/rtw8821a_fw.bin", but actually this should be only one. Not sure what is wrong.

Quoted 7 lines
WHENCE +0 -0
  File: rtw88/rtw8822b_fw.bin
  File: rtw88/rtw8822c_fw.bin
rtw88/README +0 -0
index 469db2f7..ef3a7505 100644

rtw88/README except that the device cannot be waken from the wireless NICs. · line 26

Quoted 8 lines
rtw88/README +3 -0
@@ -19,6 +19,9 @@ except that the device cannot be waken from the wireless NICs.
 
  Currently supported devices with corresponding firmwares:
 
+RTL8812AU
+    rtw8812a_fw.bin
+
  RTL8821AU
      rtw8821a_fw.bin

Similar problem here.

#2 lore raw
Quoted 7 lines · Ping-Ke Shih

+linux-wireless

Hi Nick,

Please always Cc linux-wireless for rtw88 firmware.

And subject prefix would be "rtw88: ..."

Hi Ping-Ke, I am trying to resolve what you are asking for vs. the instructions at linux-firmware. Should the subject for V3 be:

[PATCH V3] linux-firmware: rtw88: Add firmware for RTL8812AU device

Quoted 25 lines
Quoted 23 lines · Nick Morrow

This firmware was extracted from the 20210708 - v5.13.6-23 release of the vendor driver for this device and is believed to be the latest release by Realtek. Testing of the new driver has been accomplished using this firmware. Numerous testers have been involved.

---
v2:
- No change. Resubmitted now that the driver is in review.

---
   WHENCE                |   1 +
   rtw88/README          |   3 +++
   rtw88/rtw8812a_fw.bin | Bin 0 -> 27030 bytes
   3 files changed, 4 insertions(+)

create mode 100644 rtw88/rtw8812a_fw.bin

WHENCE +0 -0
index 8aebe56b..d6bd4814 100644
@@ -3270,6 +3270,7 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
   Driver: rtw88 - Realtek 802.11ac WLAN driver for RTL8822BE and RTL8822CE
 
Quoted 8 lines

WHENCE Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details. · line 3274

Quoted 3 lines
WHENCE +1 -0
   Info: Sent to Larry Finger by Realtek engineer Yan-Hsuan Chuang <[email protected]>
+File: rtw88/rtw8812a_fw.bin
   File: rtw88/rtw8821a_fw.bin

I failed to apply this patch, even this textual part.

Two leading spaces before "File: rtw88/rtw8821a_fw.bin", but actually this should be only one. Not sure what is wrong.

I am carefully going over this patch again... while preparing a new version of the patch. I do not recall editing the line that has two leading spaces.

#3 lore raw
Quoted 5 lines · Nick Morrow
Quoted 4 lines · Ping-Ke Shih

+linux-wireless

Hi Nick,

Quoted 8 lines
Quoted 3 lines

Please always Cc linux-wireless for rtw88 firmware.

And subject prefix would be "rtw88: ..."

Hi Ping-Ke, I am trying to resolve what you are asking for vs. the instructions at linux-firmware. Should the subject for V3 be:

[PATCH V3] linux-firmware: rtw88: Add firmware for RTL8812AU device

Most commits excepting to mediatek's ones don't use "linux-firmware: " as prefix. I don't want that neither. Or I miss this new rule?

Quoted 32 lines
Quoted 32 lines
Quoted 21 lines · Nick Morrow

This firmware was extracted from the 20210708 - v5.13.6-23 release of the vendor driver for this device and is believed to be the latest release by Realtek. Testing of the new driver has been accomplished using this firmware. Numerous testers have been involved.

---
v2:
- No change. Resubmitted now that the driver is in review.

---
   WHENCE                |   1 +
   rtw88/README          |   3 +++
   rtw88/rtw8812a_fw.bin | Bin 0 -> 27030 bytes
   3 files changed, 4 insertions(+)

create mode 100644 rtw88/rtw8812a_fw.bin

WHENCE +0 -0
index 8aebe56b..d6bd4814 100644

WHENCE Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details. · line 3274

Quoted 5 lines
WHENCE +1 -0
@@ -3270,6 +3270,7 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
   Driver: rtw88 - Realtek 802.11ac WLAN driver for RTL8822BE and RTL8822CE
 
   Info: Sent to Larry Finger by Realtek engineer Yan-Hsuan Chuang <[email protected]>
+File: rtw88/rtw8812a_fw.bin
   File: rtw88/rtw8821a_fw.bin

I failed to apply this patch, even this textual part.

Quoted 5 lines
Quoted 2 lines

Two leading spaces before "File: rtw88/rtw8821a_fw.bin", but actually this should be only one. Not sure what is wrong.

I am carefully going over this patch again... while preparing a new version of the patch. I do not recall editing the line that has two leading spaces.

I update my linux-firmware repository to the newest:
2cdc11a7b3bf ("Merge branch 'mt7925' into 'main'")

And, add the line. The difference looks like

WHENCE +1 -0
index c18b2e0d8db9..0c03b2d03b83 100644
@@ -3270,6 +3270,7 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
 Driver: rtw88 - Realtek 802.11ac WLAN driver for RTL8822BE and RTL8822CE
 
 Info: Sent to Larry Finger by Realtek engineer Yan-Hsuan Chuang <[email protected]>
+File: rtw88/rtw8812a_fw.bin
 File: rtw88/rtw8821a_fw.bin
 File: rtw88/rtw8822b_fw.bin
 File: rtw88/rtw8822c_fw.bin

This is what I expect. Can you apply your patch successfully in your side?