tests/kms_psr2_su: add biplanar selective update tests
PATCH v3 1/1 tests/kms_psr2_su: add biplanar selective update tests
Add biplanar formats (NV12, p010) into selective update test. Use also offset for white rectangle as this reveals better possible issues with offset calculation/configuration.
v2: Add back skipping of frontbuffer rendering tests
v3: Use hyphen instead of underscore in testnames
--- tests/i915/kms_psr2_su.c | 91 +++++++++++++++++++++++++--------------- 1 file changed, 58 insertions(+), 33 deletions(-)
tests/i915/kms_psr2_su.c +58 -33
@@ -33,7 +33,8 @@IGT_TEST_DESCRIPTION ("Test PSR2 selective update" ); -#define SQUARE_SIZE 100 +#define SQUARE_SIZE 100 +#define SQUARE_OFFSET 100/* each selective update block is 4 lines tall */ #define EXPECTED_NUM_SU_BLOCKS ((SQUARE_SIZE / 4) + (SQUARE_SIZE % 4 ? 1 : 0))
@@ -50,6 +51,23 @@ enum operations {LAST }; +static const uint32_t formats_page_flip[] = { +DRM_FORMAT_XRGB8888 , +DRM_FORMAT_NV12 , +DRM_FORMAT_P010 , +DRM_FORMAT_INVALID , +}; + +static const uint32_t formats_frontbuffer[] = { +DRM_FORMAT_XRGB8888 , +DRM_FORMAT_INVALID , +}; + +static const uint32_t *formats[] = { + [PAGE_FLIP ] = formats_page_flip, + [FRONTBUFFER ] = formats_frontbuffer, +}; +static const char *op_str (enum operations op) {static const char *const name[] = {
@@ -68,6 +86,7 @@ typedef struct {igt_output_t *output;struct igt_fb fb[2 ];enum operations op; +uint32_t format;cairo_t *cr;int change_screen_timerfd;uint32_t screen_changes;
@@ -111,7 +130,7 @@ static void prepare(data_t *data)/* all green frame */ igt_create_color_fb (data->drm_fd, data->mode->hdisplay, data->mode->vdisplay, -DRM_FORMAT_XRGB8888 , + data->format,DRM_FORMAT_MOD_LINEAR ,0.0 ,1.0 ,0.0 , &data->fb[0 ]);
@@ -121,14 +140,14 @@ static void prepare(data_t *data)igt_create_color_fb (data->drm_fd, data->mode->hdisplay, data->mode->vdisplay, -DRM_FORMAT_XRGB8888 , + data->format,DRM_FORMAT_MOD_LINEAR ,0.0 ,1.0 ,0.0 , &data->fb[1 ]); cr =igt_get_cairo_ctx (data->drm_fd, &data->fb[1 ]);/* paint a white square */ -igt_paint_color_alpha (cr,0 ,0 ,SQUARE_SIZE ,SQUARE_SIZE , +igt_paint_color_alpha (cr,SQUARE_OFFSET ,SQUARE_OFFSET ,SQUARE_SIZE ,SQUARE_SIZE ,1.0 ,1.0 ,1.0 ,1.0 );igt_put_cairo_ctx (cr); }else if (data->op ==FRONTBUFFER ) {
@@ -152,8 +171,8 @@ static bool update_screen_and_test(data_t *data)struct drm_mode_rect clip;igt_plane_t *primary; - clip.x1 = clip.y1 =0 ; - clip.x2 = clip.y2 =SQUARE_SIZE ; + clip.x1 = clip.y1 =SQUARE_OFFSET ; + clip.x2 = clip.y2 =SQUARE_OFFSET +SQUARE_SIZE ; primary =igt_output_get_plane_type (data->output,DRM_PLANE_TYPE_PRIMARY );
@@ -167,16 +186,18 @@ static bool update_screen_and_test(data_t *data)case FRONTBUFFER : {drmModeClip clip; - clip.x1 = clip.y1 =0 ; - clip.x2 = clip.y2 =SQUARE_SIZE ; + clip.x1 = clip.y1 =SQUARE_OFFSET ; + clip.x2 = clip.y2 =SQUARE_OFFSET +SQUARE_SIZE ;if (data->screen_changes &1 ) {/* go back to all green frame with a square */ -igt_paint_color_alpha (data->cr,0 ,0 ,SQUARE_SIZE , +igt_paint_color_alpha (data->cr,SQUARE_OFFSET , +SQUARE_OFFSET ,SQUARE_SIZE ,SQUARE_SIZE ,1.0 ,1.0 ,1.0 ,1.0 ); }else {/* go back to all green frame */ -igt_paint_color_alpha (data->cr,0 ,0 ,SQUARE_SIZE , +igt_paint_color_alpha (data->cr,SQUARE_OFFSET , +SQUARE_OFFSET ,SQUARE_SIZE ,SQUARE_SIZE ,0 ,1.0 ,0 ,1.0 ); }
@@ -261,6 +282,7 @@ igt_main data.debugfs_fd, PSR_MODE_2), "Error enabling PSR2\n"); data.op =FRONTBUFFER ; + data.format =DRM_FORMAT_XRGB8888 ;prepare (&data); r =psr_wait_entry (data.debugfs_fd,PSR_MODE_2 );cleanup (&data);
@@ -281,31 +303,34 @@ igt_main }for (data.op =PAGE_FLIP ; data.op <LAST ; data.op++) { -igt_describe ("Test that selective update works when screen changes" ); - igt_subtest_f("%s", op_str(data.op)) { - -if (data.op ==FRONTBUFFER && -intel_display_ver (intel_get_drm_devid (data.drm_fd)) >=12 ) { -/* -* FIXME: Display 12+ platforms now have PSR2 -* selective fetch enabled by default but we -* still can't properly handle frontbuffer -* rendering, so right it does full frame -* fetches at every frontbuffer rendering. -* So it is expected that this test will fail -* in display 12+ platform fow now. -*/ -igt_skip ("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n" ); +const uint32_t *format = formats[data.op]; + +while (*format !=DRM_FORMAT_INVALID ) { + data.format = *format++; +igt_describe ("Test that selective update works when screen changes" ); + igt_subtest_f("%s-%s", op_str(data.op), igt_format_str(data.format)) { +if (data.op ==FRONTBUFFER && +intel_display_ver (intel_get_drm_devid (data.drm_fd)) >=12 ) { +/* +* FIXME: Display 12+ platforms now have PSR2 +* selective fetch enabled by default but we +* still can't properly handle frontbuffer +* rendering, so right it does full frame +* fetches at every frontbuffer rendering. +* So it is expected that this test will fail +* in display 12+ platform for now. +*/ +igt_skip ("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n" ); + } +prepare (&data); +run (&data); +cleanup (&data); } - -prepare (&data); -run (&data); -cleanup (&data); } - } - igt_fixture { -close (data.debugfs_fd); -display_fini (&data); + igt_fixture { +close (data.debugfs_fd); +display_fini (&data); + } } }
Signature · 1 line
2.25.1
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_psr2_su: add biplanar selective update tests (rev3)
== Series Details ==
== Series Details ==
Series: tests/kms_psr2_su: add biplanar selective update tests (rev3)
URL : https://patchwork.freedesktop.org/series/96110/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10796 -> IGTPW_6355
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/index.html
Participating hosts (39 -> 35)
------------------------------
Missing (4): fi-bsw-cyan bat-adlp-4 bat-dg1-6 bat-dg1-5
Known issues
------------
Here are the changes found in IGTPW_6355 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-soraka: [PASS][1] -> [INCOMPLETE][2] ([i915#4221])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/fi-kbl-soraka/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/fi-kbl-soraka/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [PASS][3] -> [DMESG-WARN][4] ([i915#4269])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/fi-cml-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/fi-cml-u2/igt@[email protected]
#### Possible fixes ####
* igt@kms_frontbuffer_tracking@basic:
- {fi-hsw-gt1}: [DMESG-WARN][5] ([i915#4290]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/fi-hsw-gt1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/fi-hsw-gt1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#4221]: https://gitlab.freedesktop.org/drm/intel/issues/4221
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4290]: https://gitlab.freedesktop.org/drm/intel/issues/4290
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6262 -> IGTPW_6355
CI-20190529: 20190529
CI_DRM_10796: c2698ab428a9398c02ef1ee3a03f51608cf97a86 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6355: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/index.html
IGT_6262: d1c793b26e31cc6ae3f9fa3239805a9bbcc749fb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Testlist changes ==
+igt@kms_psr2_su@frontbuffer-xrgb8888
+igt@kms_psr2_su@page_flip-nv12
+igt@kms_psr2_su@page_flip-p010
+igt@kms_psr2_su@page_flip-xrgb8888
-igt@kms_psr2_su@frontbuffer
-igt@kms_psr2_su@page_flip
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/index.html
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_psr2_su: add biplanar selective update tests (rev3)
In reply to Jouni Högander== Series Details ==
== Series Details ==
Series: tests/kms_psr2_su: add biplanar selective update tests (rev3)
URL : https://patchwork.freedesktop.org/series/96110/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10796_full -> IGTPW_6355_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/index.html
Participating hosts (10 -> 7)
------------------------------
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_6355_full:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_psr2_su@page_flip-nv12} (NEW):
- shard-tglb: NOTRUN -> [SKIP][1] +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb8/igt@kms_psr2_su@page_flip-nv12.html
- shard-iclb: NOTRUN -> [SKIP][2] +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb4/igt@kms_psr2_su@page_flip-nv12.html
New tests
---------
New tests have been introduced between CI_DRM_10796_full and IGTPW_6355_full:
### New IGT tests (4) ###
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_psr2_su@page_flip-nv12:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_psr2_su@page_flip-p010:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_psr2_su@page_flip-xrgb8888:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_6355_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][3] -> [SKIP][4] ([i915#658])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-iclb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb6/igt@[email protected]
* igt@gem_create@create-massive:
- shard-iclb: NOTRUN -> [DMESG-WARN][5] ([i915#3002])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb3/igt@[email protected]
- shard-snb: NOTRUN -> [DMESG-WARN][6] ([i915#3002])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-snb6/igt@[email protected]
- shard-tglb: NOTRUN -> [DMESG-WARN][7] ([i915#3002])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb6/igt@[email protected]
- shard-glk: NOTRUN -> [DMESG-WARN][8] ([i915#3002])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk7/igt@[email protected]
- shard-apl: NOTRUN -> [DMESG-WARN][9] ([i915#3002])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-apl4/igt@[email protected]
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [PASS][10] -> [DMESG-WARN][11] ([i915#180]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-kbl4/igt@gem_ctx_isolation@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl3/igt@gem_ctx_isolation@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][12] -> [TIMEOUT][13] ([i915#2369] / [i915#2481] / [i915#3070])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-iclb4/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb7/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: NOTRUN -> [FAIL][14] ([i915#2846])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl4/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][15] -> [FAIL][16] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-iclb5/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: NOTRUN -> [FAIL][17] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [PASS][18] -> [FAIL][19] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-glk7/igt@gem_exec_fair@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][20] ([i915#2842])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][21] -> [FAIL][22] ([i915#2842])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-kbl7/igt@gem_exec_fair@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-tglb: NOTRUN -> [FAIL][23] ([i915#2842])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_params@rsvd2-dirt:
- shard-tglb: NOTRUN -> [SKIP][24] ([fdo#109283])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][25] ([fdo#109283])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb6/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#2190])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-apl4/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#2190])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl6/igt@[email protected]
* igt@gem_pxp@create-protected-buffer:
- shard-snb: NOTRUN -> [SKIP][28] ([fdo#109271]) +64 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-snb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][29] ([i915#4270])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb7/igt@[email protected]
* igt@gem_pxp@verify-pxp-stale-ctx-execution:
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#4270]) +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb8/igt@[email protected]
* igt@gen9_exec_parse@cmd-crossing-page:
- shard-tglb: NOTRUN -> [SKIP][31] ([i915#2856])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][32] ([i915#2856])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb3/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][33] -> [FAIL][34] ([i915#454])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-iclb8/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb4/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][35] -> [SKIP][36] ([fdo#109271]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-apl2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-apl8/igt@[email protected]
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#109506] / [i915#2411])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb8/igt@[email protected]
* igt@i915_query@query-topology-known-pci-ids:
- shard-tglb: NOTRUN -> [SKIP][38] ([fdo#109303])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb3/igt@[email protected]
* igt@i915_query@query-topology-unsupported:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#109302])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb6/igt@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-0:
- shard-glk: [PASS][40] -> [DMESG-WARN][41] ([i915#118]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-glk6/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk4/igt@[email protected]
* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111614]) +2 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb3/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#3777]) +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl3/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#3777]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk8/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3777])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-apl3/igt@[email protected]
* igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][46] ([fdo#111615]) +5 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb6/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271]) +75 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-apl8/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#3886]) +11 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl7/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#3886]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-apl8/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#3886]) +4 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk1/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][51] ([i915#3689] / [i915#3886]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb1/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][52] ([i915#3689]) +3 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb6/igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs.html
* igt@kms_chamelium@dp-crc-fast:
- shard-snb: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +5 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-snb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109284] / [fdo#111827]) +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb2/igt@[email protected]
* igt@kms_chamelium@dp-crc-multiple:
- shard-apl: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +5 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-apl1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][56] ([fdo#109284] / [fdo#111827]) +8 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb7/igt@[email protected]
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-glk: NOTRUN -> [SKIP][57] ([fdo#109271] / [fdo#111827]) +9 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk6/igt@[email protected]
* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271] / [fdo#111827]) +13 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl7/igt@[email protected]
* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> [TIMEOUT][59] ([i915#1319]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl1/igt@[email protected]
* igt@kms_content_protection@type1:
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#111828])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb7/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#3319])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb2/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][62] ([i915#180]) +5 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl7/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-32x10-onscreen:
- shard-tglb: NOTRUN -> [SKIP][63] ([i915#3359]) +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb2/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-512x170-sliding:
- shard-iclb: NOTRUN -> [SKIP][64] ([fdo#109278]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb4/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][65] ([fdo#109279] / [i915#3359]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb1/igt@[email protected]
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size:
- shard-tglb: NOTRUN -> [SKIP][66] ([i915#4103])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb8/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
* igt@kms_dp_tiled_display@basic-test-pattern:
- shard-iclb: NOTRUN -> [SKIP][67] ([i915#426])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][68] ([i915#426])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb2/igt@[email protected]
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109274])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb1/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [PASS][70] -> [FAIL][71] ([i915#79])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-glk8/igt@kms_flip@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [PASS][72] -> [DMESG-WARN][73] ([i915#180]) +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-apl4/igt@kms_flip@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-apl4/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@c-edp1:
- shard-iclb: [PASS][74] -> [DMESG-WARN][75] ([i915#2867])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-iclb8/igt@kms_flip@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb1/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
- shard-glk: [PASS][76] -> [FAIL][77] ([i915#2546]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-glk2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109280]) +4 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-move:
- shard-tglb: NOTRUN -> [SKIP][79] ([fdo#111825]) +20 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb7/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][80] ([fdo#109271]) +241 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl3/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#533]) +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl7/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#533])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk3/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][83] ([i915#265])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][84] ([fdo#108145] / [i915#265]) +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl6/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][85] ([fdo#108145] / [i915#265]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-apl1/igt@[email protected]
* igt@kms_plane_cursor@pipe-d-viewport-size-256:
- shard-glk: NOTRUN -> [SKIP][86] ([fdo#109271]) +77 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk9/igt@[email protected]
* igt@kms_plane_lowres@pipe-b-tiling-y:
- shard-tglb: NOTRUN -> [SKIP][87] ([i915#3536])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb3/igt@[email protected]
* igt@kms_plane_lowres@pipe-c-tiling-yf:
- shard-iclb: NOTRUN -> [SKIP][88] ([i915#3536])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb8/igt@[email protected]
* igt@kms_plane_lowres@pipe-d-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][89] ([fdo#112054]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb3/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#658])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-apl7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#2920]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb7/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-kbl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#658]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl7/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-iclb: NOTRUN -> [SKIP][93] ([i915#658])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb8/igt@[email protected]
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-tglb: NOTRUN -> [FAIL][94] ([i915#132] / [i915#3467])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb1/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_psr@psr2_primary_render:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109441])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb4/igt@kms_psr@psr2_primary_render.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [PASS][96] -> [SKIP][97] ([fdo#109441])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][98] -> [FAIL][99] ([i915#31])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-apl4/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-apl1/igt@[email protected]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-tglb: [PASS][100] -> [INCOMPLETE][101] ([i915#2828] / [i915#456])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-tglb7/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb7/igt@[email protected]
* igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
- shard-tglb: [PASS][102] -> [INCOMPLETE][103] ([i915#456]) +1 similar issue
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-tglb5/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb7/igt@[email protected]
* igt@kms_writeback@writeback-check-output:
- shard-kbl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#2437])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl6/igt@[email protected]
* igt@kms_writeback@writeback-fb-id:
- shard-glk: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#2437])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk6/igt@[email protected]
* igt@nouveau_crc@pipe-b-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][106] ([i915#2530])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb1/igt@[email protected]
* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#109289])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb1/igt@[email protected]
* igt@prime_vgem@fence-flip-hang:
- shard-tglb: NOTRUN -> [SKIP][108] ([fdo#109295])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb1/igt@[email protected]
* igt@sysfs_clients@fair-3:
- shard-kbl: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#2994]) +3 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl1/igt@[email protected]
* igt@sysfs_clients@pidname:
- shard-tglb: NOTRUN -> [SKIP][110] ([i915#2994])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb7/igt@[email protected]
* igt@sysfs_clients@split-25:
- shard-glk: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#2994]) +2 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk7/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_shared@q-smoketest-all:
- shard-glk: [DMESG-WARN][112] ([i915#118]) -> [PASS][113] +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-glk6/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk8/igt@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [FAIL][114] ([i915#2842]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-kbl7/igt@gem_exec_fair@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [FAIL][116] ([i915#2842]) -> [PASS][117] +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-glk8/igt@gem_exec_fair@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk9/igt@gem_exec_fair@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][118] ([i915#3921]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-snb6/igt@i915_selftest@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-snb5/igt@i915_selftest@[email protected]
* igt@i915_suspend@debugfs-reader:
- shard-tglb: [INCOMPLETE][120] ([i915#456]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-tglb7/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb7/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][122] ([i915#72]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-glk5/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk9/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-iclb: [FAIL][124] ([i915#2346]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-iclb7/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb1/igt@[email protected]
* igt@kms_flip@modeset-vs-vblank-race-interruptible@b-edp1:
- shard-tglb: [INCOMPLETE][126] -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-tglb8/igt@kms_flip@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-tglb6/igt@kms_flip@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][128] ([i915#180]) -> [PASS][129] +7 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-kbl1/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-kbl7/igt@[email protected]
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][130] ([fdo#109441]) -> [PASS][131] +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-iclb3/igt@kms_psr@psr2_cursor_blt.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_setmode@basic:
- shard-glk: [FAIL][132] ([i915#31]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-glk4/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-glk5/igt@[email protected]
#### Warnings ####
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-iclb: [SKIP][134] ([i915#2920]) -> [SKIP][135] ([i915#658]) +1 similar issue
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-iclb2/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb8/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-iclb: [SKIP][136] ([i915#658]) -> [SKIP][137] ([i915#2920]) +1 similar issue
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10796/shard-iclb8/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][138
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6355/index.html
Quoted 8 lines
-----Original Message-----
From: Hogander, Jouni <[email protected]>
Sent: Wednesday, October 27, 2021 1:56 PM
To: [email protected]
Cc: Kahola, Mika <[email protected]>; Souza, Jose <[email protected]>; Latvala, Petri <[email protected]>
Subject: [PATCH i-g-t v3] tests/kms_psr2_su: add biplanar selective update tests
Quoted 8 lines
Add biplanar formats (NV12, p010) into selective update test.
Use also offset for white rectangle as this reveals better possible issues with offset calculation/configuration.v2: Add back skipping of frontbuffer rendering tests
v3: Use hyphen instead of underscore in testnamesSigned-off-by Jouni Högander <[email protected]>
Quoted 190 lines
--- tests/i915/kms_psr2_su.c | 91 +++++++++++++++++++++++++--------------- 1 file changed, 58 insertions(+), 33 deletions(-)tests/i915/kms_psr2_su.c index renamed from tests/i915/kms_psr2_su.c +0
-0
91de9bad..d79a1e58100644tests/i915/kms_psr2_su.c +25
-6@@ -33,7 +33,8 @@IGT_TEST_DESCRIPTION ("Test PSR2 selective update" ); -#define SQUARE_SIZE 100 +#define SQUARE_SIZE 100 +#define SQUARE_OFFSET 100/* each selective update block is 4 lines tall */ #define EXPECTED_NUM_SU_BLOCKS ((SQUARE_SIZE / 4) + (SQUARE_SIZE % 4 ? 1 : 0))@@ -50,6 +51,23 @@ enum operations {LAST }; +static const uint32_t formats_page_flip[] = { +DRM_FORMAT_XRGB8888 , +DRM_FORMAT_NV12 , +DRM_FORMAT_P010 , +DRM_FORMAT_INVALID , +}; + +static const uint32_t formats_frontbuffer[] = { +DRM_FORMAT_XRGB8888 , +DRM_FORMAT_INVALID , +}; + +static const uint32_t *formats[] = { + [PAGE_FLIP ] = formats_page_flip, + [FRONTBUFFER ] = formats_frontbuffer, }; +static const char *op_str (enum operations op) {static const char *const name[] = {@@ -68,6 +86,7 @@ typedef struct {igt_output_t *output;struct igt_fb fb[2 ];enum operations op; +uint32_t format;cairo_t *cr;int change_screen_timerfd;uint32_t screen_changes;@@ -111,7 +130,7 @@ static void prepare(data_t *data)/* all green frame */ igt_create_color_fb (data->drm_fd, data->mode->hdisplay, data->mode->vdisplay, -DRM_FORMAT_XRGB8888 , + data->format,DRM_FORMAT_MOD_LINEAR ,0.0 ,1.0 ,0.0 , &data->fb[0 ]);@@ -121,14 +140,14 @@ static void prepare(data_t *data)igt_create_color_fb (data->drm_fd, data->mode->hdisplay, data->mode- >vdisplay, -DRM_FORMAT_XRGB8888 , + data->format,DRM_FORMAT_MOD_LINEAR ,0.0 ,1.0 ,0.0 , &data->fb[1 ]); cr =igt_get_cairo_ctx (data->drm_fd, &data->fb[1 ]);/* paint a white square */ -igt_paint_color_alpha (cr,0 ,0 ,SQUARE_SIZE ,SQUARE_SIZE , +igt_paint_color_alpha (cr,SQUARE_OFFSET ,SQUARE_OFFSET ,SQUARE_SIZE , +SQUARE_SIZE ,1.0 ,1.0 ,1.0 ,1.0 );igt_put_cairo_ctx (cr); }else if (data->op ==FRONTBUFFER ) {@@ -152,8 +171,8 @@ static bool update_screen_and_test(data_t *data)struct drm_mode_rect clip;igt_plane_t *primary; - clip.x1 = clip.y1 =0 ; - clip.x2 = clip.y2 =SQUARE_SIZE ; + clip.x1 = clip.y1 =SQUARE_OFFSET ; + clip.x2 = clip.y2 =SQUARE_OFFSET +SQUARE_SIZE ; primary = igt_output_get_plane_type(data->output,
DRM_PLANE_TYPE_PRIMARY);tests/i915/kms_psr2_su.c +17
-19@@ -167,16 +186,18 @@ static bool update_screen_and_test(data_t *data)case FRONTBUFFER : {drmModeClip clip; - clip.x1 = clip.y1 =0 ; - clip.x2 = clip.y2 =SQUARE_SIZE ; + clip.x1 = clip.y1 =SQUARE_OFFSET ; + clip.x2 = clip.y2 =SQUARE_OFFSET +SQUARE_SIZE ;if (data->screen_changes &1 ) {/* go back to all green frame with a square */ -igt_paint_color_alpha (data->cr,0 ,0 ,SQUARE_SIZE , +igt_paint_color_alpha (data->cr,SQUARE_OFFSET , +SQUARE_OFFSET ,SQUARE_SIZE ,SQUARE_SIZE ,1.0 ,1.0 ,1.0 ,1.0 ); }else {/* go back to all green frame */ -igt_paint_color_alpha (data->cr,0 ,0 ,SQUARE_SIZE , +igt_paint_color_alpha (data->cr,SQUARE_OFFSET , +SQUARE_OFFSET ,SQUARE_SIZE ,SQUARE_SIZE ,0 ,1.0 ,0 ,1.0 ); }@@ -261,6 +282,7 @@ igt_main data.debugfs_fd, PSR_MODE_2), "Error enabling PSR2\n"); data.op =FRONTBUFFER ; + data.format =DRM_FORMAT_XRGB8888 ;prepare (&data); r =psr_wait_entry (data.debugfs_fd,PSR_MODE_2 );cleanup (&data);@@ -281,31 +303,34 @@ igt_main }for (data.op =PAGE_FLIP ; data.op <LAST ; data.op++) { -igt_describe ("Test that selective update works when screen changes"); - igt_subtest_f("%s", op_str(data.op)) { - -if (data.op ==FRONTBUFFER && -intel_display_ver (intel_get_drm_devid (data.drm_fd)) >= 12) { -/* -* FIXME: Display 12+ platforms now have PSR2 -* selective fetch enabled by default but we -* still can't properly handle frontbuffer -* rendering, so right it does full frame -* fetches at every frontbuffer rendering. -* So it is expected that this test will fail -* in display 12+ platform fow now. -*/ - igt_skip("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n"); + const uint32_t *format = formats[data.op]; + +while (*format !=DRM_FORMAT_INVALID ) { + data.format = *format++; + igt_describe("Test that selective update works when screen changes"); + igt_subtest_f("%s-%s", op_str(data.op), igt_format_str(data.format)) { + if (data.op == FRONTBUFFER && + intel_display_ver(intel_get_drm_devid(data.drm_fd)) >= 12) { + /* + * FIXME: Display 12+ platforms nowhave PSR2
tests/i915/kms_psr2_su.c +1
-0+* selective fetch enabled by default but we
tests/i915/kms_psr2_su.c +3
-0+* still can't properly handle frontbuffer +* rendering, so right it does full frame +* fetches at every frontbuffer rendering.
tests/i915/kms_psr2_su.c +4
-0+* So it is expected that this test will fail +* in display 12+ platform for now. +*/ + igt_skip("PSR2 selective fetch is doingfull frame fetches for frontbuffer rendering\n");
tests/i915/kms_psr2_su.c +8
-9+ } +prepare (&data); +run (&data); +cleanup (&data); } - -prepare (&data); -run (&data); -cleanup (&data); } - } - igt_fixture { -close (data.debugfs_fd); -display_fini (&data); + igt_fixture { +close (data.debugfs_fd); +display_fini (&data); + } } } --2.25.1
tests/i915/kms_psr2_su.c
Quoted 16 lines · Jouni Högander
Add biplanar formats (NV12, p010) into selective update test. Use also offset for white rectangle as this reveals better possible issues with offset calculation/configuration.
v2: Add back skipping of frontbuffer rendering tests
v3: Use hyphen instead of underscore in testnamesSigned-off-by Jouni Högander <[email protected]>--- tests/i915/kms_psr2_su.c | 91 +++++++++++++++++++++++++--------------- 1 file changed, 58 insertions(+), 33 deletions(-)tests/i915/kms_psr2_su.c +0
-0
I don't think this test is the best one to add tests for biplanar formats.
As PSR2_SU_STATUS do not work on display 13 this test is skipping in display 13 and newer so we will not have test coverage for newer platforms.
kms_psr2_sf.c is a better one but I would not add one additional test for each format to each test in that file, would be better create something new. Could even do the same that this one is doing but in one page flip sending the damaged areas and in the next flip not sending the damaged area. Something like that stressing corner cases.
Quoted 168 lines
tests/i915/kms_psr2_su.c +58
-33@@ -33,7 +33,8 @@IGT_TEST_DESCRIPTION ("Test PSR2 selective update" ); -#define SQUARE_SIZE 100 +#define SQUARE_SIZE 100 +#define SQUARE_OFFSET 100/* each selective update block is 4 lines tall */ #define EXPECTED_NUM_SU_BLOCKS ((SQUARE_SIZE / 4) + (SQUARE_SIZE % 4 ? 1 : 0))@@ -50,6 +51,23 @@ enum operations {LAST }; +static const uint32_t formats_page_flip[] = { +DRM_FORMAT_XRGB8888 , +DRM_FORMAT_NV12 , +DRM_FORMAT_P010 , +DRM_FORMAT_INVALID , +}; + +static const uint32_t formats_frontbuffer[] = { +DRM_FORMAT_XRGB8888 , +DRM_FORMAT_INVALID , +}; + +static const uint32_t *formats[] = { + [PAGE_FLIP ] = formats_page_flip, + [FRONTBUFFER ] = formats_frontbuffer, +}; +static const char *op_str (enum operations op) {static const char *const name[] = {@@ -68,6 +86,7 @@ typedef struct {igt_output_t *output;struct igt_fb fb[2 ];enum operations op; +uint32_t format;cairo_t *cr;int change_screen_timerfd;uint32_t screen_changes;@@ -111,7 +130,7 @@ static void prepare(data_t *data)/* all green frame */ igt_create_color_fb (data->drm_fd, data->mode->hdisplay, data->mode->vdisplay, -DRM_FORMAT_XRGB8888 , + data->format,DRM_FORMAT_MOD_LINEAR ,0.0 ,1.0 ,0.0 , &data->fb[0 ]);@@ -121,14 +140,14 @@ static void prepare(data_t *data)igt_create_color_fb (data->drm_fd, data->mode->hdisplay, data->mode->vdisplay, -DRM_FORMAT_XRGB8888 , + data->format,DRM_FORMAT_MOD_LINEAR ,0.0 ,1.0 ,0.0 , &data->fb[1 ]); cr =igt_get_cairo_ctx (data->drm_fd, &data->fb[1 ]);/* paint a white square */ -igt_paint_color_alpha (cr,0 ,0 ,SQUARE_SIZE ,SQUARE_SIZE , +igt_paint_color_alpha (cr,SQUARE_OFFSET ,SQUARE_OFFSET ,SQUARE_SIZE ,SQUARE_SIZE ,1.0 ,1.0 ,1.0 ,1.0 );igt_put_cairo_ctx (cr); }else if (data->op ==FRONTBUFFER ) {@@ -152,8 +171,8 @@ static bool update_screen_and_test(data_t *data)struct drm_mode_rect clip;igt_plane_t *primary; - clip.x1 = clip.y1 =0 ; - clip.x2 = clip.y2 =SQUARE_SIZE ; + clip.x1 = clip.y1 =SQUARE_OFFSET ; + clip.x2 = clip.y2 =SQUARE_OFFSET +SQUARE_SIZE ; primary =igt_output_get_plane_type (data->output,DRM_PLANE_TYPE_PRIMARY );@@ -167,16 +186,18 @@ static bool update_screen_and_test(data_t *data)case FRONTBUFFER : {drmModeClip clip; - clip.x1 = clip.y1 =0 ; - clip.x2 = clip.y2 =SQUARE_SIZE ; + clip.x1 = clip.y1 =SQUARE_OFFSET ; + clip.x2 = clip.y2 =SQUARE_OFFSET +SQUARE_SIZE ;if (data->screen_changes &1 ) {/* go back to all green frame with a square */ -igt_paint_color_alpha (data->cr,0 ,0 ,SQUARE_SIZE , +igt_paint_color_alpha (data->cr,SQUARE_OFFSET , +SQUARE_OFFSET ,SQUARE_SIZE ,SQUARE_SIZE ,1.0 ,1.0 ,1.0 ,1.0 ); }else {/* go back to all green frame */ -igt_paint_color_alpha (data->cr,0 ,0 ,SQUARE_SIZE , +igt_paint_color_alpha (data->cr,SQUARE_OFFSET , +SQUARE_OFFSET ,SQUARE_SIZE ,SQUARE_SIZE ,0 ,1.0 ,0 ,1.0 ); }@@ -261,6 +282,7 @@ igt_main data.debugfs_fd, PSR_MODE_2), "Error enabling PSR2\n"); data.op =FRONTBUFFER ; + data.format =DRM_FORMAT_XRGB8888 ;prepare (&data); r =psr_wait_entry (data.debugfs_fd,PSR_MODE_2 );cleanup (&data);@@ -281,31 +303,34 @@ igt_main }for (data.op =PAGE_FLIP ; data.op <LAST ; data.op++) { -igt_describe ("Test that selective update works when screen changes" ); - igt_subtest_f("%s", op_str(data.op)) { - -if (data.op ==FRONTBUFFER && -intel_display_ver (intel_get_drm_devid (data.drm_fd)) >=12 ) { -/* -* FIXME: Display 12+ platforms now have PSR2 -* selective fetch enabled by default but we -* still can't properly handle frontbuffer -* rendering, so right it does full frame -* fetches at every frontbuffer rendering. -* So it is expected that this test will fail -* in display 12+ platform fow now. -*/ -igt_skip ("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n" ); +const uint32_t *format = formats[data.op]; + +while (*format !=DRM_FORMAT_INVALID ) { + data.format = *format++; +igt_describe ("Test that selective update works when screen changes" ); + igt_subtest_f("%s-%s", op_str(data.op), igt_format_str(data.format)) { +if (data.op ==FRONTBUFFER && +intel_display_ver (intel_get_drm_devid (data.drm_fd)) >=12 ) { +/* +* FIXME: Display 12+ platforms now have PSR2 +* selective fetch enabled by default but we +* still can't properly handle frontbuffer +* rendering, so right it does full frame +* fetches at every frontbuffer rendering. +* So it is expected that this test will fail +* in display 12+ platform for now. +*/ +igt_skip ("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n" ); + } +prepare (&data); +run (&data); +cleanup (&data); } - -prepare (&data); -run (&data); -cleanup (&data); } - } - igt_fixture { -close (data.debugfs_fd); -display_fini (&data); + igt_fixture { +close (data.debugfs_fd); +display_fini (&data); + } } }
Quoted 25 lines · Jose
tests/i915/kms_psr2_su.c
Quoted 17 lines · Jouni Högander
Add biplanar formats (NV12, p010) into selective update test. Use also offset for white rectangle as this reveals better possible issues with offset calculation/configuration.
v2: Add back skipping of frontbuffer rendering tests
v3: Use hyphen instead of underscore in testnamesSigned-off-by Jouni Högander <[email protected]>--- tests/i915/kms_psr2_su.c | 91 +++++++++++++++++++++++++----------- ---- 1 file changed, 58 insertions(+), 33 deletions(-)tests/i915/kms_psr2_su.c +0
-0I don't think this test is the best one to add tests for biplanar formats.
AsPSR2_SU_STATUSdo not work on display 13 this test is skipping in display 13 and newer so we will not have test coverage for newer platforms.
Quoted 7 lines
kms_psr2_sf.cis a better one but I would not add one additional test for each format to each test in that file, would be better create something new.
Could even do the same that this one is doing but in one page flip sending the damaged areas and in the next flip not sending the damaged area.
Something like that stressing corner cases.
This sounds to me like an additional testcase? Doesn't it still make sense to have automated testcase checking that selective update actually happens for biplanar plane? Especially as we know there are separate hook in the code for biplanar plane. Even thought PSR2_SU_STATUS is not working in all HWs?
Quoted 177 lines
(quoted diff) +0
-0@@ -33,7 +33,8 @@Quoted 176 lines
IGT_TEST_DESCRIPTION("Test PSR2 selective update");tests/i915/kms_psr2_su.c +2
-1-#define SQUARE_SIZE 100 +#define SQUARE_SIZE 100 +#define SQUARE_OFFSET 100/* each selective update block is 4 lines tall */ #define EXPECTED_NUM_SU_BLOCKS ((SQUARE_SIZE / 4) + (SQUARE_SIZE %4 ? 1 : 0))
tests/i915/kms_psr2_su.c +21
-3@@ -50,6 +51,23 @@ enum operations {LAST }; +static const uint32_t formats_page_flip[] = { +DRM_FORMAT_XRGB8888 , +DRM_FORMAT_NV12 , +DRM_FORMAT_P010 , +DRM_FORMAT_INVALID , +}; + +static const uint32_t formats_frontbuffer[] = { +DRM_FORMAT_XRGB8888 , +DRM_FORMAT_INVALID , +}; + +static const uint32_t *formats[] = { + [PAGE_FLIP ] = formats_page_flip, + [FRONTBUFFER ] = formats_frontbuffer, +}; +static const char *op_str (enum operations op) {static const char *const name[] = {@@ -68,6 +86,7 @@ typedef struct {igt_output_t *output;struct igt_fb fb[2 ];enum operations op; +uint32_t format;cairo_t *cr;int change_screen_timerfd;uint32_t screen_changes;@@ -111,7 +130,7 @@ static void prepare(data_t *data)/* all green frame */ igt_create_color_fb (data->drm_fd, data->mode->hdisplay, data->mode->vdisplay, -DRM_FORMAT_XRGB8888 , + data->format,DRM_FORMAT_MOD_LINEAR ,0.0 ,1.0 ,0.0 , &data->fb[0 ]);@@ -121,14 +140,14 @@ static void prepare(data_t *data)igt_create_color_fb (data->drm_fd, data->mode->hdisplay, data->mode->vdisplay, -DRM_FORMAT_XRGB8888 , + data->format,DRM_FORMAT_MOD_LINEAR ,0.0 ,1.0 ,0.0 , &data->fb[1 ]); cr =igt_get_cairo_ctx (data->drm_fd, &data->fb[1 ]);/* paint a white square */ -igt_paint_color_alpha (cr,0 ,0 ,SQUARE_SIZE ,SQUARE_SIZE , +igt_paint_color_alpha (cr,SQUARE_OFFSET ,SQUARE_OFFSET ,SQUARE_SIZE ,SQUARE_SIZE ,1.0 ,1.0 ,1.0 ,1.0 );igt_put_cairo_ctx (cr);} else if (
data->op== FRONTBUFFER) {tests/i915/kms_psr2_su.c +2
-2@@ -152,8 +171,8 @@ static bool update_screen_and_test(data_t *data)struct drm_mode_rect clip;igt_plane_t *primary; -clip.x1 = clip.y1 =0 ; -clip.x2 = clip.y2 =SQUARE_SIZE ; +clip.x1 = clip.y1 =SQUARE_OFFSET ; +clip.x2 = clip.y2 =SQUARE_OFFSET +SQUARE_SIZE ; primary = igt_output_get_plane_type(data->output,DRM_PLANE_TYPE_PRIMARY);tests/i915/kms_psr2_su.c +33
-27@@ -167,16 +186,18 @@ static bool update_screen_and_test(data_t *data)case FRONTBUFFER : {drmModeClip clip; -clip.x1 = clip.y1 =0 ; -clip.x2 = clip.y2 =SQUARE_SIZE ; +clip.x1 = clip.y1 =SQUARE_OFFSET ; +clip.x2 = clip.y2 =SQUARE_OFFSET +SQUARE_SIZE ;if (data->screen_changes &1 ) {/* go back to all green frame with a square */ -igt_paint_color_alpha (data->cr,0 ,0 ,SQUARE_SIZE , +igt_paint_color_alpha (data->cr,SQUARE_OFFSET , +SQUARE_OFFSET ,SQUARE_SIZE ,SQUARE_SIZE ,1.0 ,1.0 ,1.0 ,1.0 ); }else {/* go back to all green frame */ -igt_paint_color_alpha (data->cr,0 ,0 ,SQUARE_SIZE , +igt_paint_color_alpha (data->cr,SQUARE_OFFSET , +SQUARE_OFFSET ,SQUARE_SIZE ,SQUARE_SIZE ,0 ,1.0 ,0 ,1.0 ); }@@ -261,6 +282,7 @@ igt_main data.debugfs_fd, PSR_MODE_2), "Error enabling PSR2\n"); data.op =FRONTBUFFER ; +data.format =DRM_FORMAT_XRGB8888 ;prepare (&data); r =psr_wait_entry (data.debugfs_fd,PSR_MODE_2 );cleanup (&data);@@ -281,31 +303,34 @@ igt_main }for (data.op =PAGE_FLIP ; data.op <LAST ; data.op++) { -igt_describe ("Test that selective update works when screen changes"); -igt_subtest_f("%s", op_str(data.op)) { - -if (data.op ==FRONTBUFFER && -intel_display_ver (intel_get_drm_devid (data.drm_fd)) >=12 ) { -/* -* FIXME: Display 12+ platforms now have PSR2 -* selective fetch enabled by default but we -* still can't properly handle frontbuffer -* rendering, so right it does full frame -* fetches at every frontbuffer rendering. -* So it is expected that this test will fail -* in display 12+ platform fow now. -*/ -igt_skip("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n"); +const uint32_t *format = formats[data.op]; + +while (*format !=DRM_FORMAT_INVALID ) { +data.format = *format++; +igt_describe ("Test that selective update works when screen changes"); +igt_subtest_f ("%s-%s" ,op_str (data.op), igt_format_str(data.format)) { +if (data.op ==FRONTBUFFER && +intel_display_ver (intel_get_drm_devid (data.drm_fd)) >=12 ) { +/* +* FIXME: Display 12+ platforms now have PSR2 +* selective fetch enabled by default but we +* still can't properly handle frontbuffer +* rendering, so right it does full frame +* fetches at every frontbuffer rendering. +* So it is expected that this test will fail +* in display 12+ platform for now. +*/ +igt_skip("PSR2 selective fetch is doing full frame fetches for frontbuffer rendering\n"); +} +prepare(&data); +run (&data); +cleanup (&data); } - -prepare (&data); -run (&data); -cleanup (&data); } -} -igt_fixture { -close (data.debugfs_fd); -display_fini (&data); +igt_fixture { +close (data.debugfs_fd); +display_fini (&data); +} } }