f2fs: add compr_inode and compr_blocks sysfs nodes
PATCH 1/1 f2fs: add compr_inode and compr_blocks sysfs nodes
From: Daeho Jeong <[email protected]>
Added compr_inode to show compressed inode count and compr_blocks to show compressed block count in sysfs.
--- Documentation/ABI/testing/sysfs-fs-f2fs | 10 ++++++++++ fs/f2fs/sysfs.c | 17 +++++++++++++++++ 2 files changed, 27 insertions(+)
Documentation/ABI/testing/sysfs-fs-f2fs +10 -0
@@ -350,3 +350,13 @@ Date: April 2020 Contact: "Daeho Jeong" <[email protected]> Description: Give a way to change iostat_period time. 3secs by default. The new iostat trace gives stats gap given the period. + +What: /sys/fs/f2fs/<disk>/compr_inode +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed inode count + +What: /sys/fs/f2fs/<disk>/compr_blocks +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed block count
fs/f2fs/sysfs.c +17 -0
@@ -223,6 +223,19 @@ static ssize_t avg_vblocks_show(struct f2fs_attr *a,f2fs_update_sit_info (sbi);return sprintf (buf,"%llu\n" , (unsigned long long )(si->avg_vblocks)); } + +static ssize_t compr_inode_show (struct f2fs_attr *a, +struct f2fs_sb_info *sbi,char *buf) +{ +return sprintf (buf,"%u\n" ,atomic_read (&sbi->compr_inode)); +} + +static ssize_t compr_blocks_show (struct f2fs_attr *a, +struct f2fs_sb_info *sbi,char *buf) +{ +return sprintf (buf,"%llu\n" ,atomic64_read (&sbi->compr_blocks)); +} +#endif static ssize_t main_blkaddr_show(struct f2fs_attr *a,
@@ -591,6 +604,8 @@ F2FS_STAT_ATTR(STAT_INFO, f2fs_stat_info, gc_background_calls, bg_gc);F2FS_GENERAL_RO_ATTR (moved_blocks_background);F2FS_GENERAL_RO_ATTR (moved_blocks_foreground);F2FS_GENERAL_RO_ATTR (avg_vblocks); +F2FS_GENERAL_RO_ATTR (compr_inode); +F2FS_GENERAL_RO_ATTR (compr_blocks);#endif #ifdef CONFIG_FS_ENCRYPTION
@@ -675,6 +690,8 @@ static struct attribute *f2fs_attrs[] = {ATTR_LIST (moved_blocks_foreground),ATTR_LIST (moved_blocks_background),ATTR_LIST (avg_vblocks), +ATTR_LIST (compr_inode), +ATTR_LIST (compr_blocks), #endif NULL, };
Signature · 1 line
2.29.0.rc1.297.gfa9743e501-goog
Quoted 19 lines · Daeho Jeong
From: Daeho Jeong <[email protected]>
Added
compr_inodeto show compressed inode count andcompr_blocksto show compressed block count in sysfs.Signed-off-by Daeho Jeong <[email protected]>--- Documentation/ABI/testing/sysfs-fs-f2fs | 10 ++++++++++ fs/f2fs/sysfs.c | 17 +++++++++++++++++ 2 files changed, 27 insertions(+)Documentation/ABI/testing/sysfs-fs-f2fs +0
-0@@ -350,3 +350,13 @@ Date: April 2020 Contact: "Daeho Jeong" <[email protected]> Description: Give a way to change iostat_period time. 3secs by default. The new iostat trace gives stats gap given the period.
Documentation/ABI/testing/sysfs-fs-f2fs Date: April 2020 · line 362
Quoted 10 lines
Documentation/ABI/testing/sysfs-fs-f2fs +10
-0+ +What: /sys/fs/f2fs/<disk>/compr_inode +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed inode count + +What: /sys/fs/f2fs/<disk>/compr_blocks +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed block count
Is it the count in memory, or on disk?
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Both values are from memory values.
2020년 10월 21일 (수) 오후 1:36, Eric Biggers <[email protected]>님이 작성:
Quoted 35 lines · Daeho Jeong
Quoted 19 lines
From: Daeho Jeong <[email protected]>
Added
compr_inodeto show compressed inode count andcompr_blocksto show compressed block count in sysfs.Signed-off-by Daeho Jeong <[email protected]>--- Documentation/ABI/testing/sysfs-fs-f2fs | 10 ++++++++++ fs/f2fs/sysfs.c | 17 +++++++++++++++++ 2 files changed, 27 insertions(+)Documentation/ABI/testing/sysfs-fs-f2fs +0
-0@@ -350,3 +350,13 @@ Date: April 2020 Contact: "Daeho Jeong" <[email protected]> Description: Give a way to change iostat_period time. 3secs by default. The new iostat trace gives stats gap given the period.Documentation/ABI/testing/sysfs-fs-f2fs Date: April 2020 · line 362
Quoted 10 lines
Documentation/ABI/testing/sysfs-fs-f2fs +10
-0+ +What: /sys/fs/f2fs/<disk>/compr_inode +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed inode count + +What: /sys/fs/f2fs/<disk>/compr_blocks +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed block countIs it the count in memory, or on disk?
- Eric
Quoted 4 lines · Daeho Jeong
From: Daeho Jeong <[email protected]>
Added
compr_inodeto show compressed inode count andcompr_blocksto show compressed block count in sysfs.
As there are so many entries in ../f2fs/<disk>/ directory, it looks a mess there, I suggest that we can add a new directory 'stats' in ../f2fs/<disk>/, in where we can store all readonly stats related entries there later.
How do you think?
Thanks,
Quoted 68 lines
Signed-off-by Daeho Jeong <[email protected]>--- Documentation/ABI/testing/sysfs-fs-f2fs | 10 ++++++++++ fs/f2fs/sysfs.c | 17 +++++++++++++++++ 2 files changed, 27 insertions(+)Documentation/ABI/testing/sysfs-fs-f2fs +10
-0@@ -350,3 +350,13 @@ Date: April 2020 Contact: "Daeho Jeong" <[email protected]> Description: Give a way to change iostat_period time. 3secs by default. The new iostat trace gives stats gap given the period. + +What: /sys/fs/f2fs/<disk>/compr_inode +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed inode count + +What: /sys/fs/f2fs/<disk>/compr_blocks +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed block countfs/f2fs/sysfs.c +17
-0@@ -223,6 +223,19 @@ static ssize_t avg_vblocks_show(struct f2fs_attr *a,f2fs_update_sit_info (sbi);return sprintf (buf,"%llu\n" , (unsigned long long )(si->avg_vblocks)); } + +static ssize_t compr_inode_show (struct f2fs_attr *a, +struct f2fs_sb_info *sbi,char *buf) +{ +return sprintf (buf,"%u\n" ,atomic_read (&sbi->compr_inode)); +} + +static ssize_t compr_blocks_show (struct f2fs_attr *a, +struct f2fs_sb_info *sbi,char *buf) +{ +return sprintf (buf,"%llu\n" ,atomic64_read (&sbi->compr_blocks)); +} +#endif static ssize_t main_blkaddr_show(struct f2fs_attr *a,@@ -591,6 +604,8 @@ F2FS_STAT_ATTR(STAT_INFO, f2fs_stat_info, gc_background_calls, bg_gc);F2FS_GENERAL_RO_ATTR (moved_blocks_background);F2FS_GENERAL_RO_ATTR (moved_blocks_foreground);F2FS_GENERAL_RO_ATTR (avg_vblocks); +F2FS_GENERAL_RO_ATTR (compr_inode); +F2FS_GENERAL_RO_ATTR (compr_blocks);#endif #ifdef CONFIG_FS_ENCRYPTION @@ -675,6 +690,8 @@ static struct attribute *f2fs_attrs[] = {ATTR_LIST (moved_blocks_foreground),ATTR_LIST (moved_blocks_background),ATTR_LIST (avg_vblocks), +ATTR_LIST (compr_inode), +ATTR_LIST (compr_blocks), #endif NULL, };
Yep, It sounds good to me.
2020년 10월 21일 (수) 오후 3:08, Chao Yu <[email protected]>님이 작성:
Quoted 72 lines · Daeho Jeong
Quoted 4 lines
From: Daeho Jeong <[email protected]>
Added
compr_inodeto show compressed inode count andcompr_blocksto show compressed block count in sysfs.As there are so many entries in ../f2fs/<disk>/ directory, it looks a mess there, I suggest that we can add a new directory 'stats' in ../f2fs/<disk>/, in where we can store all readonly stats related entries there later.
How do you think?
Thanks,
Quoted 57 lines
Signed-off-by Daeho Jeong <[email protected]>--- Documentation/ABI/testing/sysfs-fs-f2fs | 10 ++++++++++ fs/f2fs/sysfs.c | 17 +++++++++++++++++ 2 files changed, 27 insertions(+)Documentation/ABI/testing/sysfs-fs-f2fs +10
-0@@ -350,3 +350,13 @@ Date: April 2020 Contact: "Daeho Jeong" <[email protected]> Description: Give a way to change iostat_period time. 3secs by default. The new iostat trace gives stats gap given the period. + +What: /sys/fs/f2fs/<disk>/compr_inode +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed inode count + +What: /sys/fs/f2fs/<disk>/compr_blocks +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed block countfs/f2fs/sysfs.c +15
-0@@ -223,6 +223,19 @@ static ssize_t avg_vblocks_show(struct f2fs_attr *a,f2fs_update_sit_info (sbi);return sprintf (buf,"%llu\n" , (unsigned long long )(si->avg_vblocks)); } + +static ssize_t compr_inode_show (struct f2fs_attr *a, +struct f2fs_sb_info *sbi,char *buf) +{ +return sprintf (buf,"%u\n" ,atomic_read (&sbi->compr_inode)); +} + +static ssize_t compr_blocks_show (struct f2fs_attr *a, +struct f2fs_sb_info *sbi,char *buf) +{ +return sprintf (buf,"%llu\n" ,atomic64_read (&sbi->compr_blocks)); +} +#endif static ssize_t main_blkaddr_show(struct f2fs_attr *a,@@ -591,6 +604,8 @@ F2FS_STAT_ATTR(STAT_INFO, f2fs_stat_info, gc_background_calls, bg_gc);F2FS_GENERAL_RO_ATTR (moved_blocks_background);F2FS_GENERAL_RO_ATTR (moved_blocks_foreground);F2FS_GENERAL_RO_ATTR (avg_vblocks); +F2FS_GENERAL_RO_ATTR (compr_inode); +F2FS_GENERAL_RO_ATTR (compr_blocks);#endif
Quoted 11 lines
fs/f2fs/sysfs.c static struct attribute *f2fs_attrs[] = { · line 697
Quoted 11 lines
fs/f2fs/sysfs.c +2
-0#ifdef CONFIG_FS_ENCRYPTION @@ -675,6 +690,8 @@ static struct attribute *f2fs_attrs[] = {ATTR_LIST (moved_blocks_foreground),ATTR_LIST (moved_blocks_background),ATTR_LIST (avg_vblocks), +ATTR_LIST (compr_inode), +ATTR_LIST (compr_blocks), #endif NULL, };
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Daeho,
How about updating this patch based on below patch?
f2fs: introduce a new per-sb directory in sysfs
Quoted 75 lines · Daeho Jeong
Yep, It sounds good to me.
2020년 10월 21일 (수) 오후 3:08, Chao Yu <[email protected]>님이 작성:
Quoted 72 lines · Daeho Jeong
Quoted 4 lines
From: Daeho Jeong <[email protected]>
Added
compr_inodeto show compressed inode count andcompr_blocksto show compressed block count in sysfs.As there are so many entries in ../f2fs/<disk>/ directory, it looks a mess there, I suggest that we can add a new directory 'stats' in ../f2fs/<disk>/, in where we can store all readonly stats related entries there later.
How do you think?
Thanks,
Quoted 57 lines
Signed-off-by Daeho Jeong <[email protected]>--- Documentation/ABI/testing/sysfs-fs-f2fs | 10 ++++++++++ fs/f2fs/sysfs.c | 17 +++++++++++++++++ 2 files changed, 27 insertions(+)Documentation/ABI/testing/sysfs-fs-f2fs +10
-0@@ -350,3 +350,13 @@ Date: April 2020 Contact: "Daeho Jeong" <[email protected]> Description: Give a way to change iostat_period time. 3secs by default. The new iostat trace gives stats gap given the period. + +What: /sys/fs/f2fs/<disk>/compr_inode +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed inode count + +What: /sys/fs/f2fs/<disk>/compr_blocks +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed block countfs/f2fs/sysfs.c +15
-0@@ -223,6 +223,19 @@ static ssize_t avg_vblocks_show(struct f2fs_attr *a,f2fs_update_sit_info (sbi);return sprintf (buf,"%llu\n" , (unsigned long long )(si->avg_vblocks)); } + +static ssize_t compr_inode_show (struct f2fs_attr *a, +struct f2fs_sb_info *sbi,char *buf) +{ +return sprintf (buf,"%u\n" ,atomic_read (&sbi->compr_inode)); +} + +static ssize_t compr_blocks_show (struct f2fs_attr *a, +struct f2fs_sb_info *sbi,char *buf) +{ +return sprintf (buf,"%llu\n" ,atomic64_read (&sbi->compr_blocks)); +} +#endif static ssize_t main_blkaddr_show(struct f2fs_attr *a,@@ -591,6 +604,8 @@ F2FS_STAT_ATTR(STAT_INFO, f2fs_stat_info, gc_background_calls, bg_gc);F2FS_GENERAL_RO_ATTR (moved_blocks_background);F2FS_GENERAL_RO_ATTR (moved_blocks_foreground);F2FS_GENERAL_RO_ATTR (avg_vblocks); +F2FS_GENERAL_RO_ATTR (compr_inode); +F2FS_GENERAL_RO_ATTR (compr_blocks);#endif
Quoted 13 lines
Quoted 11 lines
fs/f2fs/sysfs.c static struct attribute *f2fs_attrs[] = { · line 697
Quoted 11 lines
fs/f2fs/sysfs.c +2
-0#ifdef CONFIG_FS_ENCRYPTION @@ -675,6 +690,8 @@ static struct attribute *f2fs_attrs[] = {ATTR_LIST (moved_blocks_foreground),ATTR_LIST (moved_blocks_background),ATTR_LIST (avg_vblocks), +ATTR_LIST (compr_inode), +ATTR_LIST (compr_blocks), #endif NULL, };.
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Sure, but I don't think we need to expose compr_inode and compr_block right now.
2020년 11월 27일 (금) 오후 6:44, Chao Yu <[email protected]>님이 작성:
Quoted 96 lines
Daeho,
How about updating this patch based on below patch?
f2fs: introduce a new per-sb directory in sysfs
Quoted 88 lines · Daeho Jeong
Yep, It sounds good to me.
2020년 10월 21일 (수) 오후 3:08, Chao Yu <[email protected]>님이 작성:
Quoted 72 lines · Daeho Jeong
Quoted 4 lines
From: Daeho Jeong <[email protected]>
Added
compr_inodeto show compressed inode count andcompr_blocksto show compressed block count in sysfs.As there are so many entries in ../f2fs/<disk>/ directory, it looks a mess there, I suggest that we can add a new directory 'stats' in ../f2fs/<disk>/, in where we can store all readonly stats related entries there later.
How do you think?
Thanks,
Quoted 57 lines
Signed-off-by Daeho Jeong <[email protected]>--- Documentation/ABI/testing/sysfs-fs-f2fs | 10 ++++++++++ fs/f2fs/sysfs.c | 17 +++++++++++++++++ 2 files changed, 27 insertions(+)Documentation/ABI/testing/sysfs-fs-f2fs +10
-0@@ -350,3 +350,13 @@ Date: April 2020 Contact: "Daeho Jeong" <[email protected]> Description: Give a way to change iostat_period time. 3secs by default. The new iostat trace gives stats gap given the period. + +What: /sys/fs/f2fs/<disk>/compr_inode +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed inode count + +What: /sys/fs/f2fs/<disk>/compr_blocks +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed block countfs/f2fs/sysfs.c +15
-0@@ -223,6 +223,19 @@ static ssize_t avg_vblocks_show(struct f2fs_attr *a,f2fs_update_sit_info (sbi);return sprintf (buf,"%llu\n" , (unsigned long long )(si->avg_vblocks)); } + +static ssize_t compr_inode_show (struct f2fs_attr *a, +struct f2fs_sb_info *sbi,char *buf) +{ +return sprintf (buf,"%u\n" ,atomic_read (&sbi->compr_inode)); +} + +static ssize_t compr_blocks_show (struct f2fs_attr *a, +struct f2fs_sb_info *sbi,char *buf) +{ +return sprintf (buf,"%llu\n" ,atomic64_read (&sbi->compr_blocks)); +} +#endif static ssize_t main_blkaddr_show(struct f2fs_attr *a,@@ -591,6 +604,8 @@ F2FS_STAT_ATTR(STAT_INFO, f2fs_stat_info, gc_background_calls, bg_gc);F2FS_GENERAL_RO_ATTR (moved_blocks_background);F2FS_GENERAL_RO_ATTR (moved_blocks_foreground);F2FS_GENERAL_RO_ATTR (avg_vblocks); +F2FS_GENERAL_RO_ATTR (compr_inode); +F2FS_GENERAL_RO_ATTR (compr_blocks);#endif Quoted 11 lines
fs/f2fs/sysfs.c static struct attribute *f2fs_attrs[] = { · line 697
Quoted 11 lines
fs/f2fs/sysfs.c +2
-0#ifdef CONFIG_FS_ENCRYPTION @@ -675,6 +690,8 @@ static struct attribute *f2fs_attrs[] = {ATTR_LIST (moved_blocks_foreground),ATTR_LIST (moved_blocks_background),ATTR_LIST (avg_vblocks), +ATTR_LIST (compr_inode), +ATTR_LIST (compr_blocks), #endif NULL, };.
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Alright, let's export readonly stats in new directory once you have such requirement. :)
Thanks,
Quoted 99 lines · Daeho Jeong
Sure, but I don't think we need to expose
compr_inodeandcompr_blockright now.2020년 11월 27일 (금) 오후 6:44, Chao Yu <[email protected]>님이 작성:
Quoted 96 lines
Daeho,
How about updating this patch based on below patch?
f2fs: introduce a new per-sb directory in sysfs
Quoted 88 lines · Daeho Jeong
Yep, It sounds good to me.
2020년 10월 21일 (수) 오후 3:08, Chao Yu <[email protected]>님이 작성:
Quoted 72 lines · Daeho Jeong
Quoted 4 lines
From: Daeho Jeong <[email protected]>
Added
compr_inodeto show compressed inode count andcompr_blocksto show compressed block count in sysfs.As there are so many entries in ../f2fs/<disk>/ directory, it looks a mess there, I suggest that we can add a new directory 'stats' in ../f2fs/<disk>/, in where we can store all readonly stats related entries there later.
How do you think?
Thanks,
Quoted 57 lines
Signed-off-by Daeho Jeong <[email protected]>--- Documentation/ABI/testing/sysfs-fs-f2fs | 10 ++++++++++ fs/f2fs/sysfs.c | 17 +++++++++++++++++ 2 files changed, 27 insertions(+)Documentation/ABI/testing/sysfs-fs-f2fs +10
-0@@ -350,3 +350,13 @@ Date: April 2020 Contact: "Daeho Jeong" <[email protected]> Description: Give a way to change iostat_period time. 3secs by default. The new iostat trace gives stats gap given the period. + +What: /sys/fs/f2fs/<disk>/compr_inode +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed inode count + +What: /sys/fs/f2fs/<disk>/compr_blocks +Date: October 2020 +Contact: "Daeho Jeong" <[email protected]> +Description: Show compressed block countfs/f2fs/sysfs.c +15
-0@@ -223,6 +223,19 @@ static ssize_t avg_vblocks_show(struct f2fs_attr *a,f2fs_update_sit_info (sbi);return sprintf (buf,"%llu\n" , (unsigned long long )(si->avg_vblocks)); } + +static ssize_t compr_inode_show (struct f2fs_attr *a, +struct f2fs_sb_info *sbi,char *buf) +{ +return sprintf (buf,"%u\n" ,atomic_read (&sbi->compr_inode)); +} + +static ssize_t compr_blocks_show (struct f2fs_attr *a, +struct f2fs_sb_info *sbi,char *buf) +{ +return sprintf (buf,"%llu\n" ,atomic64_read (&sbi->compr_blocks)); +} +#endif static ssize_t main_blkaddr_show(struct f2fs_attr *a,@@ -591,6 +604,8 @@ F2FS_STAT_ATTR(STAT_INFO, f2fs_stat_info, gc_background_calls, bg_gc);F2FS_GENERAL_RO_ATTR (moved_blocks_background);F2FS_GENERAL_RO_ATTR (moved_blocks_foreground);F2FS_GENERAL_RO_ATTR (avg_vblocks); +F2FS_GENERAL_RO_ATTR (compr_inode); +F2FS_GENERAL_RO_ATTR (compr_blocks);#endif Quoted 11 lines
fs/f2fs/sysfs.c static struct attribute *f2fs_attrs[] = { · line 697
Quoted 11 lines
fs/f2fs/sysfs.c +2
-0#ifdef CONFIG_FS_ENCRYPTION @@ -675,6 +690,8 @@ static struct attribute *f2fs_attrs[] = {ATTR_LIST (moved_blocks_foreground),ATTR_LIST (moved_blocks_background),ATTR_LIST (avg_vblocks), +ATTR_LIST (compr_inode), +ATTR_LIST (compr_blocks), #endif NULL, };.
Quoted 2 lines
.
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel