Skip to contentSkip to conversation

dt-bindings: spi: nuvoton,ma35d1-qspi: Disallow GPIO chip selects

PATCH In review Chi-Wen Weng 3 participants 6 messages Aug 3

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: spi: nuvoton,ma35d1-qspi: Disallow GPIO chip selects

From: Chi-Wen Weng <[email protected]>

The generic SPI controller binding allows GPIO-based chip selects, but the MA35D1 QSPI driver currently supports only the controller's native chip selects.

Disallow the cs-gpios property so that the binding matches the functionality provided by the driver.

---
 Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml +2 -0
index 377ccf4fb224..40965ec5163b 100644
@@ -33,6 +33,8 @@ properties:
     maximum: 2
     default: 2
 
+  cs-gpios: false
+
 required:
   - compatible
   - reg
Signature · 1 line
2.25.1
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The commit disallows the `cs-gpios` property in the DT binding based solely on a current Linux…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit disallows the cs-gpios property in the DT binding based solely on a current Linux driver limitation, violating the core Device Tree principle that bindings describe hardware, not software capabilities. --

--- Patch [1]: [PATCH] dt-bindings: spi: nuvoton,ma35d1-qspi: Disallow GPIO chip selects --- commit 3aecb6991adf3696410ad69c99107c7d732fd078
Author: Chi-Wen Weng <[email protected]>

dt-bindings: spi: nuvoton,ma35d1-qspi: Disallow GPIO chip selects

This commit updates the nuvoton,ma35d1-qspi binding to explicitly disallow the cs-gpios property. The change is made because the current driver only supports native chip selects, preventing the use of GPIO-based chip selects.

Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml properties: · line 37

Quoted 9 lines
Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml +2 -0
@@ -33,6 +33,8 @@ properties:
     maximum: 2
     default: 2
 
+  cs-gpios: false
+

[Severity: Medium]
Does this restriction violate the device tree principle that bindings should describe hardware rather than software capabilities?

By explicitly disallowing cs-gpios in the properties block based on a current Linux driver limitation, board designers who route a standard GPIO to a SPI peripheral's chip select pin will be incorrectly prevented from describing their actual physical board wiring. When running make dtbs_check on a board device tree that uses cs-gpios for this controller, the schema will reject it.

Should the hardware schema allow standard hardware properties like cs-gpios even if the current software driver lacks support for them?

Quoted 3 lines
Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml +0 -0
 required:
   - compatible
   - reg
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#2 lore raw

[email protected] 於 2026/8/3 上午 10:48 寫道:

Quoted 27 lines

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit disallows the cs-gpios property in the DT binding based solely on a current Linux driver limitation, violating the core Device Tree principle that bindings describe hardware, not software capabilities. --

--- Patch [1]: [PATCH] dt-bindings: spi: nuvoton,ma35d1-qspi: Disallow GPIO chip selects --- commit 3aecb6991adf3696410ad69c99107c7d732fd078
Author: Chi-Wen Weng <[email protected]>

dt-bindings: spi: nuvoton,ma35d1-qspi: Disallow GPIO chip selects

This commit updates the nuvoton,ma35d1-qspi binding to explicitly disallow the cs-gpios property. The change is made because the current driver only supports native chip selects, preventing the use of GPIO-based chip selects.

Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml properties: · line 37

Quoted 9 lines
Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml +2 -0
@@ -33,6 +33,8 @@ properties:
      maximum: 2
      default: 2
 
+  cs-gpios: false
+

[Severity: Medium]
Does this restriction violate the device tree principle that bindings should describe hardware rather than software capabilities?

Quoted 12 lines

By explicitly disallowing cs-gpios in the properties block based on a current Linux driver limitation, board designers who route a standard GPIO to a SPI peripheral's chip select pin will be incorrectly prevented from describing their actual physical board wiring. When running make dtbs_check on a board device tree that uses cs-gpios for this controller, the schema will reject it.

Should the hardware schema allow standard hardware properties like cs-gpios even if the current software driver lacks support for them?

Quoted 3 lines
Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml +0 -0
  required:
    - compatible
    - reg

Hi,

Thanks for pointing this out.

I agree that the binding should describe valid hardware and board wiring rather than the current driver limitation.

I will send a v2 that keeps cs-gpios supported by the binding and instead enables GPIO descriptor-based chip-select handling in the MA35D1 QSPI driver. I will also keep active-high chip selects restricted to GPIO-based chip selects, since the controller's native chip selects currently support active-low operation only.

Best regards,
Chi-Wen

#3 lore raw
In reply to [email protected]

[email protected] 於 2026/8/3 上午 10:48 寫道:

Quoted 27 lines

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit disallows the cs-gpios property in the DT binding based solely on a current Linux driver limitation, violating the core Device Tree principle that bindings describe hardware, not software capabilities. --

--- Patch [1]: [PATCH] dt-bindings: spi: nuvoton,ma35d1-qspi: Disallow GPIO chip selects --- commit 3aecb6991adf3696410ad69c99107c7d732fd078
Author: Chi-Wen Weng <[email protected]>

dt-bindings: spi: nuvoton,ma35d1-qspi: Disallow GPIO chip selects

This commit updates the nuvoton,ma35d1-qspi binding to explicitly disallow the cs-gpios property. The change is made because the current driver only supports native chip selects, preventing the use of GPIO-based chip selects.

Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml properties: · line 37

Quoted 9 lines
Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml +2 -0
@@ -33,6 +33,8 @@ properties:
      maximum: 2
      default: 2
 
+  cs-gpios: false
+

[Severity: Medium]
Does this restriction violate the device tree principle that bindings should describe hardware rather than software capabilities?

Quoted 12 lines

By explicitly disallowing cs-gpios in the properties block based on a current Linux driver limitation, board designers who route a standard GPIO to a SPI peripheral's chip select pin will be incorrectly prevented from describing their actual physical board wiring. When running make dtbs_check on a board device tree that uses cs-gpios for this controller, the schema will reject it.

Should the hardware schema allow standard hardware properties like cs-gpios even if the current software driver lacks support for them?

Quoted 3 lines
Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml +0 -0
  required:
    - compatible
    - reg

Hi,

Thanks for pointing this out.

I agree that the binding should describe valid hardware and board wiring rather than the current driver limitation.

I will send a v2 that keeps cs-gpios supported by the binding and instead enables GPIO descriptor-based chip-select handling in the MA35D1 QSPI driver. I will also keep active-high chip selects restricted to GPIO-based chip selects, since the controller's native chip selects currently support active-low operation only.

Best regards,
Chi-Wen

maintainer
#4 lore raw
In reply to Chi-Wen Weng
Quoted 5 lines · Chi-Wen Weng

From: Chi-Wen Weng <[email protected]>

The generic SPI controller binding allows GPIO-based chip selects, but the MA35D1 QSPI driver currently supports only the controller's native chip selects.

Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.

maintainer
#5 lore raw
In reply to Chi-Wen Weng
Quoted 1 line · Chi-Wen Weng

dt-bindings: spi: nuvoton,ma35d1-qspi: Disallow GPIO chip selects

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.3

Thanks!

[1/1] dt-bindings: spi: nuvoton,ma35d1-qspi: Disallow GPIO chip selects

      https://git.kernel.org/broonie/misc/c/98e69afa6d57

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark