Skip to contentSkip to conversation

gpu:ipu-v3:pre: replace of_node_put() with __free

PATCH In review R Sundar 2 participants 3 messages Apr 27, 2024 – Jun 24, 2024

Subsystems (2)
lore
Share & tools
lore

R Sundar

author
#0 lore raw

PATCH 1/1 gpu:ipu-v3:pre: replace of_node_put() with __free

use the new cleanup magic to replace of_node_put() with __free(device_node) marking to auto release when they get out of scope.

---
 drivers/gpu/ipu-v3/ipu-pre.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/gpu/ipu-v3/ipu-pre.c +2 -5
index aef984a43190..95830cf8fa3e 100644
@@ -113,8 +113,8 @@ int ipu_pre_get_available_count(void)
 struct ipu_pre *
 ipu_pre_lookup_by_phandle(struct device *dev, const char *name, int index)
 {
-	struct device_node *pre_node = of_parse_phandle(dev->of_node,
-							name, index);
+	struct device_node *pre_node __free(device_node) =
+		of_parse_phandle(dev->of_node, name, index);
 	struct ipu_pre *pre;
 
 	mutex_lock(&ipu_pre_list_mutex);
@@ -123,14 +123,11 @@ ipu_pre_lookup_by_phandle(struct device *dev, const char *name, int index)
 			mutex_unlock(&ipu_pre_list_mutex);
 			device_link_add(dev, pre->dev,
 					DL_FLAG_AUTOREMOVE_CONSUMER);
-			of_node_put(pre_node);
 			return pre;
 		}
 	}
 	mutex_unlock(&ipu_pre_list_mutex);
 
-	of_node_put(pre_node);
-
 	return NULL;
 }
 
Signature · 1 line
2.34.1
author
#1 lore raw
Quoted 29 lines · R Sundar

use the new cleanup magic to replace of_node_put() with __free(device_node) marking to auto release when they get out of scope.

---
  drivers/gpu/ipu-v3/ipu-pre.c | 7 ++-----
  1 file changed, 2 insertions(+), 5 deletions(-)
drivers/gpu/ipu-v3/ipu-pre.c +2 -3
index aef984a43190..95830cf8fa3e 100644
@@ -113,8 +113,8 @@ int ipu_pre_get_available_count(void)
  struct ipu_pre *
  ipu_pre_lookup_by_phandle(struct device *dev, const char *name, int index)
  {
-	struct device_node *pre_node = of_parse_phandle(dev->of_node,
-							name, index);
+	struct device_node *pre_node __free(device_node) =
+		of_parse_phandle(dev->of_node, name, index);
  	struct ipu_pre *pre;
 
  	mutex_lock(&ipu_pre_list_mutex);
@@ -123,14 +123,11 @@ ipu_pre_lookup_by_phandle(struct device *dev, const char *name, int index)
  			mutex_unlock(&ipu_pre_list_mutex);
  			device_link_add(dev, pre->dev,
  					DL_FLAG_AUTOREMOVE_CONSUMER);
-			of_node_put(pre_node);

drivers/gpu/ipu-v3/ipu-pre.c ipu_pre_lookup_by_phandle(struct device *dev, const char *name, int index) · line 133

Quoted 10 lines
drivers/gpu/ipu-v3/ipu-pre.c +0 -2
  			return pre;
  		}
  	}
  	mutex_unlock(&ipu_pre_list_mutex);
 
-	of_node_put(pre_node);
-
  	return NULL;
  }
 

Hi,

Any feedback on this patch.

Thanks,
Sundar