drm/amd/display: fix crash/reboot while accessing sysfs files
Subsystems (3)
PATCH 1/1 drm/amd/display: fix crash/reboot while accessing sysfs files
read/writes to aux_dpcd_* sysfs entries leads to system reboot or hang.
Hence fix the handling of input data and reporting of errors appropriately to the user space.
Signed-off-by Shirish S <[email protected]>
--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +5 -5
@@ -908,7 +908,7 @@ static ssize_t dp_dpcd_address_write(struct file *f, const char __user *buf,struct amdgpu_dm_connector *connector =file_inode (f)->i_private;if (size <sizeof (connector->debugfs_dpcd_address)) -return 0 ; +return -EINVAL ; r =copy_from_user (&connector->debugfs_dpcd_address, buf,sizeof (connector->debugfs_dpcd_address));
@@ -923,7 +923,7 @@ static ssize_t dp_dpcd_size_write(struct file *f, const char __user *buf,struct amdgpu_dm_connector *connector =file_inode (f)->i_private;if (size <sizeof (connector->debugfs_dpcd_size)) -return 0 ; +return -EINVAL ; r =copy_from_user (&connector->debugfs_dpcd_size, buf,sizeof (connector->debugfs_dpcd_size));
@@ -943,8 +943,8 @@ static ssize_t dp_dpcd_data_write(struct file *f, const char __user *buf,struct dc_link *link = connector->dc_link;uint32_t write_size = connector->debugfs_dpcd_size; -if (size < write_size) -return 0 ; +if (!write_size || size < write_size) +return -EINVAL ; data =kzalloc (write_size,GFP_KERNEL );if (!data)
@@ -967,7 +967,7 @@ static ssize_t dp_dpcd_data_read(struct file *f, char __user *buf,struct dc_link *link = connector->dc_link;uint32_t read_size = connector->debugfs_dpcd_size; -if (size < read_size) +if (!read_size || size < read_size)return 0 ; data =kzalloc (read_size,GFP_KERNEL );
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 6 lines · Shirish S
read/writes to aux_dpcd_* sysfs entries leads to system reboot or hang.
Hence fix the handling of input data and reporting of errors appropriately to the user space.Signed-off-by Shirish S <[email protected]>
Reviewed-by Harry Wentland <[email protected]>
Harry
Quoted 39 lines
--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +4
-4@@ -908,7 +908,7 @@ static ssize_t dp_dpcd_address_write(struct file *f, const char __user *buf,struct amdgpu_dm_connector *connector =file_inode (f)->i_private;if (size <sizeof (connector->debugfs_dpcd_address)) -return 0 ; +return -EINVAL ; r =copy_from_user (&connector->debugfs_dpcd_address, buf,sizeof (connector->debugfs_dpcd_address));@@ -923,7 +923,7 @@ static ssize_t dp_dpcd_size_write(struct file *f, const char __user *buf,struct amdgpu_dm_connector *connector =file_inode (f)->i_private;if (size <sizeof (connector->debugfs_dpcd_size)) -return 0 ; +return -EINVAL ; r =copy_from_user (&connector->debugfs_dpcd_size, buf,sizeof (connector->debugfs_dpcd_size));@@ -943,8 +943,8 @@ static ssize_t dp_dpcd_data_write(struct file *f, const char __user *buf,struct dc_link *link = connector->dc_link;uint32_t write_size = connector->debugfs_dpcd_size; -if (size < write_size) -return 0 ; +if (!write_size || size < write_size) +return -EINVAL ; data =kzalloc (write_size,GFP_KERNEL );if (!data)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c static ssize_t dp_dpcd_data_read(struct file *f, char __user *buf, · line 973
Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +1
-1@@ -967,7 +967,7 @@ static ssize_t dp_dpcd_data_read(struct file *f, char __user *buf,struct dc_link *link = connector->dc_link;uint32_t read_size = connector->debugfs_dpcd_size; -if (size < read_size) +if (!read_size || size < read_size)return 0 ; data =kzalloc (read_size,GFP_KERNEL );
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx