x86/EPT: drop redundant ept_p2m_type_to_flags() parameters
PATCH v2 1/1 x86/EPT: drop redundant ept_p2m_type_to_flags() parameters
All callers set the respective fields in the entry being updated before the call.
Take the opportunity and also constify the first parameter as well as make a few style adjustments.
---
v2: Drop redundant function parameters instead.
xen/arch/x86/mm/p2m-ept.c +8 -9
@@ -61,8 +61,8 @@ static int atomic_write_ept_entry(structreturn 0 ; } -static void ept_p2m_type_to_flags (struct p2m_domain *p2m,ept_entry_t *entry, -p2m_type_t type,p2m_access_t access) +static void ept_p2m_type_to_flags (const struct p2m_domain *p2m, +ept_entry_t *entry) {/* * First apply type permissions.
@@ -75,7 +75,7 @@ static void ept_p2m_type_to_flags(struct* D bit is set for all writable types in EPT leaf entry, except for * log-dirty type with PML. */ -switch (type) +switch ( entry->sa_p2mt ) {case p2m_invalid:case p2m_mmio_dm:
@@ -143,9 +143,8 @@ static void ept_p2m_type_to_flags(structbreak ; } -/* Then restrict with access permissions */ -switch (access) +switch ( entry->access ) {case p2m_access_n:case p2m_access_n2rwx:
@@ -269,7 +268,7 @@ static bool_t ept_split_super_page(struc epte->snp =is_iommu_enabled (p2m->domain) && iommu_snoop; epte->suppress_ve =1 ; -ept_p2m_type_to_flags (p2m, epte, epte->sa_p2mt, epte->access); +ept_p2m_type_to_flags (p2m, epte);if ( (level -1 ) == target )continue ;
@@ -521,7 +520,7 @@ static int resolve_misconfig(struct p2m_if ( nt != e.sa_p2mt ) { e.sa_p2mt = nt; -ept_p2m_type_to_flags (p2m, &e, e.sa_p2mt, e.access); +ept_p2m_type_to_flags (p2m, &e); } e.recalc =0 ; wrc =atomic_write_ept_entry (p2m, &epte[i], e, level);
@@ -574,7 +573,7 @@ static int resolve_misconfig(struct p2m_ e.ipat = ipat; e.recalc =0 ;if ( recalc &&p2m_is_changeable (e.sa_p2mt) ) -ept_p2m_type_to_flags (p2m, &e, e.sa_p2mt, e.access); +ept_p2m_type_to_flags (p2m, &e); wrc =atomic_write_ept_entry (p2m, &epte[i], e, level);ASSERT (wrc ==0 ); }
@@ -789,7 +788,7 @@ ept_set_entry(struct p2m_domain *p2m, gf iommu_flags ) need_modify_vtd_table =0 ; -ept_p2m_type_to_flags (p2m, &new_entry, p2mt, p2ma); +ept_p2m_type_to_flags (p2m, &new_entry); }if ( sve !=-1 )
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 10 lines
From: Jan Beulich <[email protected]>
Sent: Wednesday, January 22, 2020 10:41 PMAll callers set the respective fields in the entry being updated before the call.
Take the opportunity and also constify the first parameter as well as make a few style adjustments.
Signed-off-by Jan Beulich <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel