fbdev: make offb driver tristate
PATCH 1/1 fbdev: make offb driver tristate
Make the offb (Open Firmware frame buffer) driver tristate, i.e., so that it can be built as a loadable module.
However, it still depends on the setting of DRM_OFDRM so that both of these drivers cannot be builtin at the same time nor can one be builtin and the other one a loadable module.
Build-tested successfully with all combination of DRM_OFDRM and FB_OF.
This fixes a build issue that Michal reported when FB_OF=y and DRM_OFDRM=m:
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x58): undefined reference to `cfb_fillrect'
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x60): undefined reference to `cfb_copyarea'
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x68): undefined reference to `cfb_imageblit'
--- drivers/video/fbdev/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/fbdev/Kconfig +2 -2
@@ -456,8 +456,8 @@ config FB_ATARI chipset found in Ataris. config FB_OF - bool "Open Firmware frame buffer device support" - depends on (FB = y) && PPC && (!PPC_PSERIES || PCI) + tristate "Open Firmware frame buffer device support" + depends on FB && PPC && (!PPC_PSERIES || PCI) depends on !DRM_OFDRM select APERTURE_HELPERS select FB_CFB_FILLRECT
Am 26.11.22 um 01:04 schrieb Randy Dunlap:
Quoted 16 lines
Make the offb (Open Firmware frame buffer) driver tristate, i.e., so that it can be built as a loadable module.
However, it still depends on the setting of
DRM_OFDRMso that both of these drivers cannot be builtin at the same time nor can one be builtin and the other one a loadable module.Build-tested successfully with all combination of
DRM_OFDRMandFB_OF.This fixes a build issue that Michal reported when FB_OF=y and DRM_OFDRM=m:
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x58): undefined reference to `cfb_fillrect'
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x60): undefined reference to `cfb_copyarea'
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x68): undefined reference to `cfb_imageblit'
Quoted 10 lines
Signed-off-by Randy Dunlap <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Cc Masahiro Yamada <[email protected]>Cc Thomas Zimmermann <[email protected]>Cc Michal Suchánek <[email protected]>Cc Daniel Vetter <[email protected]>Cc Helge Deller <[email protected]>
Quoted 19 lines
--- drivers/video/fbdev/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
drivers/video/fbdev/Kconfig +2
-2@@ -456,8 +456,8 @@ config FB_ATARI chipset found in Ataris. config FB_OF - bool "Open Firmware frame buffer device support" - depends on (FB = y) && PPC && (!PPC_PSERIES || PCI) + tristate "Open Firmware frame buffer device support" + depends on FB && PPC && (!PPC_PSERIES || PCI) depends on !DRM_OFDRM select APERTURE_HELPERS select FB_CFB_FILLRECT
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
Quoted 28 lines · Thomas Zimmermann
Am 26.11.22 um 01:04 schrieb Randy Dunlap:
Quoted 16 lines
Make the offb (Open Firmware frame buffer) driver tristate, i.e., so that it can be built as a loadable module.
However, it still depends on the setting of
DRM_OFDRMso that both of these drivers cannot be builtin at the same time nor can one be builtin and the other one a loadable module.Build-tested successfully with all combination of
DRM_OFDRMandFB_OF.This fixes a build issue that Michal reported when FB_OF=y and DRM_OFDRM=m:
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x58): undefined reference to `cfb_fillrect'
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x60): undefined reference to `cfb_copyarea'
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x68): undefined reference to `cfb_imageblit'Quoted 10 lines
Signed-off-by Randy Dunlap <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Cc Masahiro Yamada <[email protected]>Cc Thomas Zimmermann <[email protected]>Cc Michal Suchánek <[email protected]>Cc Daniel Vetter <[email protected]>Cc Helge Deller <[email protected]>
Quoted 1 line
applied.
Thanks!
Helge
Quoted 19 lines
Quoted 18 lines
---
drivers/video/fbdev/Kconfig| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
drivers/video/fbdev/Kconfig +0
-0@@ -456,8 +456,8 @@ config FB_ATARIchipset found in Ataris.
configFB_OF
- bool "Open Firmware frame buffer device support" - depends on (FB = y) && PPC && (!PPC_PSERIES || PCI) + tristate "Open Firmware frame buffer device support" + depends on FB && PPC && (!PPC_PSERIES || PCI) depends on !DRM_OFDRM
selectAPERTURE_HELPERS
selectFB_CFB_FILLRECT
Quoted 29 lines · Helge Deller
Quoted 28 lines · Thomas Zimmermann
Am 26.11.22 um 01:04 schrieb Randy Dunlap:
Quoted 26 lines
Make the offb (Open Firmware frame buffer) driver tristate, i.e., so that it can be built as a loadable module.
However, it still depends on the setting of
DRM_OFDRMso that both of these drivers cannot be builtin at the same time nor can one be builtin and the other one a loadable module.Build-tested successfully with all combination of
DRM_OFDRMandFB_OF.This fixes a build issue that Michal reported when FB_OF=y and DRM_OFDRM=m:
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x58): undefined reference to `cfb_fillrect'
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x60): undefined reference to `cfb_copyarea'
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x68): undefined reference to `cfb_imageblit'Signed-off-by Randy Dunlap <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Cc Masahiro Yamada <[email protected]>Cc Thomas Zimmermann <[email protected]>Cc Michal Suchánek <[email protected]>Cc Daniel Vetter <[email protected]>Cc Helge Deller <[email protected]>
Quoted 3 lines
Quoted 1 line
applied.
Is this going to make it to Linus soon? We are now seeing this error in our CI, which has the configuration describe in this commit.
Cheers,
Nathan
Quoted 20 lines
Quoted 18 lines
Quoted 17 lines
---
drivers/video/fbdev/Kconfig| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
drivers/video/fbdev/Kconfig +0
-0@@ -456,8 +456,8 @@ config FB_ATARIchipset found in Ataris.
configFB_OF
- bool "Open Firmware frame buffer device support" - depends on (FB = y) && PPC && (!PPC_PSERIES || PCI) + tristate "Open Firmware frame buffer device support" + depends on FB && PPC && (!PPC_PSERIES || PCI) depends on !DRM_OFDRM
selectAPERTURE_HELPERS
selectFB_CFB_FILLRECT
Helge Deller
maintainerQuoted 32 lines · Nathan Chancellor
Quoted 31 lines · Helge Deller
Quoted 29 lines · Thomas Zimmermann
Am 26.11.22 um 01:04 schrieb Randy Dunlap:
Quoted 16 lines
Make the offb (Open Firmware frame buffer) driver tristate, i.e., so that it can be built as a loadable module.
However, it still depends on the setting of
DRM_OFDRMso that both of these drivers cannot be builtin at the same time nor can one be builtin and the other one a loadable module.Build-tested successfully with all combination of
DRM_OFDRMandFB_OF.This fixes a build issue that Michal reported when FB_OF=y and DRM_OFDRM=m:
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x58): undefined reference to `cfb_fillrect'
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x60): undefined reference to `cfb_copyarea'
powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x68): undefined reference to `cfb_imageblit'Quoted 10 lines
Signed-off-by Randy Dunlap <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Cc Masahiro Yamada <[email protected]>Cc Thomas Zimmermann <[email protected]>Cc Michal Suchánek <[email protected]>Cc Daniel Vetter <[email protected]>Cc Helge Deller <[email protected]>
Quoted 8 lines
Quoted 1 line
applied.
Is this going to make it to Linus soon? We are now seeing this error in our CI, which has the configuration describe in this commit.
It didn't applied cleanly earlier.
I've now added it to the fbdev for-next branch, and if no problems show up in the next few days I'll push it before next weekend.
https://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git/log/?h=for-next
Helge
Quoted 23 lines
Cheers,
NathanQuoted 20 lines
Quoted 18 lines
Quoted 17 lines
--- drivers/video/fbdev/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
drivers/video/fbdev/Kconfig +2
-2@@ -456,8 +456,8 @@ config FB_ATARI chipset found in Ataris. config FB_OF - bool "Open Firmware frame buffer device support" - depends on (FB = y) && PPC && (!PPC_PSERIES || PCI) + tristate "Open Firmware frame buffer device support" + depends on FB && PPC && (!PPC_PSERIES || PCI) depends on !DRM_OFDRM select APERTURE_HELPERS select FB_CFB_FILLRECT