Skip to contentSkip to conversation

ARM: imx_v6_v7_defconfig: enable driver of the LTC3676 PMIC

PATCH In review Pascal Zimmermann 3 participants 7 messages Aug 5, 2021 – Aug 31, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: imx_v6_v7_defconfig: enable driver of the LTC3676 PMIC

The LTC3676 is a PMIC which is used on some i.MX6 based boards (like the DHCOM i.MX6 Quad SoM), it was first used on the GW Ventana board, enable LTC3676 driver in imx_v6_v7_defconfig.

Fixes e3946fe805053 ("ARM: dts: add Gateworks Ventana support")
Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Pengutronix Kernel Team <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP Linux Team <[email protected]>
Cc Marek Vasut <[email protected]>

To: [email protected]

---
 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/imx_v6_v7_defconfig +1 -0
index 079fcd8d1d11..f94e3d11c3e9 100644
@@ -252,6 +252,7 @@ CONFIG_REGULATOR_DA9052=y
 CONFIG_REGULATOR_DA9062=y
 CONFIG_REGULATOR_DA9063=y
 CONFIG_REGULATOR_GPIO=y
+CONFIG_REGULATOR_LTC3676=y
 CONFIG_REGULATOR_MC13783=y
 CONFIG_REGULATOR_MC13892=y
 CONFIG_REGULATOR_PFUZE100=y
Signature · 7 lines
2.11.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 23 lines · Pascal Zimmermann

The LTC3676 is a PMIC which is used on some i.MX6 based boards (like the DHCOM i.MX6 Quad SoM), it was first used on the GW Ventana board, enable LTC3676 driver in imx_v6_v7_defconfig.

Fixes e3946fe805053 ("ARM: dts: add Gateworks Ventana support")
Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Pengutronix Kernel Team <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP Linux Team <[email protected]>
Cc Marek Vasut <[email protected]>

To: [email protected]

---
  arch/arm/configs/imx_v6_v7_defconfig | 1 +
  1 file changed, 1 insertion(+)
arch/arm/configs/imx_v6_v7_defconfig +0 -0
index 079fcd8d1d11..f94e3d11c3e9 100644

arch/arm/configs/imx_v6_v7_defconfig CONFIG_REGULATOR_DA9052=y · line 258

Quoted 7 lines
arch/arm/configs/imx_v6_v7_defconfig +1 -0
@@ -252,6 +252,7 @@ CONFIG_REGULATOR_DA9052=y
  CONFIG_REGULATOR_DA9062=y
  CONFIG_REGULATOR_DA9063=y
  CONFIG_REGULATOR_GPIO=y
+CONFIG_REGULATOR_LTC3676=y
  CONFIG_REGULATOR_MC13783=y
  CONFIG_REGULATOR_MC13892=y
  CONFIG_REGULATOR_PFUZE100=y

Neither board can work well without a PMIC driver.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 6 lines · Marek Vasut
Quoted 5 lines · Pascal Zimmermann

The LTC3676 is a PMIC which is used on some i.MX6 based boards (like the DHCOM i.MX6 Quad SoM), it was first used on the GW Ventana board, enable LTC3676 driver in imx_v6_v7_defconfig.

Fixes e3946fe805053 ("ARM: dts: add Gateworks Ventana support")

I don't think the Fixes tag is appropriate here. Dropped it and applied patch.

Shawn

Quoted 29 lines
Quoted 18 lines
Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Pengutronix Kernel Team <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP Linux Team <[email protected]>
Cc Marek Vasut <[email protected]>

To: [email protected]

---
  arch/arm/configs/imx_v6_v7_defconfig | 1 +
  1 file changed, 1 insertion(+)
arch/arm/configs/imx_v6_v7_defconfig +0 -0
index 079fcd8d1d11..f94e3d11c3e9 100644

arch/arm/configs/imx_v6_v7_defconfig CONFIG_REGULATOR_DA9052=y · line 258

Quoted 7 lines
arch/arm/configs/imx_v6_v7_defconfig +1 -0
@@ -252,6 +252,7 @@ CONFIG_REGULATOR_DA9052=y
  CONFIG_REGULATOR_DA9062=y
  CONFIG_REGULATOR_DA9063=y
  CONFIG_REGULATOR_GPIO=y
+CONFIG_REGULATOR_LTC3676=y
  CONFIG_REGULATOR_MC13783=y
  CONFIG_REGULATOR_MC13892=y
  CONFIG_REGULATOR_PFUZE100=y
Quoted 1 line

Neither board can work well without a PMIC driver.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw
Quoted 10 lines · Shawn Guo
Quoted 6 lines · Marek Vasut
Quoted 5 lines · Pascal Zimmermann

The LTC3676 is a PMIC which is used on some i.MX6 based boards (like the DHCOM i.MX6 Quad SoM), it was first used on the GW Ventana board, enable LTC3676 driver in imx_v6_v7_defconfig.

Fixes e3946fe805053 ("ARM: dts: add Gateworks Ventana support")

I don't think the Fixes tag is appropriate here. Dropped it and applied patch.

Can you please elaborate why do you think the Fixes tag is not appropriate ?

Neither system can work properly without the PMIC driver, so I believe the Fixes tag is correct and this should be backported to older LTS kernel releases.

[...]

Quoted 19 lines
Quoted 19 lines
Quoted 8 lines
   arch/arm/configs/imx_v6_v7_defconfig | 1 +
   1 file changed, 1 insertion(+)
arch/arm/configs/imx_v6_v7_defconfig +0 -0
index 079fcd8d1d11..f94e3d11c3e9 100644

arch/arm/configs/imx_v6_v7_defconfig CONFIG_REGULATOR_DA9052=y · line 258

Quoted 7 lines
arch/arm/configs/imx_v6_v7_defconfig +1 -0
@@ -252,6 +252,7 @@ CONFIG_REGULATOR_DA9052=y
   CONFIG_REGULATOR_DA9062=y
   CONFIG_REGULATOR_DA9063=y
   CONFIG_REGULATOR_GPIO=y
+CONFIG_REGULATOR_LTC3676=y
   CONFIG_REGULATOR_MC13783=y
   CONFIG_REGULATOR_MC13892=y
   CONFIG_REGULATOR_PFUZE100=y
Quoted 1 line
Quoted 1 line

Neither board can work well without a PMIC driver.

[...]

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw
Quoted 9 lines · Marek Vasut
Quoted 8 lines · Shawn Guo
Quoted 6 lines · Marek Vasut
Quoted 5 lines · Pascal Zimmermann

The LTC3676 is a PMIC which is used on some i.MX6 based boards (like the DHCOM i.MX6 Quad SoM), it was first used on the GW Ventana board, enable LTC3676 driver in imx_v6_v7_defconfig.

Fixes e3946fe805053 ("ARM: dts: add Gateworks Ventana support")
Quoted 8 lines
Quoted 2 lines

I don't think the Fixes tag is appropriate here. Dropped it and applied patch.

Can you please elaborate why do you think the Fixes tag is not appropriate ?

Neither system can work properly without the PMIC driver, so I believe the Fixes tag is correct and this should be backported to older LTS kernel releases.

It's enabling a feature (driver) rather than fixing a bug or regression. If you want to enable it for LTS kernel, go ahead to back port it. Do not abuse the Fixes tag.

Shawn

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw
Quoted 15 lines · Shawn Guo
Quoted 14 lines · Marek Vasut
Quoted 10 lines · Shawn Guo
Quoted 6 lines · Marek Vasut
Quoted 5 lines · Pascal Zimmermann

The LTC3676 is a PMIC which is used on some i.MX6 based boards (like the DHCOM i.MX6 Quad SoM), it was first used on the GW Ventana board, enable LTC3676 driver in imx_v6_v7_defconfig.

Fixes e3946fe805053 ("ARM: dts: add Gateworks Ventana support")

I don't think the Fixes tag is appropriate here. Dropped it and applied patch.

Can you please elaborate why do you think the Fixes tag is not appropriate ?

Quoted 7 lines
Quoted 3 lines

Neither system can work properly without the PMIC driver, so I believe the Fixes tag is correct and this should be backported to older LTS kernel releases.

It's enabling a feature (driver) rather than fixing a bug or regression. If you want to enable it for LTS kernel, go ahead to back port it. Do not abuse the Fixes tag.

I disagree with this. Without the PMIC driver, the system is basically unusable. That is because the internal regulators in the MX6 depend on the PMIC, so those fail to probe, and in turn all the other components which depend on those internal regulators also fail to probe (that is everything which depends on anatop regulators).

If I take linux-stable, compile it for a system that is supported in there, with the imx_v6_v7_defconfig which is part of it, I would expect the result to work properly, not just barely boot and be barely usable.

Therefore, I believe the Fixes tag here is justified.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#6 lore raw
Quoted 24 lines · Marek Vasut
Quoted 15 lines · Shawn Guo
Quoted 14 lines · Marek Vasut
Quoted 10 lines · Shawn Guo
Quoted 6 lines · Marek Vasut
Quoted 5 lines · Pascal Zimmermann

The LTC3676 is a PMIC which is used on some i.MX6 based boards (like the DHCOM i.MX6 Quad SoM), it was first used on the GW Ventana board, enable LTC3676 driver in imx_v6_v7_defconfig.

Fixes e3946fe805053 ("ARM: dts: add Gateworks Ventana support")

I don't think the Fixes tag is appropriate here.  Dropped it and applied patch.

Can you please elaborate why do you think the Fixes tag is not appropriate ?

Quoted 7 lines
Quoted 3 lines

Neither system can work properly without the PMIC driver, so I believe the Fixes tag is correct and this should be backported to older LTS kernel releases.

It's enabling a feature (driver) rather than fixing a bug or regression. If you want to enable it for LTS kernel, go ahead to back port it. Do not abuse the Fixes tag.

Quoted 5 lines

I disagree with this. Without the PMIC driver, the system is basically unusable. That is because the internal regulators in the MX6 depend on the PMIC, so those fail to probe, and in turn all the other components which depend on those internal regulators also fail to probe (that is everything which depends on anatop regulators).

If I take linux-stable, compile it for a system that is supported in there, with the imx_v6_v7_defconfig which is part of it, I would expect the result to work properly, not just barely boot and be barely usable.

Therefore, I believe the Fixes tag here is justified.

I am curious, is there any further clarification ?

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel