Skip to contentSkip to conversation

regulator: lp87565: Fix missing register for LP87565_BUCK_0

PATCH In review Axel Lin 2 participants 2 messages Mar 1, 2019 – Mar 13, 2019 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: lp87565: Fix missing register for LP87565_BUCK_0

LP87565_BUCK_0 is missed, fix it.

Fixes f0168a9bf ("regulator: lp87565: Add support for lp87565 PMIC regulators")

---
Hi J Keerthy,
While reading the code, it seems strange that LP87565_BUCK_0 is never used. So current code only register 3 BUCKs for lp87565-regulator. Can you confirm if this fix is correct or not?

Thanks,
Axel

 drivers/regulator/lp87565-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/lp87565-regulator.c +1 -1
index 4ed41731a5b1..0418e478c6dc 100644
@@ -193,7 +193,7 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
 	struct lp87565 *lp87565 = dev_get_drvdata(pdev->dev.parent);
 	struct regulator_config config = { };
 	struct regulator_dev *rdev;
-	int i, min_idx = LP87565_BUCK_1, max_idx = LP87565_BUCK_3;
+	int i, min_idx = LP87565_BUCK_0, max_idx = LP87565_BUCK_3;
 
 	platform_set_drvdata(pdev, lp87565);
 
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Axel Lin

LP87565_BUCK_0 is missed, fix it.

Fixes f0168a9bf ("regulator: lp87565: Add support for lp87565 PMIC regulators")

---
Hi J Keerthy,
While reading the code, it seems strange that LP87565_BUCK_0 is never used. So current code only register 3 BUCKs for lp87565-regulator. Can you confirm if this fix is correct or not?

Axel,

If you look at the if check later:

if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) {

Currently the device that i am using only uses LP87565_BUCK_10 and LP87565_BUCK_23(dual phase).

So your patch definitely makes sense when all 4 are used individually. Thanks for catching this.

Quoted 20 lines

Thanks,
Axel

  drivers/regulator/lp87565-regulator.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/lp87565-regulator.c +1 -1
index 4ed41731a5b1..0418e478c6dc 100644
@@ -193,7 +193,7 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
  	struct lp87565 *lp87565 = dev_get_drvdata(pdev->dev.parent);
  	struct regulator_config config = { };
  	struct regulator_dev *rdev;
-	int i, min_idx = LP87565_BUCK_1, max_idx = LP87565_BUCK_3;
+	int i, min_idx = LP87565_BUCK_0, max_idx = LP87565_BUCK_3;
 
  	platform_set_drvdata(pdev, lp87565);