Skip to contentSkip to conversation

Update clone3 self-tests

PATCH Superseded Eugene Syromiatnikov 2 participants 13 messages Sep 10, 2019 – Sep 16, 2019

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover Update clone3 self-tests

Hello.

This patch set updates clone3 selftest in several aspects:
- adding a check for kernel not ignoring highest 32 bits of exit_signal field of clone3 syscall arguments structure;
- adding clone3 to selftests targets;
- enabling clone3 tests on all architectures;
- minor cleanups of the clone3 test.

Applied on top of brauer/linux.git/for-next.

Eugene Syromiatnikov (6):
selftests/clone3: convert test modes into an enum selftests/clone3: add a check for invalid exit_signal selftests/clone3: use uint64_t for flags parameter selftests/clone3: fix up format strings selftests/clone3: enable clone3 self-tests on all architectures
selftests: add clone3 to TARGETS

 tools/testing/selftests/Makefile        |  1 +
 tools/testing/selftests/clone3/Makefile |  4 +---
 tools/testing/selftests/clone3/clone3.c | 37 +++++++++++++++++++++++++--------
 3 files changed, 30 insertions(+), 12 deletions(-)
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/6 selftests/clone3: convert test modes into an enum

* tools/testing/selftests/clone3/clone3.c (CLONE3_ARGS_NO_TEST, CLONE3_ARGS_ALL_0, CLONE3_ARGS_ALL_1): Change into an enum. (call_clone3): Change test_mode parameter type to enum test_mode; use switch statement for actions that dependent on test_mode selection. (test_clone3): Change test_mode parameter type to enum test_mode.

---
 tools/testing/selftests/clone3/clone3.c | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)
tools/testing/selftests/clone3/clone3.c +14 -7
index a0f1989..7b65ee5 100644
@@ -24,16 +24,18 @@
 /* V1 includes set_tid */
 #define CLONE3_ARGS_SIZE_V1 72
 
-#define CLONE3_ARGS_NO_TEST 0
-#define CLONE3_ARGS_ALL_0 1
-#define CLONE3_ARGS_ALL_1 2
+enum test_mode {
+	CLONE3_ARGS_NO_TEST,
+	CLONE3_ARGS_ALL_0,
+	CLONE3_ARGS_ALL_1,
+};
 
 static pid_t raw_clone(struct clone_args *args, size_t size)
 {
 	return syscall(__NR_clone3, args, size);
 }
 
-static int call_clone3(int flags, size_t size, int test_mode)
+static int call_clone3(int flags, size_t size, enum test_mode test_mode)
 {
 	struct clone_args args = {0};
 	pid_t ppid = -1;
@@ -46,7 +48,8 @@ static int call_clone3(int flags, size_t size, int test_mode)
 	if (size == 0)
 		size = sizeof(struct clone_args);
 
-	if (test_mode == CLONE3_ARGS_ALL_0) {
+	switch (test_mode) {
+	case CLONE3_ARGS_ALL_0:
 		args.flags = 0;
 		args.pidfd = 0;
 		args.child_tid = 0;
@@ -56,7 +59,9 @@ static int call_clone3(int flags, size_t size, int test_mode)
 		args. stack_size = 0;
 		args.tls = 0;
 		args.set_tid = 0;
-	} else if (test_mode == CLONE3_ARGS_ALL_1) {
+		break;
+
+	case CLONE3_ARGS_ALL_1:
 		args.flags = 1;
 		args.pidfd = 1;
 		args.child_tid = 1;
@@ -66,6 +71,7 @@ static int call_clone3(int flags, size_t size, int test_mode)
 		args. stack_size = 1;
 		args.tls = 1;
 		args.set_tid = 1;
+		break;
 	}
 
 	pid = raw_clone(&args, size);
@@ -91,7 +97,8 @@ static int call_clone3(int flags, size_t size, int test_mode)
 	return 0;
 }
 
-static int test_clone3(int flags, size_t size, int expected, int test_mode)
+static int test_clone3(int flags, size_t size, int expected,
+		       enum test_mode test_mode)
 {
 	int ret;
 
Signature · 1 line
2.1.4
maintainer
#2 lore raw

Re: [PATCH 1/6] selftests/clone3: convert test modes into an enum

Quoted 6 lines · Eugene Syromiatnikov

* tools/testing/selftests/clone3/clone3.c (CLONE3_ARGS_NO_TEST, CLONE3_ARGS_ALL_0, CLONE3_ARGS_ALL_1): Change into an enum. (call_clone3): Change test_mode parameter type to enum test_mode; use switch statement for actions that dependent on test_mode selection. (test_clone3): Change test_mode parameter type to enum test_mode.

You don't need the file name in the commit log. Please describe what you are fixing/doing in the commit. Describing the actual code changes doesn't help.

Including why these changes are needed as opposed the actual changes will be helpful. I think I know why, I would like you to tell me why.

Quoted 63 lines
---
  tools/testing/selftests/clone3/clone3.c | 21 ++++++++++++++-------
  1 file changed, 14 insertions(+), 7 deletions(-)
tools/testing/selftests/clone3/clone3.c +12 -6
index a0f1989..7b65ee5 100644
@@ -24,16 +24,18 @@
  /* V1 includes set_tid */
  #define CLONE3_ARGS_SIZE_V1 72
 
-#define CLONE3_ARGS_NO_TEST 0
-#define CLONE3_ARGS_ALL_0 1
-#define CLONE3_ARGS_ALL_1 2
+enum test_mode {
+	CLONE3_ARGS_NO_TEST,
+	CLONE3_ARGS_ALL_0,
+	CLONE3_ARGS_ALL_1,
+};
 
  static pid_t raw_clone(struct clone_args *args, size_t size)
  {
  	return syscall(__NR_clone3, args, size);
  }
 
-static int call_clone3(int flags, size_t size, int test_mode)
+static int call_clone3(int flags, size_t size, enum test_mode test_mode)
  {
  	struct clone_args args = {0};
  	pid_t ppid = -1;
@@ -46,7 +48,8 @@ static int call_clone3(int flags, size_t size, int test_mode)
  	if (size == 0)
  		size = sizeof(struct clone_args);
 
-	if (test_mode == CLONE3_ARGS_ALL_0) {
+	switch (test_mode) {
+	case CLONE3_ARGS_ALL_0:
  		args.flags = 0;
  		args.pidfd = 0;
  		args.child_tid = 0;
@@ -56,7 +59,9 @@ static int call_clone3(int flags, size_t size, int test_mode)
  		args. stack_size = 0;
  		args.tls = 0;
  		args.set_tid = 0;
-	} else if (test_mode == CLONE3_ARGS_ALL_1) {
+		break;
+
+	case CLONE3_ARGS_ALL_1:
  		args.flags = 1;
  		args.pidfd = 1;
  		args.child_tid = 1;
@@ -66,6 +71,7 @@ static int call_clone3(int flags, size_t size, int test_mode)
  		args. stack_size = 1;
  		args.tls = 1;
  		args.set_tid = 1;
+		break;
  	}
 
  	pid = raw_clone(&args, size);

tools/testing/selftests/clone3/clone3.c static int call_clone3(int flags, size_t size, int test_mode) · line 104

Quoted 9 lines
tools/testing/selftests/clone3/clone3.c +2 -1
@@ -91,7 +97,8 @@ static int call_clone3(int flags, size_t size, int test_mode)
  	return 0;
  }
 
-static int test_clone3(int flags, size_t size, int expected, int test_mode)
+static int test_clone3(int flags, size_t size, int expected,
+		       enum test_mode test_mode)
  {
  	int ret;
 

thanks,
-- Shuah

#3 lore raw

PATCH 2/6 selftests/clone3: add a check for invalid exit_signal

In reply to Eugene Syromiatnikov

Check that the kernel fails calls with exit_signal with non-zero highest 32 bits.

* tools/testing/selftests/clone3/clone3.c (enum test_mode): Add CLONE3_ARGS_BIG_EXIT_SIGNAL.
(call_clone3): Add args.exit_signal initialisation in case test_mode == CLONE3_ARGS_BIG_EXIT_SIGNAL.
(main): Add test_clone3 clone check with
test_mode == CLONE3_ARGS_BIG_EXIT_SIGNAL.

---
 tools/testing/selftests/clone3/clone3.c | 9 +++++++++
 1 file changed, 9 insertions(+)
tools/testing/selftests/clone3/clone3.c +9 -0
index 7b65ee5..4f23a0c 100644
@@ -28,6 +28,7 @@ enum test_mode {
 	CLONE3_ARGS_NO_TEST,
 	CLONE3_ARGS_ALL_0,
 	CLONE3_ARGS_ALL_1,
+	CLONE3_ARGS_BIG_EXIT_SIGNAL,
 };
 
 static pid_t raw_clone(struct clone_args *args, size_t size)
@@ -72,6 +73,10 @@ static int call_clone3(int flags, size_t size, enum test_mode test_mode)
 		args.tls = 1;
 		args.set_tid = 1;
 		break;
+
+	case CLONE3_ARGS_BIG_EXIT_SIGNAL:
+		args.exit_signal = 0xbadc0ded00000000;
+		break;
 	}
 
 	pid = raw_clone(&args, size);
@@ -146,6 +151,10 @@ int main(int argc, char *argv[])
 	/* Do a clone3() with all members set to 1 */
 	if (test_clone3(0, CLONE3_ARGS_SIZE_V0, -EINVAL, CLONE3_ARGS_ALL_1))
 		goto on_error;
+	/* Do a clone3() with exit_signal having highest 32 bits non-zero */
+	if (test_clone3(0, CLONE3_ARGS_SIZE_V0, -EINVAL,
+			CLONE3_ARGS_BIG_EXIT_SIGNAL))
+		goto on_error;
 	/*
 	 * Do a clone3() with sizeof(struct clone_args) + 8
 	 * and all members set to 0.
Signature · 1 line
2.1.4
maintainer
#4 lore raw

Re: [PATCH 2/6] selftests/clone3: add a check for invalid exit_signal

Quoted 3 lines · Eugene Syromiatnikov

Check that the kernel fails calls with exit_signal with non-zero highest 32 bits.

Describe what you are testing:

"Add a test case for clone3() non-zero highest 32 bits behavior. It should fail with exit_signal value??"

Add checks for unsupported cases. Handle unsupported architectures and configurations with skip

Quoted 6 lines

* tools/testing/selftests/clone3/clone3.c (enum test_mode): Add CLONE3_ARGS_BIG_EXIT_SIGNAL.
(call_clone3): Add args.exit_signal initialisation in case test_mode == CLONE3_ARGS_BIG_EXIT_SIGNAL.
(main): Add test_clone3 clone check with
test_mode == CLONE3_ARGS_BIG_EXIT_SIGNAL.

Please don't include pseudo code in the commit log.

Quoted 19 lines
---
  tools/testing/selftests/clone3/clone3.c | 9 +++++++++
  1 file changed, 9 insertions(+)
tools/testing/selftests/clone3/clone3.c +1 -0
index 7b65ee5..4f23a0c 100644
@@ -28,6 +28,7 @@ enum test_mode {
  	CLONE3_ARGS_NO_TEST,
  	CLONE3_ARGS_ALL_0,
  	CLONE3_ARGS_ALL_1,
+	CLONE3_ARGS_BIG_EXIT_SIGNAL,
  };
 
  static pid_t raw_clone(struct clone_args *args, size_t size)

tools/testing/selftests/clone3/clone3.c static int call_clone3(int flags, size_t size, enum test_mode test_mode) · line 78

Quoted 6 lines
tools/testing/selftests/clone3/clone3.c +3 -0
@@ -72,6 +73,10 @@ static int call_clone3(int flags, size_t size, enum test_mode test_mode)
  		args.tls = 1;
  		args.set_tid = 1;
  		break;
+
+	case CLONE3_ARGS_BIG_EXIT_SIGNAL:
+		args.exit_signal = 0xbadc0ded00000000;

Please add a comment to indicate what this is. I am assuming this bad sig val.

Quoted 6 lines
tools/testing/selftests/clone3/clone3.c +1 -0
+		break;
  	}
 
  	pid = raw_clone(&args, size);

tools/testing/selftests/clone3/clone3.c int main(int argc, char *argv[]) · line 160

Quoted 10 lines
tools/testing/selftests/clone3/clone3.c +4 -0
@@ -146,6 +151,10 @@ int main(int argc, char *argv[])
  	/* Do a clone3() with all members set to 1 */
  	if (test_clone3(0, CLONE3_ARGS_SIZE_V0, -EINVAL, CLONE3_ARGS_ALL_1))
  		goto on_error;
+	/* Do a clone3() with exit_signal having highest 32 bits non-zero */
+	if (test_clone3(0, CLONE3_ARGS_SIZE_V0, -EINVAL,
+			CLONE3_ARGS_BIG_EXIT_SIGNAL))
+		goto on_error;
  	/*
  	 * Do a clone3() with sizeof(struct clone_args) + 8
  	 * and all members set to 0.

thanks,
-- Shuah

#5 lore raw

PATCH 3/6 selftests/clone3: use uint64_t for flags parameter

In reply to Eugene Syromiatnikov

Flags parameter in both userspace and kernel clone args is 64-bit wide, there's little reason to have it signed and 32-bit in tests.

* tools/testing/selftests/clone3/clone3.c: Include <inttypes.h> and <stdint.h>.
(call_clone3): Change flags parameter type from int to uint64_t. (test_clone3): Change flags parameter type from int to uint64_t; change the format string that prints it accordingly.

---
 tools/testing/selftests/clone3/clone3.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
tools/testing/selftests/clone3/clone3.c +6 -3
index 4f23a0c..1746a9b 100644
@@ -4,8 +4,10 @@
 
 #define _GNU_SOURCE
 #include <errno.h>
+#include <inttypes.h>
 #include <linux/types.h>
 #include <linux/sched.h>
+#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <sys/syscall.h>
@@ -36,7 +38,7 @@ static pid_t raw_clone(struct clone_args *args, size_t size)
 	return syscall(__NR_clone3, args, size);
 }
 
-static int call_clone3(int flags, size_t size, enum test_mode test_mode)
+static int call_clone3(uint64_t flags, size_t size, enum test_mode test_mode)
 {
 	struct clone_args args = {0};
 	pid_t ppid = -1;
@@ -102,12 +104,13 @@ static int call_clone3(int flags, size_t size, enum test_mode test_mode)
 	return 0;
 }
 
-static int test_clone3(int flags, size_t size, int expected,
+static int test_clone3(uint64_t flags, size_t size, int expected,
 		       enum test_mode test_mode)
 {
 	int ret;
 
-	ksft_print_msg("[%d] Trying clone3() with flags 0x%x (size %d)\n",
+	ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %d)"
+			"\n",
 			getpid(), flags, size);
 	ret = call_clone3(flags, size, test_mode);
 	ksft_print_msg("[%d] clone3() with flags says :%d expected %d\n",
Signature · 1 line
2.1.4
maintainer
#6 lore raw

Re: [PATCH 3/6] selftests/clone3: use uint64_t for flags parameter

Quoted 3 lines · Eugene Syromiatnikov

Flags parameter in both userspace and kernel clone args is 64-bit wide, there's little reason to have it signed and 32-bit in tests.

So what are doing? You are stating the problem here, how are you fixing it?

Quoted 6 lines

* tools/testing/selftests/clone3/clone3.c: Include <inttypes.h> and <stdint.h>.
(call_clone3): Change flags parameter type from int to uint64_t. (test_clone3): Change flags parameter type from int to uint64_t; change the format string that prints it accordingly.

I am not going to say this again. Please don't include pseudo code in the commit log.

Quoted 36 lines
---
  tools/testing/selftests/clone3/clone3.c | 9 ++++++---
  1 file changed, 6 insertions(+), 3 deletions(-)
tools/testing/selftests/clone3/clone3.c +4 -2
index 4f23a0c..1746a9b 100644
@@ -4,8 +4,10 @@
 
  #define _GNU_SOURCE
  #include <errno.h>
+#include <inttypes.h>
  #include <linux/types.h>
  #include <linux/sched.h>
+#include <stdint.h>
  #include <stdio.h>
  #include <stdlib.h>
  #include <sys/syscall.h>
@@ -36,7 +38,7 @@ static pid_t raw_clone(struct clone_args *args, size_t size)
  	return syscall(__NR_clone3, args, size);
  }
 
-static int call_clone3(int flags, size_t size, enum test_mode test_mode)
+static int call_clone3(uint64_t flags, size_t size, enum test_mode test_mode)
  {
  	struct clone_args args = {0};
  	pid_t ppid = -1;
@@ -102,12 +104,13 @@ static int call_clone3(int flags, size_t size, enum test_mode test_mode)
  	return 0;
  }
 
-static int test_clone3(int flags, size_t size, int expected,
+static int test_clone3(uint64_t flags, size_t size, int expected,

tools/testing/selftests/clone3/clone3.c static int call_clone3(int flags, size_t size, enum test_mode test_mode) · line 116

Quoted 10 lines
tools/testing/selftests/clone3/clone3.c +2 -1
  		       enum test_mode test_mode)
  {
  	int ret;
 
-	ksft_print_msg("[%d] Trying clone3() with flags 0x%x (size %d)\n",
+	ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %d)"
+			"\n",
  			getpid(), flags, size);
  	ret = call_clone3(flags, size, test_mode);
  	ksft_print_msg("[%d] clone3() with flags says :%d expected %d\n",

thanks,
-- Shuah

#7 lore raw

PATCH 4/6 selftests/clone3: fix up format strings

In reply to Eugene Syromiatnikov

* tools/testing/selftests/clone3/clone3.c (test_clone3): Change format qualifier for printing size field from %d to %zu; place colon right after the word "says".

---
 tools/testing/selftests/clone3/clone3.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/clone3/clone3.c +2 -2
index 1746a9b..7b8d927 100644
@@ -109,11 +109,11 @@ static int test_clone3(uint64_t flags, size_t size, int expected,
 {
 	int ret;
 
-	ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %d)"
+	ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %zu)"
 			"\n",
 			getpid(), flags, size);
 	ret = call_clone3(flags, size, test_mode);
-	ksft_print_msg("[%d] clone3() with flags says :%d expected %d\n",
+	ksft_print_msg("[%d] clone3() with flags says: %d expected %d\n",
 			getpid(), ret, expected);
 	if (ret != expected)
 		ksft_exit_fail_msg(
Signature · 1 line
2.1.4
maintainer
#8 lore raw

Re: [PATCH 4/6] selftests/clone3: fix up format strings

Quoted 4 lines · Eugene Syromiatnikov

* tools/testing/selftests/clone3/clone3.c (test_clone3): Change format qualifier for printing size field from %d to %zu; place colon right after the word "says".

Please drop the file name. The rest looks good. I am assuming there is a reason for doing this. Please include compile warns if applicable.

Quoted 14 lines
---
  tools/testing/selftests/clone3/clone3.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/clone3/clone3.c +0 -0
index 1746a9b..7b8d927 100644
@@ -109,11 +109,11 @@ static int test_clone3(uint64_t flags, size_t size, int expected,
  {
  	int ret;
 

tools/testing/selftests/clone3/clone3.c static int test_clone3(uint64_t flags, size_t size, int expected, · line 119

Quoted 10 lines
tools/testing/selftests/clone3/clone3.c +2 -2
-	ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %d)"
+	ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %zu)"
  			"\n",
  			getpid(), flags, size);
  	ret = call_clone3(flags, size, test_mode);
-	ksft_print_msg("[%d] clone3() with flags says :%d expected %d\n",
+	ksft_print_msg("[%d] clone3() with flags says: %d expected %d\n",
  			getpid(), ret, expected);
  	if (ret != expected)
  		ksft_exit_fail_msg(

thanks,
-- Shuah

#9 lore raw

PATCH 5/6 selftests/clone3: enable clone3 self-tests on all architectures

In reply to Eugene Syromiatnikov

clone3() is available on most architectures, so there's no reason to restrict the respective self-tests to x86_64.

* tools/testing/selftests/clone3/Makefile (TEST_GEN_PROGS): Set always, not only ifeq ($(ARCH),x86_64).

---
 tools/testing/selftests/clone3/Makefile | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
tools/testing/selftests/clone3/Makefile +1 -3
index 4efcf45..faa069c 100644
@@ -4,8 +4,6 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
 
 CFLAGS += -I../../../../usr/include/
 
-ifeq ($(ARCH),x86_64)
-	TEST_GEN_PROGS := clone3 clone3_set_tid
-endif
+TEST_GEN_PROGS := clone3 clone3_set_tid
 
 include ../lib.mk
Signature · 1 line
2.1.4
maintainer
#10 lore raw

Re: [PATCH 5/6] selftests/clone3: enable clone3 self-tests on all architectures

Quoted 3 lines · Eugene Syromiatnikov

clone3() is available on most architectures, so there's no reason to restrict the respective self-tests to x86_64.

Is it missing on any? Please key off of the return value and exit with skip if unsupported.

Quoted 3 lines

* tools/testing/selftests/clone3/Makefile (TEST_GEN_PROGS): Set always, not only ifeq ($(ARCH),x86_64).

Please - no file names in commit log.

Quoted 11 lines
---
  tools/testing/selftests/clone3/Makefile | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
tools/testing/selftests/clone3/Makefile +0 -0
index 4efcf45..faa069c 100644

tools/testing/selftests/clone3/Makefile ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/) · line 9

Quoted 9 lines
tools/testing/selftests/clone3/Makefile +1 -3
@@ -4,8 +4,6 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
 
  CFLAGS += -I../../../../usr/include/
 
-ifeq ($(ARCH),x86_64)
-	TEST_GEN_PROGS := clone3 clone3_set_tid
-endif
+TEST_GEN_PROGS := clone3 clone3_set_tid
 
  include ../lib.mk

This is fine. Where is the code to handle unsupported case?

thanks,
-- Shuah

#11 lore raw

PATCH 6/6 selftests: add clone3 to TARGETS

In reply to Eugene Syromiatnikov

* tools/testing/selftests/Makefile (TARGETS): Add clone3.

---
 tools/testing/selftests/Makefile | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/Makefile +1 -0
index 25b43a8c..05163e4 100644
@@ -4,6 +4,7 @@ TARGETS += bpf
 TARGETS += breakpoints
 TARGETS += capabilities
 TARGETS += cgroup
+TARGETS += clone3
 TARGETS += cpufreq
 TARGETS += cpu-hotplug
 TARGETS += drivers/dma-buf
Signature · 1 line
2.1.4
maintainer
#12 lore raw

Re: [PATCH 6/6] selftests: add clone3 to TARGETS

Quoted 1 line · Eugene Syromiatnikov

* tools/testing/selftests/Makefile (TARGETS): Add clone3.

Again. No filenames in the commit log. Please add more detail.

"Adding clone3() tests to kselftest default run and details on what this tests"

This will be helpful to users.

Quoted 12 lines
---
  tools/testing/selftests/Makefile | 1 +
  1 file changed, 1 insertion(+)
tools/testing/selftests/Makefile +0 -0
index 25b43a8c..05163e4 100644

tools/testing/selftests/Makefile TARGETS += bpf · line 10

Quoted 7 lines
tools/testing/selftests/Makefile +1 -0
@@ -4,6 +4,7 @@ TARGETS += bpf
  TARGETS += breakpoints
  TARGETS += capabilities
  TARGETS += cgroup
+TARGETS += clone3
  TARGETS += cpufreq
  TARGETS += cpu-hotplug
  TARGETS += drivers/dma-buf

Please make sure the test doesn't hang and all the use-cases listed in the kselftest.rst are supported.

make kselftest
make -C tools/testing/selftests
O= and KBUILD_OUTPUT cases as well as running make directly in the clode3 dir.

Please include test output and usage instructions if any to this commit log as this is the patch that enables it in the default run.

thanks,
-- Shuah