iommu: Do not dereference fwnode in struct device
PATCH 1/1 iommu: Do not dereference fwnode in struct device
In order to make the underneath API easier to change in the future, prevent users from dereferencing fwnode from struct device. Instead, use the specific dev_fwnode() API for that.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/iommu/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/iommu.c +1 -1
@@ -173,7 +173,7 @@ int iommu_device_register(struct iommu_device *iommu, iommu->ops = ops;if (hwdev) - iommu->fwnode = hwdev->fwnode; + iommu->fwnode =dev_fwnode (hwdev);spin_lock (&iommu_device_lock);list_add_tail (&iommu->list, &iommu_device_list);
Signature · 1 line
2.35.1
Quoted 3 lines · Andy Shevchenko
In order to make the underneath API easier to change in the future, prevent users from dereferencing fwnode from struct device. Instead, use the specific
dev_fwnode()API for that.
Any news?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 3 lines · Andy Shevchenko
In order to make the underneath API easier to change in the future, prevent users from dereferencing fwnode from struct device. Instead, use the specific
dev_fwnode()API for that.
Seems fair,
Reviewed-by Robin Murphy <[email protected]>
Quoted 18 lines
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/iommu/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iommu/iommu.c +1
-1@@ -173,7 +173,7 @@ int iommu_device_register(struct iommu_device *iommu, iommu->ops = ops;if (hwdev) - iommu->fwnode = hwdev->fwnode; + iommu->fwnode =dev_fwnode (hwdev);spin_lock (&iommu_device_lock);list_add_tail (&iommu->list, &iommu_device_list);
Quoted 2 lines · Andy Shevchenko
drivers/iommu/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.