mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache_type
PATCH 1/1 mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache_type
REGCACHE_NONE is the default type of the cache when not provided. Drop unneeded explicit assignment to it.
Note, it's defined to 0, and if ever be redefined, it will break literally a lot of the drivers, so it very unlikely to happen.
--- drivers/mfd/intel_soc_pmic_crc.c | 1 - 1 file changed, 1 deletion(-)
drivers/mfd/intel_soc_pmic_crc.c +0 -1
@@ -113,7 +113,6 @@ static const struct regmap_config crystal_cove_regmap_config = { .val_bits = 8, .max_register = CRYSTAL_COVE_MAX_REGISTER, - .cache_type = REGCACHE_NONE, };static const struct regmap_irq crystal_cove_irqs[] = {
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac
Hi,
Quoted 7 lines · Andy Shevchenko
REGCACHE_NONEis the default type of the cache when not provided. Drop unneeded explicit assignment to it.Note, it's defined to 0, and if ever be redefined, it will break literally a lot of the drivers, so it very unlikely to happen.
Signed-off-by Andy Shevchenko <[email protected]>
Thanks, patch looks good to me:
Regards,
Hans
Quoted 16 lines
--- drivers/mfd/intel_soc_pmic_crc.c | 1 - 1 file changed, 1 deletion(-)drivers/mfd/intel_soc_pmic_crc.c +0
-1@@ -113,7 +113,6 @@ static const struct regmap_config crystal_cove_regmap_config = { .val_bits = 8, .max_register = CRYSTAL_COVE_MAX_REGISTER, - .cache_type = REGCACHE_NONE, };static const struct regmap_irq crystal_cove_irqs[] = {
Re: (subset) [PATCH v1 1/1] mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache_type
In reply to Andy ShevchenkoQuoted 8 lines · Andy Shevchenko
REGCACHE_NONEis the default type of the cache when not provided. Drop unneeded explicit assignment to it.Note, it's defined to 0, and if ever be redefined, it will break literally a lot of the drivers, so it very unlikely to happen.
[...]
Applied, thanks!
[1/1] mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache_type
commit: 0b1cfd51841c69c024facfe59ea7bbe6b589a7de
--
Lee Jones [李琼斯]