Skip to contentSkip to conversation

drm/amdkfd: Fix missing break in switch statement

PATCH Applied Gustavo A. R. Silva 2 participants 5 messages Jul 21, 2019 – Jul 22, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdkfd: Fix missing break in switch statement

Add missing break statement in order to prevent the code from falling through to case CHIP_NAVI10.

This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough.

Fixes 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)")
---
 drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +1 -0
index 792371442195..4e3fc284f6ac 100644
@@ -668,6 +668,7 @@ static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev,
 	case CHIP_RAVEN:
 		pcache_info = raven_cache_info;
 		num_of_cache_types = ARRAY_SIZE(raven_cache_info);
+		break;
 	case CHIP_NAVI10:
 		pcache_info = navi10_cache_info;
 		num_of_cache_types = ARRAY_SIZE(navi10_cache_info);
Signature · 1 line
2.22.0
Applied
#1 lore raw
Quoted 10 lines · Gustavo A. R. Silva

Add missing break statement in order to prevent the code from falling through to case CHIP_NAVI10.

This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough.

Fixes 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)")

Applied. Thanks!

Alex

Quoted 23 lines
---
 drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +1 -1
index 792371442195..4e3fc284f6ac 100644
@@ -668,6 +668,7 @@ static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev,
        case CHIP_RAVEN:
                pcache_info = raven_cache_info;
                num_of_cache_types = ARRAY_SIZE(raven_cache_info);
+               break;
        case CHIP_NAVI10:
                pcache_info = navi10_cache_info;
                num_of_cache_types = ARRAY_SIZE(navi10_cache_info);
--

2.22.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
Quoted 6 lines · Alex Deucher
Quoted 4 lines · Gustavo A. R. Silva

Add missing break statement in order to prevent the code from falling through to case CHIP_NAVI10.

Quoted 9 lines
Quoted 6 lines

This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough.

Fixes 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)")

Applied. Thanks!

By the way, Alex, I'm planning to add these fixes to my tree. I want to send a pull-request to Linus for v5.3-rc2 this afternoon. We want to have the -Wimplicit-fallthrough option globally enabled in v5.3, and these are some of the last fall-through warnings remaining in the kernel.

Can I have your Ack or Signed-off-by for all these drm patches?

Thanks!
--
Gustavo

#3 lore raw
Quoted 20 lines · Gustavo A. R. Silva
Quoted 6 lines · Alex Deucher
Quoted 4 lines · Gustavo A. R. Silva

Add missing break statement in order to prevent the code from falling through to case CHIP_NAVI10.

Quoted 9 lines
Quoted 6 lines

This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough.

Fixes 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)")

Applied. Thanks!

Quoted 7 lines

By the way, Alex, I'm planning to add these fixes to my tree. I want to send a pull-request to Linus for v5.3-rc2 this afternoon. We want to have the -Wimplicit-fallthrough option globally enabled in v5.3, and these are some of the last fall-through warnings remaining in the kernel.

Can I have your Ack or Signed-off-by for all these drm patches?

I didn't realize you were sending these yourself. I was going to include them in my upcoming -fixes pull. Feel free to add my RB to all three.

Alex

#4 lore raw
Quoted 7 lines · Alex Deucher
Quoted 7 lines

By the way, Alex, I'm planning to add these fixes to my tree. I want to send a pull-request to Linus for v5.3-rc2 this afternoon. We want to have the -Wimplicit-fallthrough option globally enabled in v5.3, and these are some of the last fall-through warnings remaining in the kernel.

Quoted 6 lines
Quoted 1 line

Can I have your Ack or Signed-off-by for all these drm patches?

I didn't realize you were sending these yourself. I was going to include them in my upcoming -fixes pull. Feel free to add my RB to all three.

Awesome! :)

Thanks
--
Gustavo