Skip to contentSkip to conversation

Revert GuC by default

PATCH In review Tvrtko Ursulin 5 participants 12 messages Jul 19, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Revert GuC by default

From: Tvrtko Ursulin <[email protected]>

It seems absence of GuC fimrware breaks the boot in a bad way:

https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/?
https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/fi-icl-u2/boot0.log

Tvrtko Ursulin (2):
Revert "drm/i915/guc: Turn on GuC/HuC auto mode" Revert "drm/i915: Update description of i915.enable_guc modparam"

 drivers/gpu/drm/i915/i915_params.c | 2 +-
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 1/2 Revert "drm/i915/guc: Turn on GuC/HuC auto mode"

From: Tvrtko Ursulin <[email protected]>

This reverts commit f774f09649192f326fa030564afd3f8f5d82c1e4.

If GuC firmware is not present on the filesystem driver crashes the machine on boot.

Fixes f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
Cc Michal Wajdeczko <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Daniele Ceraolo Spurio <[email protected]>
Cc Jani Nikula <[email protected]>
---
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_params.h +1 -1
index 5736c55694fe..d29ade3b7de6 100644
@@ -54,7 +54,7 @@ struct drm_printer;
 	param(int, disable_power_well, -1) \
 	param(int, enable_ips, 1) \
 	param(int, invert_brightness, 0) \
-	param(int, enable_guc, -1) \
+	param(int, enable_guc, 0) \
 	param(int, guc_log_level, -1) \
 	param(char *, guc_firmware_path, NULL) \
 	param(char *, huc_firmware_path, NULL) \
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

Re: [PATCH 1/2] Revert "drm/i915/guc: Turn on GuC/HuC auto mode"

Quoted 7 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

This reverts commit f774f09649192f326fa030564afd3f8f5d82c1e4.

If GuC firmware is not present on the filesystem driver crashes the machine on boot.

Do you have a log? I can't reproduce this on a SKL, I'm just getting:

[55667.026707] i915 0000:00:02.0: Direct firmware load for i915/skl_guc_33.0.0.bin failed with error -2
[55667.026714] [drm] GuC: Failed to fetch firmware i915/skl_guc_33.0.0.bin (error -2)
[55667.026717] [drm] GuC: Firmware can be downloaded from https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/i915
[55667.081885] i915 0000:00:02.0: Device initialization failed (-8)
[55667.081949] i915: probe of 0000:00:02.0 failed with error -8

This is on the latest tip (just fetched).

Daniele

Quoted 19 lines
Fixes f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
Cc Michal Wajdeczko <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Daniele Ceraolo Spurio <[email protected]>
Cc Jani Nikula <[email protected]>
---
  drivers/gpu/drm/i915/i915_params.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_params.h +0 -0
index 5736c55694fe..d29ade3b7de6 100644

drivers/gpu/drm/i915/i915_params.h struct drm_printer; · line 60

Quoted 8 lines
drivers/gpu/drm/i915/i915_params.h +1 -1
@@ -54,7 +54,7 @@ struct drm_printer;
  	param(int, disable_power_well, -1) \
  	param(int, enable_ips, 1) \
  	param(int, invert_brightness, 0) \
-	param(int, enable_guc, -1) \
+	param(int, enable_guc, 0) \
  	param(int, guc_log_level, -1) \
  	param(char *, guc_firmware_path, NULL) \
  	param(char *, huc_firmware_path, NULL) \

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Re: [PATCH 1/2] Revert "drm/i915/guc: Turn on GuC/HuC auto mode"

Quoted 17 lines · Daniele Ceraolo Spurio
Quoted 7 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

This reverts commit f774f09649192f326fa030564afd3f8f5d82c1e4.

If GuC firmware is not present on the filesystem driver crashes the machine on boot.

Do you have a log? I can't reproduce this on a SKL, I'm just getting:

[55667.026707] i915 0000:00:02.0: Direct firmware load for i915/skl_guc_33.0.0.bin failed with error -2
[55667.026714] [drm] GuC: Failed to fetch firmware i915/skl_guc_33.0.0.bin (error -2)
[55667.026717] [drm] GuC: Firmware can be downloaded from https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/i915 
Quoted 8 lines
[55667.081885] i915 0000:00:02.0: Device initialization failed (-8)
[55667.081949] i915: probe of 0000:00:02.0 failed with error -8

This is on the latest tip (just fetched).

Daniele

Found your cover letter with the links to the logs in my spam folder (damn filter!), please ignore the above request.

Daniele

Quoted 23 lines
Quoted 23 lines
Fixes f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
Cc Michal Wajdeczko <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Daniele Ceraolo Spurio <[email protected]>
Cc Jani Nikula <[email protected]>

---
  drivers/gpu/drm/i915/i915_params.h | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_params.h +1 -1
index 5736c55694fe..d29ade3b7de6 100644
@@ -54,7 +54,7 @@ struct drm_printer;
       param(int, disable_power_well, -1) \
       param(int, enable_ips, 1) \
       param(int, invert_brightness, 0) \
-    param(int, enable_guc, -1) \
+    param(int, enable_guc, 0) \
Quoted 8 lines

drivers/gpu/drm/i915/i915_params.h struct drm_printer; · line 60

Quoted 4 lines
drivers/gpu/drm/i915/i915_params.h +0 -0
       param(int, guc_log_level, -1) \
       param(char *, guc_firmware_path, NULL) \
       param(char *, huc_firmware_path, NULL) \

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Re: [PATCH 1/2] Revert "drm/i915/guc: Turn on GuC/HuC auto mode"

In reply to Daniele Ceraolo Spurio
Quoted 5 lines · Daniele Ceraolo Spurio
Quoted 2 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Quoted 7 lines
Quoted 5 lines

This reverts commit f774f09649192f326fa030564afd3f8f5d82c1e4.

If GuC firmware is not present on the filesystem driver crashes the machine on boot.

Do you have a log? I can't reproduce this on a SKL, I'm just getting:

Links are in the cover letter. The boot log does not show a crash but ends suspiciously and all Icelakes in BAT were reported missing from the test run.

Regards,

Tvrtko

Quoted 25 lines
[55667.026707] i915 0000:00:02.0: Direct firmware load for i915/skl_guc_33.0.0.bin failed with error -2
[55667.026714] [drm] GuC: Failed to fetch firmware i915/skl_guc_33.0.0.bin (error -2)
[55667.026717] [drm] GuC: Firmware can be downloaded from https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/i915 
[55667.081885] i915 0000:00:02.0: Device initialization failed (-8)
[55667.081949] i915: probe of 0000:00:02.0 failed with error -8

This is on the latest tip (just fetched).

Daniele

Quoted 13 lines
Fixes f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
Cc Michal Wajdeczko <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Daniele Ceraolo Spurio <[email protected]>
Cc Jani Nikula <[email protected]>

---
  drivers/gpu/drm/i915/i915_params.h | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
Quoted 6 lines
drivers/gpu/drm/i915/i915_params.h +0 -0
index 5736c55694fe..d29ade3b7de6 100644

drivers/gpu/drm/i915/i915_params.h struct drm_printer; · line 60

Quoted 8 lines
drivers/gpu/drm/i915/i915_params.h +1 -1
@@ -54,7 +54,7 @@ struct drm_printer;
       param(int, disable_power_well, -1) \
       param(int, enable_ips, 1) \
       param(int, invert_brightness, 0) \
-    param(int, enable_guc, -1) \
+    param(int, enable_guc, 0) \
       param(int, guc_log_level, -1) \
       param(char *, guc_firmware_path, NULL) \
       param(char *, huc_firmware_path, NULL) \

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

PATCH 2/2 Revert "drm/i915: Update description of i915.enable_guc modparam"

In reply to Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

This reverts commit 0629d4da1f159778063767fb0ac1c951034c5477.

If GuC firmware is not present on the filesystem driver crashes the machine on boot.

Fixes 0629d4da1f15 ("drm/i915: Update description of i915.enable_guc modparam")
Cc Tvrtko Ursulin <[email protected]>
Cc Michal Wajdeczko <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Daniele Ceraolo Spurio <[email protected]>
Cc Jani Nikula <[email protected]>
---
 drivers/gpu/drm/i915/i915_params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_params.c +1 -1
index b4f481e1e6b6..296452f9efe4 100644
@@ -146,7 +146,7 @@ i915_param_named_unsafe(edp_vswing, int, 0400,
 i915_param_named_unsafe(enable_guc, int, 0400,
 	"Enable GuC load for GuC submission and/or HuC load. "
 	"Required functionality can be selected using bitmask values. "
-	"(-1=auto [default], 0=disable, 1=GuC submission, 2=HuC load)");
+	"(-1=auto, 0=disable [default], 1=GuC submission, 2=HuC load)");
 
 i915_param_named(guc_log_level, int, 0400,
 	"GuC firmware logging level. Requires GuC to be loaded. "
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer Acked-by on the v1 series
#6 lore raw
In reply to Tvrtko Ursulin

Regards, Joonas

Quoting Tvrtko Ursulin (2019-07-19 12:48:43)

Quoted 7 lines

From: Tvrtko Ursulin <[email protected]>

It seems absence of GuC fimrware breaks the boot in a bad way:

https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/?
https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/fi-icl-u2/boot0.log

Quoted 15 lines

Tvrtko Ursulin (2):
Revert "drm/i915/guc: Turn on GuC/HuC auto mode" Revert "drm/i915: Update description of i915.enable_guc modparam"

 drivers/gpu/drm/i915/i915_params.c | 2 +-
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

✗ Fi.CI.CHECKPATCH: warning for Revert GuC by default

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: Revert GuC by default
URL : https://patchwork.freedesktop.org/series/63934/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5e4d613993b4 Revert "drm/i915/guc: Turn on GuC/HuC auto mode"
-:33: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 0 checks, 8 lines checked 397611e1bc62 Revert "drm/i915: Update description of i915.enable_guc modparam" -:35: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 0 checks, 8 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

✓ Fi.CI.BAT: success for Revert GuC by default

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: Revert GuC by default
URL : https://patchwork.freedesktop.org/series/63934/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6509 -> Patchwork_13700
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/

Known issues
------------

Here are the changes found in Patchwork_13700 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_create@basic-files:
- fi-icl-u3: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#109100])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-icl-u3/igt@[email protected]

* igt@i915_selftest@live_contexts:
- fi-skl-iommu: [PASS][3] -> [INCOMPLETE][4] ([fdo#111050])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-skl-iommu/igt@i915_selftest@live_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-skl-iommu/igt@i915_selftest@live_contexts.html

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [PASS][5] -> [FAIL][6] ([fdo#103167])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-icl-u2/igt@[email protected]

#### Possible fixes ####

* igt@debugfs_test@read_all_entries:
- {fi-icl-u4}: [DMESG-WARN][7] ([fdo#105602]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-u4/igt@debugfs_test@read_all_entries.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-icl-u4/igt@debugfs_test@read_all_entries.html

* igt@i915_selftest@live_client:
- fi-icl-dsi: [INCOMPLETE][9] ([fdo#107713]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-dsi/igt@i915_selftest@live_client.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-icl-dsi/igt@i915_selftest@live_client.html

#### Warnings ####

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-guc: [SKIP][11] ([fdo#109271]) -> [FAIL][12] ([fdo#107707])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-kbl-guc/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-kbl-guc/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107707]: https://bugs.freedesktop.org/show_bug.cgi?id=107707
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111050]: https://bugs.freedesktop.org/show_bug.cgi?id=111050

Participating hosts (52 -> 46)
------------------------------

Missing (6): fi-byt-squawks fi-bsw-cyan fi-apl-guc fi-icl-y fi-byt-clapper fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_6509 -> Patchwork_13700

CI_DRM_6509: 2eda05e19db04b001c2b0a9b32bfd43077d5a738 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5103: 45c31e294b9d7874a9a21860f8a89c64bc853df2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13700: 397611e1bc62a8496215128aec25d651b0830751 @ git://anongit.freedesktop.org/gfx-ci/linux

== Kernel 32bit build ==

Warning: Kernel 32bit buildtest failed:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/build_32bit.log

  CALL    scripts/checksyscalls.sh
  CALL    scripts/atomic/check-atomics.sh
  CHK     include/generated/compile.h

Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 112 modules
ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: "__divdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1
Makefile:1287: recipe for target 'modules' failed
make: *** [modules] Error 2

== Linux commits ==

397611e1bc62 Revert "drm/i915: Update description of i915.enable_guc modparam" 5e4d613993b4 Revert "drm/i915/guc: Turn on GuC/HuC auto mode"

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

Re: ✓ Fi.CI.BAT: success for Revert GuC by default

Quoted 113 lines · Patchwork

== Series Details ==

Series: Revert GuC by default
URL : https://patchwork.freedesktop.org/series/63934/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6509 -> Patchwork_13700
====================================================

Summary
-------

   **SUCCESS**

   No regressions found.

   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/

Known issues
------------

Here are the changes found in Patchwork_13700 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_create@basic-files:

     - fi-icl-u3:          [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#109100])
    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-u3/igt@[email protected]
    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-icl-u3/igt@[email protected]

* igt@i915_selftest@live_contexts:

     - fi-skl-iommu:       [PASS][3] -> [INCOMPLETE][4] ([fdo#111050])
    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-skl-iommu/igt@i915_selftest@live_contexts.html
    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-skl-iommu/igt@i915_selftest@live_contexts.html

* igt@kms_frontbuffer_tracking@basic:

     - fi-icl-u2:          [PASS][5] -> [FAIL][6] ([fdo#103167])
    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-u2/igt@[email protected]
    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-icl-u2/igt@[email protected]

#### Possible fixes ####

* igt@debugfs_test@read_all_entries:

     - {fi-icl-u4}:        [DMESG-WARN][7] ([fdo#105602]) -> [PASS][8]
    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-u4/igt@debugfs_test@read_all_entries.html
    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-icl-u4/igt@debugfs_test@read_all_entries.html

* igt@i915_selftest@live_client:

     - fi-icl-dsi:         [INCOMPLETE][9] ([fdo#107713]) -> [PASS][10]
    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-dsi/igt@i915_selftest@live_client.html
    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-icl-dsi/igt@i915_selftest@live_client.html

#### Warnings ####

   * igt@i915_pm_rpm@basic-pci-d3-state:
     - fi-kbl-guc:         [SKIP][11] ([fdo#109271]) -> [FAIL][12] ([fdo#107707])
    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-kbl-guc/igt@[email protected]
    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/fi-kbl-guc/igt@[email protected]

   
   {name}: This element is suppressed. This means it is ignored when computing
           the status of the difference (SUCCESS, WARNING, or FAILURE).

   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
   [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
   [fdo#107707]: https://bugs.freedesktop.org/show_bug.cgi?id=107707
   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
   [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
   [fdo#111050]: https://bugs.freedesktop.org/show_bug.cgi?id=111050

Participating hosts (52 -> 46)
------------------------------

Missing (6): fi-byt-squawks fi-bsw-cyan fi-apl-guc fi-icl-y fi-byt-clapper fi-bdw-samus

Build changes
-------------

   * Linux: CI_DRM_6509 -> Patchwork_13700

   CI_DRM_6509: 2eda05e19db04b001c2b0a9b32bfd43077d5a738 @ git://anongit.freedesktop.org/gfx-ci/linux
   IGT_5103: 45c31e294b9d7874a9a21860f8a89c64bc853df2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
   Patchwork_13700: 397611e1bc62a8496215128aec25d651b0830751 @ git://anongit.freedesktop.org/gfx-ci/linux

== Kernel 32bit build ==

Warning: Kernel 32bit buildtest failed:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/build_32bit.log

   CALL    scripts/checksyscalls.sh
   CALL    scripts/atomic/check-atomics.sh
   CHK     include/generated/compile.h

Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 112 modules
ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: "__divdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1
Makefile:1287: recipe for target 'modules' failed
make: *** [modules] Error 2

Quoted 4 lines

== Linux commits ==

397611e1bc62 Revert "drm/i915: Update description of i915.enable_guc modparam" 5e4d613993b4 Revert "drm/i915/guc: Turn on GuC/HuC auto mode"

I've pushed this for now per agreement with Joonas and next week we can see what the proper fix is.

Regards,

Tvrtko

Quoted 5 lines

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw
In reply to Tvrtko Ursulin
Quoted 6 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

It seems absence of GuC fimrware breaks the boot in a bad way:

https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/?
https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4640/fi-icl-u2/boot0.log

Hmm, for me looks like boot is not prepared to driver probe failure.

I guess this needs to be fixed separately, as CI.BAT **SUCCESS** is really misleading here https://patchwork.freedesktop.org/series/63931/

Quoted 4 lines

Tvrtko Ursulin (2):
Revert "drm/i915/guc: Turn on GuC/HuC auto mode" Revert "drm/i915: Update description of i915.enable_guc modparam"

Maybe instead of reverting above patches we can just apply two fixes:

1. Ignore HuC firmware fetch/load errors
User space is always relying on HUC_STATUS param so we should really never treat HuC failures so seriously.

2. Ignore GuC firmware fetch/load errors if GuC submission was not enabled If we use GuC just to authenticate the HuC, then we can ignore GuC errors,

Later on, once we are closer to re-enabling GuC submission feature, we can add more patches to change current 'fail on GuC error' behavior:

3. Ignore GuC firmware errors if GuC submission was auto-enabled We can still fallback to execlist at the cost of some resources lost for GuC data (but maybe this can be reclaimed as well)

4. Keep driver loaded on GuC fw errors if GuC submission was explicitly enabled There was already some approach for that:

	https://patchwork.freedesktop.org/series/58294/

just needs some refreshing

Michal

Quoted 4 lines
 drivers/gpu/drm/i915/i915_params.c | 2 +-
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

✓ Fi.CI.IGT: success for Revert GuC by default

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: Revert GuC by default
URL : https://patchwork.freedesktop.org/series/63934/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6509_full -> Patchwork_13700_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_13700_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110854])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-iclb6/igt@[email protected]

* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-apl2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-apl7/igt@[email protected]

* igt@i915_pm_rpm@legacy-planes:
- shard-glk: [PASS][5] -> [INCOMPLETE][6] ([fdo#103359] / [k.org#198133])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-glk8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-glk4/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-hsw: [PASS][7] -> [INCOMPLETE][8] ([fdo#103540])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-hsw5/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-hsw1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [PASS][9] -> [FAIL][10] ([fdo#103167]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-iclb2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][11] -> [FAIL][12] ([fdo#108145] / [fdo#110403])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-skl8/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-skl4/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109441]) +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html

#### Possible fixes ####

* igt@gem_eio@unwedge-stress:
- shard-snb: [FAIL][15] ([fdo#109661]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-snb5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-snb7/igt@[email protected]

* igt@gem_mmap_gtt@big-copy:
- shard-iclb: [INCOMPLETE][17] ([fdo#107713] / [fdo#109100]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb7/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-iclb3/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-iclb: [SKIP][19] ([fdo#110933]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-iclb2/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-skl: [INCOMPLETE][21] ([fdo#104108]) -> [PASS][22] +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-skl7/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-skl6/igt@[email protected]

* igt@kms_atomic_transition@plane-toggle-modeset-transition:
- shard-snb: [SKIP][23] ([fdo#109271]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-snb1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-snb1/igt@[email protected]

* igt@kms_color@pipe-c-ctm-blue-to-red:
- shard-skl: [FAIL][25] ([fdo#107201]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-skl8/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-skl10/igt@[email protected]

* igt@kms_flip@dpms-vs-vblank-race:
- shard-kbl: [FAIL][27] ([fdo#103060]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-kbl1/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-kbl2/igt@[email protected]

* igt@kms_flip@modeset-vs-vblank-race-interruptible:
- shard-glk: [FAIL][29] ([fdo#103060]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-glk5/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-glk3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render:
- shard-iclb: [FAIL][31] ([fdo#103167]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render.html

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][33] ([fdo#108566]) -> [PASS][34] +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-apl4/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][35] ([fdo#108145]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-skl2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-skl8/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][37] ([fdo#109642] / [fdo#111068]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb5/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-iclb2/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][39] ([fdo#109441]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

* igt@perf_pmu@rc6:
- shard-iclb: [SKIP][41] ([fdo#110877]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb4/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-iclb5/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rc6_residency@media-rc6-accuracy:
- shard-iclb: [SKIP][43] ([fdo#110933]) -> [SKIP][44] ([fdo#109289])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-iclb7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-skl: [FAIL][45] ([fdo#108040]) -> [FAIL][46] ([fdo#103167]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-skl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/shard-skl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html

[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107201]: https://bugs.freedesktop.org/show_bug.cgi?id=107201
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#110877]: https://bugs.freedesktop.org/show_bug.cgi?id=110877
[fdo#110933]: https://bugs.freedesktop.org/show_bug.cgi?id=110933
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_6509 -> Patchwork_13700

CI_DRM_6509: 2eda05e19db04b001c2b0a9b32bfd43077d5a738 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5103: 45c31e294b9d7874a9a21860f8a89c64bc853df2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13700: 397611e1bc62a8496215128aec25d651b0830751 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13700/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx