WireGuard Snapshot `0.0.20191205` Available

Hello,

A new snapshot, 0.0.20191205, has been tagged in the git repository.

Please note that this snapshot is a snapshot rather than a final release that is considered secure and bug-free. WireGuard is generally thought to be fairly stable, and most likely will not crash your computer (though it may). However, as this is a snapshot, it comes with no guarantees; it is not applicable for CVEs.

With all that said, if you'd like to test this snapshot out, there are a few relevant changes.

== Changes ==

(quoted diff) +0 -7

-   wg-quick: linux: suppress error when finding unused table
 
    This fixes a spurious warning messages seen with recent versions of iproute2
    and kernels.
 
-   wg-quick: linux: ensure postdown hooks execute
-   wg-quick: linux: have remove_iptables return true
-   wg-quick: linux: iptables-* -w is not widely supported
 
    Adding in iptables had some hiccups. For the record, I'm very unhappy about
    having to put any firewalling code into wg-quick(8). We'll of course need to
    support nftables too at some point if this continues. I'm investigating with
    upstream the possibility of adding a sysctl to patch the issue that iptables
    is handling now, so hopefully at somepoint down the line we'll be able to shed
    this dependency once again.
 
-   send: use kfree_skb_list
-   device: prepare skb_list_walk_safe for upstreaming
-   send: avoid touching skb->{next,prev} directly

Suggestions from LKML.

- ipc: make sure userspace communication frees wgdevice

Free things properly on error paths.

This snapshot contains commits from: Jason A. Donenfeld.

As always, the source is available at https://git.zx2c4.com/WireGuard/ and information about the project is available at https://www.wireguard.com/ .

This snapshot is available in compressed tarball form here:
https://git.zx2c4.com/WireGuard/snapshot/WireGuard-0.0.20191205.tar.xz
SHA2-256:
BLAKE2b-256:

A PGP signature of that file decompressed is available here:
https://git.zx2c4.com/WireGuard/snapshot/WireGuard-0.0.20191205.tar.asc
Signing key: AB9942E6D4A4CFC3412620A749FC7012A5DE03AE

If you're a snapshot package maintainer, please bump your package version. If you're a user, the WireGuard team welcomes any and all feedback on this latest snapshot.

Finally, WireGuard development thrives on donations. By popular demand, we have a webpage for this: https://www.wireguard.com/donations/

Thank you,
Jason Donenfeld

Quoted 59 lines · Jason A. Donenfeld

Hello,

A new snapshot, 0.0.20191205, has been tagged in the git repository.

Please note that this snapshot is a snapshot rather than a final release that is considered secure and bug-free. WireGuard is generally thought to be fairly stable, and most likely will not crash your computer (though it may). However, as this is a snapshot, it comes with no guarantees; it is not applicable for CVEs.

With all that said, if you'd like to test this snapshot out, there are a few relevant changes.

== Changes ==

(quoted diff) +0 -7

-   wg-quick: linux: suppress error when finding unused table
 
    This fixes a spurious warning messages seen with recent versions of iproute2
    and kernels.
 
-   wg-quick: linux: ensure postdown hooks execute
-   wg-quick: linux: have remove_iptables return true
-   wg-quick: linux: iptables-* -w is not widely supported
 
    Adding in iptables had some hiccups. For the record, I'm very unhappy about
    having to put any firewalling code into wg-quick(8). We'll of course need to
    support nftables too at some point if this continues. I'm investigating with
    upstream the possibility of adding a sysctl to patch the issue that iptables
    is handling now, so hopefully at somepoint down the line we'll be able to shed
    this dependency once again.
 
-   send: use kfree_skb_list
-   device: prepare skb_list_walk_safe for upstreaming
-   send: avoid touching skb->{next,prev} directly

Suggestions from LKML.

- ipc: make sure userspace communication frees wgdevice

Free things properly on error paths.

This snapshot contains commits from: Jason A. Donenfeld.

As always, the source is available at https://git.zx2c4.com/WireGuard/ and information about the project is available at https://www.wireguard.com/ .

This snapshot is available in compressed tarball form here:
https://git.zx2c4.com/WireGuard/snapshot/WireGuard-0.0.20191205.tar.xz
SHA2-256:
BLAKE2b-256:

A PGP signature of that file decompressed is available here:
https://git.zx2c4.com/WireGuard/snapshot/WireGuard-0.0.20191205.tar.asc
Signing key: AB9942E6D4A4CFC3412620A749FC7012A5DE03AE

If you're a snapshot package maintainer, please bump your package version. If you're a user, the WireGuard team welcomes any and all feedback on this latest snapshot.

Quoted 6 lines

Finally, WireGuard development thrives on donations. By popular demand, we have a webpage for this: https://www.wireguard.com/donations/

Thank you,
Jason Donenfeld

Hi, this release cause coredump on wg-quick down action:

systemd[1]: Stopping WireGuard via wg-quick(8) for wg0... wg-quick[2241]: [#] iptables -D OUTPUT -o wg0 -j ACCEPT wg-quick[2241]: [#] ip -4 rule delete table 51820 wg-quick[2241]: [#] ip -4 rule delete table main suppress_prefixlength 0 wg-quick[2257]: RTNETLINK answers: Address family not supported by protocol wg-quick[2257]: Dump terminated
wg-quick[2258]: RTNETLINK answers: Address family not supported by protocol wg-quick[2258]: Dump terminated
wg-quick[2241]: [#] ip link delete dev wg0
wg-quick[2241]: [#] resolvconf -d wg0 -f

wg-quick[2315]: [#] iptables-restore -n
audit[2316]: ANOM_ABEND auid=4294967295 uid=0 gid=0 ses=4294967295 subj==unconfined pid=2316 comm="iptables-restor" exe="/usr/bin/xtables-nft-multi" sig=11 res=1
wg-quick[2315]: /usr/bin/wg-quick: line 29: 2316 Segmentation fault (core dumped) "$@"
kernel: show_signal_msg: 40 callbacks suppressed
kernel: iptables-restor[2316]: segfault at 0 ip 000064515b66fcc9 sp 00007e6bbcbfb720 error 4 in libnftnl.so.11.2.0[64515b66d000+18000]
kernel: Code: 15 5c 20 02 00 48 85 c0 74 07 48 89 00 48 89 40 08 48 83 c4 08 c3 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 fd 53 48 83 ec 08 <48> 8b 3f 48 8b 1f 48 39 fd 74 2f 0f 1f 40 00 48 8b 47 08 48 89 43 systemd[1]: [email protected]: Succeeded.
systemd[1]: Stopped WireGuard via wg-quick(8) for wg0.

Quoted 11 lines · On Fri, Dec 6, 2019 at 4:11 PM Jordan Glover [email protected]…

Hi, this release cause coredump on wg-quick down action:
systemd[1]: Stopping WireGuard via wg-quick(8) for wg0... wg-quick[2241]: [#] iptables -D OUTPUT -o wg0 -j ACCEPT wg-quick[2241]: [#] ip -4 rule delete table 51820 wg-quick[2241]: [#] ip -4 rule delete table main suppress_prefixlength 0 wg-quick[2257]: RTNETLINK answers: Address family not supported by protocol wg-quick[2257]: Dump terminated
wg-quick[2258]: RTNETLINK answers: Address family not supported by protocol wg-quick[2258]: Dump terminated
wg-quick[2241]: [#] ip link delete dev wg0
wg-quick[2241]: [#] resolvconf -d wg0 -f

Quoted 8 lines

wg-quick[2315]: [#] iptables-restore -n
audit[2316]: ANOM_ABEND auid=4294967295 uid=0 gid=0 ses=4294967295 subj==unconfined pid=2316 comm="iptables-restor" exe="/usr/bin/xtables-nft-multi" sig=11 res=1 wg-quick[2315]: /usr/bin/wg-quick: line 29: 2316 Segmentation fault (core dumped) "$@"
kernel: show_signal_msg: 40 callbacks suppressed
kernel: iptables-restor[2316]: segfault at 0 ip 000064515b66fcc9 sp 00007e6bbcbfb720 error 4 in libnftnl.so.11.2.0[64515b66d000+18000]
kernel: Code: 15 5c 20 02 00 48 85 c0 74 07 48 89 00 48 89 40 08 48 83 c4 08 c3 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 fd 53 48 83 ec 08 <48> 8b 3f 48 8b 1f 48 39 fd 74 2f 0f 1f 40 00 48 8b 47 08 48 89 43 systemd[1]: [email protected]: Succeeded.
systemd[1]: Stopped WireGuard via wg-quick(8) for wg0.

What distro's iptables?

iptables is from Arch Linux iptables-nft package:

$ iptables --version
iptables v1.8.3 (nf_tables)

Quoted 3 lines · On Fri, Dec 6, 2019 at 4:36 PM Jordan Glover [email protected]…

iptables is from Arch Linux iptables-nft package:

$ iptables --version
iptables v1.8.3 (nf_tables)

Does the segfault happen with the latest version in the git repo?

https://git.zx2c4.com/WireGuard/tree/src/tools/wg-quick/linux.bash

Looks like an arch problem or a libnftnl problem. I've made a minimal reproducer:

printf 'filter\nCOMMIT\nraw\nCOMMIT\n*mangle\nCOMMIT\n' | sudo iptables-nft-restore -n

I filed a bug report on Arch: https://bugs.archlinux.org/task/64755
You can follow up with them.

Quoted 8 lines · Jason A. Donenfeld

Looks like an arch problem or a libnftnl problem. I've made a minimal reproducer:

printf 'filter\nCOMMIT\nraw\nCOMMIT\n*mangle\nCOMMIT\n' | sudo iptables-nft-restore -n

I filed a bug report on Arch: https://bugs.archlinux.org/task/64755
You can follow up with them.

I tried to compile myself iptables 1.8.4 which is latest upstream version and have good and bad news:

The good one is your minimal reproducer no longer causes segfault.

The bad one is wg-quick still does:

wg-quick[2325]: [#] iptables-restore -n
audit[2326]: ANOM_ABEND auid=4294967295 uid=0 gid=0 ses=4294967295 subj==unconfined pid=2326 comm="iptables-restor" exe="/usr/bin/xtables-nft-multi" sig=11 res=1
wg-quick[2325]: /usr/bin/wg-quick: line 29: 2326 Segmentation fault (core dumped) "$@"
kernel: show_signal_msg: 40 callbacks suppressed
kernel: iptables-restor[2326]: segfault at 0 ip 000069bb4df13cc9 sp 0000716fcc5b9b30 error 4 in libnftnl.so.11.2.0[69bb4df11000+18000]
kernel: Code: 15 5c 20 02 00 48 85 c0 74 07 48 89 00 48 89 40 08 48 83 c4 08 c3 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 fd 53 48 83 ec 08 <48> 8b 3f 48 8b 1f 48 39 fd 74 2f 0f 1f 40 00 48 8b 47 08 48 89 43

Maybe upstream found and fixed some regression but still missed the other one.