Skip to contentSkip to conversation

security/tomoyo: convert put_page() to put_user_page*()

PATCH In review [email protected] 3 participants 3 messages Aug 5, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 security/tomoyo: convert put_page() to put_user_page*()

From: John Hubbard <[email protected]>

For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages().

This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions").

---
 security/tomoyo/domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
security/tomoyo/domain.c +1 -1
index 8526a0a74023..6887beecfb6e 100644
@@ -931,7 +931,7 @@ bool tomoyo_dump_page(struct linux_binprm *bprm, unsigned long pos,
 	}
 	/* Same with put_arg_page(page) in fs/exec.c */
 #ifdef CONFIG_MMU
-	put_page(page);
+	put_user_page(page);
 #endif
 	return true;
 }
Signature · 1 line
2.22.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · On 2019/08/05 11:26, [email protected] wrote:

From: John Hubbard <[email protected]>

For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages().

Quoted 7 lines

This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions").

Sending to Andrew Morton means you expect this patch to go via -mm tree, don't you? Andrew, please take this patch. Thank you.

#2 lore raw
Quoted 10 lines · Tetsuo Handa
Quoted 9 lines · On 2019/08/05 11:26, [email protected] wrote:

From: John Hubbard <[email protected]>

For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages().

This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions").

Quoted 8 lines
Quoted 4 lines

Sending to Andrew Morton means you expect this patch to go via -mm tree, don't you?

Yes, exactly.

thanks,

Signature · 2 lines
John Hubbard
NVIDIA
Quoted 2 lines

Andrew, please take this patch. Thank you.