Skip to contentSkip to conversation

power_supply: sysfs: ratelimit property read error message

PATCH In review David Lechner 2 participants 3 messages Sep 13, 2018 – Sep 16, 2018 Power supply

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 power_supply: sysfs: ratelimit property read error message

This adds ratelimiting to the message that is printed when reading a power supply property via sysfs returns an error. This will prevent userspace applications from unintentionally dDOSing the system by continuosuly reading a property that returns an error.

---
 drivers/power/supply/power_supply_sysfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/power/supply/power_supply_sysfs.c +2 -1
index 6170ed8b6854..dce24f596160 100644
@@ -131,7 +131,8 @@ static ssize_t power_supply_show_property(struct device *dev,
 				dev_dbg(dev, "driver has no data for `%s' property\n",
 					attr->attr.name);
 			else if (ret != -ENODEV && ret != -EAGAIN)
-				dev_err(dev, "driver failed to report `%s' property: %zd\n",
+				dev_err_ratelimited(dev,
+					"driver failed to report `%s' property: %zd\n",
 					attr->attr.name, ret);
 			return ret;
 		}
Signature · 1 line
2.17.1
#1 lore raw
Quoted 4 lines · David Lechner

This adds ratelimiting to the message that is printed when reading a power supply property via sysfs returns an error. This will prevent userspace applications from unintentionally dDOSing the system by continuosuly reading a property that returns an error.

s/continuosuly/continuously/

Quoted 21 lines
---
  drivers/power/supply/power_supply_sysfs.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/power/supply/power_supply_sysfs.c +2 -1
index 6170ed8b6854..dce24f596160 100644
@@ -131,7 +131,8 @@ static ssize_t power_supply_show_property(struct device *dev,
  				dev_dbg(dev, "driver has no data for `%s' property\n",
  					attr->attr.name);
  			else if (ret != -ENODEV && ret != -EAGAIN)
-				dev_err(dev, "driver failed to report `%s' property: %zd\n",
+				dev_err_ratelimited(dev,
+					"driver failed to report `%s' property: %zd\n",
  					attr->attr.name, ret);
  			return ret;
  		}
#2 lore raw
In reply to David Lechner

Hi,

Quoted 7 lines · David Lechner

This adds ratelimiting to the message that is printed when reading a power supply property via sysfs returns an error. This will prevent userspace applications from unintentionally dDOSing the system by continuosuly reading a property that returns an error.

---

Thanks, queued.

-- Sebastian

Quoted 20 lines
 drivers/power/supply/power_supply_sysfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/power/supply/power_supply_sysfs.c +2 -1
index 6170ed8b6854..dce24f596160 100644
@@ -131,7 +131,8 @@ static ssize_t power_supply_show_property(struct device *dev,
 				dev_dbg(dev, "driver has no data for `%s' property\n",
 					attr->attr.name);
 			else if (ret != -ENODEV && ret != -EAGAIN)
-				dev_err(dev, "driver failed to report `%s' property: %zd\n",
+				dev_err_ratelimited(dev,
+					"driver failed to report `%s' property: %zd\n",
 					attr->attr.name, ret);
 			return ret;
 		}
Signature · 1 line
2.17.1