mtd/powerpc: Remove unused "device-width" property
Subsystems (2)
PATCH v2 3/4 mtd/powerpc: Remove unused "device-width" property
This property is unused. It's not handled as all by the physmap_of driver. So let's remove it from the documentation.
--- Documentation/powerpc/dts-bindings/mtd-physmap.txt | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
Documentation/powerpc/dts-bindings/mtd-physmap.txt +0 -3
@@ -8,8 +8,6 @@ file systems on embedded devices. - reg : Address range of the flash chip - bank-width : Width (in bytes) of the flash bank. Equal to the device width times the number of interleaved chips. - - device-width : (optional) Width of a single flash chip. If - omitted, assumed to be equal to 'bank-width'. - #address-cells, #size-cells : Must be present if the flash has sub-nodes representing partitions (see below). In this case both #address-cells and #size-cells must be equal to 1.
@@ -48,7 +46,6 @@ Example: compatible = "amd,am29lv128ml", "cfi-flash"; reg = <ff000000 01000000>; bank-width = <4>; - device-width = <1>; #address-cells = <1>; #size-cells = <1>; fs@0 {
Signature · 6 lines
1.6.2.2 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 5 lines · Stefan Roese
This property is unused. It's not handled as all by the
physmap_ofdriver. So let's remove it from the documentation.Signed-off-by Stefan Roese <[email protected]>CC Grant Likely <[email protected]>
The device tree describes the hardware, not what Linux happens to do with it at the moment.
I'd rather keep it.
-Scott
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 11 lines · Scott Wood
Quoted 5 lines · Stefan Roese
This property is unused. It's not handled as all by the
physmap_ofdriver. So let's remove it from the documentation.Signed-off-by Stefan Roese <[email protected]>CC Grant Likely <grant.likely-s3s/[email protected]>The device tree describes the hardware, not what Linux happens to do with it at the moment.
I'd rather keep it.
I find it rather confusing to "see" such bindings that are not supported. One could expect something to happen/change after defining this property. So in general I think adding unsupported properties to the Documentation is a bad idea. But that's just my 2 cents. If the general opinion is to keep this property, I'll keep it in of course.
Best regards,
Stefan
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 11 lines · Stefan Roese
Quoted 10 lines · Scott Wood
Quoted 5 lines · Stefan Roese
This property is unused. It's not handled as all by the
physmap_ofdriver. So let's remove it from the documentation.Signed-off-by Stefan Roese <[email protected]>CC Grant Likely <grant.likely-s3s/[email protected]>The device tree describes the hardware, not what Linux happens to do with it at the moment.
Quoted 7 lines
Quoted 1 line
I'd rather keep it.
I find it rather confusing to "see" such bindings that are not supported. One could expect something to happen/change after defining this property. So in general I think adding unsupported properties to the Documentation is a bad idea. But that's just my 2 cents. If the general opinion is to keep this property, I'll keep it in of course.
I say keep it. It is a valid way to describe the hardware regardless of whether or not the driver supports it yet.
g.
Signature · 2 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.