Skip to contentSkip to conversation

mpc8xxx : allow SPI without cs.

PATCH In review Rini van Zetten 6 participants 13 messages Jun 18, 2009 – Jul 3, 2009 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpc8xxx : allow SPI without cs.

This patch adds the possibility to have a spi device without a cs.

For example, the dts file should look something like this:

spi-controller {
       gpios = <&pio1 1 0      /* cs0 */
                0              /* cs1, no GPIO */
                &pio2 2 0>;    /* cs2 */

---
Changes :

	patch against 2.6.30-rc8-mm1
spi/spi_mpc8xxx.c renamed from spi/spi_mpc8xxx.c.org +24 -21
@@ -666,9 +666,10 @@ static void mpc8xxx_spi_cs_control(struc
 	struct mpc8xxx_spi_probe_info *pinfo = to_of_pinfo(dev->platform_data);
 	u16 cs = spi->chip_select;
 	int gpio = pinfo->gpios[cs];
-	bool alow = pinfo->alow_flags[cs];
-
-	gpio_set_value(gpio, on ^ alow);
+	if (gpio != -EEXIST) {
+		bool alow = pinfo->alow_flags[cs];
+		gpio_set_value(gpio, on ^ alow);
+	}
 }
 
 static int of_mpc8xxx_spi_get_chipselects(struct device *dev)
@@ -707,27 +708,29 @@ static int of_mpc8xxx_spi_get_chipselect
 		enum of_gpio_flags flags;
 
 		gpio = of_get_gpio_flags(np, i, &flags);
-		if (!gpio_is_valid(gpio)) {
+		if (gpio_is_valid(gpio)) {
+			ret = gpio_request(gpio, dev_name(dev));
+			if (ret) {
+				dev_err(dev, "can't request gpio #%d: %d\n", i, ret);
+				goto err_loop;
+			}
+
+			pinfo->gpios[i] = gpio;
+			pinfo->alow_flags[i] = flags & OF_GPIO_ACTIVE_LOW;
+
+			ret = gpio_direction_output(pinfo->gpios[i],
+					pinfo->alow_flags[i]);
+			if (ret) {
+				dev_err(dev, "can't set output direction for gpio "
+						"#%d: %d\n", i, ret);
+				goto err_loop;
+			}
+		} else if (gpio == -EEXIST) {
+			pinfo->gpios[i] = -EEXIST;
+		} else {
 			dev_err(dev, "invalid gpio #%d: %d\n", i, gpio);
 			goto err_loop;
 		}
-
-		ret = gpio_request(gpio, dev_name(dev));
-		if (ret) {
-			dev_err(dev, "can't request gpio #%d: %d\n", i, ret);
-			goto err_loop;
-		}
-
-		pinfo->gpios[i] = gpio;
-		pinfo->alow_flags[i] = flags & OF_GPIO_ACTIVE_LOW;
-
-		ret = gpio_direction_output(pinfo->gpios[i],
-					    pinfo->alow_flags[i]);
-		if (ret) {
-			dev_err(dev, "can't set output direction for gpio "
-				"#%d: %d\n", i, ret);
-			goto err_loop;
-		}
 	}
 
 	pdata->max_chipselect = ngpios;

--

Signature · 12 lines
Rini van Zetten
Senior Software Engineer

-------------------------
ARVOO Engineering B.V.
Tasveld 13
3417 XS Montfoort
The Netherlands

E-mail : <mailto:[email protected]> Rini van Zetten

Web : www.arvoo.com
#1 lore raw
Quoted 11 lines · Rini van Zetten

This patch adds the possibility to have a spi device without a cs.

For example, the dts file should look something like this:

spi-controller {
      gpios = <&pio1 1 0      /* cs0 */
               0              /* cs1, no GPIO */
               &pio2 2 0>;    /* cs2 */
Quoted 4 lines

---
Changes :

	patch against 2.6.30-rc8-mm1

Anton,

Can you review and ack this if you are ok with it.

- k

Quoted 85 lines
spi/spi_mpc8xxx.c renamed from spi/spi_mpc8xxx.c.org +4 -3
@@ -666,9 +666,10 @@ static void mpc8xxx_spi_cs_control(struc
 	struct mpc8xxx_spi_probe_info *pinfo = to_of_pinfo(dev- 
 >platform_data);
 	u16 cs = spi->chip_select;
 	int gpio = pinfo->gpios[cs];
-	bool alow = pinfo->alow_flags[cs];
-
-	gpio_set_value(gpio, on ^ alow);
+	if (gpio != -EEXIST) {
+		bool alow = pinfo->alow_flags[cs];
+		gpio_set_value(gpio, on ^ alow);
+	}
 }
 

static int of_mpc8xxx_spi_get_chipselects(struct device *dev)

spi/spi_mpc8xxx.c renamed from spi/spi_mpc8xxx.c.org +20 -19
@@ -707,27 +708,29 @@ static int of_mpc8xxx_spi_get_chipselect
 		enum of_gpio_flags flags;
 
 		gpio = of_get_gpio_flags(np, i, &flags);
-		if (!gpio_is_valid(gpio)) {
+		if (gpio_is_valid(gpio)) {
+			ret = gpio_request(gpio, dev_name(dev));
+			if (ret) {
+				dev_err(dev, "can't request gpio #%d: %d\n", i, ret);
+				goto err_loop;
+			}
+
+			pinfo->gpios[i] = gpio;
+			pinfo->alow_flags[i] = flags & OF_GPIO_ACTIVE_LOW;
+
+			ret = gpio_direction_output(pinfo->gpios[i],
+					pinfo->alow_flags[i]);
+			if (ret) {
+				dev_err(dev, "can't set output direction for gpio "
+						"#%d: %d\n", i, ret);
+				goto err_loop;
+			}
+		} else if (gpio == -EEXIST) {
+			pinfo->gpios[i] = -EEXIST;
+		} else {
 			dev_err(dev, "invalid gpio #%d: %d\n", i, gpio);
 			goto err_loop;
 		}
-
-		ret = gpio_request(gpio, dev_name(dev));
-		if (ret) {
-			dev_err(dev, "can't request gpio #%d: %d\n", i, ret);
-			goto err_loop;
-		}
-
-		pinfo->gpios[i] = gpio;
-		pinfo->alow_flags[i] = flags & OF_GPIO_ACTIVE_LOW;
-
-		ret = gpio_direction_output(pinfo->gpios[i],
-					    pinfo->alow_flags[i]);
-		if (ret) {
-			dev_err(dev, "can't set output direction for gpio "
-				"#%d: %d\n", i, ret);
-			goto err_loop;
-		}
 	}
 
 	pdata->max_chipselect = ngpios;
--
Signature · 13 lines
-- 
Rini van Zetten
Senior Software Engineer

-------------------------
ARVOO Engineering B.V.
Tasveld 13
3417 XS Montfoort
The Netherlands

E-mail : <mailto:[email protected]> Rini van Zetten

Web : www.arvoo.com
#2 lore raw
In reply to Rini van Zetten
Quoted 9 lines · Rini van Zetten

This patch adds the possibility to have a spi device without a cs.

For example, the dts file should look something like this:

spi-controller {
       gpios = <&pio1 1 0      /* cs0 */
                0              /* cs1, no GPIO */
                &pio2 2 0>;    /* cs2 */

Interesting scheme. I guess this is for eSPI controllers that can do their own chip-selects, but we want GPIO chip selects in addition (or in place of built-in ones), correct?

Quoted 4 lines

---
Changes :

	patch against 2.6.30-rc8-mm1

I assume this is v2 already, and I overlooked v1, sorry.

Technically the patch looks OK, but please fix some cosmetics issues.

checkpatch reports:

WARNING: patch prefix 'drivers' exists, appears to be a -p0 patch

WARNING: line over 80 characters
#131: FILE: spi/spi_mpc8xxx.c:714:
+ dev_err(dev, "can't request gpio #%d: %d\n", i, ret);

WARNING: line over 80 characters
#141: FILE: spi/spi_mpc8xxx.c:724:
+ dev_err(dev, "can't set output direction for gpio "

spi/spi_mpc8xxx.c static void mpc8xxx_spi_cs_control(struc · line 671

Quoted 12 lines
spi/spi_mpc8xxx.c renamed from spi/spi_mpc8xxx.c.org +3 -3
@@ -666,9 +666,10 @@ static void mpc8xxx_spi_cs_control(struc
 	struct mpc8xxx_spi_probe_info *pinfo = to_of_pinfo(dev->platform_data);
 	u16 cs = spi->chip_select;
 	int gpio = pinfo->gpios[cs];
-	bool alow = pinfo->alow_flags[cs];
-
-	gpio_set_value(gpio, on ^ alow);
+	if (gpio != -EEXIST) {
+		bool alow = pinfo->alow_flags[cs];
+		gpio_set_value(gpio, on ^ alow);

Please put an empty line after variable declaration.

Thanks!

Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2
#3 lore raw
Quoted 11 lines · Anton Vorontsov
Quoted 9 lines · Rini van Zetten

This patch adds the possibility to have a spi device without a cs.

For example, the dts file should look something like this:

spi-controller {
      gpios = <&pio1 1 0      /* cs0 */
               0              /* cs1, no GPIO */
               &pio2 2 0>;    /* cs2 */
Quoted 3 lines

Interesting scheme. I guess this is for eSPI controllers that can do their own chip-selects, but we want GPIO chip selects in addition (or in place of built-in ones), correct?

That is a good question. What HW is this for (I don't think its for eSPI but I could be wrong).

- k

#4 lore raw

This patch adds the possibility to have a spi device without a cs.

For example, the dts file should look something like this:

spi-controller {
       gpios = <&pio1 1 0      /* cs0 */
                0              /* cs1, no GPIO */
                &pio2 2 0>;    /* cs2 */

---
Changes :

	patch against 2.6.30-rc8-mm1
	style updates
	compiler warning fix

comment :
This feature is needed on our home made board to program an onboard fpga. The fpga needs some special pin toggling to put it in programming mode. That's why we want to skip the usual gpio cs and do the pin toggling in our driver

drivers/spi/spi_mpc8xxx.c +27 -20
index 0fd0ec4..3a367ce 100644
@@ -666,9 +666,12 @@ static void mpc8xxx_spi_cs_control(struct spi_device *spi, bool on)
 	struct mpc8xxx_spi_probe_info *pinfo = to_of_pinfo(dev->platform_data);
 	u16 cs = spi->chip_select;
 	int gpio = pinfo->gpios[cs];
-	bool alow = pinfo->alow_flags[cs];
 
-	gpio_set_value(gpio, on ^ alow);
+	if (gpio != -EEXIST) {
+		bool alow = pinfo->alow_flags[cs];
+
+		gpio_set_value(gpio, on ^ alow);
+	}
 }
 
 static int of_mpc8xxx_spi_get_chipselects(struct device *dev)
@@ -707,27 +710,31 @@ static int of_mpc8xxx_spi_get_chipselects(struct device *dev)
 		enum of_gpio_flags flags;
 
 		gpio = of_get_gpio_flags(np, i, &flags);
-		if (!gpio_is_valid(gpio)) {
+		if (gpio_is_valid(gpio)) {
+			ret = gpio_request(gpio, dev_name(dev));
+			if (ret) {
+				dev_err(dev, "can't request gpio #%d: %d\n",
+							 i, ret);
+				goto err_loop;
+			}
+
+			pinfo->gpios[i] = gpio;
+			pinfo->alow_flags[i] = flags & OF_GPIO_ACTIVE_LOW;
+
+			ret = gpio_direction_output(pinfo->gpios[i],
+					pinfo->alow_flags[i]);
+			if (ret) {
+				dev_err(dev, "can't set output direction for"
+							"gpio #%d: %d\n",
+							i, ret);
+				goto err_loop;
+			}
+		} else if (gpio == -EEXIST) {
+			pinfo->gpios[i] = -EEXIST;
+		} else {
 			dev_err(dev, "invalid gpio #%d: %d\n", i, gpio);
 			goto err_loop;
 		}
-
-		ret = gpio_request(gpio, dev_name(dev));
-		if (ret) {
-			dev_err(dev, "can't request gpio #%d: %d\n", i, ret);
-			goto err_loop;
-		}
-
-		pinfo->gpios[i] = gpio;
-		pinfo->alow_flags[i] = flags & OF_GPIO_ACTIVE_LOW;
-
-		ret = gpio_direction_output(pinfo->gpios[i],
-					    pinfo->alow_flags[i]);
-		if (ret) {
-			dev_err(dev, "can't set output direction for gpio "
-				"#%d: %d\n", i, ret);
-			goto err_loop;
-		}
 	}
 
 	pdata->max_chipselect = ngpios;
#5 lore raw
Quoted 15 lines · Rini van Zetten

This patch adds the possibility to have a spi device without a cs.

For example, the dts file should look something like this:

spi-controller {
      gpios = <&pio1 1 0      /* cs0 */
               0              /* cs1, no GPIO */
               &pio2 2 0>;    /* cs2 */

---
Changes :

	patch against 2.6.30-rc8-mm1
	style updates
	compiler warning fix
Quoted 8 lines

comment :
This feature is needed on our home made board to program an onboard
fpga.
The fpga needs some special pin toggling to put it in programming
mode.
That's why we want to skip the usual gpio cs and do the pin toggling in our driver

Which FSL chip are you using?

- k

#6 lore raw
Quoted 27 lines · Rini van Zetten
Quoted 11 lines

This patch adds the possibility to have a spi device without a cs.

For example, the dts file should look something like this:

spi-controller {
      gpios = <&pio1 1 0      /* cs0 */
               0              /* cs1, no GPIO */
               &pio2 2 0>;    /* cs2 */
Quoted 13 lines

---
Changes :
patch against 2.6.30-rc8-mm1
style updates
compiler warning fix
comment :
This feature is needed on our home made board to program an
onboard fpga.
The fpga needs some special pin toggling to put it in programming
mode.
That's why we want to skip the usual gpio cs and do the pin toggling in our driver

Quoted 1 line

Which FSL chip are you using?

We use the MPC8377E

Rini

Quoted 7 lines

- k

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

Signature · 12 lines
Rini van Zetten
Senior Software Engineer

-------------------------
ARVOO Engineering B.V.
Tasveld 13
3417 XS Montfoort
The Netherlands

E-mail : <mailto:[email protected]> Rini van Zetten

Web : www.arvoo.com
#7 lore raw
In reply to Rini van Zetten
Quoted 12 lines · Rini van Zetten

This patch adds the possibility to have a spi device without a cs.

For example, the dts file should look something like this:

spi-controller {
       gpios = <&pio1 1 0      /* cs0 */
                0              /* cs1, no GPIO */
                &pio2 2 0>;    /* cs2 */

---
Changes :

Quoted 8 lines
	patch against 2.6.30-rc8-mm1
	style updates
	compiler warning fix

comment :
This feature is needed on our home made board to program an onboard fpga. The fpga needs some special pin toggling to put it in programming mode. That's why we want to skip the usual gpio cs and do the pin toggling in our driver

Cool, thanks for the explanation. You may want to put it into the commit message.

[...]

drivers/spi/spi_mpc8xxx.c static int of_mpc8xxx_spi_get_chipselects(struct device *dev) · line 729

Quoted 6 lines
drivers/spi/spi_mpc8xxx.c +6 -0
+			ret = gpio_direction_output(pinfo->gpios[i],
+					pinfo->alow_flags[i]);
+			if (ret) {
+				dev_err(dev, "can't set output direction for"
+							"gpio #%d: %d\n",
+							i, ret);

There is no space between 'for' and 'gpio' words. (also the whole dev_err() may fit into two lines, no need to split it into three lines).

Otherwise looks great. On the next resend feel free to add my

Thanks,

Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2
author Acked-by Anton Vorontsov
#8 lore raw

This patch adds the possibility to have a spi device without a cs.

For example, the dts file should look something like this:

spi-controller {
       gpios = <&pio1 1 0      /* cs0 */
                0              /* cs1, no GPIO */
                &pio2 2 0>;    /* cs2 */

This feature is needed on our home made board to program an onboard fpga. The fpga needs some special pin toggling to put it in programming mode. That's why we want to skip the usual gpio cs and do the pin toggling in our driver

---
Changes :
patch against 2.6.30-rc8-mm1
style updates
compiler warning fix
v4 :
missing space in error text added
splitted lines combined

drivers/spi/spi_mpc8xxx.c +27 -21
index 0fd0ec4..de95790 100644
@@ -666,9 +666,12 @@ static void mpc8xxx_spi_cs_control(struct spi_device *spi, bool on)
 	struct mpc8xxx_spi_probe_info *pinfo = to_of_pinfo(dev->platform_data);
 	u16 cs = spi->chip_select;
 	int gpio = pinfo->gpios[cs];
-	bool alow = pinfo->alow_flags[cs];
 
-	gpio_set_value(gpio, on ^ alow);
+	if (gpio != -EEXIST) {
+		bool alow = pinfo->alow_flags[cs];
+
+		gpio_set_value(gpio, on ^ alow);
+	}
 }
 
 static int of_mpc8xxx_spi_get_chipselects(struct device *dev)
@@ -678,7 +681,7 @@ static int of_mpc8xxx_spi_get_chipselects(struct device *dev)
 	struct mpc8xxx_spi_probe_info *pinfo = to_of_pinfo(pdata);
 	unsigned int ngpios;
 	int i = 0;
-	int ret;
+	int ret = 0;
 
 	ngpios = of_gpio_count(np);
 	if (!ngpios) {
@@ -707,27 +710,30 @@ static int of_mpc8xxx_spi_get_chipselects(struct device *dev)
 		enum of_gpio_flags flags;
 
 		gpio = of_get_gpio_flags(np, i, &flags);
-		if (!gpio_is_valid(gpio)) {
+		if (gpio_is_valid(gpio)) {
+			ret = gpio_request(gpio, dev_name(dev));
+			if (ret) {
+				dev_err(dev, "can't request gpio #%d: %d\n",
+							 i, ret);
+				goto err_loop;
+			}
+
+			pinfo->gpios[i] = gpio;
+			pinfo->alow_flags[i] = flags & OF_GPIO_ACTIVE_LOW;
+
+			ret = gpio_direction_output(pinfo->gpios[i],
+					pinfo->alow_flags[i]);
+			if (ret) {
+				dev_err(dev, "can't set output direction for "
+						"gpio #%d: %d\n", i, ret);
+				goto err_loop;
+			}
+		} else if (gpio == -EEXIST) {
+			pinfo->gpios[i] = -EEXIST;
+		} else {
 			dev_err(dev, "invalid gpio #%d: %d\n", i, gpio);
 			goto err_loop;
 		}
-
-		ret = gpio_request(gpio, dev_name(dev));
-		if (ret) {
-			dev_err(dev, "can't request gpio #%d: %d\n", i, ret);
-			goto err_loop;
-		}
-
-		pinfo->gpios[i] = gpio;
-		pinfo->alow_flags[i] = flags & OF_GPIO_ACTIVE_LOW;
-
-		ret = gpio_direction_output(pinfo->gpios[i],
-					    pinfo->alow_flags[i]);
-		if (ret) {
-			dev_err(dev, "can't set output direction for gpio "
-				"#%d: %d\n", i, ret);
-			goto err_loop;
-		}
 	}
 
 	pdata->max_chipselect = ngpios;
#9 lore raw
Quoted 1 line · Rini van Zetten

This patch adds the possibility to have a spi device without a cs.

Note that there's now the SPI_NO_CS bit in spi_device.mode to describe this situation ... so no "-EEXIST" hackery should ever tempt anyone again.

#10 lore raw
In reply to Kumar Gala

Hello,

Quoted 8 lines · Kumar Gala
Quoted 4 lines · Anton Vorontsov
Quoted 3 lines · Rini van Zetten

This patch adds the possibility to have a spi device without a cs.

That is a good question.  What HW is this for (I don't think its for eSPI but I could be wrong).

We need SPI without CS too on our MPC8313E design.

In our case having a CS line to each slave (18 of them) is too expensive and we use a chip select which piggy backs on another signal.
Once the slave is selected, SPI is used to send large amounts of data.

Regards,

Signature · 1 line
Leon
#11 lore raw
Quoted 4 lines · Leon Woestenberg

Hello,

Quoted 1 line · Kumar Gala

On Jun 18, 2009, at 8:09 AM, Anton Vorontsov wrote:

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines · Rini van Zetten
Quoted 3 lines

This patch adds the possibility to have a spi device without a cs.

That is a good question.  What HW is this for (I don't think its for eSPI but I could be wrong).

We need SPI without CS too on our MPC8313E design.

We do support SPI without CS, but only for one slave device. If there is no CS, technically you can address only one device on a SPI bus.

And apparently Rini's case is not for addressing multiple chips w/o CS lines, it's just some chip-selects need quirks.

Quoted 4 lines

In our case having a CS line to each slave (18 of them) is too expensive and we use a chip select which piggy backs on another signal.
Once the slave is selected, SPI is used to send large amounts of data.

Can you describe it a little bit more? Have you patched the SPI driver to work with your setup?

If you can address 18 slaves w/o chip-select line, I quess you have a CS demuxing bridge somewhere, i.e.

spi-controller {
	/*
	 * no chip-selects from the controller, it can only talk to
	 * one device: the cs demuxing bridge, it is always selected.
	 */
	spi-cs-demuxing-bridge {
		/*
		 * knows how to manage chip-selects (or demux
		 * one chip select line for several slaves)
		 */
		spi-slave {
			reg = <0>;
		};
		...
		spi-slave {
			reg = <17>;
		};
	};
};

Surely we can hide the bridge into the SPI controller driver, but I think it would be beneficial to "factor-out" it to a stand-alone entity, so that other SPI controllers could work with this setup without any modifications (oh and btw, we could also create a bridge called "gpio-chipselects-bridge", and factor out all GPIO stuff from the drivers).

There are two options of how we can factor out chip-select machines... the bad and the ugly. :-) No, the first one is bad, but the second should be OK.

1. We can create full-fledged SPI master bridge drivers, the drivers will just pass-through all SPI IO, but will manage chip-selects. The bad part is that these drivers could degrade performance since they'll have to manage SPI IO, which is unneeded for the pure CS machines.

2. Another option (which I like more), is to create "SPI chip- select machine driver framework", so we could (finally) separate two SPI entities: SPI IO and SPI chip-select machine. CS machines of different flavours: GPIO, built-in, and board-specific (!) with a lot of demuxing magic.

(1) can be implemented trivially, while (2) is a lot of work.

Signature · 7 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev
#12 lore raw
Quoted 10 lines · Anton Vorontsov

Surely we can hide the bridge into the SPI controller driver, but I think it would be beneficial to "factor-out" it to a stand-alone entity, so that other SPI controllers could work with this setup without any modifications (oh and btw, we could also create a bridge called "gpio-chipselects-bridge", and factor out all GPIO stuff from the drivers).

There are two options of how we can factor out chip-select machines... the bad and the ugly. :-) No, the first one is bad, but the second should be OK.

[...]

Quoted 5 lines

2. Another option (which I like more), is to create "SPI chip- select machine driver framework", so we could (finally) separate two SPI entities: SPI IO and SPI chip-select machine. CS machines of different flavours: GPIO, built-in, and board-specific (!) with a lot of demuxing magic.

I agree, I think your option 2 is the way to go. It would probably need to be implemented as some form of logical bridge so that SPI requests don't go straight to the IO driver, but first go through the CS machine so that the CS driver can do funky stuff like inserting or modifying SPI requests before they go to the hardware.

g.

Signature · 2 lines
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.