Skip to contentSkip to conversation

mpc512x uart: testers wanted

DISCUSSION Albrecht Dreß 4 participants 9 messages Mar 7, 2010 – Mar 27, 2010

lore
Share & tools
lore
#0 lore raw

Hi all,

I recently posted a patch which improves the baud rate calculation on the mpc5200b. Following requests by Grant and Wolfram, I added changes which do also affect the mpc512x.

Unfortunately, I don't have access to such a system, but IMHO the code (both the old implementation and my changes) contradict the data sheet. Thus, it would be really helpful if you give give the code a try and report your experiences:

<http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-March/080815.html>

Thanks in advance,
Albrecht.

#1 lore raw

Anatolij, could you please look into this?

Thanks,
g.

On Sun, Mar 7, 2010 at 9:15 AM, Albrecht Dre=DF <[email protected]> w= rote:

Quoted 4 lines

Hi all,

I recently posted a patch which improves the baud rate calculation on the mpc5200b. =A0Following requests by Grant and Wolfram, I added changes whi=

ch do

Quoted 3 lines

also affect the mpc512x.

Unfortunately, I don't have access to such a system, but IMHO the code (b=

oth

Quoted 1 line

the old implementation and my changes) contradict the data sheet. =A0Thus=

, it

Quoted 5 lines

would be really helpful if you give give the code a try and report your experiences:

<http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-March/080815.html>

Quoted 8 lines

Thanks in advance,
Albrecht.

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

#2 lore raw

Hi Grant, Albrecht,

Quoted 1 line · On Sun, 7 Mar 2010 17:45:23 -0700 Grant Likely <[email protected]>…

Anatolij, could you please look into this?

I'll look into this tomorrow, need to finish USB support now. Unfortunately the patch doesn't apply on top of Linus' tree as patches for reworked MPC5121 PSC UART support have been merged. Albrecht, could you please rebase your patch?

BTW, the prescaler /16 or /10 was mentioned in the MPC5121e Preliminary Reference Manual, Rev.0. This seems to be the reason for the usage of /16 prescaler in the code. Since newer manuals only mention /32 or /10 prescaler, this should be corrected/tested. I'll test it later.

Thanks,
Anatolij

#3 lore raw

Hi Anatolij:

Quoted 6 lines
Quoted 1 line

Anatolij, could you please look into this?

I'll look into this tomorrow, need to finish USB support now. Unfortunately the patch doesn't apply on top of Linus' tree as patches for reworked MPC5121 PSC UART support have been merged. Albrecht, could you please rebase your patch?

Against linux/kernel/git/torvalds/linux-2.6.git? Will do that tomorrow... Grant, do you need a patch against Linus' tree, or against a released version, or against your tree?

Quoted 5 lines

BTW, the prescaler /16 or /10 was mentioned in the MPC5121e Preliminary Reference Manual, Rev.0. This seems to be the reason for the usage of /16 prescaler in the code. Since newer manuals only mention /32 or /10 prescaler, this should be corrected/tested. I'll test it later.

Dumb question: do you use U-Boot to boot your processor? If I interpret the code [1] correctly, it also uses the /16 prescaler! Or did I miss something?

Best, Albrecht.

[1] <http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=cpu/mpc512x/serial.c;h=ec2f41bb36dcfa9079d7890866a3aeec716ea124;hb=HEAD>

Sexy Stars bei den Oscars! Fotostrecken und alle aktuellen Infos zu Filmen und Preisen jetzt im Oscar-Special von Arcor.de: http://www.arcor.de/rd/footer.oscar

#4 lore raw

On Mon, Mar 8, 2010 at 9:32 AM, Albrecht Dre=DF <[email protected]> w= rote:

Quoted 10 lines

Hi Anatolij:

Quoted 6 lines
Quoted 1 line

Anatolij, could you please look into this?

I'll look into this tomorrow, need to finish USB support now. Unfortunately the patch doesn't apply on top of Linus' tree as patches for reworked MPC5121 PSC UART support have been merged. Albrecht, could you please rebase your patch?

Against linux/kernel/git/torvalds/linux-2.6.git? =A0Will do that tomorrow=

... =A0Grant, do you need a patch against Linus' tree, or against a release= d version, or against your tree?

I won't be picking this up until after -rc1 or -rc2 anyway, and it won't get merged into Linus' tree until the 2.6.35 merge window, so I'm not going to even touch it for a couple of weeks. When I do get to it I'll need it against Linus' tree.

g.

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

#5 lore raw

On Mon, Mar 8, 2010 at 9:53 AM, Grant Likely <[email protected]> wr= ote:

Quoted 1 line

On Mon, Mar 8, 2010 at 9:32 AM, Albrecht Dre=DF <[email protected]>=

Quoted 10 lines · wrote:
Quoted 10 lines

Hi Anatolij:

Quoted 6 lines
Quoted 1 line

Anatolij, could you please look into this?

I'll look into this tomorrow, need to finish USB support now. Unfortunately the patch doesn't apply on top of Linus' tree as patches for reworked MPC5121 PSC UART support have been merged. Albrecht, could you please rebase your patch?

Against linux/kernel/git/torvalds/linux-2.6.git? =A0Will do that tomorro=

w... =A0Grant, do you need a patch against Linus' tree, or against a releas= ed version, or against your tree?

Quoted 5 lines

I won't be picking this up until after -rc1 or -rc2 anyway, and it won't get merged into Linus' tree until the 2.6.35 merge window, so I'm not going to even touch it for a couple of weeks. =A0When I do get to it I'll need it against Linus' tree.

Ping? I was looking at this tonight but it of course doesn't apply. Have you gotten a chance to rebase this patch yet?

Thanks,
g.

#6 lore raw

Dear Grant:

Am 27.03.10 03:10 schrieb(en) Grant Likely:

Quoted 1 line

Ping? I was looking at this tonight but it of course doesn't apply. Have you gotten a chance to rebase this patch yet?

Thanks for the reminder - I sent Anatolij the rebased patch off-list (as I didn't want to clutter the list again with the same patch) 2½ weeks ago, but didn't get any testing results from him yet. If you want to see the patch in the list, too, please just drop me a note.

The patch works just fine for me on the 5200B, but IMHO it doesn't make sense to merge it before Anatolij could comment on the 512x part.

Cheers, Albrecht.

#7 lore raw
Quoted 5 lines · On Sat, Mar 27, 2010 at 7:29 AM, Albrecht Dre=DF <[email protected]> =…

Dear Grant:

Am 27.03.10 03:10 schrieb(en) Grant Likely:

Quoted 2 lines

Ping? =A0I was looking at this tonight but it of course doesn't apply. H=

ave

Quoted 3 lines
Quoted 1 line

you gotten a chance to rebase this patch yet?

Thanks for the reminder - I sent Anatolij the rebased patch off-list (as =

I

Quoted 1 line

didn't want to clutter the list again with the same patch) 2=BD weeks ago=

, but

Quoted 1 line

didn't get any testing results from him yet. =A0If you want to see the pa=

tch

Quoted 1 line

in the list, too, please just drop me a note.

Yes, please post it to the list. Then I can also add it to my testing bran= ch.

g.

#8 lore raw
In reply to Albrecht Dreß

Dear Albrecht =?iso-8859-1?b?RHJl3w==?=,

Quoted 5 lines · In message <1269696561.2245.2@antares> you wrote:
Quoted 1 line

Thanks for the reminder - I sent Anatolij the rebased patch off-list (as I didn't want to clutter the list again with the same patch) 2½ weeks ago, but didn't get any testing results from him yet. If you want to see the patch in the list, too, please just drop me a note.

Anatolij is on vacation until mid April.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
"If that makes any sense to you, you have a big problem."
                                  -- C. Durance, Computer Science 234