Skip to contentSkip to conversation

drm/mcde: dsi: Fix return value check in mcde_dsi_bind()

PATCH Markus Elfring 1 participant 1 message Apr 30, 2020 Kernel janitors

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines

The of_drm_find_bridge() function returns NULL on error, it doesn't return error pointers so this check doesn't work.

How do you think about a wording variant like the following?

Change description:
An error pointer check was performed after a call of the function “of_drm_find_bridge” despite of the detail that failures are indicated for the bridge search by null pointers instead.
Thus adjust a check for the failure predicate and the corresponding exception handling.

Regards,
Markus