staging: rtl8723bs: remove MGS_8192C trace logs
cover staging: rtl8723bs: remove MGS_8192C trace logs
This patchset removes the tracing private macro MSG_8192C.
This macro belongs to a redundant driver specific tracing macro family.
Moreover the default behaviour is _do nothing_ as to activate it, it's necessary to hardcode a DEBUG symbol definition.
Fabio Aiuto (3):
staging: rtl8723bs: remove all MSG_8192C logs
staging: rtl8723bs: remove commented out MSG_8192C log
staging: rtl8723bs: remove MSG_8192C macro definitions
drivers/staging/rtl8723bs/hal/odm.c | 3 --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ---- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ---- drivers/staging/rtl8723bs/include/rtw_debug.h | 6 ------ 4 files changed, 17 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/3 staging: rtl8723bs: remove all MSG_8192C logs
remove all MSG_8192C logs.
MSG_8192C is a private trace mechanism macro and is deactivated. (i.e. the default behaviour is _do nothing_)
The only way to activate it is to manually define a debug symbol.
So just remove it.
--- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ---- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ---- 2 files changed, 8 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0 -4
@@ -1787,8 +1787,6 @@ static struct hal_version ReadChipVersion8723B(struct adapter *padapter)else pHalData->rf_type =RF_1T1R ; -MSG_8192C ("RF_Type is %x!!\n" , pHalData->rf_type); -return ChipVersion; }
@@ -2139,8 +2137,6 @@ u8 GetEEPROMSize8723B(struct adapter *padapter)/* 6: EEPROM used is 93C46, 4: boot from E-Fuse. */ size = (cr &BOOT_FROM_EEPROM ) ?6 :4 ; -MSG_8192C ("EEPROM type is %s\n" , size ==4 ?"E-FUSE" :"93C46" ); -return size; }
drivers/staging/rtl8723bs/hal/sdio_halinit.c +0 -4
@@ -1175,7 +1175,6 @@ static s32 _ReadAdapterInfo8723BS(struct adapter *padapter) val8 =rtw_read8 (padapter,0x4e ); -MSG_8192C ("%s, 0x4e = 0x%x\n" , __func__, val8); val8 |=BIT (6 );rtw_write8 (padapter,0x4e , val8);
@@ -1192,9 +1191,6 @@ static s32 _ReadAdapterInfo8723BS(struct adapter *padapter)CardDisableRTL8723BSdio (padapter);/* for the power consumption issue, wifi ko module is loaded during booting, but wifi GUI is off */ } - -MSG_8192C ("<==== _ReadAdapterInfo8723BS in %d ms\n" ,jiffies_to_msecs (jiffies - start)); -return _SUCCESS; }
Signature · 1 line
2.20.1
PATCH 2/3 staging: rtl8723bs: remove commented out MSG_8192C log
In reply to Fabio Aiutoremove commented out MSG_8192C log.
MSG_8192C is a private trace mechanism macro and is deactivated. (i.e. the default behaviour is _do nothing_)
The only way to activate it is to manually define a debug symbol.
So just remove it.
--- drivers/staging/rtl8723bs/hal/odm.c | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/rtl8723bs/hal/odm.c +0 -3
@@ -776,9 +776,6 @@ void odm_TXPowerTrackingInit(struct dm_odm_t *pDM_Odm)else pdmpriv->TxPowerTrackControl = false; - -/* MSG_8192C("pdmpriv->TxPowerTrackControl = %d\n", pdmpriv->TxPowerTrackControl); */ -/* pDM_Odm->RFCalibrateInfo.TxPowerTrackControl = true; */ pDM_Odm->RFCalibrateInfo.ThermalValue = pHalData->EEPROMThermalMeter; pDM_Odm->RFCalibrateInfo.ThermalValue_IQK = pHalData->EEPROMThermalMeter;
Signature · 1 line
2.20.1
PATCH 3/3 staging: rtl8723bs: remove MSG_8192C macro definitions
In reply to Fabio Aiutoremove obsolete MSG_8192C macro definitions.
MSG_8192C is a private trace mechanism macro and is deactivated. (i.e. the default behaviour is _do nothing_)
The only way to activate it is to manually define a debug symbol.
So just remove it.
--- drivers/staging/rtl8723bs/include/rtw_debug.h | 6 ------ 1 file changed, 6 deletions(-)
drivers/staging/rtl8723bs/include/rtw_debug.h +0 -6
@@ -131,7 +131,6 @@#define _MODULE_DEFINE_ _module_efuse_#endif -#define MSG_8192C (x, ...) do {} while (0)#define DBG_8192C (x, ...) do {} while (0)#define DBG_871X_LEVEL (x, ...) do {} while (0)
@@ -196,11 +195,6 @@#ifdef DEBUG #if defined(_dbgdump) -#undef MSG_8192C -#define MSG_8192C (...) do {\ - _dbgdump(DRIVER_PREFIX __VA_ARGS__);\ - } while (0) -#undef DBG_8192C#define DBG_8192C (...) do {\ _dbgdump(DRIVER_PREFIX __VA_ARGS__);\
Signature · 1 line
2.20.1