Skip to contentSkip to conversation

linux-aio: increasing MAX_EVENTS to a larger hardcoded value

PATCH Applied Wangyong 2 participants 2 messages Jan 7, 2020 – Jan 9, 2020 Block layer

lore
Share & tools
lore

Wangyong

author
#0 lore raw

PATCH 1/1 linux-aio: increasing MAX_EVENTS to a larger hardcoded value

Since commit 6040aedddb5f474a9c2304b6a432a652d82b3d3c "virtio-blk:
make queue size configurable",if the user set the queue size to more than 128 ,it will not take effect. That's because linux aio's maximum outstanding requests at a time is always less than or equal to 128.

This patch simply increase MAX_EVENTS to a larger hardcoded value of 1024 as a shortterm fix.

---
 block/linux-aio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
block/linux-aio.c +1 -1
index c7eca9a256..91204a25a2 100644
@@ -26,7 +26,7 @@
  *      than this we will get EAGAIN from io_submit which is communicated to
  *      the guest as an I/O error.
  */
-#define MAX_EVENTS 128
+#define MAX_EVENTS 1024
 
 struct qemu_laiocb {
     Coroutine *co;

--
2.12.1.windows.1

#1 lore raw
Quoted 6 lines · Wangyong

Since commit 6040aedddb5f474a9c2304b6a432a652d82b3d3c "virtio-blk:
make queue size configurable",if the user set the queue size to more than 128 ,it will not take effect. That's because linux aio's maximum outstanding requests at a time is always less than or equal to 128.

Quoted 7 lines

This patch simply increase MAX_EVENTS to a larger hardcoded value of 1024 as a shortterm fix.

---
 block/linux-aio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

We discussed that long-terms solutions would take into account the queue size of the emulated storage controllers associated with this AioContext, but this is a first step that will improve performance.

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan