Skip to contentSkip to conversation

selftests: net: do not detect PPPoX loopback

PATCH Applied Qingfang Deng 3 participants 3 messages Jun 3 – Jun 15

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests: net: do not detect PPPoX loopback

By default, pppd attempts to detect loopbacks on the underlying interface using a pseudo-randomly generated magic number and checks if the same value is received. The seed for the PRNG is a hash of hostname XOR current time XOR pid, which is likely to collide on NIPA, causing false positives. Disable magic number generation.

Fixes 7af2a94f4dcf ("selftests: net: add tests for PPPoL2TP")
---
 tools/testing/selftests/net/ppp/pppoe-server-options | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/net/ppp/pppoe-server-options +1 -0
index 66c8c9d319e9..cd586be7061b 100644
@@ -1,2 +1,3 @@
 noauth
 noipdefault
+nomagic
Signature · 1 line
2.43.0
#1 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 11 lines · On Wed, 3 Jun 2026 14:17:44 +0800 you wrote:

By default, pppd attempts to detect loopbacks on the underlying interface using a pseudo-randomly generated magic number and checks if the same value is received. The seed for the PRNG is a hash of hostname XOR current time XOR pid, which is likely to collide on NIPA, causing false positives. Disable magic number generation.

Fixes 7af2a94f4dcf ("selftests: net: add tests for PPPoL2TP")

[...]

Here is the summary with links:
- [net-next] selftests: net: do not detect PPPoX loopback

    https://git.kernel.org/netdev/net-next/c/2eb9a81a7f73

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#2 lore raw
In reply to Qingfang Deng

Hi Qingfang,

Quoted 5 lines · Qingfang Deng

By default, pppd attempts to detect loopbacks on the underlying interface using a pseudo-randomly generated magic number and checks if the same value is received. The seed for the PRNG is a hash of hostname XOR current time XOR pid, which is likely to collide on NIPA, causing false positives. Disable magic number generation.

Thank you for the fix!

It looks like the test is no longer flaky [1], so I just unignored it on NIPA.

[1] https://netdev.bots.linux.dev/contest.html?skip=0&test=pppol2tp-sh

Cheers,
Matt