fsi/sbefifo: Add dependency on OF_ADDRESS
PATCH 1/1 fsi/sbefifo: Add dependency on OF_ADDRESS
The driver calls of_platform_device_create() which is only available if OF_ADDRESS is enabled. When building sparc64 images, this results in
ERROR: "of_platform_device_create" [drivers/fsi/fsi-sbefifo.ko] undefined!
--- drivers/fsi/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/fsi/Kconfig +1 -0
@@ -34,6 +34,7 @@ config FSI_SCOM config FSI_SBEFIFO tristate "SBEFIFO FSI client device driver" + depends on OF_ADDRESS ---help--- This option enables an FSI based SBEFIFO device driver. The SBEFIFO is a pipe-like FSI device for communicating with the self boot engine
Signature · 1 line
2.7.4
Quoted 9 lines · Guenter Roeck
The driver calls
of_platform_device_create()which is only available ifOF_ADDRESSis enabled. When building sparc64 images, this results inERROR: "
of_platform_device_create" [drivers/fsi/fsi-sbefifo.ko] undefined!Fixes 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")Cc Benjamin Herrenschmidt <[email protected]>Signed-off-by Guenter Roeck <[email protected]>
Thanks Guenter ! I'll include this into the fsi tree.
(I was wondering what that kbuild report on sparc64 was about... I must have misread the code, I didn't realize of_platform_device_create wasn't under CONFIG_OF alone).
Cheers,
Ben.
Quoted 16 lines
--- drivers/fsi/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/fsi/Kconfig +1
-0@@ -34,6 +34,7 @@ config FSI_SCOM config FSI_SBEFIFO tristate "SBEFIFO FSI client device driver" + depends on OF_ADDRESS ---help--- This option enables an FSI based SBEFIFO device driver. The SBEFIFO is a pipe-like FSI device for communicating with the self boot engine
Quoted 11 lines · Benjamin Herrenschmidt
Quoted 9 lines · Guenter Roeck
The driver calls
of_platform_device_create()which is only available ifOF_ADDRESSis enabled. When building sparc64 images, this results inERROR: "
of_platform_device_create" [drivers/fsi/fsi-sbefifo.ko] undefined!Fixes 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")Cc Benjamin Herrenschmidt <[email protected]>Signed-off-by Guenter Roeck <[email protected]>
Quoted 6 lines
Thanks Guenter ! I'll include this into the fsi tree.
(I was wondering what that kbuild report on sparc64 was about... I must have misread the code, I didn't realize
of_platform_device_createwasn't underCONFIG_OFalone).
No worries; pretty much everyone using one of the affected functions falls into that trap.
Guenter