net: ravb: Avoid unsupported internal delay mode for R-Car E3/D3
PATCH 1/1 net: ravb: Avoid unsupported internal delay mode for R-Car E3/D3
According to the R-Car Gen3 Hardware Manual Rev 1.50 of Nov 30, 2018, the TX clock internal delay mode isn't supported on R-Car E3 (r8a77990) or D3 (r8a77995).
Avoid setting the APSR:TDM bit on these SoCs. Moreover, only set APSR:TDM when the DT explicitly specifies RGMII ID or TXID mode instead of setting it unconditionally when the PHY link speed is 1000 Mbit/s.
--- drivers/net/ravb.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/net/ravb.c +10 -3
@@ -46,6 +46,8 @@#define CSR_OPS 0x0000000F#define CSR_OPS_CONFIG BIT(1) +#define APSR_TDM BIT(14) +#define TCCR_TSRQ0 BIT(0)#define RFLR_RFL_MIN 0x05EE
@@ -389,9 +391,14 @@ static int ravb_dmac_init(struct udevice *dev)/* FIFO size set */ writel (0x00222210 , eth->iobase +RAVB_REG_TGC ); -/* Delay CLK: 2ns */ -if (pdata->max_speed ==1000 ) -writel (BIT (14 ), eth->iobase +RAVB_REG_APSR ); +/* Delay CLK: 2ns (not applicable on R-Car E3/D3) */ +if ((rmobile_get_cpu_type () ==RMOBILE_CPU_TYPE_R8A77990 ) || + (rmobile_get_cpu_type () ==RMOBILE_CPU_TYPE_R8A77995 )) +return 0 ; + +if ((pdata->phy_interface ==PHY_INTERFACE_MODE_RGMII_ID ) || + (pdata->phy_interface ==PHY_INTERFACE_MODE_RGMII_TXID )) +writel (APSR_TDM , eth->iobase +RAVB_REG_APSR );return 0 ; }
Signature · 1 line
2.20.1
PATCH 1/1 net: ravb: Avoid unsupported internal delay mode for R-Car E3/D3
Quoted 8 lines · Marek Vasut
According to the R-Car Gen3 Hardware Manual Rev 1.50 of Nov 30, 2018, the TX clock internal delay mode isn't supported on R-Car E3 (r8a77990) or D3 (r8a77995).
Avoid setting the APSR:TDM bit on these SoCs. Moreover, only set APSR:TDM when the DT explicitly specifies RGMII ID or TXID mode instead of setting it unconditionally when the PHY link speed is 1000 Mbit/s.
We just ran into an issue with a very similar patch. It blocked my tree being merged for a few months. Finally got to the bottom of it.
https://patchwork.ozlabs.org/patch/1096572/
Are you sure there are no boards depending on the broken DT, like the 335-evm was?
Quoted 46 lines
Signed-off-by Marek Vasut <[email protected]>Cc Nobuhiro Iwamatsu <[email protected]>Cc Joe Hershberger <[email protected]>--- drivers/net/ravb.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)drivers/net/ravb.c +10
-4@@ -46,6 +46,8 @@#define CSR_OPS 0x0000000F#define CSR_OPS_CONFIG BIT(1) +#define APSR_TDM BIT(14) +#define TCCR_TSRQ0 BIT(0)#define RFLR_RFL_MIN 0x05EE@@ -389,9 +391,14 @@ static int ravb_dmac_init(struct udevice *dev)/* FIFO size set */ writel (0x00222210 , eth->iobase +RAVB_REG_TGC ); -/* Delay CLK: 2ns */ -if (pdata->max_speed ==1000 ) -writel (BIT (14 ), eth->iobase +RAVB_REG_APSR ); +/* Delay CLK: 2ns (not applicable on R-Car E3/D3) */ +if ((rmobile_get_cpu_type () ==RMOBILE_CPU_TYPE_R8A77990 ) || + (rmobile_get_cpu_type () ==RMOBILE_CPU_TYPE_R8A77995 )) +return 0 ; + +if ((pdata->phy_interface ==PHY_INTERFACE_MODE_RGMII_ID ) || + (pdata->phy_interface ==PHY_INTERFACE_MODE_RGMII_TXID )) +writel (APSR_TDM , eth->iobase +RAVB_REG_APSR );return 0 ; } --2.20.1
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
PATCH 1/1 net: ravb: Avoid unsupported internal delay mode for R-Car E3/D3
Quoted 10 lines · Joe Hershberger
Quoted 8 lines · Marek Vasut
According to the R-Car Gen3 Hardware Manual Rev 1.50 of Nov 30, 2018, the TX clock internal delay mode isn't supported on R-Car E3 (r8a77990) or D3 (r8a77995).
Avoid setting the APSR:TDM bit on these SoCs. Moreover, only set APSR:TDM when the DT explicitly specifies RGMII ID or TXID mode instead of setting it unconditionally when the PHY link speed is 1000 Mbit/s.
Quoted 6 lines
We just ran into an issue with a very similar patch. It blocked my tree being merged for a few months. Finally got to the bottom of it.
https://patchwork.ozlabs.org/patch/1096572/Are you sure there are no boards depending on the broken DT, like the 335-evm was?
I cannot be sure, but the boards which are supported and tested work fine. If someone runs into any issue. they can raise them, and we'll solve the problem when we come to that bridge.
Signature · 2 lines
Best regards, Marek Vasut
PATCH 1/1 net: ravb: Avoid unsupported internal delay mode for R-Car E3/D3
Quoted 16 lines · Marek Vasut
Quoted 14 lines · Joe Hershberger
Quoted 8 lines · Marek Vasut
According to the R-Car Gen3 Hardware Manual Rev 1.50 of Nov 30, 2018, the TX clock internal delay mode isn't supported on R-Car E3 (r8a77990) or D3 (r8a77995).
Avoid setting the APSR:TDM bit on these SoCs. Moreover, only set APSR:TDM when the DT explicitly specifies RGMII ID or TXID mode instead of setting it unconditionally when the PHY link speed is 1000 Mbit/s.
We just ran into an issue with a very similar patch. It blocked my tree being merged for a few months. Finally got to the bottom of it.
https://patchwork.ozlabs.org/patch/1096572/
Quoted 6 lines
Quoted 2 lines
Are you sure there are no boards depending on the broken DT, like the 335-evm was?
I cannot be sure, but the boards which are supported and tested work fine. If someone runs into any issue. they can raise them, and we'll solve the problem when we come to that bridge.
The point that came up is that the DT is considered the ABI, so it shouldn't break / change behavior. Just wanted to make sure you were aware.
Thanks,
-Joe
PATCH 1/1 net: ravb: Avoid unsupported internal delay mode for R-Car E3/D3
Quoted 20 lines · Joe Hershberger
Quoted 19 lines · Marek Vasut
Quoted 16 lines · Joe Hershberger
Quoted 8 lines · Marek Vasut
According to the R-Car Gen3 Hardware Manual Rev 1.50 of Nov 30, 2018, the TX clock internal delay mode isn't supported on R-Car E3 (r8a77990) or D3 (r8a77995).
Avoid setting the APSR:TDM bit on these SoCs. Moreover, only set APSR:TDM when the DT explicitly specifies RGMII ID or TXID mode instead of setting it unconditionally when the PHY link speed is 1000 Mbit/s.
We just ran into an issue with a very similar patch. It blocked my tree being merged for a few months. Finally got to the bottom of it.
https://patchwork.ozlabs.org/patch/1096572/Are you sure there are no boards depending on the broken DT, like the 335-evm was?
Quoted 7 lines
Quoted 3 lines
I cannot be sure, but the boards which are supported and tested work fine. If someone runs into any issue. they can raise them, and we'll solve the problem when we come to that bridge.
The point that came up is that the DT is considered the ABI, so it shouldn't break / change behavior. Just wanted to make sure you were aware.
I am, but I still prefer for the ethernet to work correctly.
Signature · 2 lines
Best regards, Marek Vasut
PATCH 1/1 net: ravb: Avoid unsupported internal delay mode for R-Car E3/D3
Quoted 26 lines · Marek Vasut
Quoted 24 lines · Joe Hershberger
Quoted 22 lines · Marek Vasut
Quoted 10 lines · Joe Hershberger
Quoted 8 lines · Marek Vasut
According to the R-Car Gen3 Hardware Manual Rev 1.50 of Nov 30, 2018, the TX clock internal delay mode isn't supported on R-Car E3 (r8a77990) or D3 (r8a77995).
Avoid setting the APSR:TDM bit on these SoCs. Moreover, only set APSR:TDM when the DT explicitly specifies RGMII ID or TXID mode instead of setting it unconditionally when the PHY link speed is 1000 Mbit/s.
Quoted 6 lines
We just ran into an issue with a very similar patch. It blocked my tree being merged for a few months. Finally got to the bottom of it.
https://patchwork.ozlabs.org/patch/1096572/Are you sure there are no boards depending on the broken DT, like the 335-evm was?
I cannot be sure, but the boards which are supported and tested work fine. If someone runs into any issue. they can raise them, and we'll solve the problem when we come to that bridge.
Quoted 5 lines
Quoted 3 lines
The point that came up is that the DT is considered the ABI, so it shouldn't break / change behavior. Just wanted to make sure you were aware.
I am, but I still prefer for the ethernet to work correctly.
Is the whole patch required to fix it? The commit log doesn't make that clear. "Moreover, only set APSR:TDM when the DT explicitly specifies RGMII ID or TXID mode instead of setting it unconditionally when the PHY link speed is 1000 Mbit/s."
Thanks,
-Joe
Quoted 8 lines
--
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
PATCH 1/1 net: ravb: Avoid unsupported internal delay mode for R-Car E3/D3
Quoted 31 lines · Joe Hershberger
Quoted 30 lines · Marek Vasut
Quoted 27 lines · Joe Hershberger
Quoted 16 lines · Marek Vasut
Quoted 14 lines · Joe Hershberger
Quoted 8 lines · Marek Vasut
According to the R-Car Gen3 Hardware Manual Rev 1.50 of Nov 30, 2018, the TX clock internal delay mode isn't supported on R-Car E3 (r8a77990) or D3 (r8a77995).
Avoid setting the APSR:TDM bit on these SoCs. Moreover, only set APSR:TDM when the DT explicitly specifies RGMII ID or TXID mode instead of setting it unconditionally when the PHY link speed is 1000 Mbit/s.
We just ran into an issue with a very similar patch. It blocked my tree being merged for a few months. Finally got to the bottom of it.
https://patchwork.ozlabs.org/patch/1096572/Quoted 6 lines
Quoted 2 lines
Are you sure there are no boards depending on the broken DT, like the 335-evm was?
I cannot be sure, but the boards which are supported and tested work fine. If someone runs into any issue. they can raise them, and we'll solve the problem when we come to that bridge.
The point that came up is that the DT is considered the ABI, so it shouldn't break / change behavior. Just wanted to make sure you were aware.
Quoted 6 lines
Quoted 1 line
I am, but I still prefer for the ethernet to work correctly.
Is the whole patch required to fix it? The commit log doesn't make that clear. "Moreover, only set APSR:TDM when the DT explicitly specifies RGMII ID or TXID mode instead of setting it unconditionally when the PHY link speed is 1000 Mbit/s."
Yep, it's a port of similar patch from Linux.
Signature · 2 lines
Best regards, Marek Vasut
PATCH 1/1 net: ravb: Avoid unsupported internal delay mode for R-Car E3/D3
In reply to Marek VasutQuoted 5 lines · Marek Vasut
According to the R-Car Gen3 Hardware Manual Rev 1.50 of Nov 30, 2018, the TX clock internal delay mode isn't supported on R-Car E3 (r8a77990) or D3 (r8a77995).
Quoted 7 lines
Avoid setting the APSR:TDM bit on these SoCs. Moreover, only set APSR:TDM when the DT explicitly specifies RGMII ID or TXID mode instead of setting it unconditionally when the PHY link speed is 1000 Mbit/s.
Signed-off-by Marek Vasut <[email protected]>Cc Nobuhiro Iwamatsu <[email protected]>Cc Joe Hershberger <[email protected]>