Skip to contentSkip to conversation

classes/populate_sdk_base: Add setscene tasks

PATCH In review Joshua Watt 2 participants 2 messages Oct 22, 2021 – Oct 23, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 classes/populate_sdk_base: Add setscene tasks

do_populate_sdk was added to SSTATETASKS, but had no _setscene task created to allow it to actually run from sstate. Add it so that SDKs can be restored from sstate.

Note that like do_image_complete, do_populate_sdk is marked with SSTATE_SKIP_CREATION by default so sstate is not used for them; adding this task will allow it to work if the user overrides this default though.

---
 meta/classes/populate_sdk_base.bbclass | 4 ++++
 1 file changed, 4 insertions(+)
meta/classes/populate_sdk_base.bbclass +4 -0
index 49e166e697..fafdd96749 100644
@@ -179,6 +179,10 @@ do_populate_sdk[cleandirs] = "${SDKDEPLOYDIR}"
 do_populate_sdk[sstate-inputdirs] = "${SDKDEPLOYDIR}"
 do_populate_sdk[sstate-outputdirs] = "${SDK_DEPLOY}"
 do_populate_sdk[stamp-extra-info] = "${MACHINE_ARCH}${SDKMACHINE}"
+python do_populate_sdk_setscene () {
+    sstate_setscene(d)
+}
+addtask do_populate_sdk_setscene
 
 PSEUDO_IGNORE_PATHS .= ",${SDKDEPLOYDIR},${WORKDIR}/oe-sdk-repo,${WORKDIR}/sstate-build-populate_sdk"
 
Signature · 1 line
2.33.0
#1 lore raw
Quoted 19 lines · Joshua Watt

do_populate_sdk was added to SSTATETASKS, but had no _setscene task created to allow it to actually run from sstate. Add it so that SDKs can be restored from sstate.

Note that like do_image_complete, do_populate_sdk is marked with SSTATE_SKIP_CREATION by default so sstate is not used for them; adding this task will allow it to work if the user overrides this default though.

---
 meta/classes/populate_sdk_base.bbclass | 4 ++++
 1 file changed, 4 insertions(+)
meta/classes/populate_sdk_base.bbclass +0 -0
index 49e166e697..fafdd96749 100644

meta/classes/populate_sdk_base.bbclass do_populate_sdk[cleandirs] = "${SDKDEPLOYDIR}" · line 187

Quoted 9 lines
meta/classes/populate_sdk_base.bbclass +4 -0
@@ -179,6 +179,10 @@ do_populate_sdk[cleandirs] = "${SDKDEPLOYDIR}"
 do_populate_sdk[sstate-inputdirs] = "${SDKDEPLOYDIR}"
 do_populate_sdk[sstate-outputdirs] = "${SDK_DEPLOY}"
 do_populate_sdk[stamp-extra-info] = "${MACHINE_ARCH}${SDKMACHINE}"
+python do_populate_sdk_setscene () {
+    sstate_setscene(d)
+}
+addtask do_populate_sdk_setscene
 
 

That was deliberately missing since we don't use/need it. I've merged this since I guess you want to use it but it isn't something I particularly want to support. It simply won't work for eSDK either.

Cheers,

Richard