spi: hisi-kunpeng: Fixed the wrong debugfs node name in hisi_spi debugfs initialization
Quoted 23 lines
In
hisi_spi_debugfs_init, spi controller pointer is calculated bycontainer_ofmacro, and the member ishs->dev. But the host pointer cannot be calculated offset directly by this, becausehs->devpoints to the device in platformdevice(pdev->dev), and it is > thehost->dev.parentpoints to thepdev->dev, which is set in__spi_alloc_controller.In this patch, this issues is fixed by getting the
spi_controllerdata frompdev->dev->driver_datadirectly,driver_datapoints to the spi controller data in the probe stage.Signed-off-by Devyn Liu <[email protected]>--- drivers/spi/spi-hisi-kunpeng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/spi/spi-hisi-kunpeng.c +1
-2@@ -164,7 +164,7 @@ static int hisi_spi_debugfs_init(struct hisi_spi *hs)struct spi_controller *host; - host = container_of(hs->dev, struct spi_controller, dev); + host = hs->dev->driver_data;snprintf (name,32 ,"hisi_spi%d" , host->bus_num); hs->debugfs =debugfs_create_dir (name,NULL );if (IS_ERR (hs->debugfs)) --
Quoted 1 line
2.33.0
Gentle ping on this patch.
Mark Brown
maintainerQuoted 1 line · liudingyuan
Gentle ping on this patch.
Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed.
Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.