net: airoha: Fix wrong GDM4 register definition
Subsystems (4)
PATCH v2 1/1 net: airoha: Fix wrong GDM4 register definition
Fix wrong GDM4 register definition, in Airoha SDK GDM4 is defined at offset 0x2400 but this doesn't make sense as it does conflict with the CDM4 that is in the same location.
Following the pattern where each GDM base is at the FWD_CFG, currently GDM4 base offset is set to 0x2500. This is correct but REG_GDM4_FWD_CFG and REG_GDM4_SRC_PORT_SET are still using the SDK reference with the 0x2400 offset. Fix these 2 define by subtracting 0x100 to each register to reflect the real address location.
---
Changes v2:
- Target correct file (fix wrong downstream branch used)
drivers/net/ethernet/mediatek/airoha_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/mediatek/airoha_eth.c +2 -2
@@ -266,11 +266,11 @@#define REG_GDM3_FWD_CFG GDM3_BASE#define GDM3_PAD_EN_MASK BIT(28) -#define REG_GDM4_FWD_CFG (GDM4_BASE + 0x100) +#define REG_GDM4_FWD_CFG GDM4_BASE#define GDM4_PAD_EN_MASK BIT(28)#define GDM4_SPORT_OFFSET0_MASK GENMASK(11, 8) -#define REG_GDM4_SRC_PORT_SET (GDM4_BASE + 0x33c) +#define REG_GDM4_SRC_PORT_SET (GDM4_BASE + 0x23c)#define GDM4_SPORT_OFF2_MASK GENMASK(19, 16)#define GDM4_SPORT_OFF1_MASK GENMASK(15, 12)#define GDM4_SPORT_OFF0_MASK GENMASK(11, 8)
Signature · 1 line
2.47.1
Quoted 4 lines · Christian Marangi
Fix wrong GDM4 register definition, in Airoha SDK GDM4 is defined at offset
0x2400but this doesn't make sense as it does conflict with the CDM4 that is in the same location.
The wording of this first paragraph is a bit odd. I think the "Fix wrong GDMA4 register definition" part is redundant with the title and makes this feel like a run-on sentence. Anyways, not worth a re-roll.
Quoted 34 lines
Following the pattern where each GDM base is at the
FWD_CFG, currently GDM4 base offset is set to0x2500. This is correct butREG_GDM4_FWD_CFGandREG_GDM4_SRC_PORT_SETare still using the SDK reference with the0x2400offset. Fix these 2 define by subtracting0x100to each register to reflect the real address location.Fixes 23020f049327 ("net: airoha: Introduce ethernet support for EN7581 SoC")Signed-off-by Christian Marangi <[email protected]>Acked-by Lorenzo Bianconi <[email protected]>---
Changes v2:
- Target correct file (fix wrong downstream branch used)drivers/net/ethernet/mediatek/airoha_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/ethernet/mediatek/airoha_eth.c +2
-2@@ -266,11 +266,11 @@#define REG_GDM3_FWD_CFG GDM3_BASE#define GDM3_PAD_EN_MASK BIT(28) -#define REG_GDM4_FWD_CFG (GDM4_BASE + 0x100) +#define REG_GDM4_FWD_CFG GDM4_BASE#define GDM4_PAD_EN_MASK BIT(28)#define GDM4_SPORT_OFFSET0_MASK GENMASK(11, 8) -#define REG_GDM4_SRC_PORT_SET (GDM4_BASE + 0x33c) +#define REG_GDM4_SRC_PORT_SET (GDM4_BASE + 0x23c)#define GDM4_SPORT_OFF2_MASK GENMASK(19, 16)#define GDM4_SPORT_OFF1_MASK GENMASK(15, 12)#define GDM4_SPORT_OFF0_MASK GENMASK(11, 8)
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 11 lines · On Mon, 20 Jan 2025 16:41:40 +0100 you wrote:
Fix wrong GDM4 register definition, in Airoha SDK GDM4 is defined at offset
0x2400but this doesn't make sense as it does conflict with the CDM4 that is in the same location.Following the pattern where each GDM base is at the
FWD_CFG, currently GDM4 base offset is set to0x2500. This is correct butREG_GDM4_FWD_CFGandREG_GDM4_SRC_PORT_SETare still using the SDK reference with the0x2400offset. Fix these 2 define by subtracting0x100to each register to reflect the real address location.[...]
Here is the summary with links:
- [net,v2] net: airoha: Fix wrong GDM4 register definition
https://git.kernel.org/netdev/net/c/d31a49d37cb1
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html