Skip to contentSkip to conversation

dt-bindings: Add Google Widevine initialization parameters

PATCH In review Yi Chou 3 participants 5 messages Sep 8, 2023 – Sep 18, 2023 3 messages not in the archive Device tree bindings

lore
Share & tools
lore

Yi Chou

author
#0 lore raw

PATCH 1/1 dt-bindings: Add Google Widevine initialization parameters

The necessary fields to initialize the widevine related functions in OP-TEE.

---
 .../bindings/options/google,widevine.yaml     | 124 ++++++++++++++++++
 1 file changed, 124 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/options/google,widevine.yaml
Documentation/devicetree/bindings/options/google,widevine.yaml new file +124 -0
new file mode 100644
index 0000000000000..bf2b834cb1454
@@ -0,0 +1,124 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/options/google,widevine.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Google Widevine initialization parameters.
+
+maintainers:
+  - Jeffrey Kardatzke <[email protected]>
+  - Yi Chou <[email protected]>
+
+description:
+  The necessary fields to initialize the widevine related functions in
+  OP-TEE. This node does not represent a real device, but serves as a
+  place for passing data between firmware and OP-TEE.
+  The public fields (e.g. tpm-auth-public-key & root-of-trust-cert) can
+  be ignored because it's safe to pass the public information with the
+  other methods(e.g. userland OP-TEE plugins).
+
+properties:
+  compatible:
+    const: google,widevine
+
+  hardware-unique-key:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The hardware-unique key of the Widevine OP-TEE. It will be used
+      to derive the secure storage key. The length should be 32 bytes.
+      For more information, please reference:
+      https://optee.readthedocs.io/en/latest/architecture/porting_guidelines.html#hardware-unique-key
+
+  tpm-auth-public-key:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The TPM auth public key. Used to communicate the TPM from OP-TEE.
+      The format of data should be TPM2B_PUBLIC.
+      For more information, please reference the 12.2.5 section:
+      https://trustedcomputinggroup.org/wp-content/uploads/TCG_TPM2_r1p59_Part2_Structures_pub.pdf
+
+  root-of-trust:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The Widevine root of trust secret. Used to sign the widevine
+      request in OP-TEE. The length should be 32 bytes. The value
+      is an ECC NIST P-256 scalar.
+      For more information, please reference the G.1.2 section:
+      https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-186.pdf
+
+  root-of-trust-cert:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The X.509 certificate of the Widevine root of trust on this
+      device. Used to provision the device status with the Widevine
+      server in OP-TEE.
+      For more information, please reference:
+      https://www.itu.int/rec/T-REC-X.509
+
+required:
+  - compatible
+  - hardware-unique-key
+  - root-of-trust
+
+additionalProperties: false
+
+examples:
+  - |+
+    options {
+      widevine {
+        compatible = "google,widevine";
+        hardware-unique-key = [
+          12 f7 98 d2 0e d2 85 92 a5 82 bf 98 b8 99 2b c0
+          c6 6f 19 85 79 86 65 18 55 eb ff 9b 6c c0 ac 27
+        ];
+        tpm-auth-public-key = [
+          00 76 00 23 00 0b 00 02 04 b2 00 20 e1 47 bf 27
+          e1 74 30 c8 16 ab 72 4d 5c 77 e1 5c 61 2d 56 81
+          b3 35 cd 9d eb 67 41 37 69 f0 32 41 00 10 00 10
+          00 03 00 10 00 20 70 9a df 50 f9 0f d5 f4 40 e0
+          ea 2c e8 f2 26 9f 0e 5c 02 70 16 c3 6c c1 83 03
+          2d 04 10 bd 85 7a 00 20 83 03 c2 66 6e 01 32 34
+          5c 5e 80 22 c7 48 24 3c 70 6b b8 e4 24 42 74 a9
+          cf fc ab f8 30 e9 de 51
+        ];
+        root-of-trust = [
+          ac 0d 86 c3 d7 b5 b7 a2 6f c3 d9 93 f7 de bc bb
+          d5 c4 25 9b 21 5f 36 af b5 dd 6d 29 9d 08 c0 10
+        ];
+        root-of-trust-cert = [
+          30 82 01 f4 30 82 01 9b a0 03 02 01 02 02 10 11
+          01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f 30
+          0a 06 08 2a 86 48 ce 3d 04 03 02 30 0f 31 0d 30
+          0b 06 03 55 04 03 0c 04 54 69 35 30 30 22 18 0f
+          32 30 30 30 30 31 30 31 30 30 30 30 30 30 5a 18
+          0f 32 30 39 39 31 32 33 31 32 33 35 39 35 39 5a
+          30 0f 31 0d 30 0b 06 03 55 04 03 0c 04 54 69 35
+          30 30 59 30 13 06 07 2a 86 48 ce 3d 02 01 06 08
+          2a 86 48 ce 3d 03 01 07 03 42 00 04 ec ef cb 0c
+          68 7e 30 f4 d5 8f 2c 88 16 f4 7f b5 8b 5b 06 77
+          d7 47 fe 1e 91 4c a3 c5 a1 54 f5 40 9c f8 a5 4e
+          85 a0 fa 05 1a 01 98 da e4 b1 e5 ff 95 0d cf 8f
+          d9 c1 ce 28 0f 91 75 ca 06 e4 91 3b a3 81 d4 30
+          81 d1 30 1a 06 0a 2b 06 01 04 01 d6 79 02 01 21
+          04 0c 5a 53 5a 56 a5 ac a5 a9 7f 7f 00 00 30 0f
+          06 0a 2b 06 01 04 01 d6 79 02 01 22 04 01 21 30
+          2e 06 0a 2b 06 01 04 01 d6 79 02 01 23 04 20 23
+          e1 4d d9 bb 51 a5 0e 16 91 1f 7e 11 df 1e 1a af
+          0b 17 13 4d c7 39 c5 65 36 07 a1 ec 8d d3 7a 30
+          2e 06 0a 2b 06 01 04 01 d6 79 02 01 24 04 20 00
+          00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+          00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 30
+          2e 06 0a 2b 06 01 04 01 d6 79 02 01 25 04 20 00
+          00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+          00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 30
+          12 06 0a 2b 06 01 04 01 d6 79 02 01 26 04 04 00
+          00 00 00 30 0a 06 08 2a 86 48 ce 3d 04 03 02 03
+          47 00 30 44 02 20 62 a8 d3 23 db 1e 9c 64 91 49
+          45 5e b3 49 8d cc 1a ae 76 70 e3 12 d2 25 65 69
+          df f1 7e bc 4b d8 02 20 25 99 7c 36 cb b3 fd ce
+          6e 84 ee d7 ea eb 05 cf 69 cf 72 75 20 f3 ba 7f
+          8b 9f 06 f3 e4 11 bc cd
+        ];
+      };
+    };
Signature · 1 line
2.42.0.283.g2d96d420d3-goog

A message that is not in the archive (sent off-list or not yet received): 20230908101539.2622864-1-yich-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org

#2 lore raw

Documentation/devicetree/bindings/options/google,widevine.yaml

Quoted 15 lines · Yi Chou

The necessary fields to initialize the widevine related functions in OP-TEE.

---
 .../bindings/options/google,widevine.yaml     | 124 ++++++++++++++++++
 1 file changed, 124 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/options/google,widevine.yaml
Documentation/devicetree/bindings/options/google,widevine.yaml new file +0 -0
new file mode 100644
index 0000000000000..bf2b834cb1454

There is no such hardware as "options". What is this supposed to be for? firmware?

Documentation/devicetree/bindings/options/google,widevine.yaml line 7

Quoted 8 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +7 -0
@@ -0,0 +1,124 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/options/google,widevine.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Google Widevine initialization parameters.

This is a title, drop full stop.

Documentation/devicetree/bindings/options/google,widevine.yaml line 19

Quoted 12 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +12 -0
+
+maintainers:
+  - Jeffrey Kardatzke <[email protected]>
+  - Yi Chou <[email protected]>
+
+description:
+  The necessary fields to initialize the widevine related functions in
+  OP-TEE. This node does not represent a real device, but serves as a
+  place for passing data between firmware and OP-TEE.
+  The public fields (e.g. tpm-auth-public-key & root-of-trust-cert) can
+  be ignored because it's safe to pass the public information with the
+  other methods(e.g. userland OP-TEE plugins).

Then why isn't this a property of optee node?

Documentation/devicetree/bindings/options/google,widevine.yaml line 23

Quoted 4 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +4 -0
+
+properties:
+  compatible:
+    const: google,widevine

From the description I have no clue what is "widevine". The more surprising is to see it as "not hardware" but having its node and compatible, like it was a hardware node.

Documentation/devicetree/bindings/options/google,widevine.yaml line 31

Quoted 8 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +8 -0
+
+  hardware-unique-key:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The hardware-unique key of the Widevine OP-TEE. It will be used
+      to derive the secure storage key. The length should be 32 bytes.
+      For more information, please reference:
+      https://optee.readthedocs.io/en/latest/architecture/porting_guidelines.html#hardware-unique-key

Why would you store it in DT? This is world readable... or you mean this is some seed?

Quoted 26 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +26 -0
+
+  tpm-auth-public-key:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The TPM auth public key. Used to communicate the TPM from OP-TEE.
+      The format of data should be TPM2B_PUBLIC.
+      For more information, please reference the 12.2.5 section:
+      https://trustedcomputinggroup.org/wp-content/uploads/TCG_TPM2_r1p59_Part2_Structures_pub.pdf
+
+  root-of-trust:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The Widevine root of trust secret. Used to sign the widevine
+      request in OP-TEE. The length should be 32 bytes. The value
+      is an ECC NIST P-256 scalar.
+      For more information, please reference the G.1.2 section:
+      https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-186.pdf
+
+  root-of-trust-cert:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The X.509 certificate of the Widevine root of trust on this
+      device. Used to provision the device status with the Widevine
+      server in OP-TEE.
+      For more information, please reference:
+      https://www.itu.int/rec/T-REC-X.509

Documentation/devicetree/bindings/options/google,widevine.yaml line 67

Quoted 10 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +10 -0
+
+required:
+  - compatible
+  - hardware-unique-key
+  - root-of-trust
+
+additionalProperties: false
+
+examples:
+  - |+

Why + ?

Documentation/devicetree/bindings/options/google,widevine.yaml line 68

Quoted 1 line
Documentation/devicetree/bindings/options/google,widevine.yaml new file +1 -0
+    options {

There is no such node as "options".

Best regards,
Krzysztof

A message that is not in the archive (sent off-list or not yet received): 2ec056f3-e8a8-c5f3-b132-4b9d2beb616e-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org

author
#4 lore raw
Quoted 12 lines · On Sun, Sep 17, 2023 at 4:40 PM Krzysztof Kozlowski…
Quoted 10 lines · Yi Chou

The necessary fields to initialize the widevine related functions in OP-TEE.

---
 .../bindings/options/google,widevine.yaml     | 124 ++++++++++++++++++
 1 file changed, 124 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/options/google,widevine.yaml
Quoted 8 lines

Documentation/devicetree/bindings/options/google,widevine.yaml

Quoted 5 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +0 -0
new file mode 100644
index 0000000000000..bf2b834cb1454

There is no such hardware as "options". What is this supposed to be for? firmware?

These DT fields would not be consumed by the OS.
https://www.spinics.net/lists/devicetree-spec/msg01195.html
The previous discussion tended to use the "options" node. Do we have any better place for these widevine related fields?

Quoted 11 lines

Documentation/devicetree/bindings/options/google,widevine.yaml line 7

Quoted 9 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +7 -0
@@ -0,0 +1,124 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/options/google,widevine.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Google Widevine initialization parameters.

This is a title, drop full stop.

Got it, will be fixed in the next patch.

Quoted 15 lines

Documentation/devicetree/bindings/options/google,widevine.yaml line 19

Quoted 13 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +12 -0
+
+maintainers:
+  - Jeffrey Kardatzke <[email protected]>
+  - Yi Chou <[email protected]>
+
+description:
+  The necessary fields to initialize the widevine related functions in
+  OP-TEE. This node does not represent a real device, but serves as a
+  place for passing data between firmware and OP-TEE.
+  The public fields (e.g. tpm-auth-public-key & root-of-trust-cert) can
+  be ignored because it's safe to pass the public information with the
+  other methods(e.g. userland OP-TEE plugins).

Then why isn't this a property of optee node?

Are you talking about the /firmware/optee node?
If I understand correctly, that node was talking about how the kernel communicates with the OP-TEE.
But what we are doing here is passing some secrets from trusted firmware into OP-TEE, and the data would not go through the linux kernel.
I'm not sure if it is a good idea to mix two different purpose fields in the same node...

Quoted 9 lines

Documentation/devicetree/bindings/options/google,widevine.yaml line 23

Quoted 5 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +4 -0
+
+properties:
+  compatible:
+    const: google,widevine

From the description I have no clue what is "widevine". The more surprising is to see it as "not hardware" but having its node and compatible, like it was a hardware node.

We already have a "chosen" node that is "not hardware" in the DT. Should we just remove the compatible field from this node?

BTW, Widevine is a digital rights management (DRM) system to make sure the video stream can only be decoded on the valid devices.

Quoted 10 lines

Documentation/devicetree/bindings/options/google,widevine.yaml line 31

Quoted 9 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +8 -0
+
+  hardware-unique-key:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The hardware-unique key of the Widevine OP-TEE. It will be used
+      to derive the secure storage key. The length should be 32 bytes.
+      For more information, please reference:
+      https://optee.readthedocs.io/en/latest/architecture/porting_guidelines.html#hardware-unique-key
Quoted 2 lines

Why would you store it in DT? This is world readable... or you mean this is some seed?

We will not pass this node to the linux kernel.
This DT node is only intended to be used between the ARM trusted firmware(BL31) and the OPTEE.

Quoted 31 lines
Quoted 31 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +30 -0
+
+  tpm-auth-public-key:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The TPM auth public key. Used to communicate the TPM from OP-TEE.
+      The format of data should be TPM2B_PUBLIC.
+      For more information, please reference the 12.2.5 section:
+      https://trustedcomputinggroup.org/wp-content/uploads/TCG_TPM2_r1p59_Part2_Structures_pub.pdf
+
+  root-of-trust:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The Widevine root of trust secret. Used to sign the widevine
+      request in OP-TEE. The length should be 32 bytes. The value
+      is an ECC NIST P-256 scalar.
+      For more information, please reference the G.1.2 section:
+      https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-186.pdf
+
+  root-of-trust-cert:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The X.509 certificate of the Widevine root of trust on this
+      device. Used to provision the device status with the Widevine
+      server in OP-TEE.
+      For more information, please reference:
+      https://www.itu.int/rec/T-REC-X.509
+
+required:
+  - compatible
+  - hardware-unique-key
Quoted 8 lines

Documentation/devicetree/bindings/options/google,widevine.yaml line 67

Quoted 6 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +6 -0
+  - root-of-trust
+
+additionalProperties: false
+
+examples:
+  - |+

Why + ?

The extra "+" will be removed in the next patch.

Quoted 4 lines

Documentation/devicetree/bindings/options/google,widevine.yaml line 68

Quoted 2 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +1 -0
+    options {

There is no such node as "options".

This is a new node that was suggested in this thread:
https://www.spinics.net/lists/devicetree-spec/msg01195.html

Quoted 5 lines

Best regards,
Krzysztof

Thanks,
Yi

A message that is not in the archive (sent off-list or not yet received): CABOkjxJpcOUyyh9vjRuqrhmd=EdQdnyyuBX-++0R+UdENfqw9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#6 lore raw
Quoted 23 lines · Yi Chou
Quoted 12 lines · On Sun, Sep 17, 2023 at 4:40 PM Krzysztof Kozlowski…
Quoted 10 lines · Yi Chou

The necessary fields to initialize the widevine related functions in OP-TEE.

---
 .../bindings/options/google,widevine.yaml     | 124 ++++++++++++++++++
 1 file changed, 124 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/options/google,widevine.yaml
Quoted 8 lines

Documentation/devicetree/bindings/options/google,widevine.yaml

Quoted 5 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +0 -0
new file mode 100644
index 0000000000000..bf2b834cb1454

There is no such hardware as "options". What is this supposed to be for? firmware?

Quoted 4 lines

These DT fields would not be consumed by the OS.
https://www.spinics.net/lists/devicetree-spec/msg01195.html
The previous discussion tended to use the "options" node. Do we have any better place for these widevine related fields?

I'll let Rob comment on this in such case.

Quoted 50 lines
Quoted 12 lines

Documentation/devicetree/bindings/options/google,widevine.yaml line 7

Quoted 10 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +7 -0
@@ -0,0 +1,124 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/options/google,widevine.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Google Widevine initialization parameters.

This is a title, drop full stop.

Got it, will be fixed in the next patch.

Quoted 15 lines

Documentation/devicetree/bindings/options/google,widevine.yaml line 19

Quoted 13 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +12 -0
+
+maintainers:
+  - Jeffrey Kardatzke <[email protected]>
+  - Yi Chou <[email protected]>
+
+description:
+  The necessary fields to initialize the widevine related functions in
+  OP-TEE. This node does not represent a real device, but serves as a
+  place for passing data between firmware and OP-TEE.
+  The public fields (e.g. tpm-auth-public-key & root-of-trust-cert) can
+  be ignored because it's safe to pass the public information with the
+  other methods(e.g. userland OP-TEE plugins).

Then why isn't this a property of optee node?

Are you talking about the /firmware/optee node?
If I understand correctly, that node was talking about how the kernel communicates with the OP-TEE.
But what we are doing here is passing some secrets from trusted firmware into OP-TEE, and the data would not go through the linux kernel.
I'm not sure if it is a good idea to mix two different purpose fields in the same node...

Quoted 9 lines

Documentation/devicetree/bindings/options/google,widevine.yaml line 23

Quoted 5 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +4 -0
+
+properties:
+  compatible:
+    const: google,widevine

From the description I have no clue what is "widevine". The more surprising is to see it as "not hardware" but having its node and compatible, like it was a hardware node.

Quoted 5 lines

We already have a "chosen" node that is "not hardware" in the DT. Should we just remove the compatible field from this node?

BTW, Widevine is a digital rights management (DRM) system to make sure the video stream can only be decoded on the valid devices.

Then describe it in the description.

Best regards,
Krzysztof

#7 lore raw
In reply to a message not in the archive
Quoted 9 lines · Yi Chou

The necessary fields to initialize the widevine related functions in OP-TEE.

---
 .../bindings/options/google,widevine.yaml     | 124 ++++++++++++++++++
 1 file changed, 124 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/options/google,widevine.yaml

I don't think this belongs in the kernel. Weren't earlier versions targeting dtschema? I'm okay with taking some stuff there, but if this is the beginning of a bunch of things for OP-TEE, then they should go in OP-TEE repo.

Quoted 22 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +15 -0
new file mode 100644
index 0000000000000..bf2b834cb1454
@@ -0,0 +1,124 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/options/google,widevine.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Google Widevine initialization parameters.
+
+maintainers:
+  - Jeffrey Kardatzke <[email protected]>
+  - Yi Chou <[email protected]>
+
+description:
+  The necessary fields to initialize the widevine related functions in
+  OP-TEE. This node does not represent a real device, but serves as a

Documentation/devicetree/bindings/options/google,widevine.yaml line 25

Quoted 10 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +10 -0
+  place for passing data between firmware and OP-TEE.
+  The public fields (e.g. tpm-auth-public-key & root-of-trust-cert) can
+  be ignored because it's safe to pass the public information with the
+  other methods(e.g. userland OP-TEE plugins).
+
+properties:
+  compatible:
+    const: google,widevine
+
+  hardware-unique-key:

These all need a 'google,' prefix (or whoever they are specific too). Unless we're saying, for example, 'root-of-trust-cert' will always (globally) be an X.509 cert and in the same form.

Documentation/devicetree/bindings/options/google,widevine.yaml line 26

Quoted 1 line
Documentation/devicetree/bindings/options/google,widevine.yaml new file +1 -0
+    $ref: /schemas/types.yaml#/definitions/uint8-array

maxItems: 32

Documentation/devicetree/bindings/options/google,widevine.yaml line 29

Quoted 3 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +3 -0
+    description: |
+      The hardware-unique key of the Widevine OP-TEE. It will be used
+      to derive the secure storage key. The length should be 32 bytes.

And drop the text defining the length.

Documentation/devicetree/bindings/options/google,widevine.yaml line 33

Quoted 4 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +4 -0
+      For more information, please reference:
+      https://optee.readthedocs.io/en/latest/architecture/porting_guidelines.html#hardware-unique-key
+
+  tpm-auth-public-key:

'tcg,' prefix here since this is defined by TCG.

Documentation/devicetree/bindings/options/google,widevine.yaml line 39

Quoted 6 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +6 -0
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The TPM auth public key. Used to communicate the TPM from OP-TEE.
+      The format of data should be TPM2B_PUBLIC.
+      For more information, please reference the 12.2.5 section:
+      https://trustedcomputinggroup.org/wp-content/uploads/TCG_TPM2_r1p59_Part2_Structures_pub.pdf

maxItems: 65537

(Maybe something less, but since the size field is uint16, it can't be more than that)

Documentation/devicetree/bindings/options/google,widevine.yaml line 45

Quoted 6 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +6 -0
+
+  root-of-trust:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The Widevine root of trust secret. Used to sign the widevine
+      request in OP-TEE. The length should be 32 bytes. The value

maxItems: 32

Documentation/devicetree/bindings/options/google,widevine.yaml line 57

Quoted 12 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +12 -0
+      is an ECC NIST P-256 scalar.
+      For more information, please reference the G.1.2 section:
+      https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-186.pdf
+
+  root-of-trust-cert:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    description: |
+      The X.509 certificate of the Widevine root of trust on this
+      device. Used to provision the device status with the Widevine
+      server in OP-TEE.
+      For more information, please reference:
+      https://www.itu.int/rec/T-REC-X.509

Size?

Quoted 70 lines
Documentation/devicetree/bindings/options/google,widevine.yaml new file +67 -0
+
+required:
+  - compatible
+  - hardware-unique-key
+  - root-of-trust
+
+additionalProperties: false
+
+examples:
+  - |+
+    options {
+      widevine {
+        compatible = "google,widevine";
+        hardware-unique-key = [
+          12 f7 98 d2 0e d2 85 92 a5 82 bf 98 b8 99 2b c0
+          c6 6f 19 85 79 86 65 18 55 eb ff 9b 6c c0 ac 27
+        ];
+        tpm-auth-public-key = [
+          00 76 00 23 00 0b 00 02 04 b2 00 20 e1 47 bf 27
+          e1 74 30 c8 16 ab 72 4d 5c 77 e1 5c 61 2d 56 81
+          b3 35 cd 9d eb 67 41 37 69 f0 32 41 00 10 00 10
+          00 03 00 10 00 20 70 9a df 50 f9 0f d5 f4 40 e0
+          ea 2c e8 f2 26 9f 0e 5c 02 70 16 c3 6c c1 83 03
+          2d 04 10 bd 85 7a 00 20 83 03 c2 66 6e 01 32 34
+          5c 5e 80 22 c7 48 24 3c 70 6b b8 e4 24 42 74 a9
+          cf fc ab f8 30 e9 de 51
+        ];
+        root-of-trust = [
+          ac 0d 86 c3 d7 b5 b7 a2 6f c3 d9 93 f7 de bc bb
+          d5 c4 25 9b 21 5f 36 af b5 dd 6d 29 9d 08 c0 10
+        ];
+        root-of-trust-cert = [
+          30 82 01 f4 30 82 01 9b a0 03 02 01 02 02 10 11
+          01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f 30
+          0a 06 08 2a 86 48 ce 3d 04 03 02 30 0f 31 0d 30
+          0b 06 03 55 04 03 0c 04 54 69 35 30 30 22 18 0f
+          32 30 30 30 30 31 30 31 30 30 30 30 30 30 5a 18
+          0f 32 30 39 39 31 32 33 31 32 33 35 39 35 39 5a
+          30 0f 31 0d 30 0b 06 03 55 04 03 0c 04 54 69 35
+          30 30 59 30 13 06 07 2a 86 48 ce 3d 02 01 06 08
+          2a 86 48 ce 3d 03 01 07 03 42 00 04 ec ef cb 0c
+          68 7e 30 f4 d5 8f 2c 88 16 f4 7f b5 8b 5b 06 77
+          d7 47 fe 1e 91 4c a3 c5 a1 54 f5 40 9c f8 a5 4e
+          85 a0 fa 05 1a 01 98 da e4 b1 e5 ff 95 0d cf 8f
+          d9 c1 ce 28 0f 91 75 ca 06 e4 91 3b a3 81 d4 30
+          81 d1 30 1a 06 0a 2b 06 01 04 01 d6 79 02 01 21
+          04 0c 5a 53 5a 56 a5 ac a5 a9 7f 7f 00 00 30 0f
+          06 0a 2b 06 01 04 01 d6 79 02 01 22 04 01 21 30
+          2e 06 0a 2b 06 01 04 01 d6 79 02 01 23 04 20 23
+          e1 4d d9 bb 51 a5 0e 16 91 1f 7e 11 df 1e 1a af
+          0b 17 13 4d c7 39 c5 65 36 07 a1 ec 8d d3 7a 30
+          2e 06 0a 2b 06 01 04 01 d6 79 02 01 24 04 20 00
+          00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+          00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 30
+          2e 06 0a 2b 06 01 04 01 d6 79 02 01 25 04 20 00
+          00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+          00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 30
+          12 06 0a 2b 06 01 04 01 d6 79 02 01 26 04 04 00
+          00 00 00 30 0a 06 08 2a 86 48 ce 3d 04 03 02 03
+          47 00 30 44 02 20 62 a8 d3 23 db 1e 9c 64 91 49
+          45 5e b3 49 8d cc 1a ae 76 70 e3 12 d2 25 65 69
+          df f1 7e bc 4b d8 02 20 25 99 7c 36 cb b3 fd ce
+          6e 84 ee d7 ea eb 05 cf 69 cf 72 75 20 f3 ba 7f
+          8b 9f 06 f3 e4 11 bc cd
+        ];
+      };
+    };
Signature · 1 line
2.42.0.283.g2d96d420d3-goog