compiler warning: fs/f2fs/node.c: In function ‘__set_nat_cache_dirty’: ‘head’ may be used uninitialized
Seems to have been introduced via:
----------------------------------------------------------------
commit 780de47cf6cb5f524cd98ec8ffbffc3da5696e17
Author: Chao Yu <[email protected]> Date: Tue Mar 20 23:08:30 2018 +0800
f2fs: don't track new nat entry in nat set
Nat entry set is used only in checkpoint(), and during checkpoint() we won't flush new nat entry with unallocated address, so we don't need to add new nat entry into nat set, then nat_entry_set::entry_cnt can indicate actual entry count we need to flush in checkpoint().
----------------------------------------------------------------
Compiler warning is:
----------------------------------------------------------------
CC fs/f2fs/node.o
In file included from ./include/linux/wait.h:7:0,
from ./include/linux/wait_bit.h:8,
from ./include/linux/fs.h:6,
from fs/f2fs/node.c:11:
fs/f2fs/node.c: In function ‘__set_nat_cache_dirty’:
./include/linux/list.h:63:13: error: ‘head’ may be used uninitialized in
this function [-Werror=maybe-uninitialized]
next->prev = new;
^
fs/f2fs/node.c:238:24: note: ‘head’ was declared here
struct nat_entry_set *head;
^cc1: all warnings being treated as errors
----------------------------------------------------------------
Thanks
Alex
Quoted 33 lines · Alexandru
Seems to have been introduced via:
----------------------------------------------------------------
commit
780de47cf6cb5f524cd98ec8ffbffc3da5696e17Author: Chao Yu <[email protected]> Date: Tue Mar 20 23:08:30 2018 +0800f2fs: don't track new nat entry in nat set
Nat entry set is used only in
checkpoint(), and duringcheckpoint()we won't flush new nat entry with unallocated address, so we don't need to add new nat entry into nat set, thennat_entry_set::entry_cntcan indicate actual entry count we need to flush incheckpoint().Signed-off-by Yunlei He <[email protected]>Signed-off-by Chao Yu <[email protected]>Signed-off-by Jaegeuk Kim <[email protected]>----------------------------------------------------------------
Compiler warning is:
----------------------------------------------------------------CC
fs/f2fs/node.o
In file included from./include/linux/wait.h:7:0,from ./include/linux/wait_bit.h:8, from ./include/linux/fs.h:6, from fs/f2fs/node.c:11: fs/f2fs/node.c: In function ‘__set_nat_cache_dirty’: ./include/linux/list.h:63:13: error: ‘head’ may be used uninitialized in this function [-Werror=maybe-uninitialized] next->prev = new; ^
Quoted 2 lines
fs/f2fs/node.c:238:24: note: ‘head’ was declared here
structnat_entry_set*head;
That's not correct, @head will only be assigned and used if new_ne equals NULL.
Thanks,
Quoted 12 lines
^cc1: all warnings being treated as errors
----------------------------------------------------------------Thanks
Alex_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 42 lines · Chao Yu
[External]
Quoted 30 lines · Alexandru
Seems to have been introduced via:
----------------------------------------------------------------
commit
780de47cf6cb5f524cd98ec8ffbffc3da5696e17Author: Chao Yu <[email protected]> Date: Tue Mar 20 23:08:30 2018 +0800f2fs: don't track new nat entry in nat set
Nat entry set is used only in
checkpoint(), and duringcheckpoint()
we
won't flush new nat entry with unallocated address, so we don't
need to
add new nat entry into nat set, thennat_entry_set::entry_cntcan indicate actual entry count we need to flush incheckpoint().Signed-off-by Yunlei He <[email protected]>Signed-off-by Chao Yu <[email protected]>Signed-off-by Jaegeuk Kim <[email protected]>----------------------------------------------------------------
Compiler warning is:
----------------------------------------------------------------CC
fs/f2fs/node.o
In file included from./include/linux/wait.h:7:0,from ./include/linux/wait_bit.h:8, from ./include/linux/fs.h:6, from fs/f2fs/node.c:11:Quoted 8 lines
fs/f2fs/node.c: In function ‘__set_nat_cache_dirty’:./include/linux/list.h:63:13: error: ‘head’ may be used uninitialized in
this function [-Werror=maybe-uninitialized]next->prev = new; ^
fs/f2fs/node.c:238:24: note: ‘head’ was declared here
structnat_entry_set*head;
Quoted 2 lines
That's not correct, @head will only be assigned and used if
new_neequals NULL.
Ack.
I admit that I don't understand the code, and don't claim to understand it.
This may be just a weird compiler issue.
I thought I'd send it just as a heads-up.
I saw this on a Raspberry Pi branch [after we enabled warnings as errors]:
https://travis-ci.org/analogdevicesinc/linux/jobs/601844926#L1208
Looking in the latest f2fs/dev[-test] tree, it looks like the code is similar as in 4.19.
https://github.com/analogdevicesinc/linux/blob/rpi-4.19.y/fs/f2fs/node.c#L235
Could be that the RPi branch has some more compiler-stuff enabled.
In any case, feel free to disregard this.
We will see how we fix this on our end for that branch specifically.
Thanks
Alex
Quoted 15 lines
Thanks,
Quoted 12 lines
^cc1: all warnings being treated as errors
----------------------------------------------------------------Thanks
Alex_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 43 lines · Alexandru
Quoted 42 lines · Chao Yu
[External]
Quoted 38 lines · Alexandru
Seems to have been introduced via:
----------------------------------------------------------------
commit
780de47cf6cb5f524cd98ec8ffbffc3da5696e17Author: Chao Yu <[email protected]> Date: Tue Mar 20 23:08:30 2018 +0800f2fs: don't track new nat entry in nat set
Nat entry set is used only in
checkpoint(), and duringcheckpoint()
we
won't flush new nat entry with unallocated address, so we don't
need to
add new nat entry into nat set, thennat_entry_set::entry_cntcan indicate actual entry count we need to flush incheckpoint().Signed-off-by Yunlei He <[email protected]>Signed-off-by Chao Yu <[email protected]>Signed-off-by Jaegeuk Kim <[email protected]>----------------------------------------------------------------
Compiler warning is:
----------------------------------------------------------------CC
fs/f2fs/node.o
In file included from./include/linux/wait.h:7:0,from ./include/linux/wait_bit.h:8, from ./include/linux/fs.h:6, from fs/f2fs/node.c:11:
fs/f2fs/node.c: In function ‘__set_nat_cache_dirty’:./include/linux/list.h:63:13: error: ‘head’ may be used uninitialized in
this function [-Werror=maybe-uninitialized]next->prev = new; ^
fs/f2fs/node.c:238:24: note: ‘head’ was declared here
structnat_entry_set*head;
Quoted 8 lines
Quoted 2 lines
That's not correct, @head will only be assigned and used if
new_neequals NULL.Ack.
I admit that I don't understand the code, and don't claim to understand it.This may be just a weird compiler issue.
I thought I'd send it just as a heads-up.
I think that's the right thing to do.
Quoted 11 lines
I saw this on a Raspberry Pi branch [after we enabled warnings as errors]:
https://travis-ci.org/analogdevicesinc/linux/jobs/601844926#L1208Looking in the latest f2fs/dev[-test] tree, it looks like the code is similar as in 4.19.
https://github.com/analogdevicesinc/linux/blob/rpi-4.19.y/fs/f2fs/node.c#L235Could be that the RPi branch has some more compiler-stuff enabled.
In any case, feel free to disregard this.
We will see how we fix this on our end for that branch specifically.
That would make sense, let me know if you have any other suspicious compiler warnings. :)
Thanks,
Quoted 19 lines
Thanks
AlexQuoted 15 lines
Thanks,
Quoted 12 lines
^cc1: all warnings being treated as errors
----------------------------------------------------------------Thanks
Alex_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel