travis.yml: Install libcap-dev for testing virito-9p
PATCH 1/1 travis.yml: Install libcap-dev for testing virito-9p
So far we were not testing virtio-9p in Travis yet, since we forgot to install libcap-devel. Do it now to get some more test coverage.
--- .travis.yml | 1 + 1 file changed, 1 insertion(+)
.travis.yml +1 -0
@@ -15,6 +15,7 @@ addons: - libaio-dev - libattr1-dev - libbrlapi-dev + - libcap-dev - libcap-ng-dev - libgcc-4.8-dev - libgnutls-dev
Signature · 1 line
2.18.1
"virito-9p" -> "virtio-9p" in subject
Quoted 14 lines · Thomas Huth
So far we were not testing virtio-9p in Travis yet, since we forgot to install libcap-devel. Do it now to get some more test coverage.
Signed-off-by Thomas Huth <[email protected]>--- .travis.yml | 1 + 1 file changed, 1 insertion(+).travis.yml +0
-0
.travis.yml addons: · line 21
Quoted 7 lines
.travis.yml +1
-0@@ -15,6 +15,7 @@ addons: - libaio-dev - libattr1-dev - libbrlapi-dev + - libcap-dev - libcap-ng-dev - libgcc-4.8-dev - libgnutls-dev
Quoted 5 lines · On Thu, 5 Sep 2019 13:33:46 +0200 Thomas Huth <[email protected]> wrote:
So far we were not testing virtio-9p in Travis yet, since we forgot to install libcap-devel. Do it now to get some more test coverage.
Signed-off-by Thomas Huth <[email protected]>---
and
Whose tree is this going through BTW ?
Quoted 15 lines
.travis.yml | 1 + 1 file changed, 1 insertion(+).travis.yml +1
-0@@ -15,6 +15,7 @@ addons: - libaio-dev - libattr1-dev - libbrlapi-dev + - libcap-dev - libcap-ng-dev - libgcc-4.8-dev - libgnutls-dev
Quoted 11 lines · On Thu, 5 Sep 2019 14:07:01 +0200 Greg Kurz <[email protected]> wrote:
Quoted 5 lines · On Thu, 5 Sep 2019 13:33:46 +0200 Thomas Huth <[email protected]> wrote:
So far we were not testing virtio-9p in Travis yet, since we forgot to install libcap-devel. Do it now to get some more test coverage.
Signed-off-by Thomas Huth <[email protected]>---
Acked-by Greg Kurz <[email protected]>
Hmm... shouldn't libcap-dev be added in the "Acceptance (Functional) tests" section as well, near line 260 ?
Quoted 22 lines
and
Tested-by Greg Kurz <[email protected]>Whose tree is this going through BTW ?
Quoted 15 lines
.travis.yml | 1 + 1 file changed, 1 insertion(+).travis.yml +1
-0@@ -15,6 +15,7 @@ addons: - libaio-dev - libattr1-dev - libbrlapi-dev + - libcap-dev - libcap-ng-dev - libgcc-4.8-dev - libgnutls-dev
Quoted 9 lines · Greg Kurz
Quoted 6 lines · On Thu, 5 Sep 2019 14:07:01 +0200 Greg Kurz <[email protected]> wrote:
Quoted 3 lines · On Thu, 5 Sep 2019 13:33:46 +0200 Thomas Huth <[email protected]> wrote:
So far we were not testing virtio-9p in Travis yet, since we forgot to install libcap-devel. Do it now to get some more test coverage.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Thomas Huth <[email protected]>---
Acked-by Greg Kurz <[email protected]>Hmm... shouldn't libcap-dev be added in the "Acceptance (Functional) tests" section as well, near line 260 ?
Unless there is a test for 9p in the "check-acceptance" suite, it likely does not make a difference - 9p would just get built one more additional time, but it won't be tested afterwards.
Thomas
Quoted 9 lines · Greg Kurz
Quoted 5 lines · On Thu, 5 Sep 2019 13:33:46 +0200 Thomas Huth <[email protected]> wrote:
So far we were not testing virtio-9p in Travis yet, since we forgot to install libcap-devel. Do it now to get some more test coverage.
Signed-off-by Thomas Huth <[email protected]>---
Quoted 7 lines
Acked-by Greg Kurz <[email protected]>and
Tested-by Greg Kurz <[email protected]>Whose tree is this going through BTW ?
According to MAINTAINERS, .travis.yml is taken care of by Alex and Fam, so I hope they will pick this patch up. Otherwise, I think it could also go via trivial (now on CC: ), since it's just a one-liner.
Thomas
Quoted 14 lines · Thomas Huth
Quoted 13 lines · Greg Kurz
Quoted 5 lines · On Thu, 5 Sep 2019 13:33:46 +0200 Thomas Huth <[email protected]> wrote:
So far we were not testing virtio-9p in Travis yet, since we forgot to install libcap-devel. Do it now to get some more test coverage.
Signed-off-by Thomas Huth <[email protected]>---
Acked-by Greg Kurz <[email protected]>and
Quoted 7 lines
Quoted 3 lines
Tested-by Greg Kurz <[email protected]>Whose tree is this going through BTW ?
According to
MAINTAINERS, .travis.yml is taken care of by Alex and Fam, so I hope they will pick this patch up. Otherwise, I think it could also go via trivial (now on CC: ), since it's just a one-liner.
Sure I'll grab it for the next iteration of testing/next - the queue is quite full at the moment.
--
Alex Bennée