Skip to contentSkip to conversation

firmware/efi sysfb_efi: Add quirk for Lenovo IdeaPad Duet 3

PATCH In review Darrell Kavanagh 3 participants 3 messages Feb 15, 2023 – Feb 17, 2023 EFI

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 firmware/efi sysfb_efi: Add quirk for Lenovo IdeaPad Duet 3

Another Lenovo convertable which reports a landscape resolution of 1920x1200 with a pitch of (1920 * 4) bytes, while the actual framebuffer has a resolution of 1200x1920 with a pitch of (1200 * 4) bytes.

---
Changes in v2:
- Improve commit message

---
 drivers/firmware/efi/sysfb_efi.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/firmware/efi/sysfb_efi.c +8 -0
index 7882d4b3f2be..f06fdacc9bc8 100644
@@ -264,6 +264,14 @@ static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = {
 					"Lenovo ideapad D330-10IGM"),
 		},
 	},
+	{
+		/* Lenovo IdeaPad Duet 3 10IGL5 with 1200x1920 portrait screen */
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_VERSION,
+					"IdeaPad Duet 3 10IGL5"),
+		},
+	},
 	{},
 };
 
Signature · 1 line
2.39.1
Reviewed-by on v2 1/1
#1 lore raw

Hi,

Quoted 8 lines · Darrell Kavanagh

Another Lenovo convertable which reports a landscape resolution of 1920x1200 with a pitch of (1920 * 4) bytes, while the actual framebuffer has a resolution of 1200x1920 with a pitch of (1200 * 4) bytes.

---
Changes in v2:
- Improve commit message

Thanks, patch looks good to me:

Regards,

Hans

Quoted 23 lines
---
 drivers/firmware/efi/sysfb_efi.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/firmware/efi/sysfb_efi.c +8 -0
index 7882d4b3f2be..f06fdacc9bc8 100644
@@ -264,6 +264,14 @@ static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = {
 					"Lenovo ideapad D330-10IGM"),
 		},
 	},
+	{
+		/* Lenovo IdeaPad Duet 3 10IGL5 with 1200x1920 portrait screen */
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_VERSION,
+					"IdeaPad Duet 3 10IGL5"),
+		},
+	},
 	{},
 };
 
maintainer
#2 lore raw
Quoted 8 lines · Hans de Goede

Hi,

Quoted 4 lines · Darrell Kavanagh

Another Lenovo convertable which reports a landscape resolution of 1920x1200 with a pitch of (1920 * 4) bytes, while the actual framebuffer has a resolution of 1200x1920 with a pitch of (1200 * 4) bytes.

Quoted 9 lines
Quoted 4 lines

---
Changes in v2:
- Improve commit message

Thanks, patch looks good to me:

Thanks. I've queued this up in efi/next.