Skip to contentSkip to conversation

imx: Kconfig: fix references to doc/README.mxc_hab

PATCH New Heinrich Schuchardt 4 participants 12 messages Apr 12, 2020 – Apr 17, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx: Kconfig: fix references to doc/README.mxc_hab

doc/README.mxc_hab was moved to doc/imx/habv4/guides/encrypted_boot.txt by commit df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation"), commit dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot documentation"), commit 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory for a cleaner documentation structure"), and commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot guide").

Fixes df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation")
Fixes dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot

documentation")

Fixes 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory

for a cleaner documentation structure")

Fixes commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot guide").
---
 arch/arm/mach-imx/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-imx/Kconfig +3 -3
index aa140c4798..44b47780ee 100644
@@ -41,7 +41,7 @@ config IMX_HAB
 	imply CMD_DEKBLOB
 	help
 	  This option enables the support for secure boot (HAB).
-	  See doc/README.mxc_hab for more details.
+	  See doc/imx/habv4/guides/encrypted_boot.txt for more details.
 
 config CSF_SIZE
 	hex "Maximum size for Command Sequence File (CSF) binary"
@@ -69,8 +69,8 @@ config CMD_DEKBLOB
 	help
 	  This enables the 'dek_blob' command which is used with the
 	  Freescale secure boot mechanism. This command encapsulates and
-	  creates a blob of data. See also CMD_BLOB and doc/README.mxc_hab for
-	  more information.
+	  creates a blob of data. See also CMD_BLOB and
+	  doc/imx/habv4/guides/encrypted_boot.txt for more information.
 
 config CMD_HDMIDETECT
 	bool "Support the 'hdmidet' command"

--
2.20.1

reviewer
#1 lore raw

PATCH 1/1 imx: Kconfig: fix references to doc/README.mxc_hab

Hi Heinrich,

Quoted 24 lines · Heinrich Schuchardt

doc/README.mxc_hab was moved to doc/imx/habv4/guides/encrypted_boot.txt by commit df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation"), commit dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot documentation"), commit 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory for a cleaner documentation structure"), and commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot guide").

Fixes df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation")
Fixes dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot

documentation")

Fixes 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory

for a cleaner documentation structure")

Fixes commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot guide").
---
 arch/arm/mach-imx/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-imx/Kconfig +0 -0
index aa140c4798..44b47780ee 100644

arch/arm/mach-imx/Kconfig config IMX_HAB · line 44

Quoted 5 lines
arch/arm/mach-imx/Kconfig +1 -1
@@ -41,7 +41,7 @@ config IMX_HAB
        imply CMD_DEKBLOB
        help
          This option enables the support for secure boot (HAB).
-         See doc/README.mxc_hab for more details.
+         See doc/imx/habv4/guides/encrypted_boot.txt for more details.

Thanks for your patch.

Indeed, doc/README.mxc_hab is gone and we should replace it, but I was wondering if we should point the file to doc/imx/habv4/guides/mx6_mx7_secure_boot.txt instead.

Breno,

What do you think?

Thanks

#2 lore raw

PATCH 1/1 imx: Kconfig: fix references to doc/README.mxc_hab

Hi Heinrich,

Em dom., 12 de abr. de 2020 ?s 12:15, Fabio Estevam <[email protected]> escreveu:

Quoted 36 lines

Hi Heinrich,

Quoted 24 lines · Heinrich Schuchardt

doc/README.mxc_hab was moved to doc/imx/habv4/guides/encrypted_boot.txt by commit df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation"), commit dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot documentation"), commit 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory for a cleaner documentation structure"), and commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot guide").

Fixes df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation")
Fixes dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot

documentation")

Fixes 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory

for a cleaner documentation structure")

Fixes commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot guide").
---
 arch/arm/mach-imx/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-imx/Kconfig +0 -0
index aa140c4798..44b47780ee 100644

arch/arm/mach-imx/Kconfig config IMX_HAB · line 44

Quoted 5 lines
arch/arm/mach-imx/Kconfig +1 -1
@@ -41,7 +41,7 @@ config IMX_HAB
        imply CMD_DEKBLOB
        help
          This option enables the support for secure boot (HAB).
-         See doc/README.mxc_hab for more details.
+         See doc/imx/habv4/guides/encrypted_boot.txt for more details.

Thanks for your patch.

Quoted 7 lines

Indeed, doc/README.mxc_hab is gone and we should replace it, but I was wondering if we should point the file to doc/imx/habv4/guides/mx6_mx7_secure_boot.txt instead.

Breno,

What do you think?

Thanks for the fix.

Yes, IMX_HAB is also used for encrypted boot but as Fabio mentioned it would be better to point users to doc/imx/habv4/guides/mx6_mx7_secure_boot.txt.

Thanks,
Breno Lima

#3 lore raw

PATCH 1/1 imx: Kconfig: fix references to doc/README.mxc_hab

In reply to Fabio Estevam
Quoted 35 lines · Fabio Estevam

Hi Heinrich,

Quoted 24 lines · Heinrich Schuchardt

doc/README.mxc_hab was moved to doc/imx/habv4/guides/encrypted_boot.txt by commit df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation"), commit dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot documentation"), commit 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory for a cleaner documentation structure"), and commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot guide").

Fixes df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation")
Fixes dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot

documentation")

Fixes 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory

for a cleaner documentation structure")

Fixes commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot guide").
---
 arch/arm/mach-imx/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-imx/Kconfig +0 -0
index aa140c4798..44b47780ee 100644

arch/arm/mach-imx/Kconfig config IMX_HAB · line 44

Quoted 5 lines
arch/arm/mach-imx/Kconfig +1 -1
@@ -41,7 +41,7 @@ config IMX_HAB
        imply CMD_DEKBLOB
        help
          This option enables the support for secure boot (HAB).
-         See doc/README.mxc_hab for more details.
+         See doc/imx/habv4/guides/encrypted_boot.txt for more details.

Thanks for your patch.

Quoted 7 lines

Indeed, doc/README.mxc_hab is gone and we should replace it, but I was wondering if we should point the file to doc/imx/habv4/guides/mx6_mx7_secure_boot.txt instead.

Breno,

What do you think?

It is doc/imx/habv4/guides/encrypted_boot.txt that mentions CONFIG_IMX_HAB and CONFIG_CMD_DEKBLOB.

Maybe both files can be merged. Anyway the imx directory should move to doc/board and be integrated into doc/board/index.rst.

Shouldn't the content of folder doc/imx be moved to doc/board/freescale/ and linked in doc/board/freescale/index.rst?

We should be able to generate HTML documentation for imx using 'make htmldocs'.

Best regards

Heinrich

#4 lore raw

PATCH 1/1 imx: Kconfig: fix references to doc/README.mxc_hab

Hi Heinrich,

Em dom., 12 de abr. de 2020 ?s 17:35, Heinrich Schuchardt <[email protected]> escreveu:

Quoted 48 lines · Fabio Estevam
Quoted 35 lines

Hi Heinrich,

Quoted 24 lines · Heinrich Schuchardt

doc/README.mxc_hab was moved to doc/imx/habv4/guides/encrypted_boot.txt by commit df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation"), commit dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot documentation"), commit 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory for a cleaner documentation structure"), and commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot guide").

Fixes df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation")
Fixes dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot

documentation")

Fixes 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory

for a cleaner documentation structure")

Fixes commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot guide").
---
 arch/arm/mach-imx/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-imx/Kconfig +0 -0
index aa140c4798..44b47780ee 100644

arch/arm/mach-imx/Kconfig config IMX_HAB · line 44

Quoted 5 lines
arch/arm/mach-imx/Kconfig +1 -1
@@ -41,7 +41,7 @@ config IMX_HAB
        imply CMD_DEKBLOB
        help
          This option enables the support for secure boot (HAB).
-         See doc/README.mxc_hab for more details.
+         See doc/imx/habv4/guides/encrypted_boot.txt for more details.

Thanks for your patch.

Quoted 7 lines

Indeed, doc/README.mxc_hab is gone and we should replace it, but I was wondering if we should point the file to doc/imx/habv4/guides/mx6_mx7_secure_boot.txt instead.

Breno,

What do you think?

It is doc/imx/habv4/guides/encrypted_boot.txt that mentions CONFIG_IMX_HAB and CONFIG_CMD_DEKBLOB.

Quoted 8 lines

Maybe both files can be merged. Anyway the imx directory should move to doc/board and be integrated into doc/board/index.rst.

Shouldn't the content of folder doc/imx be moved to doc/board/freescale/ and linked in doc/board/freescale/index.rst?

We should be able to generate HTML documentation for imx using 'make htmldocs'.

Thanks for your feedback.

Do you think we can convert this documentation to sphinx format and create an index.rst at doc/imx/? The HABv4 documentation is SoC specific and not board related.

Thanks,
Breno Lima

#5 lore raw

PATCH 1/1 imx: Kconfig: fix references to doc/README.mxc_hab

Am April 13, 2020 2:49:00 PM UTC schrieb Breno Matheus Lima <[email protected]>:

Quoted 69 lines

Hi Heinrich,

Em dom., 12 de abr. de 2020 ?s 17:35, Heinrich Schuchardt <[email protected]> escreveu:

Quoted 5 lines · Fabio Estevam
Quoted 3 lines

Hi Heinrich,

On Sun, Apr 12, 2020 at 11:23 AM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines

doc/README.mxc_hab was moved to

doc/imx/habv4/guides/encrypted_boot.txt by

Quoted 1 line
Quoted 1 line
Quoted 1 line

commit df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation"),

commit

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot documentation"), commit 8a23fc9c94bf ("doc: imx: habv4: Remove

extra hab,

Quoted 1 line
Quoted 1 line
Quoted 1 line

directory for a cleaner documentation structure"), and commit

364c0a89bcfa

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

("doc: imx: habv4: Move encrypted boot guide").

Fixes df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation")
Fixes dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance

Boot

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

documentation")

Fixes 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory

for a cleaner documentation structure")

Fixes commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot

guide").

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
---
 arch/arm/mach-imx/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 10 lines
Quoted 10 lines

arch/arm/mach-imx/Kconfig config IMX_HAB · line 44

Quoted 10 lines
arch/arm/mach-imx/Kconfig +1 -1
index aa140c4798..44b47780ee 100644
@@ -41,7 +41,7 @@ config IMX_HAB
        imply CMD_DEKBLOB
        help
          This option enables the support for secure boot (HAB).
-         See doc/README.mxc_hab for more details.
+         See doc/imx/habv4/guides/encrypted_boot.txt for more

details.

Quoted 4 lines
Quoted 4 lines

Thanks for your patch.

Indeed, doc/README.mxc_hab is gone and we should replace it, but I

was

Quoted 11 lines
Quoted 6 lines

wondering if we should point the file to doc/imx/habv4/guides/mx6_mx7_secure_boot.txt instead.

Breno,

What do you think?

It is doc/imx/habv4/guides/encrypted_boot.txt that mentions CONFIG_IMX_HAB and CONFIG_CMD_DEKBLOB.

Maybe both files can be merged. Anyway the imx directory should move

to

Quoted 3 lines

doc/board and be integrated into doc/board/index.rst.

Shouldn't the content of folder doc/imx be moved to

doc/board/freescale/

Quoted 2 lines

and linked in doc/board/freescale/index.rst?

Quoted 8 lines
Quoted 2 lines

We should be able to generate HTML documentation for imx using 'make htmldocs'.

Thanks for your feedback.

Do you think we can convert this documentation to sphinx format and create an index.rst at doc/imx/? The HABv4 documentation is SoC specific and not board related.

Maybe besides an arch and a board folder we should have a doc/soc/ folder.

Quoted 3 lines

Thanks,
Breno Lima

#6 lore raw

PATCH 1/1 imx: Kconfig: fix references to doc/README.mxc_hab

Hi Heinrich,

Em seg., 13 de abr. de 2020 ?s 11:04, Heinrich Schuchardt <[email protected]> escreveu:

Quoted 74 lines

Am April 13, 2020 2:49:00 PM UTC schrieb Breno Matheus Lima <[email protected]>:

Quoted 72 lines

Hi Heinrich,

Em dom., 12 de abr. de 2020 ?s 17:35, Heinrich Schuchardt <[email protected]> escreveu:

Quoted 5 lines · Fabio Estevam
Quoted 3 lines

Hi Heinrich,

On Sun, Apr 12, 2020 at 11:23 AM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines

doc/README.mxc_hab was moved to

doc/imx/habv4/guides/encrypted_boot.txt by

Quoted 1 line
Quoted 1 line
Quoted 1 line

commit df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation"),

commit

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot documentation"), commit 8a23fc9c94bf ("doc: imx: habv4: Remove

extra hab,

Quoted 1 line
Quoted 1 line
Quoted 1 line

directory for a cleaner documentation structure"), and commit

364c0a89bcfa

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

("doc: imx: habv4: Move encrypted boot guide").

Fixes df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation")
Fixes dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance

Boot

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

documentation")

Fixes 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory

for a cleaner documentation structure")

Fixes commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot

guide").

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
---
 arch/arm/mach-imx/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 10 lines
Quoted 10 lines

arch/arm/mach-imx/Kconfig config IMX_HAB · line 44

Quoted 10 lines
arch/arm/mach-imx/Kconfig +1 -1
index aa140c4798..44b47780ee 100644
@@ -41,7 +41,7 @@ config IMX_HAB
        imply CMD_DEKBLOB
        help
          This option enables the support for secure boot (HAB).
-         See doc/README.mxc_hab for more details.
+         See doc/imx/habv4/guides/encrypted_boot.txt for more

details.

Quoted 4 lines
Quoted 4 lines

Thanks for your patch.

Indeed, doc/README.mxc_hab is gone and we should replace it, but I

was

Quoted 11 lines
Quoted 6 lines

wondering if we should point the file to doc/imx/habv4/guides/mx6_mx7_secure_boot.txt instead.

Breno,

What do you think?

It is doc/imx/habv4/guides/encrypted_boot.txt that mentions CONFIG_IMX_HAB and CONFIG_CMD_DEKBLOB.

Maybe both files can be merged. Anyway the imx directory should move

to

Quoted 3 lines

doc/board and be integrated into doc/board/index.rst.

Shouldn't the content of folder doc/imx be moved to

doc/board/freescale/

Quoted 4 lines

and linked in doc/board/freescale/index.rst?

We should be able to generate HTML documentation for imx using 'make htmldocs'.

Quoted 8 lines
Quoted 5 lines

Thanks for your feedback.

Do you think we can convert this documentation to sphinx format and create an index.rst at doc/imx/? The HABv4 documentation is SoC specific and not board related.

Maybe besides an arch and a board folder we should have a doc/soc/ folder.

Thanks for your suggestion, do we have similar documentation for other SoCs?

Please take a look in commit df11b0c4 ("doc: imx: reorganize i.MX documentation") all i.MX documentation that were located at U-Boot doc root directory.

Thanks,
Breno Lima

#7 lore raw

PATCH 1/1 imx: Kconfig: fix references to doc/README.mxc_hab

Quoted 84 lines · Breno Matheus Lima

Hi Heinrich,

Em seg., 13 de abr. de 2020 ?s 11:04, Heinrich Schuchardt <[email protected]> escreveu:

Quoted 80 lines

Am April 13, 2020 2:49:00 PM UTC schrieb Breno Matheus Lima <[email protected]>:

Quoted 77 lines

Hi Heinrich,

Em dom., 12 de abr. de 2020 ?s 17:35, Heinrich Schuchardt <[email protected]> escreveu:

Quoted 5 lines · Fabio Estevam
Quoted 3 lines

Hi Heinrich,

On Sun, Apr 12, 2020 at 11:23 AM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines

doc/README.mxc_hab was moved to

doc/imx/habv4/guides/encrypted_boot.txt by

Quoted 1 line
Quoted 1 line
Quoted 1 line

commit df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation"),

commit

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot documentation"), commit 8a23fc9c94bf ("doc: imx: habv4: Remove

extra hab,

Quoted 1 line
Quoted 1 line
Quoted 1 line

directory for a cleaner documentation structure"), and commit

364c0a89bcfa

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

("doc: imx: habv4: Move encrypted boot guide").

Fixes df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation")
Fixes dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance

Boot

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

documentation")

Fixes 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory

for a cleaner documentation structure")

Fixes commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot

guide").

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
---
 arch/arm/mach-imx/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 10 lines
Quoted 10 lines

arch/arm/mach-imx/Kconfig config IMX_HAB · line 44

Quoted 10 lines
arch/arm/mach-imx/Kconfig +1 -1
index aa140c4798..44b47780ee 100644
@@ -41,7 +41,7 @@ config IMX_HAB
        imply CMD_DEKBLOB
        help
          This option enables the support for secure boot (HAB).
-         See doc/README.mxc_hab for more details.
+         See doc/imx/habv4/guides/encrypted_boot.txt for more

details.

Quoted 4 lines
Quoted 4 lines

Thanks for your patch.

Indeed, doc/README.mxc_hab is gone and we should replace it, but I

was

Quoted 11 lines
Quoted 6 lines

wondering if we should point the file to doc/imx/habv4/guides/mx6_mx7_secure_boot.txt instead.

Breno,

What do you think?

It is doc/imx/habv4/guides/encrypted_boot.txt that mentions CONFIG_IMX_HAB and CONFIG_CMD_DEKBLOB.

Maybe both files can be merged. Anyway the imx directory should move

to

Quoted 3 lines

doc/board and be integrated into doc/board/index.rst.

Shouldn't the content of folder doc/imx be moved to

doc/board/freescale/

Quoted 4 lines

and linked in doc/board/freescale/index.rst?

We should be able to generate HTML documentation for imx using 'make htmldocs'.

Thanks for your feedback.

Do you think we can convert this documentation to sphinx format and create an index.rst at doc/imx/? The HABv4 documentation is SoC specific and not board related.

Quoted 8 lines
Quoted 2 lines

Maybe besides an arch and a board folder we should have a doc/soc/ folder.

Thanks for your suggestion, do we have similar documentation for other SoCs?

Please take a look in commit df11b0c4 ("doc: imx: reorganize i.MX documentation") all i.MX documentation that were located at U-Boot doc root directory.

df11b0c4 was a good step forward.

doc/mvebu/armada-8k-memory.txt
seems to be another SoC related file.

A lot of other SoC files are at doc/README.*.

Overall the doc/ directory is not in a good state yet. Many documents are not yet integrated into the generated documentation.

Best regards

Heinrich

Quoted 4 lines

Thanks,
Breno Lima

#8 lore raw

PATCH 1/1 imx: Kconfig: fix references to doc/README.mxc_hab

Hi everybody,

Quoted 96 lines · Heinrich Schuchardt
Quoted 84 lines · Breno Matheus Lima

Hi Heinrich,

Em seg., 13 de abr. de 2020 ?s 11:04, Heinrich Schuchardt <[email protected]> escreveu:

Quoted 80 lines

Am April 13, 2020 2:49:00 PM UTC schrieb Breno Matheus Lima <[email protected]>:

Quoted 77 lines

Hi Heinrich,

Em dom., 12 de abr. de 2020 ?s 17:35, Heinrich Schuchardt <[email protected]> escreveu:

Quoted 5 lines · Fabio Estevam
Quoted 3 lines

Hi Heinrich,

On Sun, Apr 12, 2020 at 11:23 AM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines

doc/README.mxc_hab was moved to

doc/imx/habv4/guides/encrypted_boot.txt by

Quoted 1 line
Quoted 1 line
Quoted 1 line

commit df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation"),

commit

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot documentation"), commit 8a23fc9c94bf ("doc: imx: habv4: Remove

extra hab,

Quoted 1 line
Quoted 1 line
Quoted 1 line

directory for a cleaner documentation structure"), and commit

364c0a89bcfa

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

("doc: imx: habv4: Move encrypted boot guide").

Fixes df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation")
Fixes dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance

Boot

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

documentation")

Fixes 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory

for a cleaner documentation structure")

Fixes commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot

guide").

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
---
 arch/arm/mach-imx/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 10 lines
Quoted 10 lines

arch/arm/mach-imx/Kconfig config IMX_HAB · line 44

Quoted 10 lines
arch/arm/mach-imx/Kconfig +1 -1
index aa140c4798..44b47780ee 100644
@@ -41,7 +41,7 @@ config IMX_HAB
        imply CMD_DEKBLOB
        help
          This option enables the support for secure boot (HAB).
-         See doc/README.mxc_hab for more details.
+         See doc/imx/habv4/guides/encrypted_boot.txt for more

details.

Quoted 4 lines
Quoted 4 lines

Thanks for your patch.

Indeed, doc/README.mxc_hab is gone and we should replace it, but I

was

Quoted 11 lines
Quoted 6 lines

wondering if we should point the file to doc/imx/habv4/guides/mx6_mx7_secure_boot.txt instead.

Breno,

What do you think?

It is doc/imx/habv4/guides/encrypted_boot.txt that mentions CONFIG_IMX_HAB and CONFIG_CMD_DEKBLOB.

Maybe both files can be merged. Anyway the imx directory should move

to

Quoted 3 lines

doc/board and be integrated into doc/board/index.rst.

Shouldn't the content of folder doc/imx be moved to

doc/board/freescale/

Quoted 4 lines

and linked in doc/board/freescale/index.rst?

We should be able to generate HTML documentation for imx using 'make htmldocs'.

Thanks for your feedback.

Do you think we can convert this documentation to sphinx format and create an index.rst at doc/imx/? The HABv4 documentation is SoC specific and not board related.

Quoted 8 lines
Quoted 2 lines

Maybe besides an arch and a board folder we should have a doc/soc/ folder.

Thanks for your suggestion, do we have similar documentation for other SoCs?

Please take a look in commit df11b0c4 ("doc: imx: reorganize i.MX documentation") all i.MX documentation that were located at U-Boot doc root directory.

df11b0c4 was a good step forward.

Quoted 8 lines

doc/mvebu/armada-8k-memory.txt
seems to be another SoC related file.

A lot of other SoC files are at doc/README.*.

Overall the doc/ directory is not in a good state yet. Many documents are not yet integrated into the generated documentation.

Agree that doc/ is in a bad state - nevertheless we should try to move on to the right direction. As Breno says, this is not related to a single board. doc/README.soc was done years ago, without generating documentation. I think we should go away from this model. I see also very positive the switch to rst for any i.MX documentation.

Regards,
Stefano

Quoted 9 lines

Best regards

Heinrich

Quoted 4 lines

Thanks,
Breno Lima

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#9 lore raw

PATCH 1/1 imx: Kconfig: fix references to doc/README.mxc_hab

Quoted 108 lines · Stefano Babic

Hi everybody,

Quoted 96 lines · Heinrich Schuchardt
Quoted 84 lines · Breno Matheus Lima

Hi Heinrich,

Em seg., 13 de abr. de 2020 ?s 11:04, Heinrich Schuchardt <[email protected]> escreveu:

Quoted 80 lines

Am April 13, 2020 2:49:00 PM UTC schrieb Breno Matheus Lima <[email protected]>:

Quoted 77 lines

Hi Heinrich,

Em dom., 12 de abr. de 2020 ?s 17:35, Heinrich Schuchardt <[email protected]> escreveu:

Quoted 5 lines · Fabio Estevam
Quoted 3 lines

Hi Heinrich,

On Sun, Apr 12, 2020 at 11:23 AM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines

doc/README.mxc_hab was moved to

doc/imx/habv4/guides/encrypted_boot.txt by

Quoted 1 line
Quoted 1 line
Quoted 1 line

commit df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation"),

commit

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot documentation"), commit 8a23fc9c94bf ("doc: imx: habv4: Remove

extra hab,

Quoted 1 line
Quoted 1 line
Quoted 1 line

directory for a cleaner documentation structure"), and commit

364c0a89bcfa

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

("doc: imx: habv4: Move encrypted boot guide").

Fixes df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation")
Fixes dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance

Boot

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

documentation")

Fixes 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory

for a cleaner documentation structure")

Fixes commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot

guide").

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
---
 arch/arm/mach-imx/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 10 lines
Quoted 10 lines

arch/arm/mach-imx/Kconfig config IMX_HAB · line 44

Quoted 10 lines
arch/arm/mach-imx/Kconfig +1 -1
index aa140c4798..44b47780ee 100644
@@ -41,7 +41,7 @@ config IMX_HAB
        imply CMD_DEKBLOB
        help
          This option enables the support for secure boot (HAB).
-         See doc/README.mxc_hab for more details.
+         See doc/imx/habv4/guides/encrypted_boot.txt for more

details.

Quoted 4 lines
Quoted 4 lines

Thanks for your patch.

Indeed, doc/README.mxc_hab is gone and we should replace it, but I

was

Quoted 11 lines
Quoted 6 lines

wondering if we should point the file to doc/imx/habv4/guides/mx6_mx7_secure_boot.txt instead.

Breno,

What do you think?

It is doc/imx/habv4/guides/encrypted_boot.txt that mentions CONFIG_IMX_HAB and CONFIG_CMD_DEKBLOB.

Maybe both files can be merged. Anyway the imx directory should move

to

Quoted 3 lines

doc/board and be integrated into doc/board/index.rst.

Shouldn't the content of folder doc/imx be moved to

doc/board/freescale/

Quoted 4 lines

and linked in doc/board/freescale/index.rst?

We should be able to generate HTML documentation for imx using 'make htmldocs'.

Thanks for your feedback.

Do you think we can convert this documentation to sphinx format and create an index.rst at doc/imx/? The HABv4 documentation is SoC specific and not board related.

Quoted 8 lines
Quoted 2 lines

Maybe besides an arch and a board folder we should have a doc/soc/ folder.

Thanks for your suggestion, do we have similar documentation for other SoCs?

Please take a look in commit df11b0c4 ("doc: imx: reorganize i.MX documentation") all i.MX documentation that were located at U-Boot doc root directory.

df11b0c4 was a good step forward.

Quoted 8 lines

doc/mvebu/armada-8k-memory.txt
seems to be another SoC related file.

A lot of other SoC files are at doc/README.*.

Overall the doc/ directory is not in a good state yet. Many documents are not yet integrated into the generated documentation.

Quoted 5 lines

Agree that doc/ is in a bad state - nevertheless we should try to move on to the right direction. As Breno says, this is not related to a single board. doc/README.soc was done years ago, without generating documentation. I think we should go away from this model. I see also very positive the switch to rst for any i.MX documentation.

If it is SoC related and not board related, doc/soc/imx/ would be good place to put the files. We should provide links from the main index, e.g.

doc/index.rst -> doc/soc/index.rst -> doc/soc/imx/index.rst -> imx_encrypted_boot.rst

Best regards

Heinrich

#10 lore raw

PATCH 1/1 imx: Kconfig: fix references to doc/README.mxc_hab

Quoted 115 lines · Heinrich Schuchardt
Quoted 108 lines · Stefano Babic

Hi everybody,

Quoted 96 lines · Heinrich Schuchardt
Quoted 84 lines · Breno Matheus Lima

Hi Heinrich,

Em seg., 13 de abr. de 2020 ?s 11:04, Heinrich Schuchardt <[email protected]> escreveu:

Quoted 80 lines

Am April 13, 2020 2:49:00 PM UTC schrieb Breno Matheus Lima <[email protected]>:

Quoted 77 lines

Hi Heinrich,

Em dom., 12 de abr. de 2020 ?s 17:35, Heinrich Schuchardt <[email protected]> escreveu:

Quoted 5 lines · Fabio Estevam
Quoted 3 lines

Hi Heinrich,

On Sun, Apr 12, 2020 at 11:23 AM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines

doc/README.mxc_hab was moved to

doc/imx/habv4/guides/encrypted_boot.txt by

Quoted 1 line
Quoted 1 line
Quoted 1 line

commit df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation"),

commit

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance Boot documentation"), commit 8a23fc9c94bf ("doc: imx: habv4: Remove

extra hab,

Quoted 1 line
Quoted 1 line
Quoted 1 line

directory for a cleaner documentation structure"), and commit

364c0a89bcfa

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

("doc: imx: habv4: Move encrypted boot guide").

Fixes df11b0c4d4e3 ("doc: imx: reorganize i.MX documentation")
Fixes dfe9ff9cc79b ("doc: imx: hab: Reorganize High Assurance

Boot

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

documentation")

Fixes 8a23fc9c94bf ("doc: imx: habv4: Remove extra hab, directory

for a cleaner documentation structure")

Fixes commit 364c0a89bcfa ("doc: imx: habv4: Move encrypted boot

guide").

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
---
 arch/arm/mach-imx/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 10 lines
Quoted 10 lines

arch/arm/mach-imx/Kconfig config IMX_HAB · line 44

Quoted 10 lines
arch/arm/mach-imx/Kconfig +1 -1
index aa140c4798..44b47780ee 100644
@@ -41,7 +41,7 @@ config IMX_HAB
        imply CMD_DEKBLOB
        help
          This option enables the support for secure boot (HAB).
-         See doc/README.mxc_hab for more details.
+         See doc/imx/habv4/guides/encrypted_boot.txt for more

details.

Quoted 4 lines
Quoted 4 lines

Thanks for your patch.

Indeed, doc/README.mxc_hab is gone and we should replace it, but I

was

Quoted 11 lines
Quoted 6 lines

wondering if we should point the file to doc/imx/habv4/guides/mx6_mx7_secure_boot.txt instead.

Breno,

What do you think?

It is doc/imx/habv4/guides/encrypted_boot.txt that mentions CONFIG_IMX_HAB and CONFIG_CMD_DEKBLOB.

Maybe both files can be merged. Anyway the imx directory should move

to

Quoted 3 lines

doc/board and be integrated into doc/board/index.rst.

Shouldn't the content of folder doc/imx be moved to

doc/board/freescale/

Quoted 4 lines

and linked in doc/board/freescale/index.rst?

We should be able to generate HTML documentation for imx using 'make htmldocs'.

Thanks for your feedback.

Do you think we can convert this documentation to sphinx format and create an index.rst at doc/imx/? The HABv4 documentation is SoC specific and not board related.

Quoted 8 lines
Quoted 2 lines

Maybe besides an arch and a board folder we should have a doc/soc/ folder.

Thanks for your suggestion, do we have similar documentation for other SoCs?

Please take a look in commit df11b0c4 ("doc: imx: reorganize i.MX documentation") all i.MX documentation that were located at U-Boot doc root directory.

df11b0c4 was a good step forward.

Quoted 8 lines

doc/mvebu/armada-8k-memory.txt
seems to be another SoC related file.

A lot of other SoC files are at doc/README.*.

Overall the doc/ directory is not in a good state yet. Many documents are not yet integrated into the generated documentation.

Quoted 5 lines

Agree that doc/ is in a bad state - nevertheless we should try to move on to the right direction. As Breno says, this is not related to a single board. doc/README.soc was done years ago, without generating documentation. I think we should go away from this model. I see also very positive the switch to rst for any i.MX documentation.

Quoted 5 lines

If it is SoC related and not board related, doc/soc/imx/ would be good place to put the files. We should provide links from the main index, e.g.

doc/index.rst -> doc/soc/index.rst -> doc/soc/imx/index.rst -> imx_encrypted_boot.rst

I am not again this.

Stefano

Quoted 5 lines

Best regards

Heinrich

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
reviewer
#11 lore raw

PATCH 1/1 imx: Kconfig: fix references to doc/README.mxc_hab

In reply to Heinrich Schuchardt

Hi Heinrich,

Quoted 5 lines · Heinrich Schuchardt

If it is SoC related and not board related, doc/soc/imx/ would be good place to put the files. We should provide links from the main index, e.g.

doc/index.rst -> doc/soc/index.rst -> doc/soc/imx/index.rst -> imx_encrypted_boot.rst

Just realized that your original patch is no longer needed after this one from Patrick got applied:
https://gitlab.denx.de/u-boot/u-boot/-/commit/9d82cbd39a75f4388f3705efa99832b9376f3df5

Of course, the conversion to .rst is welcome and if someone is willing to work on it, that will be helpful indeed.